GitLab

use-gl=desktop mode got broken in r109111. GL proc addresses were not being found because ::GetProcAddress does not work with stock opengl32.dll. The stock dll just exposes GL 1.1 interface. wglGetProcAddress needs to be used to get >GL 1.1 interface, which in turn requires a GL current context.
This patch simply reverts a portion of r109111.
BUG=103765

Review URL: http://codereview.chromium.org/8588009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110455 0039d316-1c4b-4281-b951-d872f2087c98

the test doesn't make much sense on officail builds, and it fails on them

BUG=104566
TEST=none


Review URL: http://codereview.chromium.org/8589010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110454 0039d316-1c4b-4281-b951-d872f2087c98

This avoids having to recompute certain bits of data during display (for instance, there is no need to re-merge/group the data when simply changing the sorting order).

BUG=100992
Review URL: http://codereview.chromium.org/8590001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110453 0039d316-1c4b-4281-b951-d872f2087c98

GetRestoredBounds should Return normal bounds if window is normal mode.

BUG=103490
TEST=none


Review URL: http://codereview.chromium.org/8468029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110452 0039d316-1c4b-4281-b951-d872f2087c98

TabStripGtk::OnSizeAllocate() could fail to call Layout() or schedule Layout()
to be called in the future (and was reusing the code to resize the internal
tabs when a single tab was closed). The views implementation of the tabstrip
didn't use that path and would always relayout the entire tabstrip on bounds
changes.

BUG=79094
TEST=Create a window with more than 20 tabs in it. Very slowly shrink the window, one pixel at a time. The min/max/close buttons shouldn't overlap with the new tab button.


Review URL: http://codereview.chromium.org/8568026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110451 0039d316-1c4b-4281-b951-d872f2087c98

The stress sync integration tests use 10 sync clients, and were
originally flaky due to testserver bugginess.

Several fixes have gone in since then, and it might be time to re-enable
those tests.

Note to future Chromium Sheriffs: If these stress tests do fail or time out in future, feel free to revert this patch.

BUG=69604
TEST=sync_integration_tests --gtest_filter=ManyClient*


Review URL: http://codereview.chromium.org/8568033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110450 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8589011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110449 0039d316-1c4b-4281-b951-d872f2087c98

BUG=0
TEST=Ensure that sync integration tests TwoClientSearchEnginesSyncTest.* pass.


Review URL: http://codereview.chromium.org/8571005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101600,94925
TEST=none
TBR=erg,willchan

Review URL: http://codereview.chromium.org/8590003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110447 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin

Review URL: http://codereview.chromium.org/8588024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110446 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8590014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110445 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8539048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110444 0039d316-1c4b-4281-b951-d872f2087c98

It's not used for a real purpose anymore, and it was causing the SCM to have
multiple active_connection_ objects in certain cases, which is bad.

This is mostly covered by SyncAPIServerConnectionManagerTest

BUG=101639
TEST=On a debug build, no DCHECKs if the server is unreachable on sync startup.


Review URL: http://codereview.chromium.org/8590005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110443 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110442 0039d316-1c4b-4281-b951-d872f2087c98

Aura uses the views BalloonCollectionImpl, so this rewrites the test to use the generic BalloonCollection interface.

The test still fails, but will work when chromeos::SystemNotification is implemented on Aura.

BUG=104471
TEST=browser_tests

Review URL: http://codereview.chromium.org/8576010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110441 0039d316-1c4b-4281-b951-d872f2087c98

This time with unittest.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8591005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110440 0039d316-1c4b-4281-b951-d872f2087c98

r1093: Default to make generator on FreeBSD9 and 10 as well.

BUG=None


Review URL: http://codereview.chromium.org/8588008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110439 0039d316-1c4b-4281-b951-d872f2087c98

Files under webkit/media/ are now under their very own webkit_media namespace.

Review URL: http://codereview.chromium.org/8570010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110438 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97845
TEST=none


Review URL: http://codereview.chromium.org/8450018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110437 0039d316-1c4b-4281-b951-d872f2087c98

This allows the use of e.g.:

WeakHandle<T> weak_handle = MakeWeakHandle(WeakPtr<U>());

as long as U is convertible to T, instead of:

WeakHandle<T> weak_handle = WeakHandle<T>(WeakPtr<U>());

Fix all callers.

BUG=
TEST=


Review URL: http://codereview.chromium.org/8568041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110436 0039d316-1c4b-4281-b951-d872f2087c98

This CL is part of a larger effort to replace opencryptoki as the PKCS #11 layer in Chrome OS.  In this first phase, libchaps.so forwards requests to a daemon (chapsd) which loads opencryptoki to service the requests.  You can find the Chaps design doc here: https://docs.google.com/a/google.com/document/d/1TQFc6GABKa1JgwUx2hIcxAHQ329fkd03yYlGxhfHQlQ/edit

Change-Id: I42962c4703413039641b6ede40caaf0c97ab900e

BUG=chromium-os:21005
TEST=* Ensure previously existing certs still exist.
     * Import new cert and private key from PKCS12 file.


Review URL: http://codereview.chromium.org/8527006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110435 0039d316-1c4b-4281-b951-d872f2087c98

Set the clipboard text initially rather than using
whatever happened to be in the clipboard at the time
of the test.

BUG=none
TEST=Copy some non-ASCII text before running TextfieldViewsModelTest.Clipboard.
Then, run the test. It should not fail.

Review URL: http://codereview.chromium.org/8486024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103999
TEST=included
Review URL: http://codereview.chromium.org/8572036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70829
TEST=tree gets greener
TBR=mpcomplete
Review URL: http://codereview.chromium.org/8585021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104582
TEST=bots go green
TBR=japhet
Review URL: http://codereview.chromium.org/8588022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110431 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104578
TEST=none

Review URL: http://codereview.chromium.org/8586018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110430 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/8566027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110420 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Fix leak in X509UtilNSSTest VerifyCertificateSignature."

BUG=88782
TEST=none
TBR=cpu@chromium.org

Review URL: http://codereview.chromium.org/8587018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110419 0039d316-1c4b-4281-b951-d872f2087c98

Forgot to initialize the ScopedPLArenaPool, so the ASN1 functions were
leaking.

BUG=88782
TEST=memory bots
TBR=cpu@chromium.org

Review URL: http://codereview.chromium.org/8588015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110417 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110415 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93825
TEST=none

Review URL: http://codereview.chromium.org/8520024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110414 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=steveblock
Review URL: http://codereview.chromium.org/8479053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110413 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8585008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110412 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:14439
TEST=None

Change-Id: Iab663c8eaeea198f9d3d74e8f5f069d678ae9429

Review URL: http://codereview.chromium.org/8513021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110411 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8526015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110410 0039d316-1c4b-4281-b951-d872f2087c98

The motivation is to solve a dependency issue between UpgradeDetectorChromeos
and DBusThreadManager, that'll replace CrosLibrary (i.e. UpgradeDetectorChromeos
will be using DBusThreadManager internally).

BUG=16564
TEST=Upgrade detector works as before. (create a new image, start dev server, and run update_engine_client --update, and confirm that an arrow is shown on the wrench menu icon, once the update is downloaded in the background).

Review URL: http://codereview.chromium.org/8568020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110409 0039d316-1c4b-4281-b951-d872f2087c98

Also fix a possible data race issue.

Also convert NewRunnableMethod to base::Bind.

BUG=103901,87747
TEST=run chrome, then "echo hi | nc -U /tmp/.org.chromium.Chromium.FOO/SingletonSocket"


Review URL: http://codereview.chromium.org/8571019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots, local cros/arm build of chrome succeeds.


Review URL: http://codereview.chromium.org/8537032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110407 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8570011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110406 0039d316-1c4b-4281-b951-d872f2087c98