- 02 Aug, 2017 40 commits
-
-
dpapad authored
Bug: 731467 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I785ddcb08e90910c508bc38e7bb2a524de854949 Reviewed-on: https://chromium-review.googlesource.com/595194Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#491244}
-
Stuart Langley authored
This is part of the gradual process of putting all types that derive from CSSValue into blink::cssvalue:: namespace. Bug: 667961 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ida38ef3b65ff8977c286e4bcd71fa9e416fe1ff2 Reviewed-on: https://chromium-review.googlesource.com/595369Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#491243}
-
Ashley Enstad authored
Previously, run_telemetry_benchmark_as_googletest would check the validity of the benchmark run by opening results.json. This file was generated using the --output-format=json flag. By removing that flag in https://chromium-review.googlesource.com/c/589820, I broke all the Telemetry benchmarks on the perf waterfall o.O my bad. This change should fix the failing tests by checking the validity of the benchmark run by opening test-results.json, generated using the --output-format=json-test-results flag now being used for all Telemetry benchmark runs on the waterfall. BUG=751346, 748638 NOTRY=true # This script is not run on trybot/CQ, hence should be safe to notry Change-Id: I75e0abb5801f1cbaa480e65ade1827335a1195fd Reviewed-on: https://chromium-review.googlesource.com/597428 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491242}
-
Bin Zhao authored
I do not have a local repro... As Derek mentioned, DialAPI is destroyed on the IO thread, but somehow referenced after deletion on the UI thread. Not quite sure how that could happen since it is scoped_refptr<DialAPI>. It might relate to delete RefCountedKeyedService on the IO thread. Tentatively fix it by destroying DialAPI instance on the UI thread. BUG=740489 Change-Id: I3e638c14a77ffa9c5726519571d25874a20cd5f0 Reviewed-on: https://chromium-review.googlesource.com/567025 Commit-Queue: Bin Zhao <zhaobin@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#491241}
-
Yoshifumi Inoue authored
This patch changes |VisibleSelectionTemplate::AsSelection()| to utilize early- return style for improving source code readability. Change-Id: I0244919e70372e193daf7b45ffbabdeb1b4c5d85 Reviewed-on: https://chromium-review.googlesource.com/594755Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491240}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: I2385fca9d5736d3d91aec886ef5760fbb3f51990 Reviewed-on: https://chromium-review.googlesource.com/597449Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#491239}
-
Ian Clelland authored
Now that it is no longer in use, This change removes the implementation of WebCString, and cleans up the few dangling \#includes and comments which still referenced it. Bug: 568803 Change-Id: I19717da309c7ee885542e1c688a6383a12fe9081 Reviewed-on: https://chromium-review.googlesource.com/594673Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#491238}
-
Albert J. Wong authored
This radically changes the process broker architecture. Instead of trying to manage pipe passing by hand, this instead uses ServiceManager to handle lifetime of the Profiling process as well as passing of the handles. Major changes: (1) Profilng process started on demand. (2) Browser process logging delayed until ServiceManager has started. (3) Renderers push a pipe to the Profling process via Memlog interface instead of having them passed down via the memlog-pipe flag; the flag is now used to send the memlog sender_id. (4) The PlatformChannelPair is created in the profiling process. This allows us to leverage all the infrastructure built up for servicification to launch utility processes in all platforms at the cost of later startup. It also simplifies lifetime design as there is no need to worry about registering crash handlers, message loop globals, etc for the profiling process. Bug: Change-Id: Ibd1cbadd1d7c946ae442f259c3e0ae1b95acb165 Reviewed-on: https://chromium-review.googlesource.com/590575 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#491237}
-
Dave Schuyler authored
This CL removes a few instances of a div with class="action-buttons". The .action-buttons class doesn't appear to be defined and the wrapping div disturbed the styling from the button-container (which has the correct styling). Bug: 750552 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6dec5daa83c6543c809e88ccd331c5ded08461a8 Reviewed-on: https://chromium-review.googlesource.com/595212 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#491236}
-
Yutaka Hirano authored
kHttp and kDnsProbe domains are used only for showing error pages. We want to keep WebURLError as small as possible, so this CL removes them and defines error_page::Error instead. Bug: 748491 Change-Id: I3f0feea9dba0f0bdcd80e39f8bd187447173308f Reviewed-on: https://chromium-review.googlesource.com/586088 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
sczs authored
For boxing purposes this CL moves the history_popup classes into a subdirectory of its own, this way boxing this component will be easier. Bug: Change-Id: If652c9ab145fd268231fee538bfbde048a2a40e4 Reviewed-on: https://chromium-review.googlesource.com/595224 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#491234}
-
Reilly Grant authored
An ImageCapture object may be created from an HTMLElement that is part of a context that has already been destroyed. Check to see if the frame has been detached before trying to access the interface provider. Bug: 749499 Change-Id: I25838392413b218212fe2cb16a119d4379bea659 Reviewed-on: https://chromium-review.googlesource.com/592649Reviewed-by:
-
Tsuyoshi Horo authored
This reverts commit cb3af0b9. Reason for revert: This cl introduced MSan bot failure. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/2975 [ RUN ] SSLClientSocketTest.SessionCacheShard HTTPS server started on https://127.0.0.1:39100... sending server_data: {"host": "127.0.0.1", "port": 39100} (36 bytes) ==19370:19370==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0xb1f3705 in net::SSLClientSocketImpl::DoHandshakeComplete(int) net/socket/ssl_client_socket_impl.cc:1175:39 #1 0xb1eb33f in net::SSLClientSocketImpl::DoHandshakeLoop(int) net/socket/ssl_client_socket_impl.cc:1388:14 #2 0xb1f44fe in net::SSLClientSocketImpl::OnHandshakeIOComplete(int) net/socket/ssl_client_socket_impl.cc:1365:12 [ RUN ] SslCastSocketTest.TestMessageEndToEndWithRealSSL ==27991:27991==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x12dacae5 in net::SSLClientSocketImpl::DoHandshakeComplete(int) net/socket/ssl_client_socket_impl.cc:1175:39 #1 0x12da471f in net::SSLClientSocketImpl::DoHandshakeLoop(int) net/socket/ssl_client_socket_impl.cc:1388:14 #2 0x12dad8de in net::SSLClientSocketImpl::OnHandshakeIOComplete(int) net/socket/ssl_client_socket_impl.cc:1365:12 Original change's description: > Disable session caching with the default (empty) shard. > > Until we do https://crbug.com/458365 and remove the global session > cache, consumers making SSLClientSockets with the default empty shard > should not enable session caching, as they'll interact with other > sockets which do that. > > Bug: 458365 > Change-Id: Ib8bb5cc6fb51240c4e9a89184ab51775e9653168 > Reviewed-on: https://chromium-review.googlesource.com/595155 > Commit-Queue: Steven Valdez <svaldez@chromium.org> > Reviewed-by: Steven Valdez <svaldez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491118} TBR=davidben@chromium.org,svaldez@chromium.org Change-Id: Id7dc73921a36d80c9764bbb49ae36c19ef2ccaca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 458365 Reviewed-on: https://chromium-review.googlesource.com/597328Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491232}
-
Tien-Ren Chen authored
Failure to do so may result in malformed paint chunks that has chunk clip escaping its effect's output clip. BUG=707444,737275 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6e19e774e89aea8146103f741cc1939ad354aed7 Reviewed-on: https://chromium-review.googlesource.com/596930 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491231}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5a9a981edf54..943e77368b89 $ git log 5a9a981ed..943e77368 --date=short --no-merges --format='%ad %ae %s' 2017-08-01 skia-deps-roller Roll skia/third_party/externals/angle2/ 878c8b1e5..5788d24bb (2 commits) Created with: roll-dep src/third_party/skia BUG=750685 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I693087b0232535968ab8ab6de75c890745e51f29 Reviewed-on: https://chromium-review.googlesource.com/596925Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491230}
-
Darren Shen authored
Move: build/scripts/{ => core/css}/make_css_value_keywords.py And fixes some linter errors. Bug: 732657 Change-Id: Ia8983baaeb22afbe63e729a3898918152adaf9e8 Reviewed-on: https://chromium-review.googlesource.com/590888Reviewed-by: -
Alex Gaynor authored
The comment was originally written when Windows XP and Windows Vista were the only supported versions of Windows. Now there are several newer versions of Windows where integrity levels are used R=cpu@chromium.org, wfh@chromium.org Bug: Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I1a220094a6bf093a85df7abea36bfcbbe84cd212 Reviewed-on: https://chromium-review.googlesource.com/579936Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491228}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6329c5bd..6a944af5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I792c80746ef953ab743a35637e8a8e9bca7f4c7c Reviewed-on: https://chromium-review.googlesource.com/596791Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491227}
-
Devlin Cronin authored
Custom bindings can sometimes run after a context is destroyed. This is almost certainly undesirable, but tracing down each instance when it happens might be tricky. One guaranteed instance is messaging bindings performing port cleanup. If a port is cleaned up after the context is destroyed, an exception will be thrown, which is caught and then logged to the console. Console logging itself normally expects a script context, but in this case there is none. Gracefully handle this by allowing a null script context in console logging, rather than CHECKing the result (console::AddMessage already handles a null script context). Ideally, we should fix these to not have any JS code running after the script context is removed; add a TODO to that effect. Note: the null script context behavior happens in both native and JS bindings; the native bindings just CHECK'd the result. This makes MessagingApiTest.MessagingBackgroundOnly pass with native bindings. --gtest_filter=MessagingApiTest.MessagingBackgroundOnly \ --native-crx-bindings=1 Bug: 653596 Test: browser_tests \ Change-Id: Ie80da8f95cdee9dafe768b101116d116d2931404 Reviewed-on: https://chromium-review.googlesource.com/592390 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#491226}
-
jdoerrie authored
Following http://crrev.com/2944523002 base::flat_map supports transparent comparisions. This CL makes use of this by removing now unneccesary temporary std::string constructions from base::StringPieces. Bug: 646113 Change-Id: Id6672b80bd706a3e3ae62c30468cd387b11ab4e3 Reviewed-on: https://chromium-review.googlesource.com/592367Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |ExpandSelectionToRespectUserSelectAll()| to take |SelectionInFlatTree| to reduce usage of |VisibleSelectionInFlatTree|. Bug: 657237 Change-Id: Id4d884fda22208c5881d3124b476befffa43c43f Reviewed-on: https://chromium-review.googlesource.com/595309Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/de7c9620c374..33dd830890d3 $ git log de7c9620c..33dd83089 --date=short --no-merges --format='%ad %ae %s' 2017-07-28 art-snake Add public access for read stream into CPDF_SyntaxParser 2017-08-01 art-snake Improve readability in CPDF_Parser::ObjectInfo. 2017-07-29 art-snake Implement read Session. 2017-08-01 thestig Change CPDF_Parser::GetIndirectBinary() to return a std::vector. 2017-08-01 thestig Encapsulate some CFX_Char members. 2017-07-31 thestig Add a regression test for FPDF_ImportPages(). 2017-08-01 rharrison Remove support for negative params to ReleaseBuffer() 2017-08-01 rharrison Replace raw value for constant error value in string operations Created with: roll-dep src/third_party/pdfium BUG=750558 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: If79ba8091cd9e9ad042b2cadf3ba9d476ca7da9b Reviewed-on: https://chromium-review.googlesource.com/597212 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491223}
-
Sean Kau authored
This CL implements the infrastructure for logging PrinterEventProtos. Only removals are logged right now. Successful setup and setup abandonment will be added in follow up CLs. Bug: 647283 Change-Id: I9b3dbd37ee0db486d1c55686f729f65009d03cb8 Reviewed-on: https://chromium-review.googlesource.com/590584 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#491222}
-
Xiaocheng Hu authored
This patch changes TextIterator and its hellper classes to use unsigned integers to get rid of unnecessary sign checks and type casts. Public functions of TextIterator remain untouched. Bug: 751353 Change-Id: I7b888d77fde272573c70f0a7fdbcc0410eec7e82 Reviewed-on: https://chromium-review.googlesource.com/595120 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491221}
-
Dongseong Hwang authored
Forward native GMB command line flags for Guest session. BUG=475633 Change-Id: Id92d8f0a871d3c4ed644d24bb1951be5410c1dac Reviewed-on: https://chromium-review.googlesource.com/576456 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#491220}
-
Dale Curtis authored
This is a reland of 1b5b36fd Original change's description: > Refactor watch time reporting into a mojo service. > > It's not sustainable to continue to stuff metrics into the MediaInternals > reporter. Since these values aren't even displayed in the internals page > they should go into their own mojo service. Which has the benefit of > being a much simpler implementation to boot (~250 lines less). > > We now have a mojo WatchTimeRecorder interface that the WatchTimeReporter > can send watch time updates too. It can also finalize individual keys with > this new interface. As with the old interface if the process dies the mojo > channel will close and we'll finalize all held values at destruction. > > BUG=716643, 735238 > TEST=new/existing unittests all pass > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I0565422fbf70eba676dc22e08ea22cec88f09778 > Reviewed-on: https://chromium-review.googlesource.com/546903 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Yuzhu Shen <yzshen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490187} TBR=xhwang,nasko,rkaplow,yzshen,mlamouri Bug: 716643, 735238 Change-Id: Ife0d1287dc4d8655ccbc98cdcbead48659eb685a Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/593855 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491219}
-
Matt Wolenetz authored
Before this change, Chrome (with proprietary codecs enabled) supported FLAC-in-MP4 only in the regular src= media pipeline configuration. This change adds support for FLAC-in-MP4 in the MSE media pipeline to Chrome (with proprietary codecs enabled). The gating on proprietary codecs is not new (all of our existing src= and MSE demuxing of MP4 currently requires proprietary codecs in the build flags). This new FLAC-in-MP4 with MSE support is gated by a new kMseFlacInIsobmff base::Feature. Specifically, this change: * Adds MseFlacInIsobmff feature, disabled by default (it can be enabled by cmdline --enable-features=MseFlacInIsobmff). This flag controls MediaSource.isTypeSupported(..) and mediaSource.addSourceBuffer(..) for FLAC-in-MP4 mimetype+codec strings. * Adds MSE codec histogram tag to count successful addSourceBuffer() occurrences containing a mime type indicating FLAC codec. In Chrome MSE, no other bytestream besides MP4 supports addSourceBuffer with FLAC codec (and that support is new in this CL). * Updates StreamParserFactory to support (conditioned by feature flag) "flac" codec for each of audio/mp4 and video/mp4 mime types. * Adds |has_flac| parameter to MP4StreamParser ctor because FLAC-in-ISO has no standardized audio object type. * Adds support to MP4StreamParser for parsing 'fLaC' AudioSampleEntry and 'dfLa' FLACSpecificBox information to populate an AudioDecoderConfig. * Adds support to MP4StreamParser for higher-than-64k samplerate FLAC-in-ISO by parsing the FLACSpecificBox 'dfLa' containing the METADATA_BLOCK_STREAMINFO and using its sample rate instead of the one in the AudioSampleEntry. * Adds support to MP4StreamParser for 24-bit SampleFormat (the bear-flac*_frag.mp4 test files are 24-bit). * Enables partial append window trimming in MSE for FLAC-in-MP4 (conditioned by feature flag). This supports gapless FLAC playback using MSE. * Verifies the following information in 'dfLa' matches the info in the container and in the addSourceBuffer() call, giving parse error on failure: * fLaC AudioSampleEntry (or fLaC original format with cenc/sinf signalling) must only occur for SourceBuffers created with a FLAC-in-MP4 mimetype+codec. * dfLa must (only) occur for streams with fLaC AudioSampleEntry (or fLaC original format with cenc/sinf signalling). * First metadata block in dfLa must be METADATA_BLOCK_STREAMINFO * Only version 0 of dfLa is allowed * Only 0 dfLa Flags field is allowed * Channel count in METADATA_BLOCK_STREAMINFO must match that in the AudioSampleEntry. * Sample size in METADATA_BLOCK_STREAMINFO must match that in the AudioSampleEntry. * Includes new unit and browser tests: * content_browsertests: MediaSourceTest.Playback_AudioOnly_FLAC_MP4_Unsupported (the feature is forced off for this test, playback failure is verified) MediaSourceFlacInIsobmffTest.Playback_AudioOnly_FLAC_MP4_Supported (the feature is forced on for this test, playback success is verified) * media_unittests (with feature forced on): MP4StreamParserTest.Flac and Flac192kHz PipelineIntegrationTest.MediaSource_FlacInMp4_Hashed * Also includes audio/mp4 FLAC media capabilities browsertest case, though underlying support for CanDecode does not currently differentiate kFile vs kMediaSource (TODO added). Note, like other MSE ISO streams, the coded frame (eg, FLAC sample) duration is determined from the ISO boxes, not from inspecting (a possibly encrypted) coded frame header. This has similar consequence as other codecs in ISO of potential overlap-splicing or worse if the ISO metadata is incorrect with respect to the decode output of the coded frames. See also [1] for the FLAC-in-MP4 encapsulation specification (version 0.0.4 (draft) was current when this change was authored). Note, this change ignores the following metadata block types (see [2]) other than METADATA_BLOCK_STREAMINFO in the FLACSpecificBox (similar to current ffmpeg demuxing of FLAC-in-MP4): * Padding (this is stream, not timeline, padding) * Application * SeekTable * Vorbis Comment (informally, "FLAC tags") * CueSheet * Picture [1] https://github.com/xiph/flac/blob/master/doc/isoflac.txt [2] https://xiph.org/flac/format.html Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ntoLfR7rbmE BUG=666000 TEST=Multiple new tests; also manual success with http://www.bbc.co.uk/taster/projects/radio-3-concert-sound2 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I70bbe30d78d4769243d886f4a521a6b03e08a890 Reviewed-on: https://chromium-review.googlesource.com/588249 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#491218}
-
Alexei Filippov authored
Bug: 749415 Change-Id: I2c22ee57d2461c56124cf890f062cb50fec5d962 Reviewed-on: https://chromium-review.googlesource.com/591781 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#491217}
-
Regan Hsu authored
This class encapsulates the creation of RemoteDevice objects, which are created asynchronously by RemoteDeviceLoader. Bug: Change-Id: Ib9b14fba32dd4bfd6ef384b887d5c269449ca2a8 Reviewed-on: https://chromium-review.googlesource.com/576308Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#491216}
-
Zijie He authored
This change adds EvaluateD3D() function to evaluate the D3D capability of the host, which is used by HostAttributes. If the binary crashes, or DXGI components cannot be initialized, No-DirectX-Capturer will be added to the host attributes. So client can decide to let the host opt-out the experiment. Bug: 741926 Change-Id: I48f842790b6e016efa541ab767b12d4d0e67edb6 Reviewed-on: https://chromium-review.googlesource.com/592996 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#491215}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/0e4a448ab8aa66a38593f68d19fa0a2e340833e4..a4cb62f0ae6566068aef0742eb1cd46227d7dffd This includes a fix to the CFI issue which previously caused a revert. BUG=none Change-Id: Iab789ba802e4b6497b62ab6787c2ee08504515f5 Reviewed-on: https://chromium-review.googlesource.com/594649Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#491214}
-
Alex Zhang authored
TestFrameSinkManagerImpl is an empty implementation of mojom::FrameSinkManager. It takes the place of FrameSinkManagerClientBinding in WindowServer in unit tests. TestGpuHost is an empty implementation of GpuHost. It takes the places of DefaultGpuHost in WindowServer in unit tests. TestWindowServerDelegate now creates a WindowServer with the test implementations so that there is no mojo connections in ws unit tests. Bug: 698026 Change-Id: Ie8682e15a624bcfca2856f07508051cfb4f19308 Reviewed-on: https://chromium-review.googlesource.com/594849 Commit-Queue: Xingyu Zhang <staraz@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#491213}
-
nednguyen authored
THis also fix the regex of finding .wpr files in json archives list Bug: 730036 Change-Id: Iea0d1cd53caa4a45d293940a345dfa9e66737e63 Reviewed-on: https://chromium-review.googlesource.com/596589 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491212}
-
Christopher Cameron authored
Add helper in gfx::ColorSpace to, given an output color space, compute - the space in which rasterization should be performed - the space in which blending should be performed. Remove a place in the ui::Compositor where we check the kHighDyanmicRange feature, and use the above helper functions instead. Add logic in display::Display to automatically update the bit depth for media queries based on whether or not the output color space is HDR. Allow forcing an scrgb-linear profile using the --force-color-profile argument. Add logic in display::ScreenWin to enable HDR mode. This currently queries the HDR feature, but will pull the logic out of the GPU process in the next patch. R=hubbe TBR=avi (for content/) Bug: 682416 Change-Id: Ieffca5a3e0fa01a98aea5558db251712989519e7 Reviewed-on: https://chromium-review.googlesource.com/596776Reviewed-by:
ccameron chromium <ccameron@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#491211}
-
Stuart Langley authored
Bug: 712963 Change-Id: I079d33a74817c384e69ff1009e15af72c4bb9c4f Reviewed-on: https://chromium-review.googlesource.com/596619Reviewed-by:
-
Devlin Cronin authored
With the new task scheduling system, there are no guarantees that different operations will not collide - each caller has to ensure that no conflicting tasks will be scheduled and executed synchronously. This means that for file tasks, we need to have a common task runner for any tasks that may touch the same files. Introduce a common SequencedTaskRunner for the extension system, and use it in the UserScriptLoader. Additionally, use it in ExtensionService, in lieu of the prior ExtensionService-owned task runner that's used for file tasks in installation. Finally, also make the GetFileTaskRunner() method in ExtensionService non-virtual, since it's not needed on any of the interfaces. Bug: 689520 Bug: 750122 Change-Id: I9d0b993689821e7aca9b2553283609cce796a162 Reviewed-on: https://chromium-review.googlesource.com/593854Reviewed-by:
-
Scott Graham authored
This resolves e.g. base_unittests not being able to find operator new, string::string(), etc. in Debug (is_component_build=true) builds. This matches other platforms, but was missed in creating the Fuchsia test() template. Bug: 750392 Change-Id: I1a7ba2988e9d991f26d392eeab670f3a100de319 Reviewed-on: https://chromium-review.googlesource.com/596520Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491208}
-
Conley Owens authored
Currently, there are no browser-side geolocation permission checks. This change adds a GeolocationService, which performs this check in the browser. BUG=426384 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I40925adc1e18ff8549a6d9dd94f998e013ebf3a1 Reviewed-on: https://chromium-review.googlesource.com/558604 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491207}
-
Elliot Glaysher authored
Bug: 750642 Change-Id: Ibb22a58e8554916190e3e667d65740cf89d7be58 Reviewed-on: https://chromium-review.googlesource.com/596832Reviewed-by:
-
Kevin Marshall authored
Fuchsia: enable MemoryMappedFile tests Fuchsia now supports mmap() for tmpfs, so these tests Just Work. Bug: 746051, 706592 Change-Id: I208c88852bcd22cec0b03f8c2578c71fd305c663 Reviewed-on: https://chromium-review.googlesource.com/596611Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#491205}
-
