- 09 Jul, 2019 40 commits
-
-
Chih-Yu Huang authored
The attribute of VideoFrame |visible_rect| and |natural_size| are not related to the frame buffer layout. In this CL, we allocate VideoFrame only with |format| and |coded_size|, and update |visible_rect| and |natural_size| at wrapped frames when passing to the client. This CL also polished some coding style in platform_video_frame_pool_unittest.cc. BUG=chromium:941330 TEST=./media_unittests --gtest_filter=PlatformVideoFramePoolTest* Change-Id: I647cac17c73a2e75a6be35ca75b070338ae638fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686478 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#675604}
-
arthursonzogni authored
The RenderViewHostImpl is kept alive as long as it exists one RenderFrameHostImpl or one RenderFrameProxyHost depending on it. The FrameTree maintains a map: SiteInstance → RenderViewHostImpl for reusing existing RenderViewHostImpl. # Before this CL: The refcount for the RenderViewHostImpl was handled by the FrameTree. RenderFrameHostImpl and RenderFrameProxyHost had to manually call functions on the FrameTree to update it. # After this CL: The refcount is handled by the RenderViewHostImpl itself, it becomes a base::RefCounted. RenderFrameHostImpl and RenderFrameProxyHost are now holding a base::scoped_refptr and the RenderViewHostImpl are automatically deleted. # Why this CL: 1) Less code. No more manual refcount. No more risk of leaking a RenderViewHostImpl. 2) The FrameTree is no more in charge of "deleting" the RenderViewHostImpl. This allows them to move freely. The BackForwardCache will have to contain the set of used RenderViewHost for a page. This CL is a small step in this direction. Bug: 511340 Change-Id: I1afb30c919dc07cf8e693c28a34fa6f476b45a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665936Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#675603}
-
Julian Pastarmov authored
This reverts commit e77aa323. Reason for revert: Breaks the translation pipeline. Original change's description: > Replace placeholders by value in policy localized json files > > The localized files generated from policy_templates.json contain > placeholders such as $1, the placeholders should have their real > values. > > Bug: 976254 > Change-Id: I8b7ed1a61bceeef1d7443736f3f0176acaaee233 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666702 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675094} TBR=agrieve@chromium.org,ljusten@chromium.org,ydago@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 976254, 982069 Change-Id: Ic4e97947052590830215513fa3ede38ed5e7a836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692572Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#675602}
-
Javier Ernesto Flores Robles authored
Sets a default dark color for the web view when in dark mode and keeps a similar light color by default. This makes the appearing animation smoother when loading webpages while in dark mode. Bug: 976640 Change-Id: I42c3decbace1c8a136d8910343dd31c22751a2ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691199 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#675601}
-
Javier Ernesto Flores Robles authored
Updates the colors to use the new dynamic colors on iOS 13, which support dark mode. Bug: 976640 Change-Id: I49961c56918a56f17fc30318ff7fcf2608e11216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692742Reviewed-by:
-
Michael Lippautz authored
This moves all garbage collection features into Blink's common features bottleneck as these features - do not require IDL support - are not flipped for tests only but always fully enabled - often require Finch support which is not directly supported for RuntimeEnabledFeatures Change-Id: Icf5dfcdfcee3169560f133e5e77b4442fd813fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692405 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#675599}
-
Tanmoy Mollik authored
Bug: 899381 Change-Id: I8202d4d78cc42919a26dcad86fd2fca54ab9e53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688833Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#675598}
-
Miyoung Shin authored
This CL replaces the use of std::unordered_map of std containers with WTF::HashMap in indexeddb/*. Bug: 952716 Change-Id: Ic56b442d83f41a141a06002ef050ed35177e798e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692385Reviewed-by:
-
Miyoung Shin authored
This CL replaces the use of std::unordered_map of std containers with WTF::HashMap in peerconnection/*. Bug: 952716 Change-Id: Ib4f94dbda2bd07caf6c8cd144b0cec74ef5fb9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692561Reviewed-by:
-
Finnur Thorarinsson authored
and close requests that fail properly. Bug: 895776, 656015 Change-Id: I90b7d323071a38e84275b4f7ad5c96fa97a72e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690876 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#675595}
-
Nicolò Mazzucato authored
A parameter has been added to ProducerClient to specify the size of the shared memory buffer pages. So far, this value is hardcoded in producer_host.cc:62 Bug: 925148 Change-Id: I365327ac43833e8738d736c3bbdac3ef590ced31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681579Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nicolò Mazzucato <nicomazz@google.com> Cr-Commit-Position: refs/heads/master@{#675594}
-
Edvard Thörnros authored
The method has been simplified and state mutation has been hoisted to the calling methods to make it clearer what is mutating what. This is the first step in a series of commits to be able to separate the timing logic from the updating logic. This aims to make it easier to make upcoming edits. No changes should be made with this commit in how the application functions or the runtime. Bug: 981522, 641437 Change-Id: I7a969bf08d93988d500c512f3d56aebc6e2e071c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692567 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#675593}
-
Daniel Bratell authored
In some (non-default) extreme jumbo builds the CreateBorderWithVerticalSpacing in chrome/browser/ui/views/page_info/page_info_hover_button.cc and the one in chrome/browser/ui/views/hover_button.cc ended up in the same translation unit and prevented compilation. I don't know of a shared place to put it, but since one of them is only used once and it's 2 lines long, this CL manually inlines it. Bug: 969734 Change-Id: I58b0219aecc7af8803b03c1857498eda5205af89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690842 Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#675592}
-
Robbie Gibson authored
All of the removed functions in bookmark_utils_ios are not used anywhere. Bug: 976664 Change-Id: I247423c3fdcc86b87106349d716c270d52e45b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690851Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#675591}
-
Hajime Hoshi authored
kTest is not used anywhere. Change-Id: Ia025d9d867ec35e1bfd2a36ecfd821337ed8fe35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692568Reviewed-by:
-
Omer Katz authored
Replaced Scrollbar destructor with equivalent prefinalizer. Prefinalizer of ScrollableArea calls RunScrollCompleteCallbacks to Release the callbacks, and resets uniqueptr to TaskRunnerTimer. Bug: 981043 Change-Id: I45d35928eef440bc079de77364ac2d4d0ed6ecb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688968Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#675589}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/09e091321115..26cfccc5f526 git log 09e091321115..26cfccc5f526 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 fmayer@google.com Merge "Allow to symbolize profiles." Created with: gclient setdep -r src/third_party/perfetto@26cfccc5f526 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idc7fd1586006c7e203e3854540b79a84ec41de06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692071Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675588}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b8ab80843f67..0c4feb643b89 git log b8ab80843f67..0c4feb643b89 --date=short --no-merges --format='%ad %ae %s' 2019-07-08 33432579+alan-baker@users.noreply.github.com Remove extra semis (#2717) 2019-07-08 33432579+alan-baker@users.noreply.github.com Validate usage of 8- and 16-bit types with only storage capabilities (#2704) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@0c4feb643b89 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@chromium.org Change-Id: Ia38ff222068b2c9afacd66b6aa1e2fca1bb0262a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692723Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 74e4e0e7. With Chromium commits locally applied on WPT: bc7ec548 "MSE: Test addSourceBuffer and changeType relaxed type strictness and allowance for implicit changeType" 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" 2ebcc1f6 "Move movementX/Y calculation for aura pointer-locked state to Blink." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I670c4ef8816082bdfad70bdfe17277429dcd801b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692444Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675586}
-
Antonio Gomes authored
The following files have their own variations of this helper internal class: - local_media_stream_audio_source.cc - track_audio_renderer.cc - media_stream_video_capturer_source.cc This CL factors them out into a single file, media_stream_local_frame_wrapper.cc|h, so we share their identical implementations. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I7a488d11815be69376be09d1610c51dbf89570e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688185 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#675585}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3de2d3762e79..0ff2e89a416d git log 3de2d3762e79..0ff2e89a416d --date=short --no-merges --format='%ad %ae %s' 2019-07-09 perezju@chromium.org [dashboard] Update system health report Created with: gclient setdep -r src/third_party/catapult@0ff2e89a416d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:907040 TBR=sadrul@google.com Change-Id: I5594f7ed29c7aff6af1723891497a58509ad9ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692070Reviewed-by:
-
Yasmin authored
Bug: 981902 Change-Id: I9d800245dd649a13cd3772e4be9078a3baa4ad6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690877 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#675583}
-
Pauline Leitao authored
BookmarkNode types are currently mutable and either set with a set_type() method or inferred from URL validity. This CL changes this set-up so that type is defined within the constructor and remains unchanged throughout the existence of the BookmarkNode. This is not only more coherent with the concept of type itself, but also removes the redundancy of calling set_type() after having instantiated a BookmarkNode whose type was already automatically set to the same thing. It also rectifies certain incoherences within other parts of the code, such as the need to re-set permanent node types after decoding them, which had previously caused the BookmarkNode type to be changed to Folder. Objectively, this CL does the following: 1. Changed the main BookmarkNode constructor to take in a type instead of calculating it internally. 2. Changed helper BookmarkNode constructors that take in less parameters to compute node type within them based on URL validity. 3. Additional helper BookmarkNode constructors were added to allow for the creation of nodes with explicit type but not every other parameter. 4. Changed the BookmarkPermanentNode constructor to always take in a type instead of inferring it from other pieces of information. Bug: 980301 Change-Id: Iafb32cbb4c4324f39d505761b3304e6ddaaca807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683850 Commit-Queue: Pauline Leitao <psivieroleitao@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#675582}
-
Hitoshi Yoshida authored
This CL makes IRBuilder to build instances of IdlType. IdlType is an API class, and all its instances must be instances of its sub classes. Note DefinitionType and TypedefType won't be built from AST. Change-Id: I4fab477cf24294f691e6102c7360211555871dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692481 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#675581}
-
Robbie Gibson authored
The gray text came from the placeholder font color. According to the documentation, setting the |attributedText| property of a UILabel overrides the |textColor| with the color of the first character of the attributed string. However, this bug appears only on iOS-13, so that may be a recent change. Bug: 979202 Change-Id: Ic387864629d92a4e0cefb42dcf60dd2a58c076c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689199 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#675580}
-
Askar Aitzhan authored
Add documentation that gives some overview on Invalidation component and to FCMInvalidationService in particular. Add image with UML diagram. To view the markdown run in chromium/src: ./tools/md_browser/md_browser.py --external And go to http://localhost:8080/components/invalidation/impl/README.md in your browser. Change-Id: I02e43bdcc4cdb5d254e701955b6bd834e9409f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687872 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#675579}
-
Yoshifumi Inoue authored
Change-Id: I951fca6e5b86ae01aae0521f609a2d37512b4329 Bug: 975555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664033Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#675578}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dc767a415467..8679d594ec31 git log dc767a415467..8679d594ec31 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 vapier@chromium.org lint: flag legacy cmp usage Created with: gclient setdep -r src/third_party/chromite@8679d594ec31 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I31e7ad6b7b57e32456a122268a56c2d2fa280aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691853Reviewed-by:
-
Nasko Oskov authored
The metric is still useful as there is planned work to remove unneeded IPC roundtrips to the renderer process when there is no handler registered for the beforeunload event. I'm extending the expiration by 6 milestones and updating the owners. Bug: 975310 Change-Id: Ica8c088a06b51788c504f116fdfb3d2798f13a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691873 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#675576}
-
Michael van Ouwerkerk authored
Bug: 972061 Change-Id: I91eef6d3dd1f5cc00ea225b446f5481d4978135c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690580Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#675575}
-
Benoît Lizé authored
This reverts commit 72b6f10a. We are re-introducing ModernLinker for Android Q. Split legacy linker out of linker_jni.cc again. Bug: 979638 Change-Id: I5a8b5a6b8b59a5ed3a3aee7caa0cac35b7b5f780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683517 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#675574}
-
Chih-Yu Huang authored
Before passing VideoFrame to the client, PlatformVideoFramePool wraps the frame for recycling reason. The client can query the origin frame by UnwrapFrame(). However, the client might wrap the frame again to update parameters like visible_rect and natural_size. In this CL, PlatformVideoFramePool supports to query the origin frame by the frame which is wrapped multiple times. BUG=chromium:941330 TEST=Pass media_unittests TEST=Pass video_decode_accelerator_tests on Kevin Change-Id: I2501abb55b948b7b44d3651b2c4623ff19ab044d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657871Reviewed-by:
-
Dominik Röttsches authored
R=etienneb Change-Id: I12195f2a531802fdc602e5a28d07711efce224b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681124 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#675572}
-
Vasilii Sukhanov authored
Bug: 936011 Change-Id: Iafcac98934450c1220a3309d537303c407a4645d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690849Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#675571}
-
Henrique Ferreiro authored
This is an intermediate step in the process of moving all of ProfileOAuth2TokenServiceBuilder code into IdentityManagerBuilder. To do this, the building of PO2TS cannot use Profile not any code from //chrome/browser. In this CL, ProfileOAuth2TokenServiceBuilder is modified to access the AccountManager and check if the profile is a regular one, both on Chrome OS, from parameters provided by IdentityManagerFactory. Bug: 974198 Change-Id: I00ba3a804975788f5d1eb45dd25d426ec59e9f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690569Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#675570}
-
Victor Hugo Vianna Silva authored
We plumb the information of a whether a history entry is local or not to the javascript level and then use this information to determine whether to talk FaviconRequestHandler or FaviconService directly at the chrome://favicon2 level. Bug: 967746 Change-Id: I264e7064a0d07b1172cc5869956f8c689ca6fa0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674101 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#675569}
-
Gauthier Ambard authored
This CL fixes the accessibility customs actions of the Most Visited cells. Bug: 981496 Change-Id: I472743386bf728c3f2d852359978aff859088ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690576Reviewed-by:
-
Lowell Manners authored
I found while working on firing events for bfcache navigations, that it's possible to create bugs where back/forward navigation works once, but fails the second time. We should have automated coverage for this case. Change-Id: I239fab99c2ad8b81d0300eeb943bbd398eb7f6cf Bug: 976697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685380Reviewed-by:
-
Michael Lippautz authored
HeapCompact::Relocate crasher has been sorted out, so compaction can be re-enabled again. Bug: 961231 Change-Id: I5de3c08255711def71f21bf060c885aec5e073dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692404 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I9fa277d2c8a4128c0453716072b014101fa61e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692189Reviewed-by:
-
