GitLab

Add DCHECK_EQ(view, masked_view()) to the overrides of
MaskedViewTargeter::GetHitTestMask(). This is to ensure
the function is only called with |view| corresponding
to the view on which the targeter is installed.

This is nice to have because GetHitTestMask()
is called directly from a few places such as
overrides of View::GetHitTestMask() and (soon)
from within TabCloseButtonTargeter; see issue
377557.

BUG=377527
TEST=none

Review URL: https://codereview.chromium.org/308003019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274852 0039d316-1c4b-4281-b951-d872f2087c98

A request for the "TARGETS" target of the clipboard selection via
XConvertSelection(display, selection, target, property, requestor, time)
should set |property| to a property of type XA_ATOM. Mono apps set |property| to a property of type "TARGETS" instead.

This CL treats a property of type "TARGETS" the same as a property of type XA_ATOM.

BUG=377893
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/314943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274851 0039d316-1c4b-4281-b951-d872f2087c98

Clean up gin run all unittests file. I noticed some extra includes while searching for some code to copy.

BUG=
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/318543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274850 0039d316-1c4b-4281-b951-d872f2087c98

This patch enables audio / video thumbnail extraction. A lot of supporting code has already gone in. This is the last piece in the actual extension API that enables this.

BUG=304290

Review URL: https://codereview.chromium.org/250143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274849 0039d316-1c4b-4281-b951-d872f2087c98

Needed for converting some TextButtons to LabelButtons.
(eg. new avatar button, bookmark buttons on drag)

BUG=155363
TEST=Label example shows a halo'ed label.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/308083011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274848 0039d316-1c4b-4281-b951-d872f2087c98

ReadPixels with format GL_BGRA_EXT is not necessarily supported by the
GLES2-based GPU command buffer. The support for this format needs to be
explicitly queried, and if it is not supported, the pixels need to be
converted from RGBA to BGRA on the CPU if a BGRA result is desired.

BUG=380129
TEST=WebGL conformance tests

Review URL: https://codereview.chromium.org/316553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274847 0039d316-1c4b-4281-b951-d872f2087c98

And associated code.

BUG=352392

Review URL: https://codereview.chromium.org/285283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347425

Review URL: https://codereview.chromium.org/309253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274844 0039d316-1c4b-4281-b951-d872f2087c98

Temporarily move the flag into Chromium's repo, to facilitate
atomic remove-and-suppress-failures changes.

BUG=380686
TBR=humper@chromium.org

Review URL: https://codereview.chromium.org/319483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274843 0039d316-1c4b-4281-b951-d872f2087c98

Notifies the workspace layout manager when the on-screen keyboard is shown to reposition the focused window, preventing occlusion of the active text field.

BUG=235811

Review URL: https://codereview.chromium.org/313463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274842 0039d316-1c4b-4281-b951-d872f2087c98

I had to find a way to destroy a ViewManagerConnection from the client lib.
In the new world, the ViewManagerSynchronizer is the InterfaceImpl, and lifetime of all other client objects hangs off it.
ViewManagerSynchronizer is owned by the ServiceConnector which is owned by the Application object, so I had to find a way to delete that. In the test, I simply reset the ServiceLoader by URL. This tears down the synchronizer & corresponding ViewManagerConnection, triggering the correct notifications.

Dave, I had to add a NULL check in the service manager code because it hadn't considered there could be a NULL loader for a URL. LMK if you have a different idea.

R=davemoore@chromium.org, sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/315863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274841 0039d316-1c4b-4281-b951-d872f2087c98

R=rmcilroy@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/310073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274840 0039d316-1c4b-4281-b951-d872f2087c98

Background: I am currently trying to test NaCl in clank by setting disable_nacl=0 and enable_plugins=1 in gyp.  Some of the code required to get this to work is guarded under overly-specific OS==android and similar constructs.  This first CL enables a coherent build with the flags set to gyp, but does not yet turn the functionality on completely.  A sampling of issues fixed:

1) std:: prefix is more strictly observed on android
2) define NACL_LINUX, etc., is needed for nacl code
3) properly guard flag-setting code

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032
R=bradnelson@google.com, darin@chromium.org

Review URL: https://codereview.chromium.org/299703016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274839 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes it possible to run the perf profiler 
through adb_profile_chrome. The result is a trace file that 
contains samples from perf as well as events from Chrome 
trace events or systrace.

For example, to find out in which functions CPU time is 
being spent:

$ build/android/adb_profile_chrome --browser build --time 5 --perf

BUG=375754
TEST=build/android/chrome_profiler/run_tests
NOTRY=true

Review URL: https://codereview.chromium.org/293193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274837 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274836 0039d316-1c4b-4281-b951-d872f2087c98

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/313913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274835 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274829 0039d316-1c4b-4281-b951-d872f2087c98

Now that we have separated out the tests that require special resources
to the perf browsertest, we can enable the main test case on the
tree-closing waterfall. This will do the same thing as the content
browsertest but run on the full browser rather than content_shell.

BUG=375240

Review URL: https://codereview.chromium.org/313833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274826 0039d316-1c4b-4281-b951-d872f2087c98

Guest site instances that encode partition information are webview specific
so this CL moves that method to WebViewGuest for logical consistency.

BUG=364141

Review URL: https://codereview.chromium.org/314853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274825 0039d316-1c4b-4281-b951-d872f2087c98

Add methods to abstract BookmarkService and BookmarkModel methods used
by HistoryService through the HistoryClient interface.

BUG=371825
TBR=sky

Review URL: https://codereview.chromium.org/285233012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274824 0039d316-1c4b-4281-b951-d872f2087c98

* This CL depends on https://codereview.chromium.org/287383002/
* There's no caching or monitoring in this CL.
* Browser test will be done in follow-up CL. (That's pending blink interface landing.)

BUG=338511

Review URL: https://codereview.chromium.org/312773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274823 0039d316-1c4b-4281-b951-d872f2087c98

BUG=312716

Review URL: https://codereview.chromium.org/312673006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274822 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274821 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff mvstanton@chromium.org in case of problems.

R=jochen@chromium.org, mvstanton@chromium.org
TBR=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/316853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274820 0039d316-1c4b-4281-b951-d872f2087c98

Also, add interactive_ui_unittests to the exising tester.

BUG=178409
R=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/312833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375672
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/318633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274818 0039d316-1c4b-4281-b951-d872f2087c98

This is for compliance with NetInfov3 (http://w3c.github.io/netinfo/).

BUG=378785

Review URL: https://codereview.chromium.org/307943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334149
R=haraken@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/318623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274816 0039d316-1c4b-4281-b951-d872f2087c98

(This is cherry-picking a single bug fix from ChromeVox upstream.)

The repro is this html:
<div tabIndex=0 role="slider" aria-valuenow="20"></div>

The bug happens when cvox.BrailleUtil.getState calls
cvox.ChromeVox.msgs.getMsg to see if the "_brl" translation exists,
and passes it 'aria_value_now_brl' in this particular case,
whose value is just "$1". If you don't pass it an argument, you
get '' back, and that throws an error because a message should never
return the empty string.

BUG=379296
R=plundblad@chromium.org

Review URL: https://codereview.chromium.org/302063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274815 0039d316-1c4b-4281-b951-d872f2087c98

R=jamesr@chromium.org
BUG=NONE
TEST=NONE(No functional change)

Review URL: https://codereview.chromium.org/310733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274814 0039d316-1c4b-4281-b951-d872f2087c98

Ephemeral apps have a lower initial threshold, which should be
increased when they are promoted to regular installed apps.
This patch also moves the storaged monitoring related prefs
into ExtensionStorageMonitor, as they are specific only to
this service.

BUG=374018
TEST= browser_tests (ExtensionStorageMonitorTest.*)

Review URL: https://codereview.chromium.org/314563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274813 0039d316-1c4b-4281-b951-d872f2087c98

They're super useful when debugging media layout tests.

Review URL: https://codereview.chromium.org/313683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274812 0039d316-1c4b-4281-b951-d872f2087c98

TBR=oshima@chromium.org
TEST=None
BUG=None

Review URL: https://codereview.chromium.org/311943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274811 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 8dfdf978.

Breaking Linux Chromium OS Tests:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/44018

BUG=none
TBR=hamaji@chromium.org

Review URL: https://codereview.chromium.org/313053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274810 0039d316-1c4b-4281-b951-d872f2087c98

LayerTreeHostTestMaxTransferBufferUsageBytes.RunMultiThread_DirectRenderer_ImplSidePaint
is failing flakily.

BUG=380662
TBR=kaanb@chromium.org

Review URL: https://codereview.chromium.org/318633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274809 0039d316-1c4b-4281-b951-d872f2087c98

https://chromiumcodereview.appspot.com/309693002/ introduces a cache policy in Blink indicating end-to-end reload. It translates to
the load flag net::LOAD_BYPASS_CACHE (instead of having blink set HTTP cache
headers "Pragma: no-cache" and "Cache-Control: no-cache".

BUG=376025

Review URL: https://codereview.chromium.org/308083009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274807 0039d316-1c4b-4281-b951-d872f2087c98

 - false positive in FcStrStaticName due to unannotated atomics in Skia (issue 369257)
 - lock inversion in Gtk2UI (issue 380554)

BUG=380554,369257
TBR=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/318553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274806 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Fix member variables names.
3) Rename file name to mock_webrtc_dtmf_sender_handler.

BUG=360000

Review URL: https://codereview.chromium.org/310783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274805 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/308393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274804 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364712
TEST=None

Review URL: https://codereview.chromium.org/317613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274803 0039d316-1c4b-4281-b951-d872f2087c98