GitLab

Bug: 853953
Change-Id: I25c0b40b23936d8c89790153f97d135780035026
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769548
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690827}

https://quiche.googlesource.com/quiche.git/+log/3de7170b31c5..6c73c33b7d8c

$ git log 3de7170b3..6c73c33b7 --date=short --no-merges --format='%ad %ae %s'
2019-08-26 renjietang No longer send SETTINGS in gQUIC.
2019-08-26 fayang gfe-relnote: In TLS client handshaker, call OnHandshakeComplete when handshake is finished. Protected by existing FLAGS_quic_supports_tls_handshake.
2019-08-26 bnc Remove VersionUsesQpack() TODO.
2019-08-26 zhongyi Always create and destroy a single client in the creation of the QuicClientTest to ensure persistent sockets for certificate verifiers are opened before testing.
2019-08-26 bnc gfe-relnote: Deprecate gfe2_reloadable_flag_quic_avoid_empty_frame_after_empty_headers.
2019-08-26 fkastenholz Save all data from received IETF Connection Close frames
2019-08-24 ianswett gfe-relnote: Do not enable version 99 unless gfe2_reloadable_flag_quic_use_parse_public_header is also enabled.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I71b64773eb6640f78dba6b43cf864070127998f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772294
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690826}

This patch makes it a requirement for all task traits to specify their
thread affinity on ChromeOs. Previously task traits that did not name a specific
thread would implicitly run on the thread pool, which could be
surprising. To make this more obvious, thread pool tasks must now use
the base::ThreadPool() trait.

Previous patch applied the checks on all platforms except ChromeOs which was failing:
https://chromium-review.googlesource.com/c/chromium/src/+/1769080
This CL enables the check on ChromeOs:
joelhockey@ fixed the chromeos build in
https://chromium-review.googlesource.com/c/chromium/src/+/1767447

Bug: 968047
Change-Id: I18efe212b94fe35f55e446c76ce2c3f20cc259f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771976Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690825}

Adds a BinderRegistry::AddInterface() override which accepts a
PendingReceiver-based binder callback. This is to ease the ongoing
mass transition of code over to newer Mojo typenames.

Cleans up a bunch of one-off transitional helper functions that were
added recently due to a lack of this support.

Bug: 955171
Change-Id: Id55412a7e87e6ba0261f9710b40a8366d2c3226b
TBR: tkent@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772056
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690824}

The idle page test runs with and without MR extension, but there is no good way to distinguish them because they use the same name.
Now, for the test with no MR extension, we use #no_media_router to identify it.

Change-Id: Iac6bc9f1ab411e14c0d51129290c293394f8ded9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772569
Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690823}

This is necessary for a followup patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1769158

But split out here for simplicity.

This new flag will return true if a self-collapsing block has any
adjoining object descendants (typically floats).

Change-Id: I9e901aae9971a64d854a70672a5b26d5026d2bc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772291Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690822}

Bug: 900581
Change-Id: Ia92d41788e13e7fb496b3e426d54622320f137cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769306Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690821}

The type is not used for communication with chrome over the network
config api, it is associated with the chrome.send calls for
third party vpns.

Bug: 853953
Change-Id: I9c4217b2f3cd2cee482ad51c0f0c4edd66ba8326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769617
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690820}

It's coming through SkRefCnt.h incidentally today.

Change-Id: If729712090749f323c176217add7ebec5bf4cf07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773401
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Auto-Submit: Mike Klein <mtklein@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690819}

R=pkasting@chromium.org

Bug: 997713
Change-Id: I8431c2d6bf3df0d5731dc48b5870bae2604aef63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771936
Auto-Submit: Stephen Lin <stephenlin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690818}

Updates the expires_after attribute for 121 histograms that show
frequent access in the past 90 days.  These are the 70% most
frequently used histograms over that time that do not already have a date later
than or within 60 days of 2020-02-23.

Change-Id: Iad055af9ccafc95bff082623107faca6a5141202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769095
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690817}

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/ed2eef654373..6a3d632f40a1

git log ed2eef654373..6a3d632f40a1 --date=short --no-merges --format='%ad %ae %s'
2019-08-26 misterg@google.com Googletest export

Created with:
  gclient setdep -r src/third_party/googletest/src@6a3d632f40a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/googletest-chromium-autoroll
Please CC isamsonov@google.com,staphany@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng

TBR=isamsonov@google.com,staphany@google.com

Bug: None
Change-Id: Ie0dacd9cdc4c122fa7089c946ed30803a65e0af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771590
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Staphany Park <staphany@chromium.org>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690816}

Now that BlinkGenPropertyTrees has launched, there is no need to track
OverscrollBehavior on cc::Layer because it is tracked on cc::ScrollNode.

Bug: 994361
Change-Id: Ic87508ed0e67c7be47b87f9313df554be01c891b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773200
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690815}

The leak detector (enabled by --enable-leak-detection) complains because
the SVG images created and owned by the UA style sheet are not free'ed
at the end of the tests but it's expected because the UA style sheet is
a singleton (DEFINE_STATIC_LOCAL) and the SVG images will never be
free'ed while a renderer is alive.

Since the leak detector is not interested in anything referenced from
CSSDefaultStyleSheets [1], this CL addresses the leak by re-creating
the default style sheet in CSSDefaultStyleSheets::PrepareForLeakDetection
to clean up the SVG resources before the leak detection.

This CL also sets flattenhtml=true for IDR_UASTYLE_THEME_CONTROLS_REFRESH_CSS,
which was reverted by [2] due to the memory leak. (The reverted CL [3]
will be re-landed in a separate CL)

TestExpectations is also updated to re-enable password tests which was
disabled due to the memory leak.

[1] discussion on memory-dev:
https://groups.google.com/a/chromium.org/d/topic/memory-dev/LwiD2RBqUpg/discussion
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1722789
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1716161

Bug: 988232
Change-Id: I2f289e90f7c16cfe23f501ddc19ea219be7c5bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772657
Commit-Queue: Alex Keng <shihken@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690814}

Previously though TransformationMatrix was marked as alignas(16) and
the compiler generates machine instructions assuming the alignment,
the alignment was not always ensured, e.g. when a TransformationMatrix
field was in a GC object (which is allocated by Oilpan which doesn't
support alignment at 16-bytes). The program would crash when
misalignment happened (which could be random). We had to workaround
that by using something like unique_ptr but that is fragile and hard
to ensure.

The alignment was added in [1] for x86_64 16-byte-aligned SSE2
instructions which were faster than the unaligned counterparts on
older architectures.

On modern architectures since Sandy Bridge (first CPU shipped in 2011),
aligned and unaligned SSE2 instructions have the similar performance
[2][3][4].

Now we remove alignas(16) from TransformationMatrix to avoid
the alignment trouble.

[1] https://chromium.googlesource.com/chromium/src/+/acbc19c46aace2f7980876d96422067f61eb3f01
[2] https://software.intel.com/sites/landingpage/IntrinsicsGuide/#techs=SSE2
   (see Performance of _mm_load_pd, _mm_loadu_pd, mm_store_pd, mm_storeu_pd)
[3] https://software.intel.com/en-us/forums/intel-isa-extensions/topic/752392
[4] https://www.agner.org/optimize/instruction_tables.pdf

Bug: 993638
Change-Id: I24524a1dae259f69c2a47fb0ac97dc517047be03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752840Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690813}

As per UI review, we should change the swipe to dismiss
direction from vertical to horizontal. Therefore,
swiping right should dismiss the controls.

BUG=998125

Change-Id: I88998ec07b49b9ba5ad316647848a71167f5b8c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773441Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690812}

https://crrev.com/690041 added handling for out of bound indices in
PDFiumPage::GetTextRunInfo(), but failed to consider a valid situation
where all the text in a text run are whitespaces. In this case,
GetTextRunInfo() needs to report the number of characters processed.

Add a test case with just a whitespace to test this condition.

Also update hello-world.in to have a {{streamlen}} macro and regenerate
hello-world.pdf

Bug: 997747
Change-Id: Id9e074080b19e4c642cf75fa6b72c5eb969197a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769842Reviewed-by: Ian Prest <iapres@microsoft.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690811}

Previously, caBLE discovery dealt with a const pointer to a
|CableDiscoveryData| because the only possible |CableDiscoveryData|
objects were those given via the WebAuthn extension.

In the future, we'll need to be able to create |CableDiscoveryData|
objects from candidate EIDs because they could also match a QR code.
Thus, rejig the functions to return an optional |CableDiscoveryData|
rather than a const pointer.

The Bluetooth stack returns UUIDs as strings and the previous
implementation hex-encoded the expected UUID and matched the resulting
string. Since we now need to get the binary EID, the UUID needs to be
parsed instead. That leaves the binary-to-string encoding function as
something that's only used in a unittest, so the function moves into
that unit test in this change.

Change-Id: I3e675bcec66bf2416df4945ec1b2487962971729
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753697
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#690810}

Some devices may be domain joined but not have any active policies.
We should also disable DoH by default for that scenario.

Bug: 955454
Change-Id: I50ad015e9e5d072dddcaa72524e5d39ffb2e005c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773397Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#690809}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/8e49d0a2b160..be14352b8322

git log 8e49d0a2b160..be14352b8322 --date=short --no-merges --format='%ad %ae %s'
2019-08-27 zoddicus@users.noreply.github.com Refactor internals of conversion API to be more modular (#785)

Created with:
  gclient setdep -r src/third_party/shaderc/src@be14352b8322

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: Ifc810c161e0e637da8bf2fd5a5c87b27de86cbcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773238Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690808}

Bug: 995443
Change-Id: I3e468ccacc4c8391ae6d1616608dcc76fd8335e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766440Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690807}

https://skia.googlesource.com/skia.git/+log/f01008997555..c445c7d5c87b

git log f01008997555..c445c7d5c87b --date=short --no-merges --format='%ad %ae %s'
2019-08-27 senorblanco@chromium.org Dawn: Remove spirv-tools and spirv-headers rules from Dawn build files.
2019-08-27 mtklein@google.com remove unused sk_sp comparison operators
2019-08-27 michaelludwig@google.com Fix long line

Created with:
  gclient setdep -r src/third_party/skia@c445c7d5c87b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: None
Change-Id: Iccdeaf45fad85d62e97d26091b70257e965dbe37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773356Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690806}

Normally, scrolls started from a position: fixed element will chain up
to the "viewport", reglardless of DOM ancestry. This is so that
scrolling over a banner/menu scrolls the page.

The situation is a little different in the root scroller case. There,
the "viewport" is composed of the visual viewport, and a non-default
layout viewport. e.g.

<body>
  <div id='myrootscroller'>...</div>
  <div id='fixed'></div>
</body>

In this case, "viewport" scrolling will scroll |myrootscroller|.

In the above case, scrolling over |fixed| shouldn't cause scrolling in
|myrootscroller| since that would change semantics on the page which
isn't acceptable for an implicitly applied feature (e.g. this is an
interop problem).

However, in BGPT the scroll_tree_index on a fixed cc::Layer is made to
point to the ScrollNode for the nearest ScrollTranslationTransformNode
which will always be the visual viewport's, since the Fixed layer
translates with the visual viewport.

In the compositor, we unconditionally treat "inner/visual viewport"
scrolls as scrolling using cc::Viewport which will have the behavior
of scrolling both visual and layout viewports (it will scroll
|myrootscroller| above).

This CL makes two conceptual changes:

-The compositor no longer unconditionally scrolls the inner ScrollNode
 using cc::Viewport. Whether or not the inner ScrollNode should scroll
 with the cc::Viewport now depends on a Blink-set bit
 |prevent_viewport_scrolling|. We scroll using cc::Viewport only when
 this bit is false. The change in LayerTreeHostImpl::TryScroll to scroll
 the outer viewport even if it has no extent is to compensate for the
 fact that we no longer unconditionally fallback to viewport scrolling.

-Set this bit in Blink during pre-paint based on whether or not we
 have a non-default root scroller. That is, we only want to provide
 full viewport scrolling in this case if the root scroller hasn't been
 changed.

This also required some small fixes to tests, in particular, some tests
use an awkward layer tree where the outer viewport has no srolling and
the visual viewport is scrollable. Inner/Outer scrolling is unusual in
these cases because we typically want to scroll both at the same time
using cc::Viewport. Changing to explicitly scroll inner only meant these
tests break. I've changed them by adding a real scrolling layer as a
child of the outer.

For more details see:
https://docs.google.com/document/d/1bp7nQq76I1HgtWW6fjfTFo__7Sy5XTUsigS-WHpC3B0/edit

Note: This is still an issue in main thread scrolling (added tests fail
there). I don't believe this is worth fixing there since it would
require major changes to allow adding a non-DOM element to the scroll
chain and the provided value is low (root scroller is currently only
active on Android where main thread scrolling is rare). This should be
fixed by scroll unification.

Bug: 977954
Change-Id: I644e0d618a21baced50b7b99d543bd517adbd91a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752866Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690805}

Right now all the FrameSequenceTrackers are owned by LayerTreeHostImpl,
moreover, LayerTreeHostImpl also owns a FrameSequenceTrackerCollection.

This CL makes FrameSequenceTrackerCollection owns all the trackers,
any operation on the trackers can be done throughput
FrameSequenceTrackerCollection.

This CL should not cause any behavior change.

Bug: None
Change-Id: If8b15990ed6c1664af8eaa9c81c1a2888cf40ee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769025Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690804}

https://swiftshader.googlesource.com/SwiftShader.git/+log/605f863173b6..a9da772f0587

git log 605f863173b6..a9da772f0587 --date=short --no-merges --format='%ad %ae %s'
2019-08-27 chrisforbes@google.com Pass draw-to-draw varying state directly to Renderer::draw
2019-08-27 chrisforbes@google.com Do not expose extensions for KHR_shader_draw_parameters and KHR_variable_pointers

Created with:
  gclient setdep -r src/third_party/swiftshader@a9da772f0587

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/132280877
Change-Id: I5b0f1ded5be153b46704afe4630a948c8aed9334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773339Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690803}

On Q,  we never call addCompletedDownload. As a result, there is no
download ID, and querying the downloadmanager will always fail.
This cause clicking the notification to always open download home,
instead of the download itself.

BUG=997346

Change-Id: I99ca3d02ce918281ea823785a783c88f3c8df366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769630
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690802}

* Use constexpr
* Use in-declaration initializers
* Factor SetSize() out of ProcessInfoHeader(), to facilitate subsequent change
  that adds color profile decoding between the two.
* Factor out a new helper, InitFrame(), to make DecodeBMP() more readable
* Reorder DecodePixelData() to follow the class convention of "declare and
  define methods roughly in called order"
* Be consistent about updating |decoded_size_| at the end of helpers, to make it
  harder to add changes mid-helper that intend to be run repeatedly but aren't
  (ran into this while adding color profile support)
* Functional change: in theory an .ico could contain an OS/2 2.1x bitmap; change
  from DCHECK() failure on this to setFailed()
* Detect top-down BMPs at the same time we're doing other things with the height
  field
* Added some SCOPED_TRACEs to the test code to help track down failures I was
  getting while writing this

Bug: none
Change-Id: I5d9a97cdeda66a0236c557cf6345ab8bbea55de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772282Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690801}

This is the second part of bug 976446 where first part only updates eye
and headset related parameters, this cl updates stage related parameters

Bug: 976446
Change-Id: I6f18a522a2f929e6c0f1e871eaa7bee85265fd75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762587
Commit-Queue: Zheng Qin <zheqi@microsoft.com>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690800}

cpu_features GN target moved from android_sdk to android_ndk

TBR: minor rename of target
Bug: 990407
Change-Id: I82e25a24716d73e17f2e19dd5e83e94b636b8b0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756203
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690799}

This CL depends on issue http://crrev.com/c/1763553 to have a
preference prefs::kArcVisibleExternalStorages. (will rebase later)

prefs::kArcVisibleExternalStorages remembers a list of visible
external storage's UUIDs. "Visible" means that the storage is
visible to Android apps. (i.e. Android apps can use the external
storage to read/write files.)

With this CL, Chrome checks visibility of newly mounted storages
by reading the preference, and tell the visibility to ARC container
using extended MountPointInfo.
In addition, when the remembered UUID list changes, all
external mount points will be remounted in ARC container to
make sure the latest visibility is applied.

Bug: 954228
Change-Id: Ief8bd50881462f7e5ae0677883ac119eacf33f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765099
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690798}

BUG=986679

Change-Id: I60a17ce118f64291d9bc263ad587c87a651b075a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764560Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690797}

This CL adds a few metrics to track the behavior of background tasks
for notification scheduling system.

TBR=nikunjb@chromium.org

Bug: 963298
Change-Id: Ic6107269db6eb5fbd70bef2836a18336daef55be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762954Reviewed-by: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690796}

https://chromium.googlesource.com/angle/angle.git/+log/76a93c3325f5..5c81d94fa362

git log 76a93c3325f5..5c81d94fa362 --date=short --no-merges --format='%ad %ae %s'
2019-08-27 geofflang@chromium.org Fix a typo in the GL_NUM_REQUESTABLE_EXTENSIONS_ANGLE enum value.

Created with:
  gclient setdep -r src/third_party/angle@5c81d94fa362

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Bug: None
Change-Id: I5ba651da99ae31a43b9971e3573b94d1641f433c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773338Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690795}

AppShimHostManager doesn't actually manage AppShimHosts (the
ExtensionAppShimHandler does, confusingly). Rather, it listens for
incoming connections from app shim processes. Rename the files and
structures to reflect this.

Bug: 982024
Change-Id: I0c1e7031da57157da7dfc5bd5dc0c6743a6a89bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772356Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690794}

This change fixes flaky failures for SMS browsertests. Tests were previously
failing due to the race condition of tests ending before the UKM had been
recorded. Verified by running the browsertests consecutively 100 times
without any failures.

Command:
testing/xvfb.py out/ChromeOs/content_browsertests --gtest_filter="SmsBrowserTest.*" --gtest_repeat=100

Bug: 997549
Change-Id: Ic15025412bf6aa766e9443a07a70c2b489a07e93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772451
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690793}

This is the first CL containing our work to assist the user
in closing stale/unused tabs.

Bug: 993826
Change-Id: Ib73d7a18ea9f5415289ef3c73cd79cc80f97c3be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753689Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690792}

If the BinaryUploadService attempts to read the file before the download
code has renamed it to its final location, we can end up having a race
condition between the renaming and reading the file contents. So the
BinaryUploadService will now wait for the file to be renamed before reading
the contents.

We'll have to revisit this decision when launching a blocking mode, since
then the file isn't renamed until after the upload.

Bug: 980784
Change-Id: I5228e8610df9d5db7e84fbfbc2bb53bea79a9e9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769677Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690791}

https://android.googlesource.com/platform/external/perfetto.git/+log/9d5b5c3f49f3..a203388eab27

git log 9d5b5c3f49f3..a203388eab27 --date=short --no-merges --format='%ad %ae %s'
2019-08-27 lalitm@google.com Merge "trace_processor: move more files to the sqlite folder"

Created with:
  gclient setdep -r src/third_party/perfetto@a203388eab27

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Ia88663610582d682fc6114f4672742ad2f8dc55b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773341Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690790}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ede169e1..d7cac7cb

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I610cc31afb0088129233a94379e74e0d212c056b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772553Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690789}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c74d7abaa6bd..9f4081b4ef9b


Created with:
  gclient setdep -r src-internal@9f4081b4ef9b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: I72977643b356e0633552a85c7e44a5f7c2adafd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773358Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#690788}