Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 19 Aug, 2018 6 commits
    • Trent Apted's avatar
      Introduce an ObserverList<T>::Unchecked type alias. · a250ec3a
      Trent Apted authored 
      This is a precursor to https://crrev.com/c/1053338 which introduces
base::CheckedObserver. Existing observers will be unchecked (as they
are already). There is no behavior change with this CL.

The CL is mechanical. The bulk was done with variations on a sed script:

git grep -l ' base::ObserverList<.*> .*;' -- '*.cc' '*.h' '*.mm' | \
  xargs -IX sed -i -r 's/(^[ ]*)base::ObserverList<([^>]*)> (.*);/'\
    '\1base::ObserverList<\2>::Unchecked \3;/' X

With some manual follow-ups to get special cases.

TBR=gab@chromium.org

Bug: 842987
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idffe88e2b52f67f9226eb7b6d922070349dacc22
Reviewed-on: https://chromium-review.googlesource.com/1175511
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584330}
      a250ec3a
    • chrome-release-bot's avatar
      Updating trunk VERSION from 3527.0 to 3528.0 · 19d33c77
      chrome-release-bot authored 
      # This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: Ic65a498a89afdaa77da052cd7378deb16c75665d
Reviewed-on: https://chromium-review.googlesource.com/1180702Reviewed-by: default avatarchrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584329}
      19d33c77
    • Julie Jeongeun Kim's avatar
      [ozone/wayland] Add wayland_util.cc/h to create utiliy APIs · 2f1d7794
      Julie Jeongeun Kim authored 
      It introduces wayland_util.cc/h and moves the code to create shared
memory buffer and draw bitmap on it from WaylandCursor, as it could
be used generally rather than specific to cursor area.
On upcoming patch for drag and drop on Wayland, it's also required
to pass the drag icon surface to Wayland.

It doesn't bring behavioral changes.

Bug: 578890, 875164
Change-Id: I0cd4603c2abacaa899a9fcf19d97186d6f493146
Reviewed-on: https://chromium-review.googlesource.com/1179487
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Reviewed-by: default avatarAntonio Gomes <tonikitoo@igalia.com>
Reviewed-by: default avatarMaksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#584328}
      2f1d7794
    • Christopher Cameron's avatar
      RemoteMacViews: Remove browser dependencies of SetBounds · 5f99a2c0
      Christopher Cameron authored 
      The function BridgedNativeWidget::SetBounds calls back into the
NativeWidgetMac to determine
- the minimum content size
- if the widget's position should be relative to the parent or the
  screen (and the offset to do that computation)
- if the widget is a modal sheet
This call will eventually be running in the app shim process, where
these values will not be available (without adding a synchronous IPC).

Change NativeWidgetMac::SetBounds to call BridgedNativeWidgetHostImpl::
SetBounds, and have that function pre-compute the required parameters,
- minimum content size
- offset necessary to be applied to compensate for position being
  relative to the parent or the screen
- (but not if the widget is a modal sheet, that's coming later)
and pass these as parameters to BridgedNativeWidget::SetBounds.

Split out the SetBounds calls made during initialization from
being within BridgedNativeWidget::Init to being made by its caller,
BridgedNativeWidgetHostImpl::InitWindow, to allow the additional
parameters to be passed in.

Bug: 859152
Change-Id: I2f33ab08f60d2ed1bc3b6af5ecf3402e3715ffd4
Reviewed-on: https://chromium-review.googlesource.com/1178813
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584327}
      5f99a2c0
    • Chromium WPT Sync's avatar
      Import wpt@6aef6676d2f95c29de17666cc70d61b517939fbf · 0ab323dd
      Chromium WPT Sync authored 
      Using wpt-import in Chromium e57c623d.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22916

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id7f2b07592d744cd563d75f7bf95bb2ba03ad8d3
Reviewed-on: https://chromium-review.googlesource.com/1180652
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: default avatarBlink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584326}
      0ab323dd
    • Nico Weber's avatar
      Revert "[Windows Host] Prevent connection hang for hosts with 3D Display Mode enabled" · 8cc2653e
      Nico Weber authored 
      This reverts commit ee9ee634.

Reason for revert: Likely broke remoting tests on Win7, https://crbug.com/875619

Original change's description:
> [Windows Host] Prevent connection hang for hosts with 3D Display Mode enabled
> 
> This change prevents a hang when connecting to a Windows machine
> which has curtain mode and 3d display mode enabled.  The root cause
> of the hang is that creating a D3D11 device takes several seconds so
> function calls which used to take a few milliseconds now take 5+
> seconds.  I did not see a mechanism to control this display mode
> programatically so I am adding code which can detect the condition
> and the logic to prevent D3D usage when 3D mode is enabled.
> 
> Of note is the change in BasicDesktopEnvironment where I requery the
> D3D apis.  DesktopEnvironmentOptions are queried in Session 0 and
> then passed on to the Desktop process.  There is a non-obvious
> problem with this as many D3D methods cannot be queried or will
> not return reliable results.  This results in a base set of options
> being set in Session 0 (which includes user / experiment overrides)
> and then passed into a session where D3D will return new values.  In
> this CL, I requery the D3D APIs and update the capturer options if
> they should be disabled.
> 
> BUG=836007
> 
> Change-Id: Ib7a6e61fa7987bd093e93a6100b97cc49e3aff05
> Reviewed-on: https://chromium-review.googlesource.com/1164403
> Commit-Queue: Joe Downing <joedow@chromium.org>
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583276}

TBR=jamiewalch@chromium.org,joedow@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 836007
Change-Id: I464ba6eb37560ef6fc687516e9e33682bee4ac7a
Reviewed-on: https://chromium-review.googlesource.com/1180681Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584325}
      8cc2653e
  3. 18 Aug, 2018 34 commits