- 01 Oct, 2019 40 commits
-
-
Lily Chen authored
Fake Gaia sets several cookies, which must be accessible in a cross-site context. Under SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure (crbug.com/1002052), cookies must be "SameSite=None;Secure" in order to be available in a cross-site context. This change adds those attributes so that tests relying on Fake Gaia will continue to work when these SameSite features are launched. Bug: 1006816 Change-Id: Ia4508611f59b048392217c63cdd209297b147d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827183 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#701591}
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. Bug: 1006927 Change-Id: I46f55b80979520453e7e1a9a79592a85735f98cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831944 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#701590}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010061 Change-Id: Ib35d542205f85f026a1f6df271dbba4c1b6683e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833291Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701589}
-
Tom McKee authored
Since User Timing L3 is the default and we're deprecating L2 support, we can remove the virtual test suite that checks L2 coformance. Bug: 805566 Change-Id: Ie5af7c8b564a1228972257b219d52f1c75525e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763642Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#701588}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1ffc2e453b00..a7914a872657 git log 1ffc2e453b00..a7914a872657 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 halcanary@google.com experimental/tools/pdf-comparison: delete worktree when it gets into a bad state Created with: gclient setdep -r src/third_party/skia@a7914a872657 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Icff3b30c15834465206aa25fec65f7b10a9c8980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833484Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701587}
-
Lily Chen authored
This replaces two uses of net::CookieOptions where we used to manually set include_httponly and same_site_cookie_context to "strict", with the recently added CookieOptions::MakeAllInclusive(), which does both of those things automatically (and also sets do_not_update_access_time, which doesn't matter because that field is not read for these two usages). There isn't really any reason for this aside from saving a few lines of code for readability and eliminating a member variable. Bug: None Change-Id: I2311e3cb8ea06301deb3eb72d86edfe986e8cf89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832302Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#701586}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010061 Change-Id: If5db6d009c19b97dff86185d62f4ecc414f2fb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833290Reviewed-by:
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010061 Change-Id: Iac97955e581bfbe5091c7cab8ca453fdd63c1c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832693Reviewed-by:
-
Eric Stevenson authored
This CL was partially created by //base/android/jni_generator/jni_refactorer.py. The conversion also required converting unit tests to use the new JNI mocking approach provided by JniMocker. Bug: 929661 Change-Id: Ife3b8bee26e0da433341b138e7c1837d20cc4a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832623 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701583}
-
Jérôme Lebel authored
Removing SyncSetupService::PreUnityCommitChanges() since pre-unity code should be removed. IsUnifiedConsentFeatureEnabled() always returns true. Bug: 951313 Change-Id: If2bb328da4e2d1073b3b21960eefd18ea58498d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831902 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#701582}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010061 Change-Id: Ifd0d117a1f5ab110acb1456cad577d9394acaf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833287Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dba6e775bc2b..fc2b2deb2628 git log dba6e775bc2b..fc2b2deb2628 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 vapier@chromium.org run_tests: turn on more tests for python 3 Created with: gclient setdep -r src/third_party/chromite@fc2b2deb2628 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I34c5cf4a44e67fbe35653e4a8f450897c107f6fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833066Reviewed-by:
-
Ryan Hamilton authored
Fix a P2PQuic test to correctly grok v99 RST_STREAM semantics. Change-Id: I7c200aa575926396f814d3d9de3ca460b3723b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825657Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#701579}
-
Vasiliy Telezhnikov authored
This CL adds PIXEL_FORMAT_XR30 and PIXEL_FORMAT_XB30 formats to VideoPixelFormat which correspond to BGRX_1010102 and RGBX_1010102 in viz::ResourceFormat. Bug: 1005213 Test: MediaColorTest.Yuv420pHighBitDepth Change-Id: Ie06e09c0079cfc7a8f8a892190d56ab8d9c7b126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826981 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#701578}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b3bb2040a15c..7c079f650def git log b3bb2040a15c..7c079f650def --date=short --no-merges --format='%ad %ae %s' 2019-10-01 eshr@google.com Reland "Fix minor regression caused by a8336d3" 2019-10-01 saza@webrtc.org AEC3: Analyze multi-channel SubtractorOutput in AecState Created with: gclient setdep -r src/third_party/webrtc@7c079f650def If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I83f6c6b6d2b8fb63cae63cefbb9e117c5e5d150f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833064Reviewed-by:
-
Gyuyoung Kim authored
DownloadImage_Allow_FileImage has been flaky after merging "Refactor ImageDownloaderImpl::ContextDestroyed slightly" CL. The flakiness can be caused by multiple callback calls between ImageDownloaderImpl::ContextDestroyed and MultiResolutionImageResourceFetcher::Dispose. And also, we need to avoid doing complex operations in a pre-finalizer because it has a risk of resurrecting dead objects. So, this CL moves the call of |image_fetchers_.clear()| to ImageDownloaderImpl::ContextDestroyed again in order to revert the original CL for now. Bug: 1002755 Change-Id: I1e82aa827f7f536c65df2906001672be1b11524f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833025 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#701576}
-
Nick Diego Yamane authored
Currently Gdk backend is auto-selected in Ozone, which leads to crashes when, for example, ozone platform is set to x11 while the browser is being executed in a Wayland compositor (e.g: Gnome/Wayland for example). CL modifies GtkUi ctor to set allowed gdk backends based on the current ozone plarform. Bug: 1008924 Change-Id: I12163357e4d3d517c4c98672ed9db3c064c2d244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829319 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#701575}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/087f1384f233..e49df747da7e git log 087f1384f233..e49df747da7e --date=short --no-merges --format='%ad %ae %s' 2019-10-01 courtneygo@google.com Update expectations for deqp failure Created with: gclient setdep -r src/third_party/angle@e49df747da7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I9226c8b1854b3f399ebb6c32b0e468ccec7bc095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833065Reviewed-by:
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010037 Change-Id: I96c92b2adf04e076d8785521610102988c17ddd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832691Reviewed-by:
-
danakj authored
The SwapPromiseMonitor was moved to wrap only the call to WillHandleGestureEvent(), but that optionally handles the input event (it is handled for pepper when the mouse is locked). The event is otherwise handled later in the method in the call to HandleTouchEvent() or by calling out to the WebWidget. The SwapPromiseMonitor should be alive during all of these calls. This is a fix for the scope change in https://chromium-review.googlesource.com/c/chromium/src/+/1812915 R=dtapuska@chromium.org Bug: 994926 Change-Id: I3313415b4c8f90ac1b544d10a7bf68833e3ab872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831453 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#701572}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1001364 Change-Id: I84fc313f4e3467a0583119793568e285e987470c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833284Reviewed-by:
-
Jiawei Shao authored
We create new server Dawn Device for every requestAdapter() but don't create an analogous client Device. The result is that there are multiple dawn_wire::Servers and only one dawn_wire::Client which have completely different namespaces for ObjectIds. Multiple calls to requestAdapter(...) replace the Server device and messes up object lookup. This problem was discovered when rolling tests in the WebGPU CTS into Chromium. Currently we only have very basic tests. This is a temporary fix so that so we can roll a more complete test suite before making further changes. BUG=chromium:996713 TBR=kbr@chromium.org Change-Id: I172bf948a8e61bd7149ac2e5bf6d528db53dd7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832777Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#701570}
-
Stepan Khapugin authored
Adds |window| property to SceneState. It is backed by SceneDelegate's |window| property and by UIWindowScene's |scenes| property on iOS 13 with multiwindow; or with an ivar otherwise. When it's an ivar, SceneController is now responsible for window creation. Note that the getter for AppDelegate's window remains for iOS 12 compat. Note that the window is always a ChromeOverlayWindow. have tested it manually on my machine and it still works) Bug: none Test: verify that the incognito screenshot blocker works as expected (I Change-Id: Ic418ece228854e43aa0e4c9d9e503c1b54bca901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827373 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#701569}
-
Evan Stade authored
The passed profile always matches |profile_|, so just remove it. Bug: none Change-Id: I29940c6ab54e9e9dbd7b1ed1833ab8893a2212d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832611Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#701568}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/94c47dd3da78..b689fa536c9b git log 94c47dd3da78..b689fa536c9b --date=short --no-merges --format='%ad %ae %s' 2019-10-01 fmayer@google.com Merge "Add heap_graph_object table." Created with: gclient setdep -r src/third_party/perfetto@b689fa536c9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I99f39bfb93b4bbee5a3ccc61316af247f6aff071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833063Reviewed-by:
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1001364 Change-Id: Idf5ae6d99e038d159794e0cf18f9261d6d464c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833283Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f85c9327..cf9b9029 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I75a09ff4f6ccb454fb1f168cca20d9aaeab8824e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833661Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701565}
-
Matt Falkenhagen authored
This will make it easy to test the feature on Android without needing a command-line flag. Bug: 824858 Change-Id: I26736f1c2edbad635d9030f9d35939ace6daa799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833026 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#701564}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1009287 Change-Id: Ic32dd467368d3afbf9fe4ee567aecca33c8f8b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832690Reviewed-by:
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1009182 Change-Id: I3960639b4f48a33cb4836d2e394bcb11bdb00245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832990Reviewed-by:
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010032 Change-Id: I2399f478fca573cd0c9ebd8666c8832f072228f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832989Reviewed-by:
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/accelerated_widget_mac to the recommended methods/types. Also change PumpableTaskRunner::EnqueueAndPostWrappedTask to take the task as an std::unique_ptr<WrappedTask> to remove usage of base::Owned() and remove a naked "new". Bug: 1007844 Change-Id: I893b7d83715ed960898034608ea83afb39c7efe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833462 Commit-Queue: ccameron <ccameron@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#701560}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/android to the recommended methods/types. Bug: 1007845 Change-Id: Ia401c734f7530732917c94f7dea6359200f34199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833461 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Darin Fisher authored
This CL introduces a new version of WindowToViewportScalar that takes a LocalFrame parameter, marks the existing version as deprecated, and adds one caller to the new version. The new caller is DataTimeChooserImpl, and that change is what fixes bug 1006919. What was happening before is that in the context of an out-of-process subframe, WindowToViewportScalar was not finding a LocalFrame for the top frame. It would then bail out early, not calling the appropriate WebWidgetClient method. Hence, the error reported in the bug. A follow-up CL will migrate the rest of the callers over to the version of this method that takes a LocalFrame parameter and remove the other. Bug: 1006919 Change-Id: I04bd2fa80abed139b90a42b81668bcc3aba8f967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831447Reviewed-by:
-
Joonghun Park authored
Blink doesn't have table wrapper box currently while Gecko has it, so this CL tries to mimic the behavior that clientWidth/Height refers to table wrapper box which doesn't have borders applied to itself and table grid box has the borders. This CL adds table's border sizes to clientWidth/Height at |LayoutBox::PixelSnappedClientWidth/Height|. As a result of this CL, table's clientWidth/Height and offsetWidth/Height are equal now, respectively. The corresponding csswg discussion is https://github.com/w3c/csswg-drafts/issues/4245. Bug: 560528, 978019 Change-Id: I2693eaf38b882fe4a41f931ec1312ecf53352f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763510 Commit-Queue: Joonghun Park <pjh0718@gmail.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#701557}
-
Raul Tambre authored
This change is backwards compatible with Python 2 and functionally equivalent. Traceback (most recent call last): File "../../base/win/embedded_i18n/create_string_rc.py", line 601, in <module> sys.exit(main()) File "../../base/win/embedded_i18n/create_string_rc.py", line 578, in main mode_specific_strings.itervalues().next().iterkeys()] AttributeError: 'dict' object has no attribute 'itervalues' Bug: 941669 Change-Id: I2d26e810bf98840cdae46c0a0de249bf0b19f5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829208 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#701556}
-
Lily Chen authored
This change switches http://google.com to https://google.com in the GaiaCookieManagerService. This is for the purpose of fixing the DiceBrowsingDataRemoverBrowserTests, which otherwise fail when the test cookie is made Secure. This test cookie must be made Secure because it is set with SameSite=None, which under the upcoming SameSite changes (see crbug.com/1002052) means the cookie will be rejected unless it is secure. Bug: 1006816 Change-Id: I2c5b5dd393c8547dbdacb832fb1447090a00a6a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829672 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#701555}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010031 Change-Id: I9ad685d4f58729f3ac6296e3aa7297c315261660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832987Reviewed-by:
-
Xiaocheng Hu authored
Now that we support non-calc math functions in 'sizes' attribute, the name SizesCalcParser is no longer accurate. Hence, this path renames it into SizesMathFunctionParser. Bug: 825895 Change-Id: I8f995298af0495c50822fd6addebd0d437dccaf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832701 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#701553}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010027 Change-Id: If748a3342be75e72b79a4b989a9af131847e6a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829786Reviewed-by:
-
