- 07 Sep, 2018 40 commits
-
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/23d65fd54de1..990810e4ba69 git log 23d65fd54de1..990810e4ba69 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 jrbarnette@chromium.org Remove code for the provisioning workqueue. 2018-09-07 jrbarnette@chromium.org Remove support for the provisioning workqueue. 2018-09-07 vapier@chromium.org binhost_test: output each failure in a sep log line 2018-09-07 vapier@chromium.org binhost_test: make output a bit easier to read 2018-09-07 vapier@chromium.org test_image: tweak the CLI names 2018-09-07 vapier@chromium.org binhost: normalize CompatId/BoardKey tuples to ASCII Created with: gclient setdep -r src/third_party/chromite@990810e4ba69 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibf9d348efb509dd54d49b90435029b59c00decef Reviewed-on: https://chromium-review.googlesource.com/1213470Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589543}
-
Justin Donnelly authored
This reverts commit 2c0b1626. Reason for revert: The "SitePerProcessHitTestDataGenerationBrowserTest.PointerEventsNoneOOPIF/2" test is broken on the Android CFI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2797 Original change's description: > Do not hit test OOPIFs with pointer-events: none > > Frame owners may have pointer-events: none property which blocks them > from receiving mouse and touch events. Currently in V2 viz hit testing > hit test data provider has no information about whether OOPIFs have > pointer-events: none property. > > This CL plumbs pointer-events: none property from HTMLFrameOwnerElement > to cc::SurfaceLayer so that the hit test data provider in LayerTreeHostImpl > will be able to generate proper hit test data for pointer-events: none > OOPIFs. > > Bug: 841358 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I381c8f0b1dcfb14b7ef24c7b2b3806ae60ec4182 > Reviewed-on: https://chromium-review.googlesource.com/1127440 > Commit-Queue: Xianda Sun <sunxd@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589306} TBR=rjkroege@chromium.org,flackr@chromium.org,kenrb@chromium.org,pdr@chromium.org,chrishtr@chromium.org,fsamuel@chromium.org,sunxd@chromium.org,joelhockey@chromium.org,riajiang@chromium.org,gklassen@chromium.org Change-Id: I5fc43bd1b5dd60312ff9046802f8ac18b8f2e6bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841358 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1213823Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#589542}
-
Vasilii Sukhanov authored
Currently it manages a set of fill credentials. However, for a frame there is just one list corresponding to the origin. Thus, the key is redundant. Bug: 876521,846404 Change-Id: I045768683512e3eb8c258d97397de8981e630be6 Reviewed-on: https://chromium-review.googlesource.com/1211262Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589541}
-
braveyao authored
Make braveyao own more desktop capture related files under chrome/browser/media/webrtc, majorly including the new files added for the getDisplayMedia() API. Bug: 867003 Change-Id: Id1e310dc42ff8473c79d0f41de388fcb64597a56 NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1212097Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#589540}
-
Anthony Vallee-Dubois authored
Bug: 865500 Change-Id: I104a80f132b5ab0420f242328227150e05e7fb93 Reviewed-on: https://chromium-review.googlesource.com/1211506 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#589539}
-
James Cook authored
To match the new class names. Doing this in two steps helps git track the file renames more easily. Bug: 866532 Change-Id: Iae46af10438336f2ec182c863498d0eeb1c3a29c Reviewed-on: https://chromium-review.googlesource.com/1212100 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589538}
-
Joshua Bell authored
A user or admin can make a site be "session-only", i.e. all data is cleared when the user leaves the site. In the UI at chrome://settings/content/cookies this is done by adding sites to the "Clear on exit" list. We shouldn't grant the permission for sites with this property, since we do so with heuristics and we encourage developers to request the permission before offering the user a of guarantee about offline storage availability. If we granted the permission, the site would end up giving a false commitment to the user. Bug: 824950 Change-Id: I6ccd53376fc3aed65dd742b3fc0938c203281e7b Reviewed-on: https://chromium-review.googlesource.com/1208149Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#589537}
-
Sorin Jianu authored
This is a mechanical change. The rationale for this change is that the value returned from this function is formated inside a component updater request. How this value is formated depends on the protocol encoding. Therefore, to abstract out the protocol encoding (XML or JSON), the function must return its data as a map of key-values instead of joined strings. Also, as a small change, replace std::map with base::flat_map for the extra request headers. BUG: 881076 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic39e94e8de0e3e27128a80cd24c055bdd434c45f Reviewed-on: https://chromium-review.googlesource.com/1208134 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#589536}
-
Justin DeWitt authored
This is used on the wire from the Explore Sites API to Chrome. Bug: 867488 Change-Id: Id830f53b7ea7cfad8fbd6c7e38694d2de43ff558 Reviewed-on: https://chromium-review.googlesource.com/1210945Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#589535}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 923d919c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24209 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I494c003064a6099673b3799b571d2d534089ecea Reviewed-on: https://chromium-review.googlesource.com/1213365 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589534}
-
Xida Chen authored
The original CL was reverted because there were many DumpWithoutCrashing, and the reason is that the num_of_active_touches_ goes below 0. The problem is that in InputRouterImpl::TouchEventHandled, we increment this num only when it is ack from the main thread. In other words, we missed other cases such as when there is a passive event listerner. This CL fixes the problem. PS#1 is exactly the same as the original CL, so that it is easier for review. PS#2 fixes the problem and added some more unit tests. It also removes the temporary fix to prevent crashes. TBR=tdresser@chromium.org Bug: 851644 Change-Id: I4d668ab322c94ea2704e3e220e2afd1a44833dca Reviewed-on: https://chromium-review.googlesource.com/1209545 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#589533}
-
Xida Chen authored
The above function could return nullptr sometimes, which is indicated in crbug.com/751768, we should check the result of this function instead of just DCHECK. Bug: 737109 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id732898bb35cc43c9ccce81979c39efa443f0610 Reviewed-on: https://chromium-review.googlesource.com/1212352Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589532}
-
Fabio Tirelo authored
This is to prepare the field for removing feature kAutofillExpandedPopupViews. Bug: 831603 Change-Id: Ib748de088912221c3af18435286904046befb58f Reviewed-on: https://chromium-review.googlesource.com/1210165 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589531}
-
Matthew Jones authored
This patch replaces the need for several larger objects in the BottomSheetController (LayoutManager and TabModelSelector) in favor of instead using the ActivityTabProvider. This simplifies the logic in this class. Change-Id: I001593cfccaadbf1c0e60ceaa7231e203c56a338 Reviewed-on: https://chromium-review.googlesource.com/1211447Reviewed-by:
-
Raymond Toy authored
Use simple linear extrapolation to resample the data when we reach the end of the buffer. Previously, the last sample would just be repeated enough times. Manually verified that the test passes on Firefox (nightly) and fails on Chrome without this CL. Bug: 881119 Test: the-audiobuffersourcenode-interface/buffer-resampling.html Change-Id: I1eb6ee089aa5477e03ff7184eb974f769b739528 Reviewed-on: https://chromium-review.googlesource.com/1211910 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589529}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b090b2b26803..7b429aed84d8 git log b090b2b26803..7b429aed84d8 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 michaelludwig@google.com Implement boolean short circuit folding in SkSL 2018-09-07 jvanverth@google.com Reland "Revert "update to new MakeFromStream signature"" 2018-09-07 reed@google.com Revert "Revert "update to new MakeFromStream signature"" Created with: gclient setdep -r src/third_party/skia@7b429aed84d8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Ie356656272734f414b91c1252ccb34816f4940bc Reviewed-on: https://chromium-review.googlesource.com/1213443Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589528}
-
Justin Donnelly authored
This reverts commit 12435aaa. Reason for revert: Suspected of breaking the build on android-rel and closing the tree. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/1629 for the error, which references "incremental" and "json". Original change's description: > Android: Skip incremental install json for targets that don't support it > > Change-Id: I111afe4c1cd7c0c152333d678c22dc9eb284adf3 > Reviewed-on: https://chromium-review.googlesource.com/1205805 > Commit-Queue: agrieve <agrieve@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589523} TBR=agrieve@chromium.org,tiborg@chromium.org Change-Id: Ibc19c427d9afa4db971c46fa92aa05e8eb52f168 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1213370Reviewed-by:
-
James Cook authored
NativeCursorManagerAshClassic is the only subclass. I'm going to rename the file in a follow-up CL to help git rename tracking preserve the blame history. Bug: 866532 Change-Id: Icb4a0ee7211a4256d6655797393d22bb43169e77 Reviewed-on: https://chromium-review.googlesource.com/1212143Reviewed-by:
-
Tibor Goldschwendt authored
Change-Id: Ia65a75f355ecf7d035f1bdd8cac3fb55f85160b2 Reviewed-on: https://chromium-review.googlesource.com/1213366Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589525}
-
Markus Heintz authored
This reverts commit 41c5a44c. Reason for revert: This broke many webkit tests: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Linux_Trusty_MSAN%2F9844%2F%2B%2Frecipes%2Fsteps%2Fwebkit_layout_tests%2F0%2Fstdout In https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/9844 Revert speculatively since the error message is pointing to code potentially added by this cl 04:21:46.301 9979 #0 0x12242776 in blink::(anonymous namespace)::CanAccessWindowInternal(blink::LocalDOMWindow const*, blink::DOMWindow const*) ./../../third_party/blink/renderer/bindings/core/v8/binding_security.cc:73:79 04:21:46.301 9979 #1 0x1223dfac in CanAccessWindow ./../../third_party/blink/renderer/bindings/core/v8/binding_security.cc:110:7 04:21:46.301 9979 #2 0x1223dfac in blink::BindingSecurity::ShouldAllowAccessTo(blink::LocalDOMWindow const*, blink::DOMWindow const*, blink::BindingSecurity::ErrorReportOption) ./../../third_party/blink/renderer/bindings/core/v8/binding_se Original change's description: > Add a UseCounter for cross-origin accesses requiring 'document.domain'. > > Bug: 787905 > Change-Id: I2248173947ed87ff3e8f40dc86a8e9044ed2dd3b > Reviewed-on: https://chromium-review.googlesource.com/966442 > Commit-Queue: Mike West <mkwst@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589470} TBR=dcheng@chromium.org,yukishiino@chromium.org,jochen@chromium.org,mkwst@chromium.org Change-Id: Ib5c8fe269823c889c97da13e5107d1da75d7a457 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787905 Reviewed-on: https://chromium-review.googlesource.com/1213152Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589524}
-
Andrew Grieve authored
Change-Id: I111afe4c1cd7c0c152333d678c22dc9eb284adf3 Reviewed-on: https://chromium-review.googlesource.com/1205805 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589523}
-
Reilly Grant authored
This takes a hint from r588692 and moves ownership of the ProxyingURLLoaderFactory objects a user data object that hangs off of the content::ResourceContext. This prevents these objects from outliving this object on the IO thread. The previous ownership model was open to a race condition between the destruction of the BrowserContext keyed service ProxyingURLLoaderFactoryManager on the UI thread and the tasks posted to the IO thread to destroy each ProxyingURLLoaderFactory. These would be scheduled after the task to destroy the ResourceContext. Change-Id: I600b1604526b644c3ac9e010d1cb82f4b3740925 Reviewed-on: https://chromium-review.googlesource.com/1211913Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589522}
-
Roger McFarlane authored
This CL turns on deletion of disused address and credit card data. This data has already been suppressed (i.e., not suggested) for the last two quarters. As a result of this CL: * Address data will be deleted 13 months after last use (it stops being suggested 6 months after last use). * Local credit card data is deleted 13 months after the later of expiry or last use; it stops being suggested 6 months after expiry/last use). Cards coming from Google Pay stop being synced 12 months after expiry. Their lifetime is independent of this CL. Bug: 868406 Change-Id: I6113f6f96e7854b8684e3258f372c91475aa96a8 Reviewed-on: https://chromium-review.googlesource.com/1101168 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589521}
-
Nico Weber authored
Update Windows Deterministic whitelist after https://chromium-review.googlesource.com/c/chromium/tools/build/+/1185911 Like https://chromium-review.googlesource.com/1194469 but for Windows. Most of them are due to v8_context_snapshot.bin. Bug: 330260 Change-Id: I01b2194d3a64269f6332bc36b2783fdcc5749de0 Reviewed-on: https://chromium-review.googlesource.com/1213524Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589520}
-
Nico Weber authored
Merges the contents of an always-true block with the contents one scope up. There were several if (is_win) etc blocks at that scope; merge these too. No intended behavior change. Bug: 832676 Change-Id: I89ecdec3babec570c631714001edb71cfb1cca66 Reviewed-on: https://chromium-review.googlesource.com/1213522Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589519}
-
Markus Heintz authored
Change-Id: I759941dd004f4cd72966a268bb383a64b2932fec Reviewed-on: https://chromium-review.googlesource.com/1206336Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589518}
-
Tanja Gornak authored
Bug: 880204, 801985 Change-Id: Iefce8533a32ba4d77961cee9d42845503b25c839 Reviewed-on: https://chromium-review.googlesource.com/1203833 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#589517}
-
Miguel Casas authored
The original CL was reverted bc it caused a gn gen --check problem -- I assumed this was checked somewhere in our CQ :-( Anyways, fixed: //components/viz/service/main:main used the removed dependency to use //media/gpu{:buildflags,:vaapi}, so these are added explicitly. gn gen --check passes locally now w/ the diffs: crrev.com/c/1208418/2..11 TBR=rsesek@ for services/viz/privileged/interfaces/gl/gpu_service.mojom and lhchavez@ for components/arc/common/BUILD.gn (since there are no new changes in this CL re those files). Original CL ---------------------------------------------------------- Do not use components/arc/common in non CrOs builds I found that (at least win) bots are using components/arc/common stuff (see e.g. [1]), when this are supposed to be limited to CrOs. This CL corrects that by sandwiching the appropriate BUILD entries between if(is_chromeos). [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936282730877054816/+/steps/compile/0/stdout /BUILD.gn mojom(media) Bug: 732531 Change-Id: Ie870b0ccb90216b9b455a25f34761a03d5a13b16 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1208410Reviewed-by:Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589056} Reviewed-on: https://chromium-review.googlesource.com/1208418 Cr-Commit-Position: refs/heads/master@{#589516}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c61b09bf..157216ad Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifc151c1d799359e93dd79c2b20540c30c4a9289c Reviewed-on: https://chromium-review.googlesource.com/1212749Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589515}
-
Raphael Kubo da Costa authored
Supplementing LocalFrame causes the same SensorProviderProxy to be used across navigations, and so is the connection to the actual sensor provider via mojo. Making SensorProviderProxy supplement Document also helps with testing: as described in the related bug, running a manual test (which does not use sensor mocks) and then a regular test causes the latter to fail because we never establish a connection to the mock we need, but rather try to use an actual sensor that is not present. Bug: 861675 Change-Id: Ic3d2ea42f5b4654ba5ef42b6ad757a49d3e5ef08 Reviewed-on: https://chromium-review.googlesource.com/1160161Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#589514}
-
Mohsen Izadi authored
It replaces content::GpuDataManagerImpl::DomainGuilt and viz::GpuHostImpl::Delegate::DomainGuilt. BUG=709332 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5a802e53ec770835954b77ba62e9fe9920377381 Reviewed-on: https://chromium-review.googlesource.com/1201704Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589513}
-
Mike West authored
Apparently this makes a big difference to the cookie settings backend. Bug: 881715 Change-Id: Id87fa0c6a858bae6a3f8fff4d6af3f974b00d5e4 Reviewed-on: https://chromium-review.googlesource.com/1212846 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#589512}
-
Fredrik Söderquist authored
When the 'transform' presentation attribute (or CSS property) was mutated on a <clipPath>, its clients were not notified. Make sure they are. Bug: 881700 Change-Id: Id42aedf814472d8156804a955e6bbf2aa2792ec2 Reviewed-on: https://chromium-review.googlesource.com/1213142Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589511}
-
Markus Heintz authored
This reverts commit 303d77a1. Reason for revert: Did not fix the issue Original change's description: > Revert "Add UnencodableHandling::kNoUnencodables" > > This reverts commit b4edab24. > > Reason for revert: > > Webkit tests on Android nx4 are failing since: > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29/82322 > > speculative revert (sorry) since this is the only CL in the blame list realted to text encoding and the error says: > > " > UnicodeDecodeError raised: 'ascii' codec can't decode byte 0xe2 in position 146896: ordinal not in range(128) > ... > " > > Original change's description: > > Add UnencodableHandling::kNoUnencodables > > > > The are no unencodable characters in UTF-8, however previously callers > > to blink::TextCoder::Encode had to pass a dummy UnencodableHandling > > argument. Add a kNoUnencodables value to the UnencodableHandling which is > > an explicit no-op. Also add DCHECKs that is is only used for UTF-8 or > > UTF-16. > > > > Convert callers to use kNoUnencodables where the encoding is statically > > known to be UTF-8. > > > > It's still valid to use other values for the UnencodableHandling > > argument with UTF-8 or UTF-16; kNoUnencodables simply documents that it > > makes no difference. > > > > Change-Id: I5eebe4c76ae4006ee91f3884f94ec3b5e410685b > > Reviewed-on: https://chromium-review.googlesource.com/1206055 > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Joshua Bell <jsbell@chromium.org> > > Commit-Queue: Adam Rice <ricea@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#589451} > > TBR=jsbell@chromium.org,ricea@chromium.org,yhirano@chromium.org,haraken@chromium.org > > Change-Id: Iaddd13dc7e2fe9473528710dcdaf080f50d01ecc > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/1213085 > Reviewed-by: Markus Heintz <markusheintz@chromium.org> > Commit-Queue: Markus Heintz <markusheintz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589501} TBR=jsbell@chromium.org,ricea@chromium.org,markusheintz@chromium.org,yhirano@chromium.org,haraken@chromium.org Change-Id: I51221bfefd2e5d9505b05615ab38e5b1602e2fdf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1213172Reviewed-by:
-
Anna Malova authored
Remove the dynamic module interface defined in the Chromium repository in favor of the copy pulled in via DEPS and updates the build files correspondingly. Bug: 873098 Change-Id: Ic8b38906eceb7f9bf46ed9c95e5d7e3dd82b8e5e Reviewed-on: https://chromium-review.googlesource.com/1172427 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#589509}
-
Jérôme Lebel authored
When unified consent flag is enabled, the settings link in the sign-in dialog should open the Google services settings (instead of the sync settings). This patch adds the code to open the Google services settings when the settings dialog is already opened and when the settings dialog is not opened. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I560a959d49f983943ec8d39e421ba28b8992e448 Reviewed-on: https://chromium-review.googlesource.com/1196519 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#589508}
-
Vaclav Brozek authored
As described in the associated bug, the |layout| data member of |PasswordForm| contributes less benefit than it causes complexity. It is not used in the new FormData -> PasswordForm parser, and this CL also remvoes it from the old one, as well as removing all related code. Bug: 852772 Change-Id: Icdc6979a9c0a57093a459f2dfc2e27766f9e9142 Reviewed-on: https://chromium-review.googlesource.com/1209582Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589507}
-
Raphael Kubo da Costa authored
The test was originally crashing with DCHECKs enabled, but it no longer seems to do that according to the flakiness dashboard. TBR=foolip Bug: 762017 Change-Id: I1a67b94ff5fef93906ae471d49341d59d51fcb78 Reviewed-on: https://chromium-review.googlesource.com/1213165Reviewed-by:
Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#589506}
-
Benoit Lize authored
Bug: 877044 Change-Id: I6b3e7be16ade21bd9c511a6a4fda10930575efa4 Reviewed-on: https://chromium-review.googlesource.com/1210782 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Jeremy Roman authored
This is a final attempt to flush out any recursive acquisition before support is totally removed for WTF::RecursiveMutex. For pthreads, this requires maintaining the recursion_count_ variable even in non-DCHECK builds. This is still quite cheap, and is temporary in any case. Bug: 856641 Change-Id: I2b550fd58e8c4cf6293ad7628dd49aa366b41ae9 Reviewed-on: https://chromium-review.googlesource.com/1212453Reviewed-by:
-
