GitLab

Just c4267 build suppressions. 

BUG=166496
BUG=167187
TBR=jam@chromium.org
R=jam@chromium.org
Review URL: https://codereview.chromium.org/12254004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182224 0039d316-1c4b-4281-b951-d872f2087c98

Just c4267 build suppressions. 

BUG=166496
BUG=167187
TBR=yzshen@chromium.org
R=yzshen@chromium.org
Review URL: https://codereview.chromium.org/12258010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182223 0039d316-1c4b-4281-b951-d872f2087c98

In class method (not instance methods), we shouldn't use this because 'this' indicates not "instance" but "class" itself.

BUG=175657
TEST=Files.app launches. 
TBR=mtomasz@chromium.org, haruki@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12257002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175657
TEST=none
TBR=mtomasz@chromium.org, haruki@chromium.org

Review URL: https://codereview.chromium.org/12257008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182221 0039d316-1c4b-4281-b951-d872f2087c98

Add const to some the  retrieve methods.


BUG=149349


Review URL: https://chromiumcodereview.appspot.com/12221147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182220 0039d316-1c4b-4281-b951-d872f2087c98

This will help track down any problems with the installation process.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/12220146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182219 0039d316-1c4b-4281-b951-d872f2087c98

This prevents us from updating textures currently in use by active
tree before tree activation.

BUG=173886


Review URL: https://chromiumcodereview.appspot.com/12185008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182218 0039d316-1c4b-4281-b951-d872f2087c98

Closure linter checks if descriptions end with valid punctuation such as a period. This patch adds periods.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org, haruki@chromium.org

Review URL: https://codereview.chromium.org/12262003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182217 0039d316-1c4b-4281-b951-d872f2087c98

There are a variety of benchmarks that want to measure the cost of
raster for now bin only, and similarly, only for low res tiles. This
patch provides very primitive infrastructure for this.

R=reveman
CC=egraether,skyostil

BUG=175976

Review URL: https://chromiumcodereview.appspot.com/12258004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182216 0039d316-1c4b-4281-b951-d872f2087c98

These methods will be used to implement InitiateUpload{New,Existing}Operation
on Drive API v2.

BUG=148632
TEST=Ran unit_tests


Review URL: https://chromiumcodereview.appspot.com/12225101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182215 0039d316-1c4b-4281-b951-d872f2087c98

This CL converts the SessionLengthLimiter from a RepeatingTimer that
fires once per second to a OneShotTimer that fires when the session
time is up and the user should be logged out.

BUG=175797
TEST=Manual, unittests


Review URL: https://chromiumcodereview.appspot.com/12218123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182214 0039d316-1c4b-4281-b951-d872f2087c98

The test wasn't testing what it was supposed to; it didn't destroy the storage
systems of a Profile and recreate them. We can't test crash recovery like this.

BUG=172770
R=jochen


Review URL: https://chromiumcodereview.appspot.com/12208131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182213 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/12221154/
Review URL: https://codereview.chromium.org/12225148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129187

Review URL: https://codereview.chromium.org/12213074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182211 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mal, cpu

BUG=175842

Review URL: https://codereview.chromium.org/12230010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182210 0039d316-1c4b-4281-b951-d872f2087c98

The resulting JSON is equivalent, but now everything is smashed into one line.

This shaves 30% off the size of the NetLog dumps.

BUG=132160


Review URL: https://chromiumcodereview.appspot.com/12226132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182207 0039d316-1c4b-4281-b951-d872f2087c98

Wait 30 secs before activating PowerSaveBlocker to dismiss small uploads.

BUG=173119


Review URL: https://chromiumcodereview.appspot.com/12226005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182206 0039d316-1c4b-4281-b951-d872f2087c98

Currently we are just coalescing scrollUpdates and we end up not utilizing
this when we have interleaved scrollUpdate and pinchUpdates. This change makes
that possible and makes sure the gesture_event_queue doesnt get flooded with
interleaved scroll and pinch updates.

BUG=174189


Review URL: https://chromiumcodereview.appspot.com/12225056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182205 0039d316-1c4b-4281-b951-d872f2087c98

For current impl, Resource ID of a file is not updated for this sequence:
 (1) Add a file with resource_id_1
-- wait for synced --
 (2) Delete the file
 (3) Add a file with resource_id_2, and same content with the first file.

If the (2) and (3) come together, (2) is squashed into (3). And then (3) becomes nop since the content is not modified.

As the result, the metadata of the file has wrong Resource ID and all other change is ignored.

(notry, since most of try jobs are passed, and failed try looks not related to the patch)

BUG=175667
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12223088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182204 0039d316-1c4b-4281-b951-d872f2087c98

This patch changes "add language" overlay page in chrome://settings/language
from listed links to drop-down menu.

This patch only affects Chrome OS settings page.

BUG=133346
TEST=try bots

Review URL: https://chromiumcodereview.appspot.com/12087105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=172102


Review URL: https://chromiumcodereview.appspot.com/12036096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182202 0039d316-1c4b-4281-b951-d872f2087c98

Make sure on_asan_mac_host() always returns 1 on non-Darwin systems.

BUG=170629, 174873
TBR=thakis
Review URL: https://codereview.chromium.org/12256005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182201 0039d316-1c4b-4281-b951-d872f2087c98

> Added suppression for WebLayerTreeViewImpl::setShowDebugBorders().
> 
> TBR=zhaoqin
> BUG=175985
> 
> Review URL: https://codereview.chromium.org/12260007

TBR=atwilson@chromium.org
Review URL: https://codereview.chromium.org/12257006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182200 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin
BUG=175985

Review URL: https://codereview.chromium.org/12260007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175657
TEST=Files.app harness launches without error.
TBR=mtomasz@chromium.org, haruki@chromium.org

Review URL: https://codereview.chromium.org/12258002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182198 0039d316-1c4b-4281-b951-d872f2087c98

Native Messaging API is useful only on desktop OSes, i.e. on Linux, OSX and 
Windows. Disable it in all other configurations. Also improved how we handle 
the case when native messaging is disabled is handled: now the app will get 
disconnect notification.

BUG=142915
TBR=thakis@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12218099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182197 0039d316-1c4b-4281-b951-d872f2087c98

Previously, it was easy to resize the nav, so the file list would disappear. We shouldn't let users break the ui.

TEST=Follow the bug's repro steps.
BUG=175958


Review URL: https://chromiumcodereview.appspot.com/12217164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=152854


Review URL: https://chromiumcodereview.appspot.com/12217129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182195 0039d316-1c4b-4281-b951-d872f2087c98

When a shell window was closed, it wasn't removed from the registry immediately
(it was removed in a callback from OnNativeClose, which happens a bit later.)
This meant that when the app was loaded again, the window was still in the
registry with a stale pointer to the old extension. ExtensionSettingsHandler
was tickling this by iterating shell windows on extension load.

BUG=174250


Review URL: https://chromiumcodereview.appspot.com/12210107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182194 0039d316-1c4b-4281-b951-d872f2087c98

Also gradually deprecate FileUtilHelper since its code is no longer
used in the actual code path (used only in unittests).

Original review (with lgtm): https://codereview.chromium.org/12223006/

No changes made from the original review (the link error should be gone now by other gypi change that is already landed)

BUG=146215
TEST=content_unittests:LocalFileSystem*
TBR=jam, tzik, tbarzic (original reviewers)

Review URL: https://codereview.chromium.org/12209068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182193 0039d316-1c4b-4281-b951-d872f2087c98

All the changes are in comment.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org, haruki@chromium.org

Review URL: https://codereview.chromium.org/12262006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182192 0039d316-1c4b-4281-b951-d872f2087c98

Since this is just removal of unused code, I TBR James for the OWNER's review...

TBR=jhawkins@chromium.org
BUG=175850

Review URL: https://chromiumcodereview.appspot.com/12207138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182191 0039d316-1c4b-4281-b951-d872f2087c98

This updates the CSS flexbox property names to their most recent
iterations, displays the entire footer in a flexbox to make the layout
more obvious, and rearranges the footer's right-side flexbox so that it
always has the same width.

The logo on the footer's left side is resized once when the page is
rendered to make it the same width as the right side.  This keeps the
nav dots centered in the footer.

BUG=


Review URL: https://chromiumcodereview.appspot.com/12038090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182190 0039d316-1c4b-4281-b951-d872f2087c98

This patch includes:
- Adding proxy implementation (DircetoryReaderResource and PepperDirectoryReaderHost)
- Merging PPB_DirectoryReader_impl into PepperDirectoryReaderHost

BUG=106129
TEST=browser_tests --gtest_filter=\*DirectoryReader\*


Review URL: https://chromiumcodereview.appspot.com/11958033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182189 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6295515


Review URL: https://chromiumcodereview.appspot.com/11280284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182188 0039d316-1c4b-4281-b951-d872f2087c98

This is a resubmit of https://codereview.chromium.org/12041059

BUG=175308, 170921

Review URL: https://codereview.chromium.org/12249003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182187 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182181 0039d316-1c4b-4281-b951-d872f2087c98

The launcher install is now done by the webstore, so this code is no longer
needed.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/12208146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182179 0039d316-1c4b-4281-b951-d872f2087c98

Introducing chrome::GetTotalBrowserCount() in browser_finder.cc which counts browsers across all desktops and profiles (this is the desired count for most BrowserList::empty() and BrowserList::size() consumers).

Otherwise calling a specific BrowserListImpl's size() when appropriate.

BUG=129187


Review URL: https://chromiumcodereview.appspot.com/12212120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182178 0039d316-1c4b-4281-b951-d872f2087c98

Renamed  --is-asan-mac-builder to --is-asan-mac-builder-hackfix per Nico's suggestion.
Added more comments.

BUG=170629, 174873
TBR=thakis
Review URL: https://codereview.chromium.org/12255003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182175 0039d316-1c4b-4281-b951-d872f2087c98