- 31 Aug, 2020 40 commits
-
-
Yann Dago authored
This is a reland of e0309342 Original change's description: > Policy WebUI: 'Reload Policies' button reloads google update policies > > Bug: 1119703 > Change-Id: Ib91b37dc1da4f06782caea7b67ecc6d0c8c87b2d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367673 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802644} Bug: 1119703 Change-Id: I0542a481dc512b1c214e050084114cf313c10baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382216Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#803150}
-
Sébastien Séguin-Gagnon authored
Some of the tests were not working with the new illustrated empty states. An interface needed to be added to access the feature status in Chrome app as opposed to the test app. Change-Id: I1f7bf0e3d8e3e17cdbfca8948377e5086ae78059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378714 Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#803149}
-
Martin Kreichgauer authored
In CL:2350026, I tried to be clever and eliminate the unused FidoDiscoveryFactory argument from SetPINHandler. However, its base FidoRequestHandlerBase ctor expects a pointer to the discovery factory and is run before initialization of the SetPINHandler data members, and so we now pass it the address of an uninitialized member. Instead, inject the FidoDiscoveryFactory from the outside, like before. Bug: 1122892 Change-Id: I8ea881c57c9dc2b3c33c1bda2f0512459f3a7c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384133Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#803148}
-
dpapad authored
Fixed: 1123225 Change-Id: Ied7432e2dfede4f126da879ce139e7cc9e883ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384910 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#803147}
-
Koji Ishii authored
This patch adds `third_party/hyphenation-patterns` from: https://android.googlesource.com/platform/external/hyphenation-patterns/ Please see README.chromium. Exceprts below: Description: Hyphenation patterns for automatic hyphenation from Android. The data is originated from TeX hyphenation patterns project at http://www.hyphenation.org, modified by Android engineers. See src/README.android. Local Modifications: * The script `build_hyb.sh` is added to generate binary data files for the minikin library. Also the `hyb` directory contains the binary data files generated by the script. * The `LICENSE` file was generated by concatenating `NOTICE` or `LICENSE` files in each locale directory. * Removed `src/OWNERS`. Bug: 1093555 Change-Id: Ie155442c902811b33f32708e53c3a7e92877979b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254498Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#803146}
-
Noah Rose Ledesma authored
This change makes the audio device picker invisible when the MediaSessionInfo object reports that changing audio devices is not possible. The MediaNotificationContainerImplView will notify the device picker UI when the support for device switching changes. The MediaNotificationService will provide the device picker UI with the support boolean when the UI is constructed. Bug: 1120620 Change-Id: I09a35135569a79800fbe5ade0c36a5f37f6bee70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368051 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#803145}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /google_apis/gcm This CL was uploaded by git cl split. R=dimich@chromium.org Bug: 1110266 Change-Id: I2403e075be078395a691fdf6ea1f04e33dc76fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370299Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#803144}
-
Mitsuru Oshima authored
This reverts commit 20aca0dd. Reason for revert: The issue has been resoved in crrev.com/c/2384070 Original change's description: > Revert "Chrome OS: Use layer animation browser window frame activation animation." > > This reverts commit 3a2299e5. > > Reason for revert: Suspected breaking https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38374 and https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20193 > > Original change's description: > > Chrome OS: Use layer animation browser window frame activation animation. > > > > This is a revised version of original attempt crrev.comc/c/2166804. > > Instead of creating a new layers, this clone and animate the window's layer, > > but makes sure that the animating layer is at the bottom of other layers > > within the window. > > > > * It adds a invisible view with a layer > > at the bottom of the non_client_view (no frame w/o this, so we can exclude such case). > > * Adds the animating layer as a child of this view, with > > "SetMasksToBounds(false)" so that it will not be clipped during animation. > > * Once animation is done, this animating, old layer will be removed. > > > > Bug: 1073685 > > Test: covered by unittests. > > Change-Id: Ib5ae6a218d200394c54932e5b559217fcc7f89e1 > > Fixed: 2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375686 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#802386} > > TBR=sky@chromium.org,oshima@chromium.org > > Change-Id: I10600b9bc69818257f66fb5c1ae86f7fd1119c75 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1073685 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381217 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802539} TBR=sky@chromium.org,oshima@chromium.org,melzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1073685 Change-Id: I38725fa15f79576db154db91f7ca384578f545b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385815Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#803143}
-
Ilya Nikolaevskiy authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2353461 implementing suggestions on struct member types. Bug: chromium:1116430 Change-Id: I27d89e5c22b0bb258112fa68a82f97da9e87777b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375168 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#803142}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I7c78266d7455037d4262d6c272fed1dfcd89df8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382833Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803141}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I4ea0a82440442e986e82a41206a0904223d2a858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382816Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803140}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79257bae3c9a..19157ee4a2fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I79dc15535412b5924bab29d9802097d1da4b57fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803139}
-
Gabriel Charette authored
It's flaky as far as flakiness dashboard history goes. Recently introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2348294 assigning as such. TBR=dmblack@google.com, xiyuan@chromium.org Bug: 1123542 Change-Id: I8195565f33e6637401a77326513f551c17ca4661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385755Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#803138}
-
Liquan (Max) Gu authored
Change: * break down parseAndValidateDetailsOrDisconnectFromClient into business logic (parsing details) and UI logic (updating UI with details). * move the client-disconnection logic out of parseAndValidateDetailsOrDisconnectFromClient. Bug: 1102522 Change-Id: I3636884ba883d38eb75e3584b3205b2c13d26abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382406 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#803137}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /components/cookie_config This CL was uploaded by git cl split. R=blundell@chromium.org Bug: 1110266 Change-Id: I61908a6d547eb9efefc9cc4e07e7f95188f3c1df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371286Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#803136}
-
Scott Violet authored
importMinidumpsCrashKeys may return null. The code was not handling that. BUG=1123207 TEST=none Change-Id: Ibf775a9b053d8c051beb741e43daebc0d3c68fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382876Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#803135}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I9b268c698d8be0a349867f31d78868fd5e25644c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383018 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803134}
-
Henrik Boström authored
Nits and misc cleanup as a follow-up to landing Perfect Negotiation and "onsignalingstatechange" patches, some of which were pointed out in earlier code reviews but weren't fixed to avoid excessive rebasing. Changes include: - Now that RTCPeerConnectionHandler::OnSignalingChange only does thing related to the tracker, it is renamed TrackSignalingChange, and it is called after TrackSessionDescriptionCallback to be consistent with the order prior to my patches. - Readability: use of auto, for-each and std::move. - Remove TODOs and introduce a DCHECK. TBR=hta@chromium.org Bug: chromium:1122561 Change-Id: Ie888441e07ad2e5f18a7d72bfacb674a356e1305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385356 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#803133}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc This CL was uploaded by git cl split. R=siggi@chromium.org Bug: 1110266 Change-Id: I9014a8e3003f5dba8151c2599d550441a401d7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371255Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#803132}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c23eeb8c78ec..ffd61ca01246 2020-08-31 bsalomon@google.com Simpler SkYUVAPixmapInfo construction If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I44d8b1ce12eb81def266833d8a3757dc3a2728dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384861Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803131}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be19a45481cf..4191c5c973ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gab@google.com,kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: gab@google.com,kolos@google.com Change-Id: Ifc5e459ee9379a1f83e36e741af46c8c274e5f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384862Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803130}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ie1df128b9c677f4b86ea138cb8087cd68285dbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383012Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803129}
-
Philipp Hancke authored
increases the maximum precision of the graphs drawn to 3 since we can have values like jitter or roundtrip time which are measured in seconds but can have millisecond values BUG=chromium:678292 Change-Id: Ibcde153a518d65d1beae2cfb137f39da602b131c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382837Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#803128}
-
Yuly Novikov authored
Recent regressions. conformance/reading/read-pixels-pack-alignment.html conformance/rendering/clear-after-copyTexImage2D.html conformance/rendering/gl-viewport-test.html conformance/rendering/multisample-corruption.html conformance/textures/misc/tex-image-canvas-corruption.html TBR=bsheedy Bug: swiftshader:154, 1123524 Change-Id: I0cb48304919cfe96065d1bfdecaa22fe5680babf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385595Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#803127}
-
Oriol Brufau authored
The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568 that properties like 'text-indent' that don't apply to ::marker, should not be able to affect the ::marker via inheritance when set to an ancestor. Therefore, this patch sets 'text-indent: 0 !important' in UA origin. Bug: 1031667 TEST=external/wpt/css/css-pseudo/marker-content-023.html TEST=external/wpt/css/css-pseudo/marker-default-styles.html TEST=http/tests/devtools/elements/styles-2/pseudo-elements.js Change-Id: I4dd9e8afd448bd5fe237c084d3c0215e91560dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382750Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#803126}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/updater This CL was uploaded by git cl split. R=sorin@chromium.org Bug: 1110266 Change-Id: Ic96765ed15e30fdc5c6c84804c75f4290dcefc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370289Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#803125}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I1aa8dc85cdb849382d1dc6ece9b03d0c435cf4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382852Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803124}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f36682af28e2..59d25cd7ff01 2020-08-31 mathias@chromium.org [ts] Type-check ui/Geometry.js with TypeScript 2020-08-31 szuend@chromium.org [issues] Remove issues tab experiment 2020-08-31 mathias@chromium.org Ensure the SplitWidget is not a scrollable container 2020-08-31 kimanh@chromium.org Sort and merge location ranges on stepOver and stepInto 2020-08-31 kimanh@chromium.org Send skipList on stepOver and stepInto 2020-08-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-31 patrick.brosset@microsoft.com Layout: Assorted cosmetic changes to the layout pane as per mockups If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1066415,chromium:1072302,chromium:1105765,chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icc8e2c17044e89f6f8376f4867f9b8d5acc326f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384865Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803123}
-
Mohamed Amir Yosef authored
... 1- SavedPasswordsPresenter 2- CompromisedCredentialsManager Bug: 1108422 Change-Id: I5beccb92538186d3d0958866110d64f3693386cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385276 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#803122}
-
Antonio Sartori authored
This CL implements the part computing the intersection of two sources of the Content Security Policy: Embedded Enforcement subsumption algorithm following https://w3c.github.io/webappsec-cspee/#intersection-source-expressions in the services/network Content Security Policy module. This is part of a series of CL implementing the whole subsumption algorithm according to that spec. Bug: 1094909 Change-Id: I835c42632cacfd884321ee43a2f2a06c31abab8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315687Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#803121}
-
Benoit Lize authored
We get the process creation time on Linux by reading /proc/PID/stat. On Android, this is allowed if PID == "self". Make the code allow that. Change-Id: Ib2d41f3c361c3d632cae450e79c1e3d6bcafa60a Bug: 691874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379743Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#803120}
-
adamta authored
Adds UMA histograms for any action taken in the Discover feed header menu. Bug: 1085419, 1122672 Change-Id: Ic9d4612af10b975a084bbb5b8416e23f048f747e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380413Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#803119}
-
Aaron Leventhal authored
TBR=dmazzoni@chromium.org NOTRY=true Bug: None Change-Id: Ic4a13ac76e42a2813d2c476c4bd552eb6b46b3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383690Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#803118}
-
adamta authored
Refactors infinite feed triggering by moving the conditional logic in the VC. Logs an action when user reached the bottom of the current feed, requesting a new set of articles. Bug: 1085419, 1122409 Change-Id: I99c734aaa5912e1d82e2330ec200593648fa8153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363219Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#803117}
-
Ewann authored
This CL adds the following actions to the ReadingList Context Menu: - Mark As Read - Mark As Unread - View Offline Version in New Tab Bug: 1093302 Change-Id: Ie17e58417738cbc5cc2c3a345c281464339170b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366799Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#803116}
-
Liquan (Max) Gu authored
Change: * Move calculateWhetherShouldSkipShowingPaymentRequestUi() and mShouldSkipShowingPaymentRequestUi into PaymentUIsManager because they are UI logic. Bug: 1102522 Change-Id: I0f91e56298fb211c55eff1efc5c33871173a5f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382653Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#803115}
-
Peter Kasting authored
Bug: 1123344, 1123345 Change-Id: Id0433c3defeadc07aaf35d81de1b37f965e0d8aa Tbr: jdonnelly Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385240 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#803114}
-
Sundoo Kim authored
Fix swapping argument to FromVectorIcon() in location bar. Bug: 1123344 Change-Id: Ib2ddcd50b5095d349f9d996f750e9b61f6c52860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385478Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#803113}
-
Martin Kreichgauer authored
WebAuthn Level 2 adds an enum-valued |resident_key| property to AuthenticatorSelectionCriteria. When making a credential, the existing boolean |require_resident_key| property indicates whether the browser should create a client-side discoverable (resident) credential. The new enum-valued alternative adds a middle value ("preferred") that yields a resident credential if the user's authenticator supports it, and a non-resident credential otherwise. Web-facing changes in this CL, i.e. the addition of the ResidentKeyRequirement enum as well as the resident_key property in AuthenticatorSelectionCriteria, are guarded by a new Blink feature flag (WebAuthenticationResidentKeyRequirement). Bug: 1117630 Change-Id: I89656a10a977023a4ca60b59ad1de5cd03800f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376570Reviewed-by:
Matthias Körber <koerber@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#803112}
-
Scott Violet authored
The crash is happening because setTranslationY is being called when the InfoBarContainerView's tab is no longer active. This is problematic as when the tab is not active getBrowser().getViewController() returns null. Two fixs: . make SwipableOverlayView cancel the animation when removed. . make InfoBarContainerView handle this situation better. The latter is necessary as setTranslationY() is a public method, and may be called at any time. BUG=1121393 TEST=none (at the moment it's a bit hard to trigger this code path from tests). Change-Id: I95cd82f13efc07f81bec3a00b6c7513472bdbaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382680Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#803111}
-