- 27 Sep, 2017 40 commits
-
-
Matthew Jones authored
This change introduces the framework for the CompositorAnimator and a suite of unit tests. The following classes have been added: - CompositorAnimator: The new Animator for compositor animation in Java. This class extends the android.animation.Animator class in order to be interoperable and consistent with Android. The AnimatorListener is supported but does not support the reverse or repeat events. - AnimatorUpdateListener: This is an analog to ValueAnimator.AnimatorUpdateListener which provides notification of frame updates. - CompositorAnimationHandler: This class is responsible for pushing updates to CompositorAnimators associated with a particular instance of Chrome. The handler, listeners, and basic hookup have been integrated into Chrome but no existing animations have been converted yet. BUG=750381 Change-Id: Ia4612901cf1beacc13994b866b5f691ec9b38011 Reviewed-on: https://chromium-review.googlesource.com/627718 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#504714}
-
Dale Curtis authored
Seems the signature for this has changed slightly for some reason. BUG=244856,757162 TEST=no more race Change-Id: Ia733eb93e65e27a93d978c2b15e5901549335e5b Reviewed-on: https://chromium-review.googlesource.com/683156Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#504713}
-
Xida Chen authored
TBR=bokan@chromium.org NOTRY=true Bug: 769350 Change-Id: I6bc4cb6c15e89c6450e06b0bee1949f9f50ba5f1 Reviewed-on: https://chromium-review.googlesource.com/687794Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504712}
-
Colin Blundell authored
This CL follows up on https://chromium-review.googlesource.com/593654 by adding another browsertest. This browsertest covers an aspect of the semantics that I had not realized before: - When the primary account signs in, a signin event fires not just for that account but also for all secondary accounts that have refresh tokens available. As described fully in the prior CL, these semantics are defined by examination of the AccountTracker implementation in preparation for refactoring away from using AccountTracker. This CL also updates the test with my new understanding that when a single state change causes multiple events to fire, the order in which these events fire is effectively undefined (to be precise, it's defined by internal implementation details of AccountTracker and ProfileOAuth2TokenService that are not part of those classes' public contracts). Bug: 729542 Change-Id: If10d3c25f0a5be015678dabae882d2eafc6f1212 Reviewed-on: https://chromium-review.googlesource.com/684835Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#504711}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/fe9ea0eff300..c29c16f8cb98 $ git log fe9ea0eff..c29c16f8c --date=short --no-merges --format='%ad %ae %s' 2017-09-26 dsinclair Enable PRINTF_FORMAT for clang Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I6d7bca5780182e89fe46df1ba6f6dcc80d068017 Reviewed-on: https://chromium-review.googlesource.com/687280 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504710}
-
Fabio Tirelo authored
The histogram added earlier was intended to track download errors for the cleanup tool. However, the errors we received for this histogram is -1, which means the problem is not in the HTTP request. Collecting the net error codes as well to better understand what is going on. Net error codes include HTTP response codes: - https://cs.chromium.org/chromium/src/net/base/net_error_list.h Bug: Change-Id: I6117192740327c6a1742d78fc4b4ddd8bc0305ee Reviewed-on: https://chromium-review.googlesource.com/682534 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#504709}
-
Francois Doray authored
This class is deprecated and no longer used. TBR=agl@chromium.org,holte@chromium.org Bug: 659191, 251774 Change-Id: I111c334d3feac302abd14aa9d4d142aa237a00b4 Reviewed-on: https://chromium-review.googlesource.com/650368 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#504708}
-
Mohamad Ahmadi authored
Bug: 769336 Change-Id: I218395e5538f8d58a35dcd4fe359de7080d788af Reviewed-on: https://chromium-review.googlesource.com/687615Reviewed-by:
Marc-Antoine Courteau <macourteau@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#504707}
-
Sidney San Martín authored
Bug: Change-Id: I2658152ba91c08ddeee4d7925396e807b2431be3 Reviewed-on: https://chromium-review.googlesource.com/687399Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#504706}
-
Scott Violet authored
Specifically: . Ability for the utility process's MessageLoop to be TYPE_UI. . Adds switch to identify when utility process is running a service. . Adds ability for ContentBrowserClient to adjust command line of process launched for services. I'll use this in Chrome to force utility process to use TYPE_UI message loop. BUG=763529 TEST=none Change-Id: I7a0deadb9750d05f8ab7d15dbf8d433a51867a2c Reviewed-on: https://chromium-review.googlesource.com/685977Reviewed-by:
-
Shakti Sahu authored
Currently we are recording metrics for context menu downloads in RenderViewContextMenu which is only invoked for non-android platforms. Added code to DownloadController to collect the same metrics in android too. Bug: 767960 Change-Id: Ieb3fcbeb92293937c579ad354e6bc8fd27ad5bef Reviewed-on: https://chromium-review.googlesource.com/678858Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504704}
-
Jan Krcal authored
This CL changes the deletion procedure to actually delete only icons that have been explicitly stored as on-demand icons. One reason is that the cleanup procedure is a potential culprit for http://crbug.com/758272, where some icons disappear too aggressively. Another reason is a performace regressions (https://bugs.chromium.org/p/chromium/issues/detail?id=756101#c3). The clean-up of previously stored icons would be better as an on-off procedure (mastiz@ is looking into that). Bug: 709471 Change-Id: If46fb9f8ef912e8103d78209c86cacde02eae966 Reviewed-on: https://chromium-review.googlesource.com/670666 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#504703}
-
Sylvain Defresne authored
The version of clang shipped with Xcode up to 9.0 (excluded) had a bug where returning a std::unique_ptr<Derived> from a function declared as returning a std::unique_ptr<Base> failed. As Xcode 9.0 or higher is required to compile Chrome on iOS, the workaround (explicitly doing "return std::move(derived)") can be removed. Bug: 703565 Change-Id: I1d04872ff071c8e536a18bee6724e66b45250e48 Reviewed-on: https://chromium-review.googlesource.com/687514Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#504702}
-
Becca Hughes authored
User-Agent CSS resources are incorrectly flagged as a leak because they persist beyond a page navigation. This CL will count the number of live resources originating from UA CSS and exclude them from the test. BUG=769249 Change-Id: I5b7233d0740b9411bc836b301fdc96459ef2cb7f Reviewed-on: https://chromium-review.googlesource.com/686714Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#504701}
-
Rouslan Solomakhin authored
Before this patch, an Android payment app with duplicate default and supported URL payment method would crash Chrome due to a null pointer dereference if the payment method manifest contained "supported_origins": "*". This patch adds an integration test testDuplicateDefaultAndSupportedMethodAndAllOriginsSupported which crashes without a fix due to mMethodToSupportedAppsMapping map omitting supported payment method names that are duplicates of the default payment method name of an Android payment app. The fix is to check for a null set of supported apps before iterating over it. The new test passes after the fix has been applied. After this patch, an Android payment app with duplicate default and supported URL payment method does not crash Chrome, even if the payment method manifest contains "supported_origins": "*". The payment app can be used in Chrome. Bug: 756665 Change-Id: I58756942baeec7b365c71fcf44fd29a513190b65 Reviewed-on: https://chromium-review.googlesource.com/687295Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504700}
-
Peng Huang authored
Bug: 765393 Change-Id: I0b47f6862e9190e9ee01248fefa0c33a3ccf6923 Reviewed-on: https://chromium-review.googlesource.com/685501Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#504699}
-
Elly Fong-Jones authored
This change: 1) Reroutes invocations of this dialog from BrowserWindow to TabDialogs 2) Adds a TestTabDialogs subclass of TabDialogs for unit tests to override individual methods 3) Changes SaveCardBubbleView to accept an anchor point Bug: 728165 Change-Id: I3776bd0c9e17f3722685df1cbb25ff5d82e30537 Reviewed-on: https://chromium-review.googlesource.com/598546 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#504698}
-
Jared Saul authored
- Was already fully disabled via Finch in cl/166721855 - This CL also rearranges the impacted tests for consistency Bug: Change-Id: Id045e68e4a829d21af702ca3401fe98a2ed8818f Reviewed-on: https://chromium-review.googlesource.com/685492Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Removes unnecessary empty lines from methods.cpp.tmpl. Bug: Change-Id: I5e906ccd338afc859907aff911a4c292d7597846 Reviewed-on: https://chromium-review.googlesource.com/657778 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#504696}
-
Eric Lawrence authored
When dropping text onto the Omnibox, any leading JavaScript schemes should be stripped to avoid a "self-XSS" attack. This stripping already occurs in all cases except when plaintext is dropped on Linux. This CL corrects that oversight. Bug: 768910 Change-Id: I43af24ace4a13cf61d15a32eb9382dcdd498a062 Reviewed-on: https://chromium-review.googlesource.com/685638Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#504695}
-
Katie Dektar authored
NOTRY=true Change-Id: Idb932de14ca3eb79a1be1b175f19db48bf51fc07 Reviewed-on: https://chromium-review.googlesource.com/685413 Commit-Queue: Katie Dektar <katydek@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#504694}
-
iOS Autoroller authored
TBR=smut Change-Id: I4bd3d80fd8038d0b1e10a0beb7177b2ee432a826 Reviewed-on: https://chromium-review.googlesource.com/686779Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504693}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/6e0a6b3c40de..a78f1bc1d405 $ git log 6e0a6b3c4..a78f1bc1d --date=short --no-merges --format='%ad %ae %s' 2017-09-26 benjaminwagner Add cpu dimension for Build tasks. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I1d93164cf4a40b420432b428077479ec15b95829 Reviewed-on: https://chromium-review.googlesource.com/687194Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504692}
-
Olivier Robin authored
On iOS9, Next button is spelled "next". Bug: 759904 Change-Id: Ifa2d9048f8fec9354c9bda1f8d79a70c9d5078ec Reviewed-on: https://chromium-review.googlesource.com/686818Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#504691}
-
Xida Chen authored
NOTRY=true TBR=mlamouri@chromium.org Bug: 769323 Change-Id: I8d7e94ba162481c2a73c5164a557f3c85abd2619 Reviewed-on: https://chromium-review.googlesource.com/687279Reviewed-by:
-
proberge authored
Also removes code in chrome_elf/blacklist which was added to support this incident. Also starts clearing suspicious module incidents from the state_store, which I forgot to do in https://chromium-review.googlesource.com/c/chromium/src/+/656086 Bug: 767992 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I0562fe18704f7bfab8ed4e8732eebb49652a5a1a Reviewed-on: https://chromium-review.googlesource.com/679205Reviewed-by:
Robert Shield <robertshield@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#504689}
-
David Roger authored
This CL adds the new parameters to the HTTP request header. Unittest coverage is improved, and more assertions are added to ensure that dice_header_helper cannot add the header without sync_account parameter when fixing auth errors. Bug: 768459 Change-Id: Ie38f7db8445593e58ceb3886edd255ae2749e278 Reviewed-on: https://chromium-review.googlesource.com/686816Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#504688}
-
Reza.Zakerinasab authored
Color managed CreateImageBitmap from OffscreenCanvas layout tests do not use the passed canvas color space and canvas pixel format when creating the offscreen context 2d. This change fixes this issue. Bug: 768896 Change-Id: I296c845953d3d31ee3599a203e9890fdf5a442f6 Reviewed-on: https://chromium-review.googlesource.com/685258Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#504687}
-
Shanmuga Pandi M authored
WTF::TriState is used only in core/editing. So it is better to keep it inside core/editing. Bug: 751942 Change-Id: I62262240c6e39d8ed8108cb462262cd699490a71 Reviewed-on: https://chromium-review.googlesource.com/670206Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#504686}
-
Xida Chen authored
TBR=vitaliii@chromium.org NOTRY=true Bug: 757955 Change-Id: I415435d5964d1ea50a5dc2a08d39cb3f1007fb5c Reviewed-on: https://chromium-review.googlesource.com/687474Reviewed-by:
-
Mathieu Perreault authored
Would previously not catch when the month name was contained in the string along with other stuff (e.g. "01 - January"). The code will now recognize this as the month name. Bug: 767942 Test: components_unittests Change-Id: Iff5b5f531337ede4372361dccb2565363f5e6f31 Reviewed-on: https://chromium-review.googlesource.com/687114Reviewed-by:
-
stkhapugin@chromium.org authored
Renames PopupMaterialViewController->PopupViewController. Renames PopupMaterialRow->PopupRow. Keeps ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.h for compatibility with downstream includes. This will be removed in a follow-up CL. This is a reland of 660277. Change-Id: Id044d5875d82fda271bfbf328476f742f40f7b87 Reviewed-on: https://chromium-review.googlesource.com/687016Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5553195b. With Chromium commits locally applied on WPT: dc84d178 "Teach LinkLoader about the 'nonce' attribute" Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2491 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: Ib0db435183bc34f79543137ba7fc0cb77e2a8dc1 Reviewed-on: https://chromium-review.googlesource.com/686797 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504682}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/620223167f1d..fe9ea0eff300 $ git log 620223167..fe9ea0eff --date=short --no-merges --format='%ad %ae %s' 2017-09-27 npm Remove unreachable code in fx_codec_icc Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ifa4e3ec10a9cba6f0295c91e75f845fd89de1012 Reviewed-on: https://chromium-review.googlesource.com/687000 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504681}
-
Leonard Grey authored
This prevents a crash when a user tries to delete a bookmark bar folder while in fullscreen mode. Deleting (and thus closing) the folder affects the visibility of the toolbar, which causes the bookmark bar to relayout, which attempts to close the folder again, leading to an overrelease. Guard against this by removing the call to close the bookmark folder from the "remove" method, allowing the layout method to close it. Bug: 485664 Change-Id: Ia2d6b89604339a52a9b7865d69b9942c5f5596a8 Reviewed-on: https://chromium-review.googlesource.com/685034 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#504680}
-
iOS Autoroller authored
TBR=smut Change-Id: I8be22e0701f2a792bc2c4aacbb25a38db5d105fb Reviewed-on: https://chromium-review.googlesource.com/686799Reviewed-by:
-
Nicolas Dossou-gbete authored
Updates the SuggestionCardActionModern style to be more generic and be usable for classic cards, use it for the classic generic signin promo and the action item. Preview: https://photos.app.goo.gl/GC9l01D8QI7YSLtI2 Bug: None Change-Id: If1a007ad4288cc88511845b3ac89a9c8f2f1cbab Reviewed-on: https://chromium-review.googlesource.com/674691 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#504678}
-
Xida Chen authored
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/15129 Revert "[Zucchini] Add Reloc support to DisassemblerWin32." This reverts commit 9ee94f7e. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Zucchini] Add Reloc support to DisassemblerWin32. > > This CL implements code to read and write reloc data in Win32 PE files. > Reloc reading is split into 2 layers: One to naively extract (type, RVA) > data, and another to translate and filter it (by type and validity). > This enables more thorough testing. Other changes: > - DisassemblerWin32 extraction of .reloc data, and code to process > reloc data. > - InclusiveClip() and ceil(), along with tests, in algorithm.h. > > Bug: 729154 > Change-Id: Ifca83d62d66d3e34ceb4693a879b88097d2cb979 > Reviewed-on: https://chromium-review.googlesource.com/667062 > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504670} TBR=huangs@chromium.org,grt@chromium.org,etiennep@chromium.org Change-Id: I9e9a37fbae5e0f0fcc7ba608e0411a461e220f1a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 729154 Reviewed-on: https://chromium-review.googlesource.com/687434Reviewed-by:
-
Paweł Hajdan Jr. authored
This reverts commit f036ddd7. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=769304 Original change's description: > Add checkout_nacl gclient flag (default true) > > See https://groups.google.com/a/chromium.org/d/msg/chromium-dev/tO8kIrDtQc8/bCRO-UXxBQAJ for discussion. > > Bug: 756688 > Change-Id: I80f0526b278a813b398f6f81baacf36552da1792 > Reviewed-on: https://chromium-review.googlesource.com/681854 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504598} TBR=dschuff@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org Change-Id: I4040923ea80defb25803406485d846fe0c82046d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756688 Reviewed-on: https://chromium-review.googlesource.com/687414Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504676}
-
Klemen Kozjek authored
This CL changes order of buttons (affirmative action, dismissive action), style, and text for the title and affirmative action. As a result, dialog to enter a password to gain access to protected files, now follows UI/UX style of ChromeOS dialogs. Bug: 768731 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I65965cfdba9efcf6e677574e228336116978779d Reviewed-on: https://chromium-review.googlesource.com/684100 Commit-Queue: Klemen Kozjek <klemenko@google.com> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#504675}
-
