- 12 Jun, 2018 40 commits
-
-
Scott Chen authored
Bug: 832177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I493b2b14e0489254fecdfef608f842af369809f6 Reviewed-on: https://chromium-review.googlesource.com/1089575 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#566531}
-
Rayan Kanso authored
Bug: N/A Change-Id: Ic1bec0e6c4481c83cfcf1b8629cffb7a0936dbf2 Reviewed-on: https://chromium-review.googlesource.com/1097484Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#566530}
-
Jeremy Roman authored
Bug: 851647 Change-Id: Id7acf348daf9a2af3a961a59643593b40da686a3 Reviewed-on: https://chromium-review.googlesource.com/1097227Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566529}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a8802477752f..7ce4a15115cb git log a8802477752f..7ce4a15115cb --date=short --no-merges --format='%ad %ae %s' 2018-06-12 jmadill@chromium.org Add support for uint8_t and uint16_t bitsets. 2018-06-12 jmadill@chromium.org Vulkan: Minor style fixes. 2018-06-12 lucferron@chromium.org Vulkan: Fix point coord management Created with: gclient setdep -r src/third_party/angle@7ce4a15115cb The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ie2ee0bb7da4ee5365bef4dfb3065603005ce85c1 Reviewed-on: https://chromium-review.googlesource.com/1097377Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566528}
-
Fabio Tirelo authored
When focus change to a field, announce to screen readers if there are autofill suggestions available. When suggestions are not available, block screen readers from announcing anything. This is only enabled when screen readers are available, since it's not useful to spam users otherwise. Follow-up CLs will add telemetry collection to allow evaluate performance impact. Bug: 848427 Change-Id: Ic4955a9f1b25a34f0d4f02e7d87ef7cc99e44998 Reviewed-on: https://chromium-review.googlesource.com/1090792Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#566527}
-
Maks Orlovich authored
The in-memory cache (the browser, not renderer one) before this change could have quite a lot of waste because it directly uses std::vector's to store payload bodies; which with exponential growth and data getting streamed in could mean that, say, a 145613 byte file could end up using up 256KiB. In practice that seems to work out at roughly 70MiB total storage for 50MiB useful payload. Bug: 845639 Change-Id: I8791e2cb6cb13ce4c1eead250cff8825b95723ea Reviewed-on: https://chromium-review.googlesource.com/1096077 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566526}
-
Patrick Monette authored
This old UI is deprecated, and the replacement (IncompatibleApplicationWarning feature) is already in place and being experimented with. Bug: 643532 Change-Id: Ia2ba7c072fcd2901dc0901f94650a153b8138426 Reviewed-on: https://chromium-review.googlesource.com/1091497Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#566525}
-
Annie Sullivan authored
TBR: szager@chromium.org Change-Id: I8ed55fc88924fa31cc537ee76e1543b919e7a21d Reviewed-on: https://chromium-review.googlesource.com/1097700Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#566524}
-
Takumi Fujimoto authored
When |widget_| becomes null, |web_contents_| becomes invalid as well. So this CL checks for |widget_| before using |web_contents_|. Bug: 843023, 846505 Change-Id: I113de199ed7b0799308c99299ee36c1acd7c8656 Reviewed-on: https://chromium-review.googlesource.com/1093419 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#566523}
-
Allen Bauer authored
Bug: 848482 Bug: 848474 Bug: 848480 Change-Id: Iea9528748e81529e4673a3b69f22d50135a9324d Reviewed-on: https://chromium-review.googlesource.com/1089723 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#566522}
-
Matt Menke authored
Previously, on network service crash, QUIC was only being re-disabled on the first use of the system NetworkContext. This was incidentally fixed in https://chromium-review.googlesource.com/1067959. This CL adds policy browser tests for that case to protect against regression. Bug: 845772 Change-Id: Ie0e0afa02d36807288f56f75782c94d4c1f8ca78 Reviewed-on: https://chromium-review.googlesource.com/1087408Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#566521}
-
danakj authored
Also remove unused num_unclipped_descendants_, and redundant scroll_offset() accessor, when CurrentScrollOffset() also exists. R=weiliangc@chromium.org TBR=bokan Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I69f63e987b35985389e9ad78d5d18a08e619d50b Reviewed-on: https://chromium-review.googlesource.com/1093780 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#566520}
-
Yuri Wiitala authored
While there were DCHECKs and mojo struct traits to guard against clients using invalid scaling parameters, we encountered a common crash on Android. This is because: 1) the release builds were not doing the DCHECKs; and 2) the mojo struct traits were not involved as Viz was running in the same process as the client code. This change adds the approprate guards at all code points where scaling CopyOutputRequests are being made (if they were missing/insufficient). It also changes the DCHECKs in CopyOutputRequest::SetScaleRatio() to CHECKs to make future crash reports more actionable, pointing to where the illegal values originate. R=boliu@chromium.org,danakj@chromium.org,fsamuel@chromium.org Bug: 848725 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I64c5134f1547abe9a6faefa2e869e346cac574bd Reviewed-on: https://chromium-review.googlesource.com/1093519 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566519}
-
Chris Lu authored
Helps determine which kind of ListItem to put into the view controller's model. Change-Id: I5a5e64a533e160a497eb5d3b59070f3ec534c028 Reviewed-on: https://chromium-review.googlesource.com/1092096 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#566518}
-
Marc-Antoine Ruel authored
This guarantees that the same python runtime is used as the calling script. This also saves an unnecessary cmd.exe process on Windows, which saves a few ms. Add notes about commands that are run remotely. TBR=mmeade@chromium.org BUG=761523 Change-Id: I84e809be158f747425ac486d40a92f29e1278d1c Reviewed-on: https://chromium-review.googlesource.com/648351Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#566517}
-
Patrick Monette authored
Change-Id: I0118d26fe9b7f11f2608dd66c10418e210393733 Reviewed-on: https://chromium-review.googlesource.com/1083842 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#566516}
-
Eric Karl authored
Android OOP-D doesn't currently receive swap notifications, as the output surface has moved to the Viz process. This patch adds IPCs to deliver these notifications via DisplayClient. In order to reduce complexity and IPC spam, these notifications will only be delivered on platforms that require them, as indicated in RootCompositorFrameSinkParams. Bug: 811970 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5ddc23c59b7c6a5851e9f82d2bcb18c12bb25839 Reviewed-on: https://chromium-review.googlesource.com/1087869Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#566515}
-
Henrique Nakashima authored
Bug: 825038,851805 Change-Id: I3212b090bc9085dd163a514926bdbef86bc5f093 Reviewed-on: https://chromium-review.googlesource.com/1097495Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#566514}
-
Nikunj Bhagat authored
Bug: 843286 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0d5f04339a79025ad4cb5e97b76c54695ad66088 Reviewed-on: https://chromium-review.googlesource.com/1086301 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#566513}
-
Michael Thiessen authored
When the device is OOM or nearly OOM, querying the daydream viewer parameters can throw exceptions. Chrome will probably just end up crashing somewhere else from OOM, but maybe this will mitigate some of the crashes. Bug: 851979 Change-Id: If4a9d53cc7ab87ae47ffbac3967fa3a7225cf6dc Reviewed-on: https://chromium-review.googlesource.com/1097463 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#566512}
-
Sigurdur Asgeirsson authored
Bug: 755840 Change-Id: I76dc1108a56197df92263750df7a0b72c1c08d1f Reviewed-on: https://chromium-review.googlesource.com/1095421 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#566511}
-
Nasko Oskov authored
This test was flaky due to a race condition in navigation code, which has now been fixed. Let's try to enable it and see if the fix has helped deflake this test. Bug: 660288 Change-Id: I2d8377e42172d30b3af19f23c632d09c3e99f5f3 Reviewed-on: https://chromium-review.googlesource.com/1097555Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#566510}
-
Ryan Landay authored
The Android non-horizontal tab switcher with overlapping tabs has logic to show more of a tab (by scrolling other ones down) if you long press on it. This logic was inadvertently carried over to the new horizontal tab switcher, where it has odd results. This CL fixes this bug by moving this logic from Stack into OverlappingStack so we don't use it in NonOverlappingStack. Bug: 851521,831359 Change-Id: I98c18790a170661a221a61df109ed3ea050b6fd5 Reviewed-on: https://chromium-review.googlesource.com/1096477 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#566509}
-
Roger McFarlane authored
This reverts commit ac0ccdc1. Reason for revert: Consistent failures in FilesAppBrowserTest See https://crbug.com/852044 Original change's description: > Add a FakeDriveFs and change FileManagerBrowserTestBase to use it. > > Bug: 848126 > Change-Id: Icb7b5edf28aa61e133aff0f0bf639f06b32adcfa > Reviewed-on: https://chromium-review.googlesource.com/1088336 > Commit-Queue: Sam McNally <sammc@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Sasha Morrissey <sashab@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566333} TBR=xiyuan@chromium.org,noel@chromium.org,sashab@chromium.org,sammc@chromium.org,dats@chromium.org Change-Id: Ia41b2921db3a493fd9612d769c04ece88b014a48 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 848126 Reviewed-on: https://chromium-review.googlesource.com/1097655Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#566508}
-
Zhongyi Shi authored
Update flags. https://chromium-review.googlesource.com/c/chromium/src/+/1096348 Fix udp proxy with ietf header packets. Merge internal change: 199858756 https://chromium-review.googlesource.com/c/chromium/src/+/1096341/ Deprecate FLAGS_quic_reloadable_flag_quic_early_retransmit_detects_in_flight_packet_lost. Merge internal change: 199836853 https://chromium-review.googlesource.com/c/chromium/src/+/1096335/ Add a flag which further reduces the ACK overhead in QUIC. On it's own it reduces overhead by ~20%, but combined with ACK_DECIMATION_WITH_REORDERING it r educes the overhead by 25-30%. Enable quic_deprecate_scoped_scheduler2 flag in Quartc's Quic connection. Merge internal change: 199633680 https://chromium-review.googlesource.com/c/chromium/src/+/1096310/ Update a QUIC_BUG_IF in sent_packet_manager because when session decides to write, a previous RTO retransmission can cause connection close (and hence stream close). Merge internal change: 199525677 https://chromium-review.googlesource.com/c/chromium/src/+/1096308/ Enable ACK_DECIMATION_WITH_REORDERING in Quartc's Quic connection. Enable ACK_DECIMATION_WITH_REORDERING, which reduces the number of ACKs significa ntly (on the quic-test for receiver overhead goes down from 270KB to 170KB, on th e sender for audio-only call overhead goes down from, 1.7 ratio to 1.4 ratio) Merge internal change: 199515468 https://chromium-review.googlesource.com/c/chromium/src/+/1096307/ LSC: Replace calls to deprecated absl::string_view methods as_string, to_string, and ToString with string(). The former member functions are deprecated and will soon be removed. The edits were generated by the clang-mr tool replace_string_view_conversion_members and th e clang-tidy check for redundant string conversions. Merge internal change: 199510453 https://chromium-review.googlesource.com/c/chromium/src/+/1096304/ Make largest peer stream ID tracking virtual. QBONE has no need to know what the peer stream IDs are, since everything is completely independent and the stream pairs are not actually correlated. Disabling this tracking in QBONE eliminates memory usage by the available_streams_ map. Merge internal change: 199457611 https://chromium-review.googlesource.com/c/chromium/src/+/1096302/ deprecate FLAGS_quic_reloadable_flag_quic_path_degrading_alarm2. Merge internal change: 199341125 https://chromium-review.googlesource.com/c/chromium/src/+/1096298/ In QUIC, remove overrided GetStatelessResetToken in GfeQuicServerSession and GfeQ uicTimeWaitListManager because they are all faked tokens. Not protected. Merge internal change: 199303584 https://chromium-review.googlesource.com/c/chromium/src/+/1096294/ Deprecate FLAGS_quic_reloadable_flag_quic_fast_free_mem_slice. Merge internal change: 199285801 https://chromium-review.googlesource.com/c/chromium/src/+/1093797/ Change-Id: I1f153e288c6f464b43a8613697cb8c75751a156e Reviewed-on: https://chromium-review.googlesource.com/1096350 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#566507}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I61ad7b7fb7656619be687ec28d25aff2a827b5b7 Reviewed-on: https://chromium-review.googlesource.com/1097573Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#566506}
-
Jinsuk Kim authored
ChildProcessLauncherHelper is now in content_public. This CL removes the exception rules not necessary any more. They should have been in https://crrev.com/c/1072211 but were left out. Bug: 617324 Change-Id: I4bfca26b4a94e30194d8f2327faa7eabb32dc8ba Reviewed-on: https://chromium-review.googlesource.com/1097466Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#566505}
-
David Bokan authored
Came across these old TODOs which can now be applied and removed. They are safe to remove because the layers are all created at the same time and never removed. Thus, since we don't check inner_viewport_scroll or page_scale the rest should also exist. Change-Id: Iaf619aaf9b159152b9fcccc74cdf4da8e680a6e2 Reviewed-on: https://chromium-review.googlesource.com/1096369Reviewed-by:
enne <enne@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#566504}
-
Eugene Y. Q. Shen authored
Bug: 852010 Change-Id: I01489210cc83381de2706d945f63e2bfbd10a4bf Reviewed-on: https://chromium-review.googlesource.com/1097557Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#566503}
-
Morten Stenshorne authored
We need to consider both LayoutListItem and LayoutNGListItem as list items. Furthermore, LayoutNGListItem differs from LayoutListItem in that its marker child has a text child rather than being childless. We need to make sure that we also set the font size multiplier on that text child. Also, the marker object itself is actually a (tiny) block, so we need to make sure that the text autosizer doesn't ruin for itself when laying it out. It's up to the list item whether to autosize or not, and we shouldn't let the marker child override that decision (that would typically leave us with tiny markers beside an otherwise correctly inflated list item. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie99c5ce559bae62db465527a3d6a337abbc4a75a Reviewed-on: https://chromium-review.googlesource.com/1095278Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
cathie chen <cathiechen@tencent.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#566502}
-
John Abd-El-Malek authored
1) extensions_browsertests isn't run, so don't run it with network service. 2) interactive_ui_tests is marked as experimental, so do the same with network service. Bug: 818832 Change-Id: I893a613bde1b95c14c456dcdb8ee129633557a0d TBR: jbudorick@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1097498Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#566501}
-
Tommy C. Li authored
This disables Steady State Elisions on Mac Cocoa regardless of the flag setting. It simply does not function correctly. On MacViews, Steady State Elisions is still enabled. Bug: 843097 Change-Id: Ife0068038222d942eece481d7f511935e216da09 Reviewed-on: https://chromium-review.googlesource.com/1095679Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#566500}
-
crystallambert@chromium.org authored
Change-Id: Ib1f5c24f9162e982ee4ec9c279203b527a5af944 Reviewed-on: https://chromium-review.googlesource.com/1097571Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#566499}
-
Toni Barzic authored
BUG=842979 Change-Id: I489be916e8dbe042ae93dced9abea3bdfe378842 Reviewed-on: https://chromium-review.googlesource.com/1095541 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#566498}
-
Roger McFarlane authored
TBR: battre@chromium.org Bug: 851854 Change-Id: I6b7e57ef8c739dcbb9fc0135fad8edb5d78b4f8f Reviewed-on: https://chromium-review.googlesource.com/1097504Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#566497}
-
bsheedy authored
At some point in the past few weeks, the way we were performing fling scrolls in tests stopped working reliably. However, whatever caused it to stop working as-is also caused the bug where we couldn't fling scroll if using too much of the touchpad to go away. So, this CL does the following: 1. Gets rid of the extra boolean for the VR controller's scroll() method since it isn't necessary anymore. 2. Changes the test's fling scrolling to more closely match actual fling scrolling behavior (i.e. just scroll quickly) Bug: 851761, 820281 Change-Id: Iaaf9c33e79e3ae0496eb1e0b234018e5362d44ec Reviewed-on: https://chromium-review.googlesource.com/1097496Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#566496}
-
Kyle Horimoto authored
This CL re-lands a reverted CL: Original - https://chromium-review.googlesource.com/c/chromium/src/+/1092231 Revert - https://chromium-review.googlesource.com/c/chromium/src/+/1096774 The original CL is uploaded as patchset 1. The issue in the original CL was that memory was used after it was deleted, and the fix is part of patchset 2. Original CL description: This class queues requests for advertisements to a given remote device. Each advertisement is given a 10-second timeout before it gives up. This class uses a SharedResourceScheduler to prioritize requests and updates priorities when needed if a request is added or its priority is changed. Bug: 824568, 752273 Change-Id: I918a752e3dd896ea7e140ba6323f761012997fd7 Reviewed-on: https://chromium-review.googlesource.com/1097462 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#566495}
-
Vaclav Brozek authored
After https://crrev.com/c/1078108, IsPasswordGenerationEnabled can be false while generation is still enabled in renderer. This is because IsPasswordGenerationEnabled only checks the flags related to generation, while the renderer code also enables generation while kExperimentalUi is enabled. This is confusing. The reason was a dependency cycle explained in [1]. This has been fixed in https://crrev.com/c/1092863. Therefore, this CL ensures that all checks, including for kExperimentalUi are included in IsPasswordGenerationEnabled. [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/nX63vp-75_U/h7H19i9dAQAJ Bug: 850931 Change-Id: I548c1a584537445d88a8595152f75ca5d28a72d0 Reviewed-on: https://chromium-review.googlesource.com/1092856 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#566494}
-
John Abd-El-Malek authored
I'm seeing this on main waterfall bot after I enabled network service test suites there. Change-Id: I59adf212739b6ec4534ebbbfc08c7fc05ff963be Reviewed-on: https://chromium-review.googlesource.com/1097465 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#566493}
-
Koji Ishii authored
Following bot results are included. 6366 6650 6652 6661 6668 6681 6693 6707 6719 6720 15 lines were removed and 4 lines were deflaked by consecutive results since 6635. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id2d68407988606974a088c44a05c4af2aff956b1 Reviewed-on: https://chromium-review.googlesource.com/1095065 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#566492}
-