- 17 Nov, 2020 22 commits
-
-
Gordon Seto authored
Add ESimManager bindings to OS Settings and create FakeESimManagerRemote to use as a mock for unit testing. Bug: 1093185 Change-Id: I03ab65d280f497ef9fac39bd1b48cef725083441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536113Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#828004}
-
Fergal Daly authored
This is some ugly but temporary debugging to log extra information when we find the the view has no main frame but the local root does. Bug: 1139104 Change-Id: I791fc7572a4a5a5abf3c7c689c4029e1696bbd48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532535Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#828003}
-
Eric Lawrence [MSFT] authored
Remove the unneeded feature declarations now that passive mixed content is autoupgraded by default. Bug: 1042877 Change-Id: I60ab635bc7f75527ca27f0657719b1ef42dbe7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540654Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#828002}
-
Nektarios Paisios authored
On some platforms a node is represented as an "object replacement character" in the text of its parent node. When calculating the parent AXPosition of a text position, we added special logic that adjusts the resulting position to be either before or after the object replacement character depending on the navigation operation. For example, if we are trying to find the start of line, we need to move to before the "object replacement character". Similarly, we need to adjust to after the replacement character if we are trying to find the end of the line. This adjustment is not necessary unless there is some ambiguity in the original position. Ambiguity only occurs when the original position is not at the start and not at the end of its anchor. Unfortunately this special logic was not applied to tree positions, and it was inconsistently applied to text positions at the end of their anchors, hence this patch. Also fixes a few bugs in the CompareTo, SlowCompareTo and AtStartOfAnchor methods that were found during testing: 1. AtStartOfAnchor was using text offsets for tree positions, even though they might not have been calculated yet because AsTextPosition() hadn't been called. 2. CompareTo was adjusting both text and tree positions that are inside embedded objects to after the embedded object character for comparison purposes, even though the comment in the code only talks about text positions. Also the adjustment was done manually by adding or subtracting 1, which is error prone. Now the comparason is done by SlowCompareTo. 3. CompareTo and SlowCompareTo were not properly comparing a tree and a text position that have the same anchor. 4. SlowCompareTo was not comparing a tree with a text position by converting the tree position to a text position. It was doing the opposite, thereby losing information in the process. 5. SlowCompareTo was not taking embedded objects and affinity into consideration when comparing two text positions that are not ancestors of one another. 6. SlowCompareTo was not normalizing tree positions to the start of their anchors before comparing them, thereby running the risk of comparing an "After children" or an "After text" position with an adjacent "before children" or "before text" position and erroniously finding them to be equal. Split out from a larger patch that merges AXNodePosition and BrowserAccessibilityPosition into one class: https://crrev.com/c/2327552 AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1049261 Change-Id: Icedaebca48468c95bdbf1fc5c10393c4ace7dadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343031 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Victor Fei <vicfei@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#828001}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e371caae2fd..bee2bff5b0e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1136305,chromium:1146954 Tbr: tguilbert@google.com Change-Id: I2266e8827053512a614f66c0bb57ed372d95ce73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542647Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828000}
-
Charlene Yan authored
- Update tests to verify tabstrip is not larger than parent when growing - Add a test to ensure the grab handle space is always visible - Update new tab button always visible test to match this - Rename kTabStripWidth to kTabStripRegionViewWidth Bug: 1141674 Change-Id: I7fa527ed836c78ea9a3c1958715dc83ba7893a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536238Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827999}
-
Charlene Yan authored
When the browser window is large enough, the tabstrip should expand to accommodate tabs dragging past the last tab. This is a test for crrev.com/c/2472577 Bug: 1141674 Change-Id: Icfb4b0d6b9ebfa243a0e352b0cef68a2a6f2c263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537068Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827998}
-
dpapad authored
The helper is no longer used. Mocking chrome.send() calls is happening via the use of browser proxies in all newer WebUIs. Fixed: 1148403 Change-Id: I543ad1d36a0a92110182b4998380b3061c478f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537770 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#827997}
-
Luciano Pacheco authored
This CL changes Audio Player background page to run as JS module. Bug: 1133186 Change-Id: Ib9657c09bcea95deb97e63d19bfdfac88644daeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537287Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#827996}
-
Brian Geffon authored
To prepare for adding new channel types (ie. fast posix channels) we will need a way to extend existing Mojo NodeChannel messages. Bug: b:173022729 Change-Id: I56b80ed58f28d058927d94ef9421319fe547c719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538166 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#827995}
-
Michael Checo authored
Screenshot: http://shortn/_AyCiiMx92w - Center cards - Adjust margin within cards - Adjust card width - Remove minimum height requirement from cards Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I4c4f31182c7c835f6015b15af0f5a3aab64f489d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530744 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#827994}
-
Matthias Körber authored
Rename variables containing the parsing patterns. Removes auto& statements in favor of explicit type declarations. Removes spurious comments. Change-Id: I9ca9523a5039952ab7de9dbeaa45f0baaa476d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535770 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#827993}
-
Matt Menard authored
Refactor print server components from CupsPrintersManager into its own class. Bug: b:168650771 Change-Id: If62b27ffde97257e9e0ac5b745ceecdd13721fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521226 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#827992}
-
Nina Satragno authored
CTAP 2.1 devices support the authenticatorSelection command to get a touch. Use authenticatorSelection instead of creating a dummy credential on those devices. Fixed: 1039426 Change-Id: I89420f1a181470fbbcce59a6ca0cdf3a44bd2ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535874 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#827991}
-
Yuly Novikov authored
Bug: 1148989 Change-Id: I2a9f46f26eb076cc73166db300d14a1feb63fa28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541579Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#827990}
-
Curt Clemens authored
File preview icons have been enlarged to match the size of the <nearby-progress> icon. The confirmation page spec has been updated to require that the dashed line between the file preview icon and the progress icon should be aligned with their centers. Bug: b/163036847 Change-Id: Ib86109fe36e275a90cf8db3d2ed70585e9a28b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530736 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827989}
-
Leonard Grey authored
Bug: 1014639 Change-Id: I27a3ca26e027fc4059285de2462edc25c400d399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537144 Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#827988}
-
Alex Newcomer authored
UX wants them to be a bit larger. Bug: 1147637 Change-Id: I6980cc2cf0d35f757ca55e4a0cb1d91291eaa5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542925 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827987}
-
Dirk Pranke authored
The upload_trace_processor step on the perfetto bots has been failing on Windows since a change that changed how vpython dependencies were packaged landed. This CL adds what I believe to be a missing data dependency on //.vpython that will hopefully fix the problem. Bug: 1122953 Change-Id: I7b42278bf1a1177b36e2547d0737cc9288c289e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536819Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#827986}
-
Sorin Jianu authored
The test failed on the Win7 Debug CI bot because the COM apartment of the code making COM calls in the unit test was not initialized. COM apartment initialization must be done per-process or at least, per thread. It is unwise to do it per-function. Bug: 1149213 Change-Id: I4ef5ae6396bbb101da3f6dfdccf070e54ae26983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543122Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827985}
-
Rachel Carpenter authored
With the genius app finally deleted, there are no possible entry points left to get to the welcome tour. Means all the Welcome tour code can be deleted. Bug: 1001460, b/145710734 Change-Id: I95e6c3f23a1ccc47a017a434b8b17a3dcedc6a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989721Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#827984}
-
Chris Sharp authored
Updated the following policies: NTPCustomBackgroundEnabled PrintPreviewUseSystemDefaultPrinter RequireOnlineRevocationChecksForLocalAnchors SafeBrowsingForTrustedSourcesEnabled SamlInSessionPasswordChangeEnabled Bug: 1139306 Change-Id: I4657d533ad8dbf86f1a2ff4394d2122a4c2deb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534712Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#827983}
-
- 16 Nov, 2020 18 commits
-
-
Curt Clemens authored
Display a generic error message on the discovery page when the share target selection fails or if we can't get the discovery manager. Hide the help section when the error section is showing to avoid crowding the page, since the help is irrelevant if we're in an error state. Bug: 1123934 Change-Id: If417cc633987da59fec495f329d2f54fe4d8eb83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538425 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827982}
-
Tim Sergeant authored
This is a reland of 5d6ecbfb The failing Tast test (ui.ShelfLaunchedApps) has been updated to ensure it continues passing after this CL is landed. This is the second of a chain of 3 CLs: 1. crrev.com/c/2538305: Allow Files app to be pinned by default in ui.ShelfLaunchedApps 2. crrev.com/c/2538857: Add Files app to default shelf pins in second position 3. crrev.com/c/2538307: Update ui.ShelfLaunchedApps to ensure Chrome and Files are always pinned Original change's description: > CrOS: Add Files app to default shelf pins in second position > > This adds the Files app to the spot after the Chrome icon, for new users > only. There's also some variations of the default pin layout controlled > by a Finch experiment, I've moved the Files app up in those layouts for > consistency. > > This change was requested for M88 and will be merged back. > > Bug: 1148519 > Change-Id: Iae54561fec599b813ba97e82a5678fa834a02db2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537214 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Auto-Submit: Tim Sergeant <tsergeant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827272} Bug: 1148519 Change-Id: I9186b43a651dea4c4de9e46f849d35da9cc6062c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538857Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#827981}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f46e6201b40b..620cb770e3dd 2020-11-13 syoussefi@chromium.org Fix texture buffer unbind and size query 2020-11-13 senorblanco@chromium.org Wrap a paragraph in DevSetup docs to 100 chars. 2020-11-13 senorblanco@chromium.org Fix some apostrophes, because I'm possessive like that. 2020-11-13 timvp@google.com Vulkan: Suppress VkSubpassDescriptionDepthStencilResolve 2020-11-13 timvp@google.com Add test running flag: --delay-test-start 2020-11-13 senorblanco@chromium.org Fix EGL_ANGLE_platform_extension* filenames in DevSetup docs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: KHR-GLES31.core.texture_buffer.texture_buffer_parametersTest: Test: dEQP-GLES31.functional.texture.texture_buffer.state_query.texture_buffer_size_integer Change-Id: I16f60b0dabd54a7092c51e8a32d8f45f2f00144b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#827980}
-
My Nguyen authored
Bug: b/173433294 Change-Id: Iabb04f870cc05700bbdf7823c7296ddce221ee15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541943Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#827979}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605516929-4169c4fef8b75b908f60a07df9383038ad3b6191.profdata to chrome-win64-master-1605538580-6a865849c18026af9e6bfd8c91f845d03275941b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7d9224677584f66329589054ed9aeae2d7fc3c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827978}
-
Thomas Guilbert authored
This reverts commit fc8af8e6. Reason for revert: Crashing on MAC bots https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/5816 Original change's description: > Fix Crash in Hung Pages view while in screen reader > > There seems to be a timing issue between the AX queries for > GetText and when the model is updating. Looking at the model > it seems not all TabDestroyed calls are informing the Observers > that the model has changed. > > The TableView uses Virtual AX Children that depends on the > observers to call. Moved the observer call from TabDestroyed to Reset > to handle all delegate_->TabDestroyed() calls defined below: > > - RenderProcessExited > - RenderWidgetHostDestroyed > - TabDestroyed, > - RenderViewHostChanged > - WebContentsDestroyed > > Bug: 1140454 > Change-Id: Ie7fd07d6540b9509b998d5cd95d1fd16f47f9018 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530295 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Mohamed Mansour <mmansour@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#827900} TBR=sky@chromium.org,tapted@chromium.org,robliao@chromium.org,dfried@chromium.org,mmansour@microsoft.com Change-Id: Ifb73fc1762d043fbba1d3a3a8b5744c169b9a88b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543191Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#827977}
-
Noel Gordon authored
No "(c)" in chrome project copyright notices. Comment only change. No-try: true Bug: 1113981 Change-Id: I35202f41caeff12d3fdae794ae7c6a74af27939f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542927Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827976}
-
Sebastien Lalancette authored
Tapping anywhere else on the app (e.g. the keyWindow) will make the popover disappear. Bug: 1149618 Change-Id: If7f712cd3498b0a055a364d047105464d58492d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542366 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#827975}
-
Robert O'Callahan authored
Expose v8dbg symbols so that V8's postmortem metadata is accessible in the Chromium binary, if built Exposing the v8dbg postmortem metadata symbols in Chromium builds (when built, which they aren't by default) enables detailed analysis of V8 JS execution by observing binary-level execution: https://robert.ocallahan.org/2020/05/omniscient-js-debugging-in-pernosco.html Bug: 1147409 Change-Id: I8f5863df2c2860ce3120c548e915f95bd16d321c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528209Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#827974}
-
Wenyu Fu authored
HomepageSettings is 100% launched in M83. Cleaning: 1. Feature flag; 2. HomepageEditor and related tests Change-Id: I65c99cbf45014805044a01933e2f971d8393a2d3 Bug: 1148104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536084 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#827973}
-
Luciano Pacheco authored
Add the build rules to build the background page as JS module. Bug: 1133186 Change-Id: Ic2759ebd3475ca01f49f153020a16a99673a4fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537448 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#827972}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7a9525a7. With Chromium commits locally applied on WPT: eaff997c "[GridNG] Allow stretching in block-axis." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams guidou@chromium.org, emircan@chromium.org, emircan@chromium.org: external/wpt/screen-capture yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I3aa16341bea4c78b99bd9cb7cce8368bf7e18a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541605Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827971}
-
Darren Shen authored
It is never used. Change-Id: Ida1aab177d931ce174c0278aefc8b5a02a761132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539216Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#827970}
-
Nate Chapin authored
NavigatorBase is a newly-added base class for Navigator and WorkerNavigator. Making MediaCapabilities a Supplement of NavigatorBase allows a single class to handle all of the work of exposing the navigator.mediaCapabilities getter for both windows and workers, and greatly reduces boilerplate. Bug: 1147612 Change-Id: I06f0e138a2be9ce0cd170e43c7997cd69340de24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537780 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#827969}
-
Nnamdi Theodore Johnson-Kanu authored
Fix regression caused by this cl crrev.com/c/2490785. screenshot: https://screenshot.googleplex.com/5nHRPBM6j8Wkn9H.png Bug: 1148721 Change-Id: I6070847c567f0ccee28a574722996445597c3d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541226 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827968}
-
Zhaoyang Li authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/e8573af9803f..891b1b683a7e $ git log e8573af98..891b1b683 --date=short --no-merges --format='%ad %ae %s' 2020-11-12 albertbow Fix xcode complaint of "implicit reference of 'self'". 2020-11-09 chanheepark Move performing action to the main thread to improve stability. 2020-11-09 tirodkar Test rig cleanup 2020-11-09 chanheepark Use common method for snapshotElement: method in GREYScreenshotter. 2020-11-06 chanheepark Add shouldRunOnMainThread method to GREYAction protocol. 2020-11-06 tirodkar Export GREYConstants.h 2020-11-04 mobile-devx-github-bot Use common method for snapshotElement: method in GREYScreenshotter. 2020-11-03 chanheepark Use common method for snapshotElement: method in GREYScreenshotter. 2020-11-03 tirodkar NSTimer Ignoring 2020-11-03 tirodkar FunctionalTest Failure handler cleanup 2020-11-02 mobile-devx-github-bot Fix "variable length array folded to constant array as an extension" 2020-10-29 tirodkar NSRunloop tracking improvements 2020-10-29 tirodkar Multi-window setter API. 2020-10-27 tirodkar Dedupe superview/subview pairs. 2020-10-27 chanheepark Location alert strings cleanup and add iOS 14 string. 2020-10-27 tirodkar Fix type text comment in GREYActions.h 2020-10-23 albertbow Update Demo app's Podfile since EarlGrey now pins to eDO 1.0.1. 2020-10-23 tirodkar Verblose Log docs 2020-10-23 chanheepark Modify system alert text check so it doesn't depend on the iOS version. 2020-10-21 tirodkar Add CLLocationManager to GREYValueType 2020-10-21 tirodkar Successful app launch eDO property. 2020-10-21 chanheepark Internal 2020-10-21 mobile-devx-github-bot Add dismissKeyboard to the Swift EarlGrey wrapper. 2020-10-20 albertbow Update Podspec for 2.2.0 release. 2020-10-19 tirodkar Update GREYLogger docs. 2020-10-16 albertbow Update CHANGELOG.md for 2.2.0 release. 2020-10-09 tirodkar GREYCAAnimationDelegate optimization. 2020-10-09 chanheepark Internal 2020-10-07 tirodkar Internal 2020-10-07 chanheepark Use runloop spinner to wait for the keyboard to appear instead of CFRunLoopRunInMode. 2020-10-06 chanheepark Track completion block for UIView animations for better synchronization. 2020-10-06 tirodkar Device test fix. 2020-10-06 chanheepark Wait for the uppercase keyplane to appear when autocapitalization is on. 2020-10-02 tirodkar Fix runtime-error with functional tests. 2020-09-30 tirodkar Fix Xcode project in OSS 2020-09-29 tirodkar Fix Slide test for Xcode 12. 2020-09-28 chanheepark Minor improvements / cleanups. 2020-09-28 tirodkar Fix nullability in GREYLogger 2020-09-25 tirodkar Verbose Logging Config. 2020-09-24 tirodkar Context Menu support 2020-09-24 albertbow Fix isKindOfClass check in Diagnostics. 2020-09-23 tirodkar Small accessibility refactor 2020-09-18 albertbow Adds C helper functions to transfer array's hosting process in EarlGrey. 2020-09-17 tirodkar Fix iOS 14 selection test. Created with: roll-dep src/ios/third_party/earl_grey2/src Bug: 1146576 Change-Id: Ia6cab97990b3e7ee4edef812cad7a7734cb89186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536814Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#827967}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a73ba689e695..598b98fe2b9b 2020-11-16 chrche@microsoft.com [Loc] Migrate web_audio to localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I996410c33248685d534f0b67778bc01fd8042311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827966}
-
Tanya Gupta authored
Added logic to call FDT in the tab service to capture the bitmap. Change-Id: I9c0e01641b6393ded8227e82fddd0b63c895e45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533327Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#827965}
-