GitLab

https://pdfium.googlesource.com/pdfium.git/+log/6814f49aa839..9468639bc3c4

$ git log 6814f49aa..9468639bc --date=short --no-merges --format='%ad %ae %s'
2016-12-12 dsinclair Update ICU

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2567033002
Cr-Commit-Position: refs/heads/master@{#437908}

ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild was
detected to be flaky by chromium-try-flakes.

TBR=lizeb@chromium.org

BUG=673028

Review-Url: https://codereview.chromium.org/2564213002 .
Cr-Commit-Position: refs/heads/master@{#437907}

ResourceProvider knows if a resource has requested hints about
overlay promotion.  This CL closes the loop, allowing
ResourceProvider to notify a GLStreamTextureImage that's bound to
the resource's texture about the promotion hint.

This is supported only on Android.  The purpose is to let
AndroidVideoDecodeAccelerator figure out if video frames should be
backed by SurfaceTexture or SurfaceView.

BUG=671357
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2559523002
Cr-Commit-Position: refs/heads/master@{#437906}

Fetch a warmup URL if data reduction proxy (DRP) is enabled. The fetching
of the warm up URL is disabled by default, and enabled only via the
field trial.

BUG=672334

Review-Url: https://codereview.chromium.org/2503273002
Cr-Commit-Position: refs/heads/master@{#437905}

The method RenderWidget::GetInputMethodController() can return nullptr in
the following cases:
1- RenderWidget is swapped out.
2- There is no focused frame in the local root which accepts IME.
  2.1 There are no focused local frames.
  2.2 The focused local frame does not belong to the same local root as RenderWidget.
  2.3 The focused local frame cannot accept IME since WebWidget is not focused (e.g., switched tabs).

Therefore, to handle set composition IPC we should not assume controller can
never be nullptr. A valid repro case:
1- Create an OOPIF in a page.
2- Add input in OOPIF.
3- Write javascript code which would randomly take focus away from OOPIF.
4- Activate some IME and start typing.

Eventually, DCHECK fires because the IPC to set composition arrived after
the widget lost the focused frame.

BUG=578168

Review-Url: https://codereview.chromium.org/2558303003
Cr-Commit-Position: refs/heads/master@{#437904}

Mark org.chromium.chrome.browser.payments.PaymentRequestIncompleteContactDetailsTest#testEditIncompleteContactAndCancel as flaky

BUG=673299
TBR=grt@chromium.org

Review-Url: https://codereview.chromium.org/2567023002
Cr-Commit-Position: refs/heads/master@{#437903}

When a user signs out and Sync starts to shut down, we immediately
clear the LocalDeviceInfoProvider. Many methods in DeviceInfoSyncBridge
depend on being able to access information in the provider, and can
crash at this point. The bridge should be disabled momentarily, but
this will require threads hops UI->Sync->UI. Meanwhile, various other
posted tasks can call into the bridge and hit this race condition.

We were previously guarding against this scenario when the pulse timer
would fire, but we were not guarding against processor's Merge/Apply
calls or ModelTypeStore async initialization. I've added nullptr checks
to all async entry points that mostly no-op when they detect this
scenario.

One slight hiccup is that the bridge currently leaves the pulse timer
running even when disabled. My intention is that this change will be
merged back into M56 so I wanted to keep this CL as small as possible.
When crbug.com/672600 is addressed I think it will make the most sense
to disable the pulse timer while disabled, since it should always be
re-enabled with an accurate timer when things are working again.

Additionally, some state tracking such as has_provider_initialized_
should probably just be removed at this point. This should be caught in
crbug.com/659263

BUG=672534

Review-Url: https://codereview.chromium.org/2568543003
Cr-Commit-Position: refs/heads/master@{#437902}

BUG=chromium:663373

Review-Url: https://codereview.chromium.org/2563423003
Cr-Commit-Position: refs/heads/master@{#437901}

It's important for ANGLE to be able to test both NVIDIA and AMD (our
support Windows WebGL 2 conformance targets) standalone with dEQP
for correctness on ANGLE rolls and ANGLE try bots. This change will
add the dEQP-GLES3 tests with ANGLE to the Windows GPU.FYI bots, and
the ANGLE CQ. The Optional tester is not included for now.

Re-land with JSON added.

BUG=641080
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2566643003
Cr-Commit-Position: refs/heads/master@{#437900}

IndexedDBDatabase requires BrowserThread::IO to be alive when it is
destroyed or it leaks some of its DeleteOnIOThread scoped_refptr members.
Not doing so results in LSAN failures in
https://codereview.chromium.org/2464233002 per it tightening
TestBrowserThread's shutdown semantics.

BUG=653916

Review-Url: https://codereview.chromium.org/2566693004
Cr-Commit-Position: refs/heads/master@{#437899}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/35e713ce..7f7160ed

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2573433002
Cr-Commit-Position: refs/heads/master@{#437898}

If an incorrect type is provided to the call, the generated IDL code will
reject with a TypeError. This patch removes code in the service
implementation which was checking whether the type was invalid and returning
a NotSupportedError. The only way this code could be hit would be if there
was a programming error, so it should be a DCHECK.

BUG=672113

Review-Url: https://codereview.chromium.org/2570463003
Cr-Commit-Position: refs/heads/master@{#437897}

BUG=chromium:670284

Review-Url: https://codereview.chromium.org/2556193002
Cr-Commit-Position: refs/heads/master@{#437896}

cancelWithError() should be removed because:
- The code creating a ResourceError when error is null in
  cancelWithError() can be moved to cancel() to simplify the logic.
- Check on m_client and resource() is unnecessary when it's called from
  didTimeout.

As a bonus, factor out the common logic that detaches m_client and
calls didFail()/didFailAccessControlCheck() on the detached client into
methods.

R=yhirano@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2563933003
Cr-Commit-Position: refs/heads/master@{#437895}

PingLoaderImpl just needs a WeakMember<LocalFrame>.
It doesn't need to inherit from DOMWindowProperty.

BUG=610176

Review-Url: https://codereview.chromium.org/2567933003
Cr-Commit-Position: refs/heads/master@{#437894}

Ran `tools/clang/scripts/upload_revision.py 289228`.

BUG=

Review-Url: https://codereview.chromium.org/2564983002
Cr-Commit-Position: refs/heads/master@{#437893}

https://skia.googlesource.com/skia.git/+log/bbab477b49e2..c30833327f0d

$ git log bbab477b4..c30833327 --date=short --no-merges --format='%ad %ae %s'
2016-12-12 mtklein proposed gn_to_bp fixes
2016-12-09 brianosman Make subset param to texture generation API non-optional
2016-12-09 mtklein Convert image width and height (used by tiling) to float once.
2016-12-11 update-skps Update SKP version
2016-12-12 djsollen Add documentation for being a Android RoboCop.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2572463002
Cr-Commit-Position: refs/heads/master@{#437892}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2569713002
Cr-Commit-Position: refs/heads/master@{#437891}

The component build copier can always rely on having runtime deps
available.

BUG=586967

Review-Url: https://codereview.chromium.org/2556253009
Cr-Commit-Position: refs/heads/master@{#437890}

Revert of Eagerly dispose of ScheduledActions. (patchset #2 id:20001 of https://codereview.chromium.org/2552673002/ )

Reason for revert:
Speculative revert for reported perf decrease on system_health.memory_mobile, https://crbug.com/672098

Original issue's description:
> Eagerly dispose of ScheduledActions.
>
> The DOMTimer's ScheduledAction hold on to the script source and
> state needed to execute the timer action. Let go of ShceduledAction's
> resource early.
>
> Apart from reducing the lifetime of script source, this is a speculative
> fix for crashes reported in v8::PersistentValueVector::Clear() during
> lazy sweeping of ScheduledAction objects.
>
> R=
> BUG=
>
> Committed: https://crrev.com/11bd50343795ed1dc1977da91e9a1588687522fd
> Cr-Commit-Position: refs/heads/master@{#436298}

TBR=oilpan-reviews@chromium.org,haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2568103002
Cr-Commit-Position: refs/heads/master@{#437889}

Revert of Delay Input.dispatchKeyEvent response until after key event ack. (patchset #16 id:300001 of https://codereview.chromium.org/2387353004/ )

Reason for revert:
Tentative revert for:

Failed steps failed chrome_public_test_apk on android failed content_browsertests on android

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29?numbuilds=200

as of this CL (and 2 others which are mere renames + don't touch content so suspecting this one from the 3: https://chromium.googlesource.com/chromium/src/+log/b671a5234f41f1784bd261a7c1eb6010434cd2c2..92aad3c0c15d18263af3e5ce0dad525c0b063297?pretty=fuller&n=10000)

No logs from failures on Android bot unfortunately :-(... Don't understand why it would have passed CQ and not waterfall but still can't see what else in range could be at fault, sorry..

Original issue's description:
> Delay Input.dispatchKeyEvent response until after key event ack.
>
> BUG=chromedriver:1506
>
> Review-Url: https://codereview.chromium.org/2387353004

TBR=tdresser@chromium.org,dtapuska@chromium.org,dgozman@chromium.org,pfeldman@chromium.org,samuong@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=673218, chromedriver:1506

Review-Url: https://codereview.chromium.org/2565313002
Cr-Commit-Position: refs/heads/master@{#437888}

Originally, this was a virtual, but it meant that LocalFrame::domWindow
could not return a LocalDOMWindow, due to the circular dependencies
between the LocalFrame and LocalDOMWindow header. As a workaround,
LocalFrame exposed a special localDOMWindow getter. However, this leads
to code that reads very LocalFrame-centric. Since the ultimate goal of
OOPIF integration is to integrate seamlessly, it would be nice to
remove the "local" prefix from the getter.

Since this function doesn't need to be virtual, just de-virtualize it
and have the getters of derived classes return the appropriate type.

BUG=none

Review-Url: https://codereview.chromium.org/2562323002
Cr-Commit-Position: refs/heads/master@{#437887}

BUG=
TEST=

Review-Url: https://codereview.chromium.org/2562363002
Cr-Commit-Position: refs/heads/master@{#437886}

Before OnWebDataServiceRequestDone is called for a request, the request is marked as being complete by being removed from the WebDataRequestManager's pending_requests_ map.

When a query from AutofillCounter fails, it is handled inside OnWebDataServiceRequestDone. By that time, it has been removed from the pending_requests_ map and is no longer allowed to be canceled. Therefore, make sure that AutofillCounter marks it as being complete so that it doesn't try to cancel it.

BUG=672823

Review-Url: https://codereview.chromium.org/2555373007
Cr-Commit-Position: refs/heads/master@{#437885}

Review-Url: https://codereview.chromium.org/2501113002
Cr-Commit-Position: refs/heads/master@{#437884}

Revert of Mark org.chromium.chrome.browser.payments.PaymentRequestIncompleteContactDetailsTest#testEditIncomp… (patchset #1 id:1 of https://codereview.chromium.org/2566173002/ )

Reason for revert:
The tree is closed:
../../chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java:47: error: cannot find symbol
    @FlakyTest
     ^
  symbol:   class FlakyTest
  location: class PaymentRequestIncompleteContactDetailsTest
Note: Some input files additionally use or override a deprecated API.

Original issue's description:
> Mark org.chromium.chrome.browser.payments.PaymentRequestIncompleteContactDetailsTest#testEditIncompleteContactAndCancel as flaky
>
> BUG=673299
> TBR=grt@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/257f431c44c930193c082bf608c18282a063785e

TBR=grt@chromium.org,vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=673299

Review-Url: https://codereview.chromium.org/2574433002
Cr-Commit-Position: refs/heads/master@{#437883}

Recently we discovered, that our dismissed IDs pruning may happen at a
wrong time, when DownloadManager does not have a complete list.
Unfortunately, there is no way to check whether DownloadManager
finished starting up.
Therefore, this CL removes pruning of asset downloads and instead
limits maximal number of stored IDs to 100 (the oldest are removed
once the threshold is reached).

BUG=672758

Review-Url: https://codereview.chromium.org/2562073002
Cr-Commit-Position: refs/heads/master@{#437882}

Mark org.chromium.chrome.browser.payments.PaymentRequestIncompleteContactDetailsTest#testEditIncompleteContactAndCancel as flaky

BUG=673299
TBR=grt@chromium.org

Review-Url: https://codereview.chromium.org/2566173002 .
Cr-Commit-Position: refs/heads/master@{#437881}

The comment specified the purpose and possible values of the --password-store
switch. It was outdated in both respects. Since the proper implementation of
os_crypt on Linux earlier this year, the storage was used not just for
passwords, but also for os_crypt's encryption key.

This is even more problematic because the comment is picked up to generate
http://peter.sh/experiments/chromium-command-line-switches/.

This CL updates the description based on the relevant code in
components/os_crypt/key_storage_util_linux.cc.

The CL does not change the name of the flag on purpose: it is likely contained
in a lot of testing and developers' set-ups, and changing it could have
unwanted side-effects of testing data suddenly piling up in people's
Keyrings/KWallets. Once the alternative backends for Linux will stop being
used for storing passwords (https://crbug.com/571003), and only for the single
encryption key of os_crypt, it will be much safer to rename the switch.

BUG=673121

Review-Url: https://codereview.chromium.org/2563253002
Cr-Commit-Position: refs/heads/master@{#437880}

I marked it as slow in https://codereview.chromium.org/2568793002/ but it didn't help.

BUG=673296
TBR=grt@chromium.org

Review-Url: https://codereview.chromium.org/2565423003 .
Cr-Commit-Position: refs/heads/master@{#437879}

Add a new target for GmsCore integration to let WebView code depend on
GmsCore without depending on //android_webview/android_webview_java.
Note that we don't remove PlatformServiceBridge from the
android_webview_java target yet as that would break downstream.

BUG=657314

Review-Url: https://codereview.chromium.org/2566903003
Cr-Commit-Position: refs/heads/master@{#437878}

```--
Allows for custom comparison of results and exotic navigation setup.

Details
```

--
- New browser tests will be needed to test edge cases. For example verifying behavior during cross tab navigation. Useful for regression with PlzNavigate.
- To be able to add the test cases we need to have some more customization
than what the current test framework provides. Specifically, partial
comparison and new navigation types. Implemented that.

BUG=650253

Review-Url: https://codereview.chromium.org/2561493003
Cr-Commit-Position: refs/heads/master@{#437877}

this adds the user agent to the dump. This allows identifying
the chrome version from the dump.

BUG=

Review-Url: https://codereview.chromium.org/2543493003
Cr-Commit-Position: refs/heads/master@{#437876}

Revert of Disable v8.browsing_desktop & v8.browsing_desktop_ignition on Win Perf bots (patchset #1 id:1 of https://codereview.chromium.org/2401253002/ )

Reason for revert:
Speculatively re-enabling to see if it still fails on the bots.

Original issue's description:
> Disable v8.browsing_desktop & v8.browsing_desktop_ignition on Win Perf bots
>
> TBR=nednguyen@google.com
> BUG=chromium:654209
>
> Committed: https://crrev.com/1a039dd675016be7597d84dcef408e1b786a56d4
> Cr-Commit-Position: refs/heads/master@{#424086}

TBR=zhenw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:654209

Review-Url: https://codereview.chromium.org/2562373002
Cr-Commit-Position: refs/heads/master@{#437875}

Also fixes a typo.

This is a follow-up from https://codereview.chromium.org/2391883006

BUG=612339

Review-Url: https://codereview.chromium.org/2564953003
Cr-Commit-Position: refs/heads/master@{#437874}

Also changed the order of the attributes/methods under Shadow DOM to match the spec.

BUG=662005

Review-Url: https://codereview.chromium.org/2562343002
Cr-Commit-Position: refs/heads/master@{#437873}

Keep retries on 5xx errors only for user-triggered, interactive requests.
Other fetches have no immediate priority and their number will
be determined by a variation parameter.

This CL does not reschedule/retry non-interactive requests,
as we figured that this small change improves the current state on its own and rescheduling requires some more discussion.

BUG=668074

Review-Url: https://codereview.chromium.org/2548343002
Cr-Commit-Position: refs/heads/master@{#437872}

This will fix Windows python license check presubmit errors. It
will ensure the presubmit check always sees "LF" line ending.

BUG=669941

Review-Url: https://codereview.chromium.org/2558413002
Cr-Commit-Position: refs/heads/master@{#437871}

We don't require a write barrier here as TraceWrapperMember is used for the
following scenarios:
- Initial initialization: The write barrier will not fire as the parent is
   initially white.
- Wrapping when inserting into a container: The write barrier will fire upon
  establishing the move into the container.
- Assignment to a field: The regular assignment operator will fire the write
  barrier.

Note that support for black allocation would require a barrier here.

BUG=chromium:468240

Review-Url: https://codereview.chromium.org/2564153002
Cr-Commit-Position: refs/heads/master@{#437870}

Revert of perf: Disable browse:news:reddit on Mac (patchset #1 id:1 of https://codereview.chromium.org/2484783002/ )

Reason for revert:
The failure does not reproduce at TOT locally.
Re-enabling to see if it still fails on bots.

Original issue's description:
> perf: Disable browse:news:reddit on Mac
>
> BUG=662959
> TBR=perezju@chromium.org
>
> Committed: https://crrev.com/31caf2b1bb934e61b2b79fda4ebb8a8791546f54
> Cr-Commit-Position: refs/heads/master@{#430320}

TBR=perezju@chromium.org,skyostil@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=662959

Review-Url: https://codereview.chromium.org/2565393002
Cr-Commit-Position: refs/heads/master@{#437869}