- 19 Aug, 2019 40 commits
-
-
Christopher Grant authored
Prior to enabling native code partitioning, the VR DFM was equipped with a small dummy library to soak the delivery and opening mechanism. Now that the real library is present, we can pull out the dummy version. Bug: None Change-Id: I4b2b4d576e5428c2eedae47159a55ad4dcccb784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751829Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#688080}
-
Thomas Tangl authored
- The logic of the link actions remains in ProfileMenuView. - The link handling is done in ProfileMenuViewBase. Bug: 966388 Change-Id: I54100962956bd6acc873b88d1da1b196f967ffd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757842Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#688079}
-
Yi Gu authored
This reverts commit 97622f89. Reason for revert: Sufficient information has been collected. Original change's description: > [VizHitTesting V2] Add dump without crash to identify sites with mismatch results > > Collect data after fixing the outdated hit test data issue at > crbug.com/992064 for future investigation. > > Bug: 976284 > Change-Id: I2a59f2902908c09162ccbe41ebbd860b0331ac4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756625 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687744} TBR=rjkroege@chromium.org,yigu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 976284, 977092 Change-Id: I3f26396a09bd7b6ab41406c22cd648dab7b85047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760867Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688078}
-
Benoît Lizé authored
The chromium linker doesn't have static initializers, which make assert_static_initializers.py fail. Instead of adding it to the list of libraries that should be skipped, make sure that it has none. Bug: 979638 Change-Id: I5450031a2e49dbfbf21d991ac6b901ddbb5c7008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760215Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#688077}
-
Dominik Röttsches authored
Replace the snowman emoji (U+2603) with the sum sign (U+2211) in order to avoid situations in which a color fallback font is chosen for the emoji, which cannot be colored white and the reftest thus failing, since the test case shows and emoji, while the reference content does not contain any characters. Bug: 976737 Change-Id: I342d81870418e56575700d3c0941a16544121a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760304 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#688076}
-
Sahel Sharify authored
This reverts commit bbe68ab3. Reason for revert: Find it founds this cl with 100% confidence to be the cause of CrostiniInstallerViewBrowserTest.InstallFlow failure on MSAN Original change's description: > Factor non-ui logic out of CrostiniInstallerView > > The current CrostiniInstallerView contains a lot of non-ui logic such as > histogram recording and somewhat complex interaction with CrostiniManager. This > CL factors out the non-ui logic into new class CrostiniInstaller. This not only > makes the code cleaner, but also allows us to port the installer UI to WebUI > much more easily. > > > Bug: 912638 > Change-Id: Ie0195c8580518aa39e59aa539ef2fb614978776b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701024 > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Commit-Queue: Jason Lin <lxj@google.com> > Cr-Commit-Position: refs/heads/master@{#688021} TBR=benwells@chromium.org,timloh@chromium.org,lxj@google.com Change-Id: I751183d3e79e4455535750c0d700a7e35ee407a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759680Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688075}
-
Himanshu Jaju authored
Change-Id: I00276f97946577bbd15c51ceb5eb64df9975daf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760222Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#688074}
-
Tanisha Mandre authored
- Directory will contain generic superclass files required for both QR and credit code scanner. - This refactoring is required to help use common elements of the QR scanner in the credit card scanner from a shared abstract class. Bug: 990744 Change-Id: I830eb4b34cb10fdf940dc28ab1390270d91c12cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760302Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Cr-Commit-Position: refs/heads/master@{#688073}
-
Yi Gu authored
The test may miss a frame occasionally. See bug for details. TBR=flackr@chromium.org NOTRY=true Bug: 986019 Change-Id: I6bb3e35c26b3d2914a135d52b0b0bb758565da38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760888Reviewed-by:
-
Yaron Friedman authored
There's no specialized knowledge for this and it's a single function. Change-Id: I2d994ff6eac6f26482287b200491b813870d6144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758659 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688071}
-
Thiemo Nagel authored
virtual/omt-worker-fetch/external/wpt/xhr/responsexml-document-properties.htm external/wpt/html/dom/documents/resource-metadata-management/document-lastModified-01.html virtual/blink-cors/external/wpt/xhr/responsexml-document-properties.htm virtual/omt-worker-fetch/external/wpt/xhr/responsexml-document-properties.htm https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fomt-worker-fetch%2Fexternal%2Fwpt%2Fxhr%2Fresponsexml-document-properties.htm TBR=robertma@chromium.org Bug: 626703 Change-Id: I718f35346a8d20f5872d9592a44686b35db8dd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757925 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688070}
-
Miyoung Shin authored
This CL converts SharedWorkerPtr and SharedWorkerRequest in content to new Mojo types, and uses pending_remote<SharedWorker> in shared_worker_factory.mojom. Bug: 955171, 978694 Change-Id: I15bb365ec38415c575cfb1accaba4664bb60e3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757259 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#688069}
-
Stephen McGruer authored
Bug: 900581 Change-Id: I610cfe981f2dee98bc22a450a893e452ff9cbe91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760671Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#688068}
-
Javier Ernesto Flores Robles authored
Since the refactor to the form input accessory last year, moving the UI files to ios/c/b/ui/ was due. This CL aims to do that and at the same time organize the form input accessory files in their own folder. Creates a new form_input_accessory folder in ios/chrome/browser/ui/autofill/ to organize the input accessory UI files. Moves the UI files from ios/chrome/browser/ui/autofill and ios/chrome/browser/autofill to this folder. Adds OWNERS file to the new folder. Change-Id: I1b5c4c504a4c9e4ca0d5cfb06f96d4851ce5791c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753008 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#688067}
-
Thiemo Nagel authored
virtual/cross-origin-embedder-policy/external/wpt/html/cross-origin-embedder-policy/require-corp.https.html Sample failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/82496 Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fcross-origin-embedder-policy%2Fexternal%2Fwpt%2Fhtml%2Fcross-origin-embedder-policy%2Frequire-corp.https.html TBR=robertma@chromium.org Bug: 995129, 626703 Change-Id: I2865dbc00a6f3bf3a605372c948ed009af62a16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760787Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688066}
-
Francois Doray authored
The worker is joined to prevent memory leaks. Bug: 846121 Change-Id: I0a89d7a39cc411d098c12be9e60ea000619a2f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757317 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#688065}
-
Javier Ernesto Flores Robles authored
This requires to be compiled with Xcode 11 (iOS SDK 13). Bug 976682 Change-Id: I1b33eded1d0df7bda09cc9abb38e04d4de7ba1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731943 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#688064}
-
Christian Dullweber authored
This is a reland of b21dff94 This CL wasn't the cause of renderer crashes. crbug.com/994537#c21 Original change's description: > Pass top frame origin to cookie settings > > In order to correctly apply content settings with secondary patterns, > CookieSettings needs to know the TopFrameOrigin of a request. > Currently it only has access to SiteForCookies, which can be an empty > url for cross-origin iframes. > This CL passes TopFrameOrigin from UrlRequests to CookieSettings and > uses this value to look up ContentSettings. SiteForOrigin is still > used to determine whether the cookie is used in a third-party context. > > As TopFrameOrigin is not yet always available, this new behavior is > behind the ImprovedCookieControls flag. > > Bug: 988398 > Change-Id: Ibb6180b68ae9f4780046be6fb2a9dcbb39f9ccf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698419 > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686759} TBR=rogerta@chromium.org,engedy@chromium.org,jrummell@chromium.org,sdefresne@chromium.org,ntfschr@chromium.org,dullweber@chromium.org,mkwst@chromium.org,morlovich@chromium.org,arthursonzogni@chromium.org Bug: 988398, 994557 Change-Id: I9adf51d62326e75374bc41145e30f377c540f82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760212Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#688063}
-
Ivana Zuzic authored
Add an icon to PasswordEntryEditor layout so passwords could be unmasked and masked, like in PasswordEntryViewer. The unmasking/masking logic is going to be implemented in a future CL. The positioning of the icon might slightly change in the future, but it's going to stay in this fragment. Bug: 377410 Change-Id: I9fbd6295d23901b1c825d2758c56d990656d2052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748894Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#688062}
-
Stephen McGruer authored
Bug: 900581 Change-Id: I35db0f6dbadea7f490cbf770b1700621bd5a35d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757291Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 42d0334d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ib8a1fef0e4ec310c8b7e9fda5bbd4c9881c552e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760411Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688060}
-
Artem Titarenko authored
This is needed because in [1] Xcode version was updated to 11m382q which requires Mac OS 10.14+. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1724702 TBR: justincohen@chromium.org Bug: 992500, 994319 Change-Id: Ic015a2fcc4e99c96740982110c7031ad3e31b6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760213Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Artem Titarenko <artit@chromium.org> Cr-Commit-Position: refs/heads/master@{#688059}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1a492d68712bfff7b169c76952641078baf00b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760457Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688058}
-
Chih-Yu Huang authored
This CL uses ScopedClosureRunner to signal event when we exit the method, instead of manually signaling the event at every exit point. BUG=none TEST=run video_encode_accelerator_unittests on kevin Change-Id: Ib468cb29c9a2e9e70f86e494464887227777f075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760571 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#688057}
-
Stefano Sanfilippo authored
Remove getExposedPolicy and replace it with a defaultPolicy property, which is needed internally and fixes #992031 in one go. Bug: 992006, 992031 Change-Id: Ic5f1ae6a9001a18cb72828fd8b854453605d3c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751723Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688056}
-
Hans Wennborg authored
TBR=rnk Bug: 994333,992860 Change-Id: I3fbe70c890d02c66422822a0a2d1bcd344e26383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760732Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#688055}
-
Vlad Tsyrklevich authored
As far as I can tell this shim was never in use, there was a never a -Wl,-wrap,malloc_usable_size added to BUILD.gn so this shim has never done anything. Bug: 923493 Change-Id: I67e0f1915816a41016b2328e40aab4cd0b3c6fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726898 Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#688054}
-
Miyoung Shin authored
This CL converts ControllerServiceWorkerConnectorPtr and ControllerServiceWorkerConnectorRequest in content to new Mojo types. Bug: 955171, 978694 Change-Id: I95f3b708a19e3b0abce281a819c18a733bc6a546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757719Reviewed-by:
-
Robbie Gibson authored
With the new +widgetVibrancyEffectForStyle: visual effect views, setting the alpha of the button in HighlightButton doesn't work. (According to the docs, this never should have worked.) Now, HighlightButton takes a list of views to highlight. Bug: 976683 Change-Id: I44e6b10e58fad7acb25bb591f46ae31878ab0fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736673 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#688052}
-
Robbie Gibson authored
Bug: 976665 Change-Id: I482c5fdf140af94b90106273fc875f26192fff7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744407Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Robbie Gibson authored
Bug: 976674 Change-Id: I4a8c084c66cbaa77445124affa35ef879286d2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720710 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#688050}
-
Leon Han authored
crrev.com/c/1755546 has already removed those old nfc impl that uses these UseCounters, this CL is a follow-up for that. BUG=520391 Change-Id: I1a118e0fd728eb367fbc98ae70215ff57ca34d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760668 Commit-Queue: Leon Han <leon.han@intel.com> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#688049}
-
Miyoung Shin authored
This CL converts SharedWorkerHostPt in content to new Mojo types, and uses pending_remote<SharedWorkerHost> in shared_worker_factory.mojom. Bug: 955171, 978694 Change-Id: I8002ae44f231f029942bf79b376b78ca9f42a8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757254Reviewed-by:
-
Chih-Yu Huang authored
Port the V4L2SVDA output queue to V4L2Queue, in order to reduce the amount of code in this messy class and make it overall more secure. BUG=990687,938156 TEST=run video_encode_accelerator_unittests on kevin Change-Id: I1fc8c4dbe68df860b4901d50ac05b6ebb13d8b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741429Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#688047}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7b4e5bd5ec82..bc62722b80a6 git log 7b4e5bd5ec82..bc62722b80a6 --date=short --no-merges --format='%ad %ae %s' 2019-08-18 stevenperron@google.com Handle overflow in wrap-opkill (#2801) 2019-08-16 stevenperron@google.com More handle overflow in sroa (#2800) 2019-08-16 greg@lunarg.com Instrument: Add support for Buffer Device Address extension (#2792) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@bc62722b80a6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: I1a38bf110dd0b719ba90b61e18356de2eb64c269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760687Reviewed-by:
-
Henrik Boström authored
Prior to M77, totalAudioEnergy was always on the track stats, for both the sending and receiving side. As of M77, totalAudioEnergy is still there for receiving track stats, but on the sending side it has been moved to the media-source stats. This CL adds the AudioLevelRmsCalculator() to the media-source such that you can see the same audio level on both sides. // Already reviewed by kron@ TBR=guidou@chromium.org Bug: chromium:994186 Change-Id: I2190eca7e42f0b7159b3d055521bc5d52e6c56e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758067Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688045}
-
Henrik Boström authored
This adds a Calculated Metric that looks up the codecId and constructs an informative string, e.g. "VP8 (payloadType: 96)". These are added to "outbound-rtp" and "inbound-rtp" stats objects. This is especially useful because chrome://webrtc-internals/ filters out RTCCodecStats objects to avoid bloating the page with negotiated-but-unused codecs. // Already reviewed by kron@ TBR=guidou@chromium.org Bug: chromium:994731 Change-Id: Ibef42fc5bb7e8b810f9bb0623c02109306f238c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758078Reviewed-by:
-
Henrik Boström authored
Instead of calculating average target per encoded frame multiplied by average encode frame rate, we simply look at the average encoded bytes target. Side-by-side comparisons suggest we get the same result, but the name is different now. // Already reviewed by kron@ TBR=guidou@chromium.org Bug: chromium:994574 Change-Id: I3851fccc711f728bcbe1d58c07719d3eddfa1600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757827Reviewed-by:
-
Henrik Grunell authored
Bug: 974448 Change-Id: Ia6f609d815821d57540ccf08e9f662fd131dae28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757829Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#688042}
-
Makoto Shimazu authored
ServiceWorkerSingleScriptUpdateChecker used to be confused that the script is identical when the new script is truncated and OnComplete() is received after the end of the body. This fixes it by calling CompareData(nullptr, 0) instead of Succeed(kIdentical), which is the same with a fix in the past (https://crrev.com/c/1714584). Bug: 995146 Change-Id: I06b324ed0b999addb49d232901beeab67c93e2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760629 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688041}
-
