GitLab

The Lenovo Horizon device displays the wrong number of the touch pointers when all fingers released from the screen. Because HWND Message sometimes sends inconsistent number of touch pointers, we keep the IDs of touch pointers we have seen from last time, and release the ones which are not in the current message.

BUG=316085

Review URL: https://codereview.chromium.org/988473002

Cr-Commit-Position: refs/heads/master@{#329770}

This is to remove dependencies from test runner on content

BUG=478250
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1133753003

Cr-Commit-Position: refs/heads/master@{#329769}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b333144..d7eac4f

TBR=alancutter@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/1132413005

Cr-Commit-Position: refs/heads/master@{#329768}

chrome_extensions.js: be4926041286f314d648ab5f3fcce5721693e602 -> ca37fefd29fef41fa481685c4b3398ba6ad10b8d

Also manually added networkingPrivate.onDeviceStateListChanged while it
makes its way to the github externs (to fix compile).

TBR=
BUG=

Review URL: https://codereview.chromium.org/1134693004

Cr-Commit-Position: refs/heads/master@{#329767}

R=vabr@chromium.org
BUG=486739

Review URL: https://codereview.chromium.org/1139913004

Cr-Commit-Position: refs/heads/master@{#329766}

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/1134373002

Cr-Commit-Position: refs/heads/master@{#329765}

Some of ui::WindowShowState were not supported in Linux so this CL implemented
SHOW_STATE_MINIMIZED, SHOW_STATE_MAXIMIZED, and SHOW_STATE_FULLSCREEN state.

BUG=473228

Review URL: https://codereview.chromium.org/1125383008

Cr-Commit-Position: refs/heads/master@{#329764}

When a reload occurs (or other inert commits), we leave the history tree alone. However, if iframes are dynamically created, we end up with both the old iframes and the new iframes in the history tree, and we never prune them. Instead, if a different-document inert commit occurs, remove the committing node's children, since the corresponding frames are no longer in the frame tree.

BUG=485385

Review URL: https://codereview.chromium.org/1139033002

Cr-Commit-Position: refs/heads/master@{#329763}

BUG=485381

Review URL: https://codereview.chromium.org/1132613003

Cr-Commit-Position: refs/heads/master@{#329762}

always recreating was causing extra XRANR event on X11 system.

Delete WindowTreeHost asynchronously when the change can be made via input event.

BUG=484580,486190
TEST=tested manually. no flicker.

Review URL: https://codereview.chromium.org/1133323002

Cr-Commit-Position: refs/heads/master@{#329761}

This adds the tests which are green on chromium.fyi's Chromium Mac 10.10 builder.

BUG=449316

Review URL: https://codereview.chromium.org/1123213005

Cr-Commit-Position: refs/heads/master@{#329760}

Really minor cleanup, remove some unused code from the header.

Review URL: https://codereview.chromium.org/1132103008

Cr-Commit-Position: refs/heads/master@{#329759}

.sh tests don't work on Windows.

BUG=486571
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1135363003

Cr-Commit-Position: refs/heads/master@{#329758}

BUG=487800

Review URL: https://codereview.chromium.org/1137363002

Cr-Commit-Position: refs/heads/master@{#329757}

Mainly to remove dependency from test runner on content

BUG=478250
R=enne@chromium.org

Review URL: https://codereview.chromium.org/1129683003

Cr-Commit-Position: refs/heads/master@{#329756}

BUG=471536

Review URL: https://codereview.chromium.org/1130783004

Cr-Commit-Position: refs/heads/master@{#329755}

MigrationSingleClientTest.AllTypesIndividually
MigrationSingleClientTest.AllTypesIndividuallyTriggerNotification

BUG=403778

Review URL: https://codereview.chromium.org/1127403005

Cr-Commit-Position: refs/heads/master@{#329754}

Fixes the issue where an OnSetDuration call truncates the selected_range_ and resets the
next_buffer_position. kEndOfStream is now returned instead of kNeedBuffer from
GetNextBufferInternal when selected_ranges_ is NULL.

BUG=484992

Review URL: https://codereview.chromium.org/1119163005

Cr-Commit-Position: refs/heads/master@{#329753}

It is now possible to remove extensions from the GL_EXTENSIONS string
by specifying "--disable-gl-extensions=extension1,extension2".

R=sievers@chromium.org
BUG=482067

Review URL: https://codereview.chromium.org/1110923003

Cr-Commit-Position: refs/heads/master@{#329752}

App banners require several engagement, service worker, and manifest
checks to pass before being displayed. This allows developers to see
in the console the reasons why banners are not displayed, given the
switch --bypass-app-banner-engagement-checks on chrome startup

BUG=458866

Review URL: https://codereview.chromium.org/1129103003

Cr-Commit-Position: refs/heads/master@{#329751}

Wires the call to Add/RemoveHeartbeatInterval through:
* GCMDriver/Desktop/Android/Fake
* GCMDriverDesktop::IOWorker
* GCMClient/Impl to MCSClient
* Adding loading of persisted interval in MCSClient

BUG=481174

Review URL: https://codereview.chromium.org/1124783002

Cr-Commit-Position: refs/heads/master@{#329750}

Enable the BLUETOOTH, BLUETOOTH_ADMIN
permissions for use with Web Bluetooth.

BUG=471536

Review URL: https://codereview.chromium.org/1125143003

Cr-Commit-Position: refs/heads/master@{#329749}

BUG=485435

Review URL: https://codereview.chromium.org/1123283009

Cr-Commit-Position: refs/heads/master@{#329748}

1. Recently close tabs
2. Download cancel dialog
3. Cloud Printer discovery
4. extension: usb device selection

For #2, some strings are revised per the string review with ainslie@.
For both browser shutdown and incognito exit, the title is simply
'Download in progress' and the 'go-ahead' button is simply 'Cancel download'
(or their plural forms).

Besides, recently_closed.js is also removed because it's not used any more and removing it let us drop two strings (about closed_tabs) that has become unnecessary with this CL.

BUG=21407,455005,482092
TEST=Open a new window, open multiple tabs and close the windows. In another window, go to 'Recent tabs' menu. '# tabs' for the closed window is shown as expected
TEST=1. Go to http://www.thinkbroadband.com/download.html 2. Start downloading a single file 3. Try to quit chrome before the download is completed 4. Check the dialog popping up.
TEST=Do the above with multiple file downloads
TEST=Do the above two in the only open incognito window (close the only open incognito window)

Review URL: https://codereview.chromium.org/1103293004

Cr-Commit-Position: refs/heads/master@{#329747}

The method can be called from Files app, and crashes if there are no
browser windows open.

BUG=None

Review URL: https://codereview.chromium.org/1139603003

Cr-Commit-Position: refs/heads/master@{#329746}

When building a debug version of Chromium in Linux with
component=shared_library build flag, there are link errors as follows:

error: undefined reference to 'SkDebugf_FileLine'
error: undefined reference to 'SkToS32'

BUG=None

Review URL: https://codereview.chromium.org/1128203009

Cr-Commit-Position: refs/heads/master@{#329745}

BUG=487674

Review URL: https://codereview.chromium.org/1138513003

Cr-Commit-Position: refs/heads/master@{#329744}

This fixes the component=shared_library build on Chrome OS. Previously,
the TPM token initialization would crash the browser because libchaps.so
loads a 2nd, incompatible copy of the protobuf-lite library into the
browser.

The crash happens because by default the global scope takes precedence,
so symbols in the bundled copy shadow symbols in the system copy. This
can lead to accessing the wrong object or calling the wrong function.
The usual symptom is a crash during static initialization of libchaps.so.

RTL_DEEPBIND rearranges the scope for libchaps.so so that the system
library takes precedence instead. The scope for chrome is unaffected.

Some other possibilities were considered:

  - Unbundling the library. This would cause us to lose our local
    modifications to libprotobuf on Chrome OS.

  - Fixing the soname so that the bundled copy is used by chaps. This
    doesn't even link because the bundled code is not ABI compatible
    with upstream.

  - Statically linking libchaps.so. This is tricky because we need
    position-independent static libs for its deps, and we don't support
    building those currently. It will also cause bloat.

This hack is minimally invasive and allows use of shared library builds
on Chrome OS devices.

BUG=175508
TEST=cros chrome-sdk --board=link
  GYP_DEFINES="$GYP_DEFINES component=shared_library" gclient runhooks
  ninja -C out_link/Release chrome chrome-sandbox
  deploy_chrome --board link --build-dir out_link/Release --to $IP
  Log into the system. No crash.
  TPM-backed user certs show up in chrome://certificate-manager.

Review URL: https://codereview.chromium.org/1111373003

Cr-Commit-Position: refs/heads/master@{#329743}

Whitespace in the form of tabs and line feeds and the like can screw
things up.

This fixes the fresh.amazon.com bug.  (I tested it interatively.)

By the way, there is no need to do a migration pass.
The data will be correctly loaded when read from the
database.  (I checked.)  While it's true the database
will be out of date until written again, given that
the actual data used is correct, I don't think that's
an issue.

TBR=rdevlin.cronin,isherman,lazyboy,pvalenzuela,kmadhusu,avi
rdevlin.cronin - this trivial template URL data API change required some changes in chrome/browser/extensions
isherman - this trivial template URL data API change required some changes in chrome/browser/importer
lazyboy - this trivial template URL data API change required some changes in chrome/browser/renderer_context_menu
pvalenzuela - this trivial template URL data API change required some changes in chrome/browser/sync/test/integration
kmadhusu - this trivial template URL data API change required some changes in chrome/browser/ui/search/
avi - this trivial template URL data API change required some changes in chrome/browser/ui/cocoa/browser/

BUG=485357

Review URL: https://codereview.chromium.org/1135163002

Cr-Commit-Position: refs/heads/master@{#329742}

Reason for revert:
broke linux gn build

../../third_party/angle/src/libANGLE/Display.cpp:113:24:error: no type named 'DisplayGLX' in namespace 'rx'
        impl = new rx::DisplayGLX();
                   ~~~~^
1 error generated.
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/190/steps/compile/logs/stdio

Original issue's description:
> Roll ANGLE.
>
> https://chromium.googlesource.com/angle/angle/+log/b11e24..71632d
>
> BUG=484963
> BUG=483252
>
> Committed: https://crrev.com/6e8e29564f8590bff2215668d959b17075b96240
> Cr-Commit-Position: refs/heads/master@{#329727}

TBR=jmadill@chromium.org,geofflang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=484963

Review URL: https://codereview.chromium.org/1128913010

Cr-Commit-Position: refs/heads/master@{#329741}

Four new tests for SyncCustomizationFragment:

- SCF state is correct starting from sync on and transitioning to off.
- SCF state is correct starting from sync off and transitioning to on.
- SCF's data type controls respond correctly to the sync everything switch.
- SCF opening and closing does not start sync.

In order to prevent flakiness, this CL makes some additional changes.

- Remove MockAccountManager.postAsyncAccountChangedEvent().
  Justification: we have no control about when Android performs
  the callback from it. The callback coming in at weird points
  during other test cases was making tests flaky. Testing mechanisms
  should be predictable.
- SCF now caches the backend initialized state in order to filter
  syncStateChanged() calls down to only changes to that state.

BUG=480604

Review URL: https://codereview.chromium.org/1118833002

Cr-Commit-Position: refs/heads/master@{#329740}

This is necessary because we want to remove the 'blink_tests' target
from Blink (third_party/WebKit).

BUG=483171
TEST=build/gyp_chromium
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1129653004

Cr-Commit-Position: refs/heads/master@{#329739}

BUG=484541
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/1144463002

Cr-Commit-Position: refs/heads/master@{#329738}

[Smart Lock] Brading string (Google Smart Lock) in save password infobar should be link to help center article.

Google Smart Lock in save password infobar should be a link to help
center article. Link is open in new tab, infobar is not dismissed when
link is clicked.

BUG=454815,486739

Review URL: https://codereview.chromium.org/1128073003

Cr-Commit-Position: refs/heads/master@{#329737}

Revert of Pass Surface ID namespace to renderer compositors. (patchset #4 id:60001 of https://codereview.chromium.org/1129883003/)

Reason for revert:
Speculative revert to address widespread blink layout test failures on mac following a chromium revision in range 329707-329709.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9%20%28retina%29/builds/655

No stacks but sample output:

STDERR: Assertion failed: (impl_.get() != nullptr), function operator->, file ../../base/memory/scoped_ptr.h, line 386.

We'll try reproducing locally and watch the bots. We can reland if this does not green up the webkit waterfall.

Original issue's description:
> Pass Surface ID namespace to renderer compositors.
>
> In order to enable renderer processes to create SurfaceSequences, they
> have to receive Surface ID namespaces from the browser process so that
> they can avoid collisions.
>
> BUG=478802
>
> Committed: https://crrev.com/c7a5afd66499fc8442e1b3146f55b227638934d8
> Cr-Commit-Position: refs/heads/master@{#329708}

TBR=jbauman@chromium.org,nasko@chromium.org,kenrb@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478802

Review URL: https://codereview.chromium.org/1131673009

Cr-Commit-Position: refs/heads/master@{#329736}

Also exit early in the function when possible.

Review URL: https://codereview.chromium.org/1130153005

Cr-Commit-Position: refs/heads/master@{#329735}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7a62fa1..b333144

TBR=alancutter@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/1135423003

Cr-Commit-Position: refs/heads/master@{#329734}

BUG=485381

Review URL: https://codereview.chromium.org/1138013005

Cr-Commit-Position: refs/heads/master@{#329733}

This is a no-op change. BoringSSL deprecated EVP_PKEY_dup in favor of a new
EVP_PKEY_up_ref. This makes it more obvious there isn't actually a copy and is
more consistent with other ref-counted types.

See https://boringssl.googlesource.com/boringssl/+/517da2f1efc91b179dfb1898f826b18a6a38f547%5E%21/#F3

BUG=none

Review URL: https://codereview.chromium.org/1129083007

Cr-Commit-Position: refs/heads/master@{#329732}

The header include guards should match the file path from root.

These entries were found using a modified version of Eric's
fix-include-guards.py script found attached in
https://code.google.com/p/chromium/issues/detail?id=435361#c7.

BUG=435361
TEST=base_unittests
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/1137323003

Cr-Commit-Position: refs/heads/master@{#329731}