- 12 Nov, 2020 40 commits
-
-
Daniel Cheng authored
This converts PaintTiming and ScriptLoader metrics to use the macro helper, and WorkerThread termination metrics to use the function helper. The distinction between function vs macro was made based on a guess on how performance sensitive the code recording the metric appears to be. In addition, the recorded enumerations have been updated to use the kMaxValue convention, allowing: - clang to enforce kMaxValue correctness - autodeduction of the max value by the enum histogram macro/function helpers. Bug: 742517, 1047547 Change-Id: I24f51cde75880c6ac42675724bc0fad321bcaf33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524933Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826737}
-
Henrik Boström authored
This CL makes "InCaptureConvertToNv12" enabled-by-default. Because this path is only used by the "AVFoundationCaptureV2" path, the result of this is that our "AVFoundationCaptureV2" experiment will transform all frames to NV12 in M88. Performance impact indicated below when running: https://webrtc.github.io/samples/src/content/getusermedia/resolution/ This is comparing AVFoundationCaptureV2 with or without InCaptureConvertToNv12. Logitech C920 Full HD (MJPEG): Old path MJPEG -> I420 SW buffer: 8.71 W New path MJPEG -> NV12 IOSurface: 7.88 W (-0.83 W) Logitech C920 VGA (YUVS): Old path YUVS -> I420 SW buffer: 6.62 W New path YUVS -> NV12 IOSurface: 6.49 W (-0.13 W) Facetime HD (NV12): Triggers pass-through path, same as before. Bug: chromium:1132299 Change-Id: Iede80be8407373a39c87a9b042168fbb43a15809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532558 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Evan Shrubsole <eshr@google.com> Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#826736}
-
Amr Aboelkher authored
This CL add unit tests that tests all different scenarios for PSM + Hash dance. See go/cros-psm-client-unittests-coverage for an overview of the test cases for the different cases. BUG=chromium:1136866 Change-Id: Ia6a90617d33fdbc50cc8c1a9c06d214cb89f37e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529155Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#826735}
-
Viktor Semeniuk authored
This change adds a new feature kUseOfHashAffiliationFetcher. This feature will allow using Affiliation service for all users. Bug: 1108279 Change-Id: Id8331eaa2d4d5128d2ef270a8a07802653e60149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527140Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#826734}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2b1513dc094d..5dec87fb9844 2020-11-12 jec@google.com Update What's New UI for Chrome 88 2020-11-12 changhaohan@chromium.org Fix <angle> keydown issue 2020-11-12 alexrudenko@chromium.org Clear label container in reset() 2020-11-12 szuend@chromium.org [issues] Introduce substitutions in markdown issue descriptions 2020-11-12 tonykostowny@gmail.com Support expanding uppercased shorthand CSS properties If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1125465,chromium:1148183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I91d175d0f98df227ce56db8680a89b883370d2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826733}
-
Bettina authored
The Chrome Cleanup Tool may start to clean up shortcuts, and the prompt that is opened from the profile resetter should also update to reflect this change. http://screen/5TAo37jMzqSMPHu.png Bug: 1116017 Change-Id: I8269b7ce8da123587734a3cd7fa8f9810bbace12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531656 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#826732}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b638dfe160a1..4804ac8724ff 2020-11-12 capn@google.com Implement MemorySanitizer instrumentation of Reactor routines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I93486a692873ac764c586b5b992ebce5404bdbf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533584Reviewed-by:
-
Lutz Vahl authored
This is a roll-back to 8.8.278. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. R=machenbach@chromium.org,vahl@chromium.org,hablich@chromium.org Change-Id: Id46522e00600559681ed4740c61c7edd9be62f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532583 Auto-Submit: Lutz Vahl <vahl@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#826730}
-
Illia Klimov authored
As part of the Flash/Plugins deprecation, the resource identifier becomes obsolete. This CL removes resource_identifier from the content_settings::ProviderInterface Bug: 1134547 Change-Id: Id17a43b9896c48a500995d7854b92ffa3f169640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529889Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#826729}
-
Henrik Boström authored
As detailed in https://crbug.com/1147867, after rebooting Logitech C920 produces a single invalid MJPEG sample buffer frame that we are unable to transform into I420 or NV12. Subsequent frames are valid, and this issue cannot be reproduced again until the computor is rebooted. Prior to this CL the invalid MJPEG frame causes a DCHECK crash inside SampleBufferTransformer. This CL makes it fail gracefully instead by returning null if this happens. There is no known way to cause non-MJPEG transformations to fail, so all other code paths still DCHECK. This fix is verified in both unit tests that use a clearly invalid MJPEG frame, and manually using the Logitech C920 camera. This CL unblocks making InCaptureConvertToNv12 enabled-by-default. Bug: chromium:1147867 Change-Id: Iefb6f5407918b4a8ea81f9ce41acc211ef80bdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532556 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Nazerke authored
This CL moves TabGrid and TabStrip to the common folder in order to share the reusable code. Bug: 1128249 Change-Id: Ibac6573dfa1828882828ff2c699985c6c5af2fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521531Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#826727}
-
Mihai Sardarescu authored
Before using the cookie jar APIs to add and remove CHROME_CONNECTED cookie, |IOSChromeSigninClient| used to call the AccountConsistencyService::RemoveAllChromeConnectedCookies to delete these cookies. This was removed as part of CL https://chromium-review.googlesource.com/c/chromium/src/+/2421669. This CL fixes the AccountConsistencyService service to actually remove the CHROME_CONNECTED cookie when the user signs out of Chrome as this is no longer called by IOSChromeSigninClient. Bug: 1148200 Change-Id: I336a420d42f9cb2e653441be61c3adc14e5be095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532001 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#826726}
-
Tanmoy Mollik authored
This cl adds a test for checking SyncPromo in NewTabPageTest when MOBILE_IDENTITY_CONSISTENCY flag is on. Signin promo was not being updated when signed in state had changed. This cl also fixes that issue. Bug: 1100895 Change-Id: I760f563d4ae54813e3cf06d7cf88d4c601be91fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513218 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#826725}
-
Thomas Tellier authored
Bug: 1104336 Change-Id: Ia528cbd3595da7f7b2459e0f0ea475235b491f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533773 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#826724}
-
Guido Urdaneta authored
Prior to this CL, if a mic was opened, it could not be opened again with different settings, except for echoCancellation when already opened using a ProcessedLocalAudioSource. After this CL, some of the restrictions are removed for getUserMedia: 1. If the mic is opened using a ProcessedLocalAudioSource, it can be opened again with a different ProcessedLocalAudioSource with a different echoCancellation setting (same as before), but now it can also be opened with a non-processed source. 2. If the mic is opened with a non-processed source, it can be opened again with any type of source and settings. As before, if, after constraints processing, a new track requests the same settings as an existing source, the existing source is reused. Note that these changes apply only to getUserMedia. applyConstraints stays unmodified and still cannot change source properties. Bug: 1082049 Change-Id: I18f124eca40a9461691a67ac7b2c2d0cde6fb494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532078Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#826723}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/06bbeb3398af..3ab1aba2f4d5 2020-11-12 mbonadei@webrtc.org Trigger bots on CI. 2020-11-11 ssilkin@webrtc.org Make SEA to be codec agnostic. 2020-11-11 landrey@webrtc.org Add possibility of upload check for pc perf tests 2020-11-11 jakobi@webrtc.org Add delay manager config options. 2020-11-11 alessiob@webrtc.org RNN VAD: pitch search optimizations (part 4) 2020-11-11 sprang@webrtc.org Avoids potential rounding of -inf time delta in TaskQueuePacedSender. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5d3c149baae82da6c0c7e9f7db383905ddd5ff59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533543Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a61d07a72763..1cda495274bb 2020-11-11 dneto@google.com Use less stack space when validating Vulkan builtins (#4019) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC timvp@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: timvp@google.com,radial-bots+chrome-roll@google.com Change-Id: Ie426b6a2aff145650ee26c12ee446802921a491a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533425Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53d3c085a784..4fb2d48fe563 2020-11-12 eseckler@google.com Merge "docs: Add docs about branching Perfetto for a Chrome milestone" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3a8ee24ab1a69abb8103a3402ee1dd7c637195e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533427Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ifc027928982c4e6e9272e0d149fd19410c5c61de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494603 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#826719}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6067e9ce8bb3..62c10c170bb3 2020-11-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ca966cfb to a927c079 (518 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ibedbee6a56e2fc08287d042e855ea0ae34606af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533542Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I3b6f490991001a9d8e5caafd5cb04d5f68651891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533967Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=tschumann@chromium.org Bug: 1145565 Change-Id: Iecd38a26630d7a6565455c42942b4b61144f1d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532719 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#826716}
-
Takashi Sakamoto authored
Bug: 1086388 Change-Id: Iadcb930d49e905dcf94511f3fb213e06f0cce547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505704Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#826715}
-
Vincent Boisselle authored
... card in Feed V2" This is a reland of 6fe88955 after fixing the issue of uninitialized notice_card_acknowledged Original change's description: > Feature to locally auto-dismiss the notice card in Feed V2 > > Bug: 1146458 > Change-Id: Ibca4559552d991667ea5043687845e845b251db1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527719 > Commit-Queue: Vincent Boisselle <vincb@google.com> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826640} TBR=harringtond@chromium.org,vincb@google.com Bug: 1146458,1148208 Change-Id: Id35d072feee01609c21c82fcb46f698132df7ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532223Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#826714}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e48f06fb0cca..2b1513dc094d 2020-11-12 szuend@chromium.org TypeScript-ify profiler/ProfileView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I260b3ec17ec89eb2106278fe4cb75f5314edebd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533541Reviewed-by:
-
Jérôme Lebel authored
The SettingsImageDetailTextItem needs to set the detail text color each time the cell is configured. Fixed: 1145527 Change-Id: I1607709f02ce6703b9b74c93854f0f267db78871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527044 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74f0f62cef42..479bba705e88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mamir@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mamir@google.com Change-Id: I5bef210508fea08d308b929e0eb585d2d0e4f426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534003Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826711}
-
Ioana Pandele authored
Bug: 1141082 Change-Id: I95a97c34668f2e7eda78aa6a52f844dc6c73e590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529549Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#826710}
-
Bartek Nowierski authored
Direct map didn't have trailing guard page, yet it was subtracted when calculating |map_extent->map_size|, as if it was there. Clarify relationship between slot_size, map_size and reserved_size, while at it. Change-Id: I7845c63771014ad319ee41e7d523bbb145177e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532479 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#826709}
-
dpapad authored
Instead, the "async" keyword is directly used on the functions that are passed to the testing framework. Bug: None Change-Id: Ife6c66a85cf60cf2bc3d9ec47a33d088c44b38ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531861 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#826708}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605041937-c87b025ab4b9cd2fe14d3e7cb6f1c951afd90e7c.profdata to chrome-win32-master-1605139151-5e724661a0d96b85fc6a4800d483b70ce425d91c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I96f53517194b32ae3d128657f0e0e3dcc5ec04df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533963Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 1145565 Change-Id: I2cf67c8a4ba3ed66ff67b0e0809116e972a34269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532656 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#826706}
-
Hiroki Nakagawa authored
This CL integrates multiple WebContents based (non-MPArch based) Prerender2 into navigation. The feature is used only when the runtime flag is enabled. Design Doc: https://docs.google.com/document/d/15N-HYdSnItZyDIqRFui5OVzYFcNwxtq7kYkKBx3J3xQ/edit#heading=h.88qfv92t9hg9 <Overview> The Prerender2 runs navigation code twice: navigation for prerendering a page and navigation for displaying the prerendered page. The first navigation is basically the same as the normal navigation: running regular navigation code and notifying PrerenderHost of navigation completion via WebContentsObserver. This part was already implemented by the previous CLs (see https://crbug.com/1132746). The second navigation known as "activation" is special. That needs to look up a prerendered page and activate it instead of fetching a page from network. Also, activation should run throttling as well as the normal navigation. This CL implements this part. <Implementation Details> This CL works as follows: - On navigation start, a navigation request finds an available prerendered page for a request URL. When it's found, the request creates a noop CachedNavigationURLLoader like the BFCache not to issue a network request. - On navigation commit, the navigation request activates the prerendered page and aborts remaining steps for navigation. This is a minimum change for running end-to-end prerendering tests. This doesn't implement some essential functionalities, for example, session history integration yet. Bug: 1132746, 1138711, 1138723 Change-Id: I0371de7ed01ede50a2c1887d8d558c3debdcd2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494291 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#826705}
-
Roman Sorokin authored
Bug: 1115203 Change-Id: Id4671eb42ae66ab62d779d404b7a59ace583f8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526322 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#826704}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ie1e86a9e513a14f15414ffeaf95d8b30b49e175a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490915 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826703}
-
Clemens Arbesser authored
This CL also allows the onboarding to reuse the previous bottom sheet content to allow for a smooth transition. Finally, this CL fixes a potential issue where the bottom bar delegate was not always correctly set for users who saw the onboarding. Bug: b/171776026 Change-Id: I747333d80c08860192eae7b8414b5c731bc792ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526068 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#826702}
-
Ella Ge authored
This CL adds a jni method to let QualityEnforcer notify native and send a console message for violations. We will move to use devtools issue tab instead in the near future. (TODO in quality_enforcer.cc) The warning together with the toast warning are behind a flag TRUSTED_WEB_ACTIVITY_QUALITY_ENFORCEMENT_WARNING, just in case we need to disabled them for any reason. The flag is *Enabled* for now since we have all approval on launch bug: crbug/1127892 To have a valid tab and WebContent to send the message to, moves the check of digital asset link violation to onDidFinishNavigation from onFinishNativeInitialization. This also moves the ViolationType enum to c++ part to be able to share between c++ and java. Bug: 1147479 Change-Id: If0f80fee412ea522a7202226a72b169092525cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530800 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Yuki Shiino authored
This reverts commit 6fe88955. Reason for revert: Suspicious about causing test failures: ProtoUtilTest.* https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/26187 Original change's description: > Feature to locally auto-dismiss the notice card in Feed V2 > > Bug: 1146458 > Change-Id: Ibca4559552d991667ea5043687845e845b251db1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527719 > Commit-Queue: Vincent Boisselle <vincb@google.com> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826640} TBR=vincb@google.com,harringtond@chromium.org Change-Id: Ia0515d8e3d2c1af678cbf5533c4e28ac5f46ed77 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531812Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#826700}
-
Clemens Arbesser authored
This adds handling for when the user taps the back button or the feedback button. This CL also makes swipe-to-dismiss a configurable trigger script action. The corresponding metric enum was moved from |Finished| to |Shown|, since this may now happen more than once per run. Bug: b/171776026 Change-Id: I6d78c15ab1378c533eeafb41b59117ba241f17ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530329Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#826699}
-
Yuki Shiino authored
This reverts commit 23c810e8. Reason for revert: Suspicious about causing test failures. https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 Original change's description: > removed unnecessary defderred PrepareTpmDeviceAndFinalizeProfile > > According to the current program flow, this to-be-removed branch seems a > useless special handling. > > This CL might affect how UserSessionManager utilitzes tpm manager client > in the near future. > > BUG=b:172748724 > TEST=unittests. > > Change-Id: I93f05a45409878db1138c8d49d835f1d7f0c427e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525471 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Leo Lai <cylai@google.com> > Cr-Commit-Position: refs/heads/master@{#826319} TBR=alemate@chromium.org,rsorokin@chromium.org,khmel@chromium.org,cylai@google.com Change-Id: If82cbaa7a634a6a33667ea139f0ec8e6f5055716 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:172748724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534273Reviewed-by:
-
