- 06 Nov, 2019 40 commits
-
-
Chase Phillips authored
Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/FvM-qo7BfkI/AvxoE6JpBgAJ This change marks AppCache API use and manifest selection on a secure origin as deprecated. All AppCache tests that used a secure origin have been updated with new expectations showing the console message. Three of the tests became flaky after the change since they wouldn't always run the exact same code paths, which would cause the output to differ and expectations to fail. This CL migrates those tests from testRunner to testharness.js. Bug: 1019951 Change-Id: I4c58206c094ababc92975cc61625139644607504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891461Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#713198}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/41be80f6159c..23247b993215 git log 41be80f6159c..23247b993215 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 danakj@chromium.org Don't fetch tags when fetching to deapply a patch. 2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@23247b993215 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1019824 Change-Id: Ia7e8137b1f186174ff3d5ffda638936fc60954ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713197}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/2dfba53b8214..13adddb32ef0 git log 2dfba53b8214..13adddb32ef0 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 rharrison@google.com Move spirv_cross state out of result and rename opaque state handle (#865) Created with: gclient setdep -r src/third_party/shaderc/src@13adddb32ef0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I5f287e063416f62b70328a9e2c8bd90e706d9fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901535Reviewed-by:
-
Albert Chaulk authored
Changing RFH can change the surface the WebContents draws into, so we need to update the current draw quad being used. Since we can't guarantee that we will get a timely wayland commit, force one immediately Bug: 143651420 Test: browsing webpages Change-Id: I70ebe9b09551c0adbede1eebe245c899572a0984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899751Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#713195}
-
Daniel Rubery authored
This file is opened by Microsoft Access by default, and should be treated as equivalent to MDB. Bug: 1021855 Change-Id: I3398e48b57407a8730100061a57d9de13ecf2191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901638 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#713194}
-
Junbo Ke authored
chromium/1870492 sets |trusted_params| of a ResourceRequest, which can only be used by a trusted URLLoaderFactory. Bug: None Test: Manual Change-Id: I9f589ce4161b87c4e1387c8adbfc37bc68b96cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900552Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#713193}
-
Francois Doray authored
Prior to this CL, Startup.FirstWebContents.NonEmptyPaint2 was recorded for the active WebContents in the first browser of the BrowserList. However, tests highlighted that the first browser is not necessarily visible in session restore. This CL changes the behavior to instead record Startup.FirstWebContents.NonEmptyPaint2 for the active WebContents in the first *visible* browser. It also adds a FinishReason for when no browser is initially visible. This would allow us to track if there is a change in how often Chrome starts with no initially visible browser (e.g. if this CL lands https://chromium-review.googlesource.com/c/chromium/src/+/1888405/3/chrome/browser/sessions/session_restore.cc#477 we would start more often with no initially visible browser). This CL also adds some DCHECKs to make sure that navigation events occur in the order expected by FirstWebContentsProfiler. Bug: 1020549 Change-Id: I0733a2b5af2f3617102232e9996459ad3b1c4c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894417Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#713192}
-
Patrick Monette authored
This CL ensures that the ModuleDatabase task runner, the inspection results cache task runner and the module blacklist cache task runner don't block shutdown. Also, this CL changes the inspection results cache so that it is updated atomically. Bug: 1021904, 1022041 Change-Id: Ia87e13f60e00725583f95c55e231edfd4d7648b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899750Reviewed-by:
-
Jose Dapena Paz authored
GCC build of blink_heap_unittests is broken as it requires the fuzzed data provider. But libfuzzer is not available without clang. Bug: 819294 Change-Id: I377ed09d03fd8bdc2561d766a1964d4ab61943dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901038Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#713190}
-
Dana Fried authored
This CL separates a request for capture from actual video capture (since there may be a delay), and captures thumbnails from pages opportunistically as they are loading. This does not solve the attached bug but will allow us to do the following in subsequent CLs: - isolate the issue of capture not triggering render view creation - rate-limit actual video capture across tabs if necessary, by putting candidates for capture in a queue the prioritizes (but is not exclusive to) those we are currently requesting Bug: 1020782 Change-Id: Ib00747d5c839cd8fe8ca9564ee84dfa6c19262d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897485Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#713189}
-
Natalie Chouinard authored
Move Safe Browsing feature-specific methods from PrefServiceBridge to the dedicated (and renamed) SafeBrowsingBridge. Bug: 1016957 Change-Id: Ia3acb1f505e152369268b20c5fbf24f6449da55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896041 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#713188}
-
Xiaocheng Hu authored
generic_trace.py currently makes multiple calls to AddMeasurement() with the same name if it encounters multiple trace items of the same name. This is now broken, as patch [*] has forbidden that, and requires caller to consolidate measurements of the same name into a list. This patch fixes generic_trace.py to follow the new requirements. Change-Id: I44a0fbc1e4260bfbcbfc2558defd25a3f8cc3fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899903 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#713187}
-
James Cook authored
As part of the Split Settings Sync project Chrome OS settings have a new sync controls UI. This requires that new prefs be registered with the type SYNCABLE_OS_PREF instead of SYNCABLE_PREF. Add a presubmit warning if new code in directories known to be Chrome OS specific register a pref with the browser registration type. This is a warning and not an error because it's theoretically possible to add a browser setting that only affects Chrome OS and hence appears in a Chrome OS-only directory. There are no such prefs today. Bug: 1019988 Test: added to PRESUBMIT_test.py Change-Id: I59b46ac831855ae71d3eb5811b54cabf5ec35995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901646Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#713186}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f7b3a2ac7768..6072d056a7cb git log f7b3a2ac7768..6072d056a7cb --date=short --no-merges --format='%ad %ae %s' 2019-11-06 tobine@google.com Vulkan:Ignore layer warnings about provoking vtx ext Created with: gclient setdep -r src/third_party/angle@6072d056a7cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ieb95991a559104ed0780c3bd1bdc8ec1bb8f717e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901796Reviewed-by:
-
Toni Barzic authored
AppListView uses AppListViewDelegate::GetShelfSize() to get the shelf size for calculating: * background shield rounded corners. * the app list layout. For both purposes, app list can assume that the shelf height equals non-in-app height (i.e. assume that in-app shelf is not used). The former is only used in clamshell mode. For the later, app list will not be shown with the in-app shelf (at least in static state). Though, while transitioning from app window to app list (e.g. while dragging the app window), app list view will be laid out while in-app shelf shown - if the actual current shelf height is used to calculate the layout, the app list grid items might jump up once the transition completes (as the shelf height changes and the app list gets laid out again with less vertical space available). This can be avoided if app list view always assumed that the shelf size equals the non-in-app size, as done in this cl. BUG=1013706 Change-Id: I5175781baefe1e92cf8abcd92185b1b3fdf8dc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857200Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713184}
-
Raymond Toy authored
Change base::Bind to base::BindOnce. Bug: 1007838 Change-Id: I43034aa8bcac8bb26c7108ca4c98d0819a00aaad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901634Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#713183}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0f5f46f39281..61ec88a68d6d git log 0f5f46f39281..61ec88a68d6d --date=short --no-merges --format='%ad %ae %s' 2019-11-06 dhanyaganesh@chromium.org chromite: remove binhost-pre-cq Created with: gclient setdep -r src/third_party/chromite@61ec88a68d6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ica48588c917d423df1ff043e37bb109571547b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901792Reviewed-by:
-
Matt Falkenhagen authored
1) Properly toggle Site Isolation off, when trying to test that config. 2) Add unnamed namespaces to use the DontAssignSiteContentBrowserClient class defined in this file rather than the class of the same name in another file. 3) Fix the class to actually skip |url_to_skip_|. 4) Test that a new process is not created. Bug: 1012143 Change-Id: I383d3740a42b1ef5ae8126f733c82b927c4ee878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900794Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#713181}
-
wutao authored
Currently UiElementContainerView does not auto scroll when the focus in the AssistantCardElementView changes, e.g. during Tab traversing. This patch surfaces the OnFocusChangedInPage event from WebContentsImpl to NavigableContentsObserver, so that the UiElementContainerView can do scroll accordinglly. In this patch, if the bounds of the focused node is clipped by the container, it will scroll the node to the center of the container. Bug: 966806 Test: manual Change-Id: I974db35731b85fdcb957d9898ae921a12dbd7607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885253 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713180}
-
Etienne Bergeron authored
This is a reland of 55549387 Original change's description: > Fix RenderText itemization for complex emoji > > > > This CL is a refactoring on the way RenderText do > > ItemizeTextToRuns for the corner cases where a run > > should be split in grapheme clusters. > > > > The previous code was naming these cases: > > * Unusual characters > > * Special characters > > * Non-regular characters > > But they should be more specific on the purpose of splitting the runs. > > > > Also, the algorithm used for splitting a sequence of codepoint > > was based on the code block of the corresponding codepoints > > and few cases where trying to merge adjacent codepoint in > > a grapheme. The algorithm was incorrect multiple cases (e.g. emoji). > > > > Unicode provide a way to split a sequence of codepoints into > > grapheme and grapheme clusters. > > They provide a state machine which is using the codepoint proporties > > to decide if the current location is a grapheme boundaries. > > > > The ICU library is providing an API over the character properties > > to help iterating over graphemes. > > * ubrk_open > > * ubrk_first > > * ubrk_next > > * ubrk_close > > > > The class base::i18n::BreakIterator(..., BREAK_CHARACTER) is > > providing an easy to use wrapper over that API. > > > > > > The current CL is replacing the previous characters based splitting > > algorithm by the graphemes based version. > > > > > > > > See emoji sequence: > > http://www.unicode.org/reports/tr51/ > > 1.4.5 Emoji Sequences > > > > The full emoji list: > > * http://unicode.org/emoji/charts/full-emoji-list.html > > Emoji data, used to make our unittests: > > * http://www.unicode.org/Public/emoji/12.0/emoji-data.txt > > > > > see: UNICODE TEXT SEGMENTATION (http://unicode.org/reports/tr29/) > > see: https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ubrk.h > > see: https://cs.chromium.org/chromium/src/base/i18n/break_iterator.h > > Change-Id: I6b9a9c79021f2ce0e2db7cdefdd0838b5911f445 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788804 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712704} Change-Id: I64c877907d6e961bd223a7c4cb1193c240b0b7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900347Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713179}
-
Bo Liu authored
The compositor surface is opaque, which means when video is lifted into a separate surface during fullscreen below the compositor surface, it is never showing through. Always set the compositor surface to translucent for now, which will use more memory even when not in fullscreen. Bug: 1022042 Change-Id: I2ff368dfa2a04ba0e62891039244c0bcb148e6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899901Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713178}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f73369ec458..2d87f9edb488 Created with: gclient setdep -r src-internal@2d87f9edb488 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:992974 Change-Id: I3ff53a1e3e9f0260747d79cc9624fc7310c1f57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901794Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713177}
-
Owen Min authored
All machine_level_user_cloud_policy* files under chrome/browser/policy are renamed to chrome_browser_cloud_management*. Updating the per-file oaner as well. Bug: 1010704 Change-Id: Ib8bafb1c36227c3d725d973b38d3b330cda445a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900551Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713176}
-
manuk authored
Previously, the document provider backed off upon receiving http 200 responses with certain error codes (403 & 503). However, the backend sends http 400 and 499 responses to notify the client to backoff. This CL modifies doc provider to backoff upon receiving any of the backoff responses: http 200 w/ code 403, http 503 w/ code 503, http 400, and http 499 responses). To avoid having to wait for this CL to rollout, the backend may be modified to reply with the http 200 backoff responses. If that is the case, once this CL rolls out to stable, the backend will return to sending http 403 and 499 backoff responses. Afterwards, the document provider will be modified to no longer listen for the http 200 backoff responses. Alternatively, if the backend is never modified to send http 200 backoff responses, backoff won't work until this CL rolls out. Regardless, the document provider should be modified to only listen to one set of backoff responses going forward. Bug: 1022071 Change-Id: I60070be5a0f727bfda3cf165daed03a82efbb277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900400 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#713175}
-
Maggie Cai authored
This CL connects the App Service with the Pref Service. This is to allow the App Service store and retrieve preferred apps from the preferences file. BUG=853604 Change-Id: I2802173d80126595966626af5d1ff1f42761c49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892475Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#713174}
-
Scott Violet authored
As the aidl directory contains more than just aidl files, the name is mildly confusing. This renames it to 'interfaces' ('interface' would be nice, but 'interface' is a reserved word, event for package names). BUG=none TEST=none Change-Id: I29e9fb737d8f7bbe5b586d26399d78ff262c1bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901727 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#713173}
-
kylechar authored
InProcessGpuMemoryBufferManager wasn't providing memory dumps for GpuMemoryBuffers it allocated. Any GMBs allocated for the GPU process weren't accounted for in memory traces. Share the implementation with HostGpuMemoryBufferManager by refactoring it into AllocateBufferInfo class. Bug: none Change-Id: Ieaf1597106bee2562b0fc99a47243f55af7faf5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894457 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#713172}
-
Sahel Sharify authored
This cl removes dump without crashing in case of multiple attempts to record journey logger bit vector. Dump without crashing is not needed anymore since enough stacktraces and events_ are gathered from stable channel. Bug: 994675 Change-Id: I150704344deff3ec8dcf5def01386a8104dc7264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900252 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713171}
-
Collin Baker authored
This moves content::PageVisibilityState into blink and uses this instead of a boolean for blink::Page's visibility. A follow-up CL will use the kPrerender state to set a Page as not hidden but not fully visible for certain capture scenarios. This CL is not intended to change behavior yet. crbug.com/995131#c24 describes this series of changes. Bug: 995131 Change-Id: I41d05228c1ca830ce57ffcb3a04735279bf324f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898471 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Manas Verma authored
The url-safe base64 encoding of the credential_id was being sent to Payments server, but only standard base64 is accepted. This CL ensures only standard base64 is used. Bug: 949269 Change-Id: I423ab314aeb6a40f21dcc1e9304329afa7a52147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897493Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#713169}
-
Eric Stevenson authored
This is a reland of ef04b24c. Fixed in the reland: * Now stripping out -checkdiscards from test targets. Original change's description: > Android: Add @CheckDiscard to proxy native wrappers. > > This will cause compile errors for proguard_enabled builds if generated > proxy native classes aren't fully inlined and removed. > > An example where this would happen is caching the result of > WrapperClassNameJni.get() in a member variable. > > Example errors: > Item void org.chromium.base.MemoryPressureListenerJni.<init>() was not discarded. > Some JNI wrapper classes were not fully optimized. > org.chromium.base.MemoryPressureListenerJni should not appear in a release .dex file. > Common causes include storing a @NativeMethods class as a member variable or passing a JNI method reference to a function instead of using a lambda. > ... > > Item void org.chromium.base.library_loader.LibraryPrefetcherJni.<init>() was not discarded. > Some JNI wrapper classes were not fully optimized. > org.chromium.base.library_loader.LibraryPrefetcherJni should not appear in a release .dex file. > Common causes include storing a @NativeMethods class as a member variable or passing a JNI method reference to a function instead of using a lambda. > ... > > Bug: 993421 > Change-Id: I488640859a939d41eed2e44bb01904062942257d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894151 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712239} Bug: 993421 Change-Id: I14edd406de4028dfef2761d7129b7579238a3ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898303 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713168}
-
Xianzhu Wang authored
Change-Id: I8da35697fa6df741be7269c4566b9b7636557412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901642Reviewed-by:
-
Daniel Murphy authored
This change moves the error reporting out of TransactionalLevelDBDatabase and into the leveldb environment configuration. This allows better separation of logic, and also removes dependencies of TransactionalLevelDBDatabase on indexed_db/. Bug: 1015212 Change-Id: I3ce7e3b2896e2e1555114500d48789192a1381ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898779 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
David Grogan authored
FlexibleBoxAlgorithm flips the positions of items in RTL row containers. Legacy flips items in RTL column containers before setting their positions and I thought I'd have to do something similar in LayoutNG. But LayoutNG assumes children will be positioned without flipping for RTL; the fragment flips children automatically upon creation [1]. So this patch prevents FlexibleBoxAlgorithm from flipping for RTL in FlexNG. [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/ng/ng_physical_container_fragment.cc?rcl=70b1c5fbc63772bd98d26d26ddded71ca96f5f1f&l=76 Bug: 845235 Change-Id: I672b0b8b4f9781c54edaa60cb2ce7e0f46610cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889011Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713165}
-
Tommy Steimel authored
This CL moves the ui/base/now_playing component into the new System Media Controls component as the Mac implementation. This CL adds a SystemMediaControlsMac object which holds both the NowPlayingInfoCenterDelegate and RemoteCommandCenterDelegate and uses the combination to implement the SystemMediaControls API. Bug: 949596 Change-Id: I7f82ff6c3f86836530f7af4843e0b4c832ee4e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898513 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713164}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2f2049af23f4..33cff37c6035 git log 2f2049af23f4..33cff37c6035 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-06 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-11-06 mbonadei@webrtc.org Disable goma on GCC bots. 2019-11-06 alessiob@webrtc.org Reland "RNN VAD: prepare for SIMD optimization" Created with: gclient setdep -r src/third_party/webrtc@33cff37c6035 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1021931 Change-Id: Ic69036492cbab4c0979e23608a3047c300cb44db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899599Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0efc01d54063..3dce06be0e24 git log 0efc01d54063..3dce06be0e24 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-06 jvanverth@google.com Fix issue with RenderPipelineDescriptor creation 2019-11-06 mtklein@google.com JIT splat(0) as xor 2019-11-06 bsalomon@google.com fix tolerance in read pixels tests Created with: gclient setdep -r src/third_party/skia@3dce06be0e24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I7355b4e068d6396c5b56bd9b993790c34094c1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901789Reviewed-by:
-
Manas Verma authored
During a GetRealPan request, either the "encrypted_cvc" field is set, or the "fido_assertion_info" field is set, but never both. Bug: 949269 Change-Id: I5f44efc175c8401e99bd6d5236f859319577e8d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897494Reviewed-by:
-
Anupam Snigdha authored
This change contains the prototype implementation of EditContext APIs. EditContext simplifies the process of integrating a web app with advanced text input methods such as IME, VK shape-writing, speech recognition etc. EditContext decouples text input from the HTML DOM view. Rather than having the web platform infer the data required to enable sophisticated text input mechanisms from the HTML DOM, the author will provide that data explicitly through the API surface of the EditContext. Additionally, EditContext communicates events driven from text input UI to JavaScript. Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/ master/EditContext/explainer.md Test: run_web_tests web_tests/editing/input/edit-context.html Bug: 999184 Change-Id: I36f115bf37e6ea2adb64c2f42e024dc800b56480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868848 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#713160}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c1c6fa243e83..1171cdd4f791 git log c1c6fa243e83..1171cdd4f791 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 lalitm@google.com Merge "trace_processor: optimize filtering a range into a BitVector" 2019-11-06 lalitm@google.com Merge "trace_processor: improve SelectRangeWithBv for start == 0 case" 2019-11-06 lalitm@google.com Merge "trace_processor: make filtering of non-null columns faster" Created with: gclient setdep -r src/third_party/perfetto@1171cdd4f791 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I5abaa004ca159ba79a2fc21fe048558c6b5e44a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901545Reviewed-by:
-
