- 14 May, 2019 40 commits
-
-
Greg Thompson authored
From time to time, a stray window is left behind on the Windows 10 bots that interferes with interactive_ui_tests (it's usually an OpenWith.exe dialog asking the user to pick an app to open some file/URL protocol). This change augments ShowAndFocusNativeWindow so that it makes up to five attempts to close any window that remains in the foreground despite its best efforts to bring the desired NativeWindow to the foreground. BUG=711256 R=sky@chromium.org Change-Id: Iccb568f34c66b5d0571d6d4dc3648c7b06ac35de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610766 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659635}
-
Gary Bressler authored
This change publishes services to both "public" and "svc" in preparation for the ABI change to "svc". Bug: CF-540 Change-Id: I64cf34316b015c29f86d361958209eb6c15cde00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609593 Commit-Queue: Gary Bressler <geb@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#659634}
-
Oskar Sundbom authored
Glitches are detected by comparing the differences between the device clock's position and the performance counter value at which the position was recorded. If the performance counter has moved further than the device position has, then it's treated as a glitch. Initially, I tried detecting when the write position (based on the audio device's clock) moved more than a single buffer's duration ahead between two calls. This did not prove reliable on my machine, as the device clock stopped moving forward unless fed enough data. Bug: 864463 Change-Id: Idb1d6c732964b5c4ca30f98f3521f3dbefe3b937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611919 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#659633}
-
Peter Boström authored
Previously the extensions menu would wait for popups to trigger to rely on being closed due to other widgets appearing. This is more responsive for slow popups that take a while to trigger, but also feels better for extensions that don't have an action and therefore do not close this menu. Bug: chromium:959923 Change-Id: If31ef24ea0caf400486f1002435fb3a1c2be7261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598802 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659632}
-
Xiyuan Xia authored
- Pass local state PrefService to ash directly during init instead of getting it through prefs::ConnectToPrefService. - Simplify DisplayPrefs since local state is passed directly to ash; - Update WallpaperController to handle local state is available before its Init call and remove obsolete IgnoreShowUserWallpaper; Bug: 958237 Change-Id: I981fa3cbd5a2a6ebd2a088c678608b601a1fde2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606567 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#659631}
-
Daniel Libby authored
Note: based on crrev.com/1595296 When scroll gestures are injected during the handling of an input on the main thread, we want to dispatch the scroll gesture with the LatencyInfo information from the original input event, but with a different type. This allows the end to end latency metrics to be computed correctly and classified separately as a specific type of scroll (not just, e.g. as mouse latency). Bug: 954007 Change-Id: I725eaa46f21883aff08ab209d73dc5d0398a85db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603342 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659630}
-
Sylvain Defresne authored
This code is there to support migration of a flag that is not used since M-48. According to the histogram, 100% of the user have been converted on Chrome OS and Android (the two platforms that still support child accounts). Bug: 960028 Change-Id: I2ca06df6876c96b6cd8407cab429e32e4751090d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609899Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659629}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/209ebc015a2f..69258ffdb88a git log 209ebc015a2f..69258ffdb88a --date=short --no-merges --format='%ad %ae %s' 2019-05-14 csmartdalton@google.com Add a workaround to allow sample variables for stencil draws Created with: gclient setdep -r src/third_party/skia@69258ffdb88a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I814072a9b0a8378c99a9a9cce4ea8f5ee4790a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659628}
-
Scott Violet authored
The presubmit enforces no usage of aura::Env. That restriction was put in place for SingleProcessMash, when there would be two aura::Envs. As we're no longer doing mash, that restriction is no longer applicable. BUG=958062 TEST=none Change-Id: I405f2d515941677cbfd7a1e440620f9e5538ef5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611729 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659627}
-
Caleb Rouleau authored
This reverts commit 49cbd4e9. Reason for revert: This causes error "RuntimeError: Platform does not have a shard map at /usr/local/google/home/crouleau/chromium/chromium/src/tools/perf/core/shard_maps/android_arm64-builder-perf_map.json." I will fix this and reland with PRESUBMIT support. (I assumed PRESUBMIT would cover this, but it didn't). Original change's description: > [Speed Waterfall] Official benchmarks not longer need to run across all platforms. > > The current code has an assumption that every official benchmark must be scheduled > on either pixel2 or linux platform. However, we are hoping to allow benchmarks > to choose when platforms are the most important for them instead of having them > run across all platforms by default. > > Bug: 961830 > Change-Id: I26de896c921a85213a867e89ff137fce81959550 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610484 > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659293} TBR=crouleau@chromium.org,johnchen@chromium.org,jbudorick@chromium.org Change-Id: Ic4c6b34bbc0dc73484a670e5b1b39bd05849afd0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610094Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#659626}
-
Alex Cooper authored
The WebXR spec requires that the Gamepad object on an XRInputSource be tagged as "SameObject." The current implementation would allow for the Gamepad to be toggled between null and present on the same XRInputSource object as it currently is written. This change exposes a method "NeedsReCreation" as well as static helper methods (and a deep- copy constructor) to allow for that re-creation to occur in a pattern which could be re-used by 958019 if the spec requires those changes. While this change adds an xr_browser_test to validate the blink code that destroys/re-creates the object, the work to add a WPT test for all of the same object properties is tracked by 960958. The exemption to audit_non_blink_usage was added because the xr module was currently utilizing device::Gamepad, but since it was previously wrapped in base::Optional, that usage was not flagged. Note that 955101 (currently tagged for 77) may relax/change this requirement, but this makes the code compliant with the spec for M76. Bug: 960978 Change-Id: Ie36990f47e43c6df91af3fca06dd269a860a2a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606421 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#659625}
-
Vladislav Kaznacheev authored
These values are no longer used anywhere (including UMA) and hence are safe to remove. Existing usages of kWebStoreApp in unit tests are purely illustrative and can be replaced with kPlayStoreApp. Bug: 940036 Test: compile Chrome and unit_tests Change-Id: Ib193324dbb28e40b1cd621b09ae59c568fd08aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610549 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659624}
-
Carlos Knippschild authored
And also add a new team owner to broadcast related messages more broadly. Bug: 960071, 960070, 960068, 960067, 960065, 960064, 960063, 960061, 960059, 960058, 960057 Change-Id: I0c9d687f30725026137797cd51d1de602fe73ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611119Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#659623}
-
Zentaro Kavanagh authored
- They are never needed by derived classes BUG=None TEST=compiles Change-Id: I1b2fda58fbe391be9fbda4273fa4e40269493bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607155Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#659622}
-
Chris Lu authored
The JavaScript keeps track of all matches regardless of visibility. This change ensures that, given an index, selectAndScrollToMatch will not select a hidden match. Bug: 919685 Change-Id: I0256951e2170e7638571ff1d358ac0610f1bef56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594173 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#659621}
-
Daniel Bratell authored
In autofill, AddressField is both a locally defined type and an imported type from i18n::addressinput. In some non-default jumbo builds they end up in the same translation unit, causing compilation problems. This renames the imported classes so they have distinct names. This appeared May 13-14 but I don't know why. No change looks relevant. Change-Id: I77885ce1f8f2a120570cd281868682637a3f79b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611609 Commit-Queue: Tommy Martino <tmartino@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#659620}
-
Steven Bennetts authored
Bug: 862420 Change-Id: I5389e338ef01ec875fbfb6d7687e4e11c40816f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585978 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#659619}
-
Hugo Holgersson authored
Let's use "Ahem" so snav-fragmented-link.html passes on Mac too. Original review: http://crrev.com/c/1587559. Background: SpatNav compares activeElement's bounding rect with all other focusables' bounding rects. Example (snav-fragmented-link.html): A multi-line ("fragmented") link has focus. xxxxxxLINK L INKLINKxx #A Here LINK's bounding box's area is bigger than the the combined area of its two fragments. The box, returned by NodeRectInRootFrame(), even overlaps another focusable, #A. We can say that LINK's bounding box "contains" #A. Problem: Spatial navigation searches _from_ the focused element's bounding box (but not inside of it). Here LINK's rect completely contains A's rect so #A will never be considered as a focus candidate. Solution: Give priority to focusables inside the current focus rect. This also solves the generic case, crbug.com/798102, where one focusable lays "under" another one, i.e where a focus rect "contains" (or is positioned behind) another focusable. I test this case in snav-focus-rect-contains-links.html. Previously, such containers where unreachable because of 86d40f3d's (anno 2010): "... if there are 2 overlapping focusable nodes, we do a hit test and only the node on top can get focus." Now, when two focusables overlap, SpatNav first goes go the outer box. From there, focus can go to the "on-top", or "inner" (thinking in 2D) focusables. Related CLs: Search scrollers from their edges: crrev.com/589502. This CL uses the same approach as crrev.com/589502; when a "container" is focused, we first search inside of it, from one of its edges. Distance calculation fixup: OppositeEdge()'s returned slice will now be "just outside" the box it is slicing. This change helps us avoid if-logic to cover cases when focusables sit at the very top of their container. Bonus cleanup: AreElementsOnSameLine() can now be removed. It was introduced back in 2011 at 3568f132 to support [some] line-broken links but it didn't fix 956900. Bug: 798102, 956900 Change-Id: I05ee4e92f237d68664f24b45da969178ebca85c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605696 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#659618}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia236074fe40308f76c7400aa2e4052294188aca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611383Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659617}
-
Greg Kerr authored
Bug: 961005 Change-Id: I4b9f0e49b1394f6c8d877edcd94572d03f821c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611215 Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#659616}
-
Henrique Nakashima authored
PrefetchServiceFactory currently uses the URLLoaderFactory from Profile. To make it a SimpleKeyedServiceFactory, all dependencies to Profile must be severed. Bug: 953918 Change-Id: Icfd72e0e468a18065936d8d1286fb426fd19326b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603386Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#659615}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/4d0fe85c1957..78c44e2dc26e $ git log 4d0fe85c1..78c44e2dc --date=short --no-merges --format='%ad %ae %s' 2019-05-13 jianj Reland "vp9: Enable ml based partition for speed>=8 low res." 2019-03-04 ravi.chaudhary Fix update of mb_smooth_pct and mb_av_energy Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I202ab58a304053d86a503bf1d29928c1f3b3613a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611649Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#659614}
-
Tetsui Ohkubo authored
This is a follow-up change of https://crrev.com/c/1602193 and https://crrev.com/c/1599758. After the first change landed, gamepad vendor ID and product ID are exposed to ARC. However, device version wasn't included because the field wasn't available in ui::InputDevice. After the second change, now the information is available. This is a part of the effort to improve ARC Gampad compatibility. Design doc: go/arc-improved-gamepad TEST=manual(--enable-features=ExoRawGamepadInfo to /etc/chrome_dev.conf) BUG=b:130597086 Change-Id: Ie2def04cafaa52295e8e0d2e75313b1bb5f8c314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610272Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#659613}
-
Steve Kobes authored
This tweaks the DVLOG output of JankTracker to be more useful, printing the URL of the document in which the layout shift occurred, indicating whether it's in a subframe, and suppressing output for devtools windows. Bug: 581518 Change-Id: I5515137219a6ff88fb46ca9181f500e5b23c191d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1459802Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#659612}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/701ac9a6e80f..88ad352aa1c6 git log 701ac9a6e80f..88ad352aa1c6 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 oysteine@google.com Devtools tracing handler: Propagate Tracing.end errors Created with: gclient setdep -r src/third_party/catapult@88ad352aa1c6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:956191 TBR=oysteine@google.com Change-Id: I3328578f00f9ee84e1700ce8b4b14a43316b4fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659611}
-
John Rummell authored
BUG=none Change-Id: I0c207a6cb2131ede179b5c03aed4cb58277363b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606594Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#659610}
-
Kevin Ellis authored
Spec: https://drafts.csswg.org/web-animations/#the-animation-interface Animation.updatePlaybackRate differs from the setter for playbackRate in a number of aspects. The updatePlaybackRate method provides a guarantee that the update will not trigger a visual jump in the animation by ensuring that current time remains continuous. Furthermore the update method does not alter the playback rate retrieved via the getter until after the next async update cycle if there is a pending run or pause task. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/lTYK1HT47Qk Bug: 827634 Change-Id: Ic7c9e520786a7bbf1894cb50a991185f2f400b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598210 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#659609}
-
Robert Ma authored
The tool is broken because our builders.json is out of date (lots of testers have been moved or renamed during the LUCI migration and the teardown of chromium.webkit). Although LUCI no longer has the concept of masters (only groups), the legacy test-results app that this tool relies on still requires the master param in the URL. Besides, with chromium.webkit gone, the builders that run webkit_layout_tests are now in different groups (masters), so we need to add a "master" field to builders.json. Bug: 840230 Change-Id: I3f9c17ea8c8e72506a5680f717b9b11163d14aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604332 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#659608}
-
Andrew Grieve authored
They were showing up as nodes with count of 0 because their size had changed but not their count. When in method count mode, it makes more sense to just hide these nodes. Bug: 947372 Change-Id: Ic90cf0a41e0cd601687199b7a938a90a786cdab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611763Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#659607}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bbe382ef. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I19d32f095c3bbbc67e582de5c6592f1aca9c1d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610204Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659606}
-
Koji Ishii authored
Following bot results are included. 19482 19483 19486 19495 19501 19507 19512 19532 19550 19570 19578 19585 19595 19607 19614 19638 2 lines were removed and 5 lines were deflaked by consecutive results since 19501. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: Ibdbc0a5f1ff7e53722ccb2d0356b094e500cdb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607709Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#659605}
-
Sky Malice authored
Certain actions on the touchless builds that loaded the NTP would cause a DCHECK during cleanup of observer state. This change simply passes the modified tab through in NavigationRecorder#onDestroy(). It is unclear if passing null in onDestroy() initially was an oversight or on purpose. Bug: 959230 Change-Id: I23b9e9abe6ed03183af80e525ee6ec2f582cdee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611507Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#659604}
-
Mason Freed authored
Previous to this CL, an empty rect was used to signal that no clipping should be performed on the backdrop filtered image. However, in the corner case that the element with backdrop-filter was zero size, this would cause no clipping to be performed, which is incorrect. With this CL, backdrop_filter_bounds is base::Optional. There is also a test for this case. Change-Id: I8d3d1e383ccf807f1e4f569847bd828a8d04fd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604330Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#659603}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a82ea5d..8642c0be Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6c840537335c32cf707e9723e17e0b5511619ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610207Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659602}
-
Bruce Dawson authored
pe_summarize.py had a "convenient" dependency on VS 2015 which now seems anachronistic, and hard to maintain. Run it from a VS command prompt with dumpbin in the path. Also use the /nopdb option to avoid querying symbol servers, and print an informative error message if dumpbin can't be found. Change-Id: I2dad597ae4fb397b46caed969c6b46eac091c2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610030 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#659601}
-
Devlin Cronin authored
Karan's been the go-to person for webRequest issues for awhile. Add him to the ONWERS file. Also add an OWNERS file to extensions/browser/api/web_request (and have the //chrome one point to that). Bug: None Change-Id: Iaac56b50c305238e99c2e033ce710c05c0847860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612023Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659600}
-
Devlin Cronin authored
Opaque origins (such as about:blank and data: URLs) inherit the security and privileges of their creator origins, which are tracked in precursor tuples. ScriptContext::GetEffectiveDocumentURL() attempts to determine the precursor origin of an opaque URL today by traversing the creation chain and looking for the first non-about:blank opener or parent. However, this is not always strictly correct for all opaque origins; for instance, the precursor tuple of a data: frame may not be that of its immediate parent in the case of nested iframes. Update ScriptContext::GetEffectiveDocumentURL() to use Origin::GetTupleOrPrecursorTupleIfOpaque(), which correctly tracks this. Note that we still have to do the opener/parent traversal case because content script matching needs to have the full URL (including path), and not just the scheme, host, and port tuple. To balance these, we simply return the document URL (which is potentially opaque) in the case of a mismatch between opener/parent traversal and the precursor tuple. This should be an exceptionally rare case in practice. Updating this method to use the precursor tuple is a prerequisite for adding support for data:-URL content script injection. Bug: 55084 Change-Id: I8f7d17b999f909cc32091b8fff06bd53a2370db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601663 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#659599}
-
dpapad authored
No longer used anywhere and not needed. Bug: 961063 Change-Id: I699773db478aac13495a63166edbbe774f3115f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607128Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#659598}
-
Avi Drissman authored
It is redundant to the one that Chromium provides. BUG=960209 Change-Id: I5d9133311f19196b3cbe4d59376300defe5451c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611910 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659597}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb19-26.html BUG=412078 TBR=jschuh@chromium.org Change-Id: Iba1a2b628b7fb796788691693c4ca94cf9651af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611648Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659596}
-