GitLab

instead of anchorPoint.

The hack is no longer necessary because transformOrigin is an additive offset,
as opposed to a multiplicative one.

BUG=372837

Review URL: https://codereview.chromium.org/329553003

git-svn-id: svn://svn.chromium.org/blink/trunk@175911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=abarth
BUG=382129

Review URL: https://codereview.chromium.org/328783002

git-svn-id: svn://svn.chromium.org/blink/trunk@175910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target. (https://codereview.chromium.org/320933003/)

Reason for revert:
event-listener-breakpoints.html always timing out on Mac 10.6 (dbg):
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(dbg)

Original issue's description:
> DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target.
> 
> This will allow debugger to pause on "load", "error" and etc. event breakpoints only
> when they happen on XHR event targets.
> 
> BUG=381470
> R=yurys, pfeldman@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175882

TBR=pfeldman@chromium.org,yurys@chromium.org,aandrey@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=381470

Review URL: https://codereview.chromium.org/322893006

git-svn-id: svn://svn.chromium.org/blink/trunk@175909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix InternalsGeolocation::setGeolocationClientMock to actually set the test client for all GeolocationController.

This was caught by kenrb. It didn't manifest itself because it's a test-only method, and none of the geolocation tests which use this do so for an iframe.

Review URL: https://codereview.chromium.org/322583002

git-svn-id: svn://svn.chromium.org/blink/trunk@175907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoid branching in createAttributeEventListener, also it should not be needed to test for SVG specific stuff in this spot.

Review URL: https://codereview.chromium.org/321023002

git-svn-id: svn://svn.chromium.org/blink/trunk@175902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376194

Review URL: https://codereview.chromium.org/324013005

git-svn-id: svn://svn.chromium.org/blink/trunk@175901 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/323873007

git-svn-id: svn://svn.chromium.org/blink/trunk@175900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These represent the same concept, and having two separate
enumerations is redundant.

BUG=382916

Review URL: https://codereview.chromium.org/328453004

git-svn-id: svn://svn.chromium.org/blink/trunk@175899 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Timeline front-end used to assume that if call stack is present, it contains at
least one call frame. Let's not break that expectation when transitioning to
trace-based instrumentation and return null, not empty array, for the absent stack.

BUG=361045

Review URL: https://codereview.chromium.org/327793002

git-svn-id: svn://svn.chromium.org/blink/trunk@175898 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/323503002

git-svn-id: svn://svn.chromium.org/blink/trunk@175897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/324963002

git-svn-id: svn://svn.chromium.org/blink/trunk@175895 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When creating a new GraphicsContextState the constructor initializes the state
with various default values. In GraphicsContext::realizePaintState we immediately
overwrite these values after creation. This patch adds a copy constructor to
GraphicsContextState to avoid that.

Even though this seems like a clear win, the benefits are not visible when
profiling. Looks like the overhead of the redundant initialization is
not very large. Still seems worth fixing though.

BUG=377687

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174985

Review URL: https://codereview.chromium.org/303613002

git-svn-id: svn://svn.chromium.org/blink/trunk@175894 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Timeline: move TracingTimelineModel.reset() call from startRecording() to _startRecordingWithCategories()

This is a follow-up to https://codereview.chromium.org/326693002/ (r175810)

BUG=361045
TBR=yurys

Review URL: https://codereview.chromium.org/324913003

git-svn-id: svn://svn.chromium.org/blink/trunk@175893 bbb929c8-8fbe-4397-9dbb-9b2b20218538

highlightQuad method is added to TimelineMode.Rectord. The method encapsulates logic specific to timeline events and trace events.

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/326063004

git-svn-id: svn://svn.chromium.org/blink/trunk@175892 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This prepares inspector for switching chromium-side trace events used
for building timeline to the category names consistent with the rest of
timeline trace-based instrumentation in blink.

BUG=361045

Review URL: https://codereview.chromium.org/328723002

git-svn-id: svn://svn.chromium.org/blink/trunk@175891 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/323063002

git-svn-id: svn://svn.chromium.org/blink/trunk@175890 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/321113003

git-svn-id: svn://svn.chromium.org/blink/trunk@175889 bbb929c8-8fbe-4397-9dbb-9b2b20218538

result declaration was moved close to the usage:

     TypeBuilder::HeapProfiler::HeapSnapshotObjectId out_heapSnapshotObjectId;

-    RefPtr<JSONObject> result = JSONObject::create();
     if (protocolErrors->length()) {
         reportProtocolError(&callId, InvalidParams, String::format(InvalidParamsFormatString, commandName(kHeapProfiler_getHeapObjectIdCmd)), protocolErrors);
         return;
     }
     ErrorString error;
+    RefPtr<JSONObject> result = JSONObject::create();
     m_heapProfilerAgent->getHeapObjectId(&error, in_objectId, &out_heapSnapshotObjectId);
     if (!error.length()) {
         result->setString("heapSnapshotObjectId", out_heapSnapshotObjectId);

BUG=

Review URL: https://codereview.chromium.org/326013005

git-svn-id: svn://svn.chromium.org/blink/trunk@175888 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should avoid memory leaks when the program exits gracefully.

Review URL: https://codereview.chromium.org/324813002

git-svn-id: svn://svn.chromium.org/blink/trunk@175887 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In RenderGrid::placeAutoMajorAxisItemOnGrid if the empty grid area does
not fit in the minor axis direction we should discard it. That way we 
will avoid to grow in that direction at this moment, as this was 
previously done at RenderGrid::populateExplicitGridAndOrderIterator().

A simple use case to reproduce the problem would be a 2x2 grid with
grid-auto-flow property set to "row", where the only empty cell is at
row 2 and column 2. If you try to place an item with the following
properties:
    grid-row: auto;
    grid-column: span 2;

It should be inserted in a new row, however before this patch it was
inserted at row 2 using columns 2 and 3. As even when the empty grid
area does not fit in the minor axis direction, it was still being used
later to insert the item.

Updated layout test to include similar cases that don't work without
this patch.

BUG=353789
TEST=fast/css-grid-layout/grid-item-auto-placement-automatic-span.html

Review URL: https://codereview.chromium.org/314993002

git-svn-id: svn://svn.chromium.org/blink/trunk@175886 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now it's called RenderGrid::ensureGridSize and it allows to grow both 
directions at once.
Remove checkings before calling it as they are not needed anymore.

Review URL: https://codereview.chromium.org/319593002

git-svn-id: svn://svn.chromium.org/blink/trunk@175885 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/311053004

git-svn-id: svn://svn.chromium.org/blink/trunk@175884 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was added as a part of this patch
https://codereview.chromium.org/13937017

The patch was reverted here
https://chromiumcodereview.appspot.com/23072015

Review URL: https://codereview.chromium.org/322103003

git-svn-id: svn://svn.chromium.org/blink/trunk@175883 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will allow debugger to pause on "load", "error" and etc. event breakpoints only
when they happen on XHR event targets.

BUG=381470
R=yurys, pfeldman@chromium.org

Review URL: https://codereview.chromium.org/320933003

git-svn-id: svn://svn.chromium.org/blink/trunk@175882 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Just moving things around, no actualy logic change, though dropped unused
FrameAdded event.

BUG=361045

Review URL: https://codereview.chromium.org/320953002

git-svn-id: svn://svn.chromium.org/blink/trunk@175881 bbb929c8-8fbe-4397-9dbb-9b2b20218538

|m_elementDependencies| had raw ptr to |SVGElement|s.
This was to avoid reference cycles, but we can convert this to strong references in oilpan.

If the whole document is dead, rebuild code is not called. This means that
rebuildElementReference is not called for referencing element, but the
referencing element must be in the same document and is going to die anyway.
If the whole document isn't dead (== the part of the document tree is going
away), the unregister/rebuild code is guaranteed to be called from removedFrom,
and rebuildElementReference is guaranteed to be triggered from there.

BUG=357163, 370834

Review URL: https://codereview.chromium.org/327473002

git-svn-id: svn://svn.chromium.org/blink/trunk@175880 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/322793003

git-svn-id: svn://svn.chromium.org/blink/trunk@175879 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are accidentally added by r175288.


BUG=n/a
TEST=n/a

Review URL: https://codereview.chromium.org/320423006

git-svn-id: svn://svn.chromium.org/blink/trunk@175878 bbb929c8-8fbe-4397-9dbb-9b2b20218538

and reduce binary footprint by 5% ~25kb of 587k (clang x64 release)

BUG=382569
R=yurys@chromium.org

Review URL: https://codereview.chromium.org/325833002

git-svn-id: svn://svn.chromium.org/blink/trunk@175877 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- We need to add Persistent<Element> in ImageLoader in order to
  follow the current behavior by manual ref/deref.
  Also, the manual ref/deref is replaced with RefPtr<Element>.

- ImageLoader was the last off-heap user of EventSender<T>. Now all of
  EventSender<T> users are on-heap. We can trace EventSender::m_dispatchSoonList
  and m_dispatchingList.

- HTMLImageElement and SVGImageElement had ImageLoader as part objects. This CL
  makes them OwnPtr / Member because using on-heap objects as part objects are
  dangerous.

- Add HTMLImageElement::create and SVGImageElement::create.

BUG=357163
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/320253002

git-svn-id: svn://svn.chromium.org/blink/trunk@175876 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Go the whole hog and use (non-const) bare pointers for the conversion
constructor and assignment operator.

R=
BUG=340522

Review URL: https://codereview.chromium.org/329463004

git-svn-id: svn://svn.chromium.org/blink/trunk@175875 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to this GCC bug/patch, a user-specified constructor is
required for the emulated C++11 nullptr_t class if we want to be able
to create const nullptr_t objects without an explicit initializer,
a la: "const std::nullptr_t nullptr;"

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42844

This fixes a build failure in GCC 4.5.

BUG=374431

Review URL: https://codereview.chromium.org/322913002

git-svn-id: svn://svn.chromium.org/blink/trunk@175874 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=337618
TEST=fast/dom/shadow/getComputedStyle-with-distribution.html

Review URL: https://codereview.chromium.org/240293007

git-svn-id: svn://svn.chromium.org/blink/trunk@175873 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dmazzoni@chromium.org,haraken@chromium.org,tommi@chromium.org,tkent@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/315133004

git-svn-id: svn://svn.chromium.org/blink/trunk@175872 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No one is using a value different from the FormDataList object's m_encoding.

BUG=none

Review URL: https://codereview.chromium.org/329513002

git-svn-id: svn://svn.chromium.org/blink/trunk@175871 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Debugger is always enabled at the moment when we run the test so we don't need to check that and dump the message.
Also we don't need to disable it manually at the end because it might hide an error as it happens with debugger-step-into-custom-element-callbacks.html

BUG=

Review URL: https://codereview.chromium.org/316403002

git-svn-id: svn://svn.chromium.org/blink/trunk@175870 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When upgrading ICU to 52, I removed the stringprep data for IDNA 2003 because Chrome/Blink switched to UTS46/IDNA 2008. I overlooked that Blink email form handling still uses IDNA 2003 API that fails without stringprep data for IDNA 2003. 

This CL changes Blink to use UTS46 API. 

BUG=132145,376587
TEST=LayoutTest: fast/forms/email-idn-conversion.html

Review URL: https://codereview.chromium.org/326453002

git-svn-id: svn://svn.chromium.org/blink/trunk@175869 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Followup to:
IDL build: factor out global objects action into a GYP template
https://codereview.chromium.org/316173008/

R=haraken

Review URL: https://codereview.chromium.org/319933002

git-svn-id: svn://svn.chromium.org/blink/trunk@175868 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org,tzik@chromium.org,tkent@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/314333002

git-svn-id: svn://svn.chromium.org/blink/trunk@175867 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=378942

Review URL: https://codereview.chromium.org/316153002

git-svn-id: svn://svn.chromium.org/blink/trunk@175866 bbb929c8-8fbe-4397-9dbb-9b2b20218538