- 15 Jul, 2020 40 commits
-
-
Lijin Shen authored
Add a suffix to the key of intent data to distinguish intent from another chrome channel. Otherwise, intent from another chrome channel leads to an unnecessary metrics logging. Bug: 1090103 Change-Id: Iead382e1c052759da2c491c4d87bf61d142698f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299523 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#788781}
-
XiangYang authored
The page show white color in navigation initial. For dark mode, this excepted a dark color. If developer don't set WebView background color, just show a black background in dark mode. Bug: 1098235 Change-Id: I9b221d0a899d228c71f6ce3b9a46c9dda45c4536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256921 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#788780}
-
rbpotter authored
Add the annotations button and bar to the new toolbar. Hook up the button so that entering/exiting annotation mode works. Bug: 1105732 Change-Id: I87f1067b474c552295c66c0946ce98a813083b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298999Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#788779}
-
Eric Mill authored
of publicly trusted certificates. Change-Id: Ia22a664eea5a33bf23149d5f04ec3d48bc029d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300536Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Eric Mill <ericmill@google.com> Cr-Commit-Position: refs/heads/master@{#788778}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594814211-0517d79b9f4059a1b68c79d5638e00f140bf56b4.profdata to chrome-mac-master-1594835994-5147b08f1c93c88abb9731970c5f21d575c9bbcd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic01e6c36c60221a550751726becd2e64878cc3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300298 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788777}
-
behdad authored
This change adds some unittests for adjust_upper_limit script used by rendering representative pertf tests. Bug: chromium:1052361 Change-Id: I5850b5ca888d6dca7318277ca8bd6eb4bdf40a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283660Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#788776}
-
Rushan Suleymanov authored
When reupload is initiated after loading from the disk right away, it may lead to upload bookmarks which were removed from the other device. This would restore removed bookmarks. In practise it may be caused by some devices which a rarely used. Initiating reupload after receiving latest updates from the server helps to prevent such behaviour. Bug: 1061411 Change-Id: Ibc5646b19bf133de496140fa152b544bc06ebcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299721 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#788775}
-
Lan Wei authored
Avoid testRunner.eventSender in paint/invalidation/table/ table-overflow-auto-in-overflow-auto-scrolled.html Bug: 1047176 Change-Id: I853c88de12cbf36f854a57f0d0f6216d9c1412d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297099Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#788774}
-
Katie D authored
This keeps Switch Access from getting stuck in a state where the user cannot use SA at all after the user tries to go into a quick settings subpage from the status tray settings. However, users still can't access quick settings subpages after this change: that will be addressed later. AX-Relnotes: N/A Bug: 1105196 Change-Id: I251ffb4f8937076ee7e5e079300636972aaa4beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300621 Auto-Submit: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#788773}
-
David Tseng authored
This change unconditionally recovers ChromeVox's pointer focus except when touch exploring. This choice was made after various pieces of feedback: - from the CFM team (regarding lost focus) - from Chrome OS accessibility testers Additional changes: - rename BackgroundMouseHandler -> PointerHandler (which more accurately captures its new function) - caught some places where we were sending direct pass through touches (when an anchor point wasn't being explicitly set). Always convey these paths to ChromeVox as click gestures. ChromeVox will decide how to handle them - revise tests accordingly - allow PointerHandler to be owned by GestureCommandHandler, the only place it is used explicitly - adds coverage for re-reading of nodes in touch exploration - removes the single tap at anchor point logic behavior. Prior to this change, TouchExplorationController sends a tap press/release if a user quickly double taps. This is fairly confusing to explain and goes somewhat against the purpose of having a double tap and hold pass through R=akihiroota@chromium.org, dmazzoni@chromium.org Bug: 1102990 AX-Relnotes: makes double tap feedback not be so strict when touch exploring off of items in ChromeVox Change-Id: I1ebb54b0f31c08d01f46d5bf49d1862c30aca337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296364 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#788772}
-
Kristi Park authored
This reverts commit 43370549. Reason for revert: Suspect for failing "Win7 Tests (dbg)(1)" browser_tests https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/83627 Original change's description: > Roll DevTools Frontend from 2a4147183191 to d8d96d5f0af2 (5 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2a4147183191..d8d96d5f0af2 > > 2020-07-15 jacktfranklin@chromium.org Ship new ElementsBreadcrumbs to production > 2020-07-15 wolfi@chromium.org Use FrameManager for frames section in application panel > 2020-07-15 tvanderlippe@chromium.org Move copy_lighthouse_locale_files to third_party/lighthouse > 2020-07-15 tvanderlippe@chromium.org Move copy_wasm_deps to sdk/wasm_source_map/BUILD.gn > 2020-07-15 tvanderlippe@chromium.org Move embedder-scripts to front_end/BUILD.gn > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1093247,chromium:1101262 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I493eb47f07ded2676ab3f949bf3df79096dad6e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300286 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#788702} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If35df14e3465658e849a11cb7ffc513893619aa9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1093247, chromium:1101262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300821Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#788771}
-
Shelley Vohr authored
Refs https://chromium-review.googlesource.com/c/chromium/src/+/2231678. When the label was updated to use underscores, the associated jQuery call in accessibility.js was not likewise updated, so it would error with: "Uncaught TypeError: Cannot read property 'value' of null" Change-Id: Iac01a1246a0bb1e0bb8a7c02a5965cfba5f66323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296883Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#788770}
-
Justin Cohen authored
Bug: 1106030 Change-Id: I7a422c99de9f3de5b613e38625260c93927adb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299533 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#788769}
-
Leonid Baraz authored
Bug: b:161266545 Change-Id: I57f47b6c8acff90de983ca4c553b6f4fdacfba0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296636 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#788768}
-
Miguel Casas authored
VASupportedProfiles is an internal class of vaapi_wrapper.cc in charge of enumerating the encoding/decoding video/image profiles supported in Chrome. It basically holds a |supported_profiles_| member, filled upon construction from GetSupportedProfileInfosForCodecModeInternal(). This CL: - Refactors GetSupportedProfileInfosForCodecModeInternal(), renaming it to FillSupportedProfileInfos()) to do all the enumerations needed, and reorders a bit the contents of the for-for-for loops, so that IsEntrypointSupported_Locked() is unnecessary and removed entirely. - Changes the signature of IsProfileSupported() to maybe-return a ptr to the ProfileInfo entry (and not a bool), which simplifies callsites. - Removes GetSupportedProfileInfosForCodecMode(), simplifying some of the callsites as well (except GetSupported...ForTesting() which is made a friend). - Sprinkles static_assert()s to verify sizes of constexpr data structs. This CL also removes the references to VAProfileVP9Profile1 and 3, because those are not present in my experience in the wild, neither in libva impls nor in videos, and are not properly validated nor tested. Bug: 1040291, 1105103 Change-Id: I6717cac3e57f5e304eae04272842efacf7e1f762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292780Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#788767}
-
chrome://nearby-internalsJuliet Levesque authored
Add a tab that will eventually display Nearby-related HTTP messages. See the following screenshot for display: https://screenshot.googleplex.com/mL7965ihWuh. Bug: 1093634 Change-Id: I7d0cb3a15f6f114a888ff86ab0545f645ae5b9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269700Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#788766}
-
Xiaohan Wang authored
The session expiration should only change after Update(), Load() or Remove(). This CL updates Update() and Remove() to update session expiration if needed. Load() remains unimplemented. Note that we don't need to update expiration on Close(), which is handled at a higher layer in MediaKeySession::OnSessionClosed(). Bug: 999747 Change-Id: Ie0f32cde8fcae46581cf135753a3de4b7e2ca7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298344Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#788765}
-
Stephanie Kim authored
It looks like win-official and win32-official occasionally take 4+ hours to complete. Even though win32-official hasn't seen any5 hour timeouts, some runs cut it pretty close so I'm increasing timeout for that too. Bug: 1106006, 1072012 Change-Id: I361ea8a3ee921a6af86fee34163f497529222ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300628Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#788764}
-
Anupam Snigdha authored
Clamped the values in |EnclosingIntRect| to avoid integer overflow while calculating the |IntSize| of the rectangle. Bug: 1100102 Change-Id: Ied4208ff989ac4bbf6c9a1f469ea4699b55b9dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293232Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#788763}
-
Tommy Li authored
Currently the section toggle buttons just announce the tooltips, which are a succinct "Show Suggestions" or "Hide Suggestions". This CL makes the announcement a more explanatory: "Show the 'Related to recent searches' section" Bug: 1099788 Change-Id: I7a8e982ab9bf1b62d8e5f5200174ff2ebb19488a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295929 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#788762}
-
Sven Zheng authored
Bug: 1104291 Change-Id: I5a988387b7c200aed1add10efe853d36c96a6578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300229Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#788761}
-
Xi Han authored
Adds more logs to investigate the failures on test-go-phone. Bug: 1096833 Change-Id: Ic067a93ddb87c6afb314f415f69307fe31794394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300269Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788760}
-
Stepan Khapugin authored
Removes this histogram since it's not longer logged, and M85 has already branched. Bug: 1089174 Change-Id: Ic20d16aaedaf8aea83d6d58facd539bbec932820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300112Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788759}
-
Justin Cohen authored
Bug: 1103822 Change-Id: Id17a92cd2da3bbc57343c190fd63e77a859afc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298940Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#788758}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6531f33eb2bc..ed9549e829b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kristipark@google.com,rogerm@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kristipark@google.com,rogerm@google.com Change-Id: I6b5ce281e4c811b4a5fd1ca6774b8a0045f342c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300291Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788757}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=sorin@chromium.org Change-Id: Ic4ae22fba1a0d2012a6d89a80ef332a84a452e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298761 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788756}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I256e893dacffdc33c793824249429d62fdc77d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300503Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788755}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I99ec4b5a1f2b4c23384b58d8e1a1eeb44848de65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300620Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788754}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c44b2b2567ae..9277ee741395 2020-07-15 lehoangq@gmail.com Metal: Implement MSAA default framebuffer. 2020-07-15 jmadill@chromium.org Fix stale validation cache on buffer deletion. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1105202 Tbr: jonahr@google.com Change-Id: I20ba4fe11548660d3a0203425f1c64fc98ee85f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788753}
-
Nodir Turakulov authored
metadata-exporter builder is modernization of https://ci.chromium.org/p/chromium/builders/ci/linux_chromium_component_updater It uses a new recipe which uses a new tool that understands both legacy OWNERS and new DIR_METADATA files. Try using new bbagent (as opposed to kitchen) from the start. Rename "component-mapping" notifier to "metadata-mapping" because it is cheap, compared to changing mailing list emails and service account emails. Create a new Milo console for new builder. Move existing builder from goma-specific console, because it has nothing to do with goma. Bug: 1102997 Change-Id: Ia0a988768c334b319fc11c38804c524a899fb119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300602 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#788752}
-
Vasiliy Telezhnikov authored
WebView/GLRenderer checks active frame of child surface for backdrop filters to decide if merging SurfaceQuad is possible. If surface doesn't have active frame it will fail CHECK. This CL adds guard if the surface has active frame before retrieving to prevent crashing. Bug: 1100340 Change-Id: Ia02cead1c2195ba738ad19cf99db83b10669c948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300323Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#788751}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Change-Id: I9bb8090747407e77408a9fa1556ccba3633cbd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298783 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788750}
-
Kristi Park authored
Multiple flakes on Webkit Linux Leak (e.g. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/16692) TBR=hiroshige@chromium.org Bug: 1068175 Change-Id: Iee830b5b4c604ff4cf0527643447f389d3674a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300231Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#788749}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Change-Id: Ic1fa9cea86ab7c6106af4db2837d773aaf8dac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298859 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788748}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b0b63703..e7945d6e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id36999313702de5f83d56987884af85326c2c5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300007Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788747}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1de497cc50ab..0a8f44c514ce 2020-07-15 bclayton@google.com Regres: Collate and add new documentation for Regres If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I92e566619f9a7e5d14deb678350a73e7109bff4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788746}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bda66062b2e..1a82e68482aa 2020-07-15 treehugger-gerrit@google.com Merge "Use version script for heapprofd client API." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia0c02d196546ad0dcdfda94e76362e6e10b94592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300524Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788745}
-
Peter Wen authored
Add benchmarks to measure improvements to turbine header generation and java compilation. A change to turbine.py will re-build all headers that chrome_public_apk depends on. Similarly for compile_java.py and building all .javac.jar files. Example: $ tools/android/build_speed/benchmark.py extra_incremental Summary gn args: target_os="android" use_goma=true android_fast_local_dev=true gn gen: 6.6s turbine_headers: 43.3s avg (43.2s, 43.5s) compile_java: 60.2s avg (59.9s, 60.5s) Bug: 1092528 Change-Id: I815ea2020b054c0fc0552afb5837dc1aa670e2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300404 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#788744}
-
Francois Doray authored
This method was only used by the obsolete agent interference recorder. The "enqueue order at which we became unblocked" is still tracked internally, because it is used to compute the value of the "was_blocked_or_low_priority" argument passed to TaskObserver::WillProcessTask(). Bug: 1019856, 984057 Change-Id: Iaf7d742c7ab978eee4e105c53b28c6170642698a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297661 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788743}
-
Bin Wu authored
Change-Id: Ib6254975ed3313b1debd3e147abeec11ddfa4c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292788Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#788742}
-