GitLab

--force-device-scale-factor is kept for dev purpose.

BUG=None

Review URL: https://codereview.chromium.org/580083004

Cr-Commit-Position: refs/heads/master@{#295673}

This CL adds a UMA histogram for the amount of time taken to build the
app list.

BUG=415389

Review URL: https://codereview.chromium.org/580993003

Cr-Commit-Position: refs/heads/master@{#295672}

per the comment in apps_client.h

BUG=None
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/583583008

Cr-Commit-Position: refs/heads/master@{#295671}

Revert of Cleanup: Remove remaining generated extensions APIs on Android. (patchset #4 id:60001 of https://codereview.chromium.org/573933002/)

Reason for revert:
Android bot fails with error: gen/extensions/common/api/generated_schemas.cc: No such file or directory

Original issue's description:
> Cleanup: Remove remaining generated extensions APIs on Android.
>
> BUG=305852
>
> Committed: https://crrev.com/379f0be47f454cce5c912f25d1b3302ba679b472
> Cr-Commit-Position: refs/heads/master@{#295669}

TBR=yoz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=305852

Review URL: https://codereview.chromium.org/582933003

Cr-Commit-Position: refs/heads/master@{#295670}

BUG=305852

Review URL: https://codereview.chromium.org/573933002

Cr-Commit-Position: refs/heads/master@{#295669}

This pulls in the following Native Client changes:

r13749: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13750: (dyen) Added tests for remaining directory functions in irt_ext.
r13751: (uekawa) NonSFI mode: Make tests/common/register_set.h PIC-friendly
r13752: (uekawa) NonSFI mode: Add libcrt_platform for native/mixed linking.
r13753: (dschuff) Remove i686-hosted Linux build and start switching to new directory layout
r13754: (dschuff) export_header.py: Mangle include guards in exported headers
r13755: (bradnelson) Turning on goma on nacl bots.
r13756: (dbrazdil) Implemented the _exit() syscall in MinSFI.
r13757: (bradnelson) Disable goma on win7-32 bots because it doesn't suport that platform.
r13758: (mseaborn) Cleanup: Use NaClCopyInFromUser() in one case in mmap()
r13759: (dschuff) Update revision for PNaCl r13739->r13753

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/582213004

Cr-Commit-Position: refs/heads/master@{#295668}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b14e4a0..3c29c4d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/586593003

Cr-Commit-Position: refs/heads/master@{#295667}

BUG=415564

Review URL: https://codereview.chromium.org/586503002

Cr-Commit-Position: refs/heads/master@{#295666}

This CL is part of the refactoring of webview into extensions/, and the webview test infrastructure depends heavily on this. Webview tests will be added to extensions soon.

BUG=352290

Review URL: https://codereview.chromium.org/584513003

Cr-Commit-Position: refs/heads/master@{#295665}

ServiceWorkerContainer.unregister() is going away. This patch
updates ServiceWorkerBrowserTest.ImportsBustMemcache to use
ServiceWorkerRegistration.unregister() function.

BUG=404064

Review URL: https://codereview.chromium.org/579183002

Cr-Commit-Position: refs/heads/master@{#295664}

This CL improves the app list startup time on non-Linux platforms. A new
FontList object was being unnecessarily created on every AppListItemView
which forced recalculations of otherwise cached values.

This was most noticeable on ChromeOS where the app list is
rebuilt every time it is shown.

BUG=415389

Review URL: https://codereview.chromium.org/574983002

Cr-Commit-Position: refs/heads/master@{#295663}

The following supressions are no longer needed:
bug_293088
bug_298887
bug_299647
bug_310351
bug_312332
bug_327672
bug_329960
bug_331061
bug_333992

BUG=293088,298887,299647,310351,312332,327672,329960,331061,333992
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/583103003

Cr-Commit-Position: refs/heads/master@{#295662}

Currently if some option is selected from options menu then in that
case content view does not gain focus in operations(like prev,next ).
Added code to handle this.

BUG=414219

Review URL: https://codereview.chromium.org/573653003

Cr-Commit-Position: refs/heads/master@{#295661}

The following supressions are no longer needed:
bug_259188
bug_259303
bug_259789
bug_259799
bug_262875
bug_262934
bug_268258
bug_269201
bug_269844

BUG=259188,259303,259789,259799,262875,262934,268258,269201,269844
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/582983003

Cr-Commit-Position: refs/heads/master@{#295660}

Enumeration and iteration were passing around void**. With this CL, we
instead use an Iterator object.

R=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org
BUG=413644

Review URL: https://codereview.chromium.org/542733002

Cr-Commit-Position: refs/heads/master@{#295659}

The following supressions are no longer needed:
bug_246148
bug_246153
bug_247525a
bug_247525b
bug_247525c
bug_250533
bug_250688
bug_252209
bug_252228
bug_253797

BUG=246148,246153,247525,250533,250688,252209,252228,253797
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/587453004

Cr-Commit-Position: refs/heads/master@{#295658}

Previously, windows that have only one of maxWidth or maxHeight defined
could not be maximized by the user, but they would still snap when
dragged to the edge of the screen.

This changes WindowState::CanSnap to use CanMaximize which is false
when there is a maxWidth or maxHeight, or when the window is not
resizable.

BUG=412610, 408737

Review URL: https://codereview.chromium.org/557693002

Cr-Commit-Position: refs/heads/master@{#295657}

if some format is supported or not.IsReadbackConfigSupported
takes care of validating this.

BUG=376769, 415131

Review URL: https://codereview.chromium.org/570003002

Cr-Commit-Position: refs/heads/master@{#295656}

If user right clicks immediately on entering a bookmark button, then open the
folder without delay so that context menu appears over the folder menu.

BUG=168758
R=asvitkine@chromium.org

TEST=
1. Add a bookmark folder to Bookmarks Bar (folder1).
2. Add a subfolder (folder2) inside folder1.
3. Add few bookmarks to folder2.
4. Click on folder1 and immediately right click on folder2 and observe.
5. Context Menu should appear over the folder menu (folder contents window).

Review URL: https://codereview.chromium.org/581053002

Cr-Commit-Position: refs/heads/master@{#295655}

The following supressions are no longer needed:
bug_233541
bug_238547
bug_241044
bug_243132
bug_243753

BUG=233541,238547,241044,243132,243753
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/587563002

Cr-Commit-Position: refs/heads/master@{#295654}

Refactoring PasswordAutofillAgent::FillUserNameAndPassword for early return if password_element is not autocompleteable.

PasswordAutofillAgent::FillUserNameAndPassword function refactor done for early return as we chould check this at start only.

BUG=398436

Review URL: https://codereview.chromium.org/557703002

Cr-Commit-Position: refs/heads/master@{#295653}

Move declaration of AttachmentServiceProxyForTest's destructor to make
it clear the WeakPtrFactory is the last data member.

BUG=303818

Review URL: https://codereview.chromium.org/575383002

Cr-Commit-Position: refs/heads/master@{#295652}

and added proper history change notification on history data change.

BUG=None

Review URL: https://codereview.chromium.org/579753002

Cr-Commit-Position: refs/heads/master@{#295651}

The following supressions are no longer needed:
bug_180381
bug_184264
bug_222363
bug_222898
bug_224747
bug_225596

BUG=180381,184264,222363,222898,224747,225596
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/585783002

Cr-Commit-Position: refs/heads/master@{#295650}

The following supressions are no longer needed:
bug_170340
bug_172025
bug_173096
bug_175100
bug_175985
bug_176270

BUG=170340,172025,173096,175100,175985,176270
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/585773002

Cr-Commit-Position: refs/heads/master@{#295649}

The following supressions are no longer needed:
bug_162828
bug_164198
bug_166470
bug_166470c
bug_166470d
bug_166709
bug_166709b
bug_166709c
bug_166976a
bug_166976b

BUG=162828,164198,166470,166709,166976
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/585753002

Cr-Commit-Position: refs/heads/master@{#295648}

The following supressions are no longer needed:
bug_150995
bug_151006
bug_151007
bug_151908
bug_155404
bug_156829
bug_158514
bug_159005
bug_160877

BUG=150995,151006,151007,151908,155404,156829,158514,159005,160877
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/586603002

Cr-Commit-Position: refs/heads/master@{#295647}

It's currently hard for the AppListService to access the model. The
model is now profile keyed. However, to get the "right" profile, the
AppListViewDelegate is the current source of truth. And to get this,
AppListService needs to dig into its platform-specific parts to get it
via the platform-specific view.

However, the AppListView can be destroyed, so the delegate doesn't
always exist. Therefore the AppListViewDelegate doesn't always exist --
it is created each time the AppListView is created. On ChromeOS, this is
each time the app list is shown.

Before the model was profile-keyed, some state was tricky to store.
E.g., some is stored in ExtensionAppModelBuilder, and updated via
notifications (e.g. NOTIFICATION_APP_INSTALLED_TO_APPLIST). Also, since
the model must now outlive the AppListView for sync, it makes less sense
for the AppListViewDelegate to be owned by the view. Currently showing
the app list can create a new ALVD, which must be re-attached to the
model each time.

This change moves ownership of the AppListViewDelegate into the
AppListServiceIpml or test/shell controllers, which will create it
lazily and then cache the result.

BUG=403647, 404535

Review URL: https://codereview.chromium.org/508813002

Cr-Commit-Position: refs/heads/master@{#295646}

BUG=384041
TEST=new tests added

Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63
Cr-Commit-Position: refs/heads/master@{#295524}

Review URL: https://codereview.chromium.org/561943002

Cr-Commit-Position: refs/heads/master@{#295645}

The target_arch should be ia32 for x86 builders. This is causing the x86 try and
fyi bots to fail during runhooks because it doesnt match a case in common.gypi.

BUG=359644
TBR=cmp@chromium.org

Review URL: https://codereview.chromium.org/581173004

Cr-Commit-Position: refs/heads/master@{#295644}

R=dbeam@chromium.org
BUG=393873
TEST=./third_party/closure_compiler/bump_compiler_version

Review URL: https://codereview.chromium.org/582193002

Cr-Commit-Position: refs/heads/master@{#295643}

They were used only in tests, so change those tests to set a global state instead.

Review URL: https://codereview.chromium.org/547003002

Cr-Commit-Position: refs/heads/master@{#295642}

This changes OOP PDF to use BrowserPlugin which allows it to be loaded without
navigating to the extension page.

BUG=303491

Review URL: https://codereview.chromium.org/582583002

Cr-Commit-Position: refs/heads/master@{#295641}

BUG=408765
TEST=back-to-back requests don't bypass the cache lock.

Review URL: https://codereview.chromium.org/579393002

Cr-Commit-Position: refs/heads/master@{#295640}

BUG=318404,320774
R=newt@chromium.org

Review URL: https://codereview.chromium.org/582303002

Cr-Commit-Position: refs/heads/master@{#295639}

* Previous behavior is to cancel only one item.
* After Issue 400636, this behavior doesn't make sense because only the
  number is decreased.

BUG=414610
TEST=manually
1. Copy the file from Download to Drive.
2. Push the button in syncing status.
3. Confirm all jobs are canceled.

Review URL: https://codereview.chromium.org/576063002

Cr-Commit-Position: refs/heads/master@{#295638}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Review URL: https://codereview.chromium.org/559423003

Cr-Commit-Position: refs/heads/master@{#295637}

This is breaking after r295514 which enforces that every file listed in an isolate file exists.

BUG=414808
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/587503002

Cr-Commit-Position: refs/heads/master@{#295636}

In order to contain the newer timing information, net::LoadTimingInfo::ServiceWorkerTiming is defined and contained in net::LoadTimingInfo. Of course this struct is widely used, so is this okey? or is there some another solution?

1st patch: https://codereview.chromium.org/515583005/

BUG=401389
TEST=N/A

Review URL: https://codereview.chromium.org/515753003

Cr-Commit-Position: refs/heads/master@{#295635}

This allows us to read MSRs on Windows Vista+.
Also move ReadMsr into PlatformBackend.

BUG=336558
TEST=tools/telemetry/run_tests msr

Review URL: https://codereview.chromium.org/578123002

Cr-Commit-Position: refs/heads/master@{#295634}