- 10 May, 2018 40 commits
 - 
- 
Peter Wen authored
Includes documentation for recent changes for native editing, fast by default, and channel support. Bug: 620034 Change-Id: Ie6570a4c032853a4bfdfd3443091ea7f698e8e99 Reviewed-on: https://chromium-review.googlesource.com/1054333 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#557653}
 - 
https://chromium.googlesource.com/angle/angle.git/+log/a932b6b51505..6110763fec16 $ git log a932b6b51..6110763fe --date=short --no-merges --format='%ad %ae %s' 2018-05-09 geofflang Refactor the GL surfaces and framebuffers to not hold renderer objects. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I772f5370dc65670e539cc2d256fbfc094c1fba0d Reviewed-on: https://chromium-review.googlesource.com/1053792Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557652}
 - 
Eric Karl authored
This reverts commit 7241f600. Reason for revert: These flakes are addressed with https://chromium.googlesource.com/chromium/src.git/+/044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659 Original change's description: > Disable flaky testControlsVisibleAfterExitingVr_WebXr. > > Disable org.chromium.chrome.browser.vr_shell.WebVrTransitionTest > testControlsVisibleAfterExitingVr_WebXr, because it is flaky. > > TBR=bsheedy@chromium.org > > Bug: 841103 > Change-Id: I55651a634cfd81b43fd3668660cc3d59eda008a1 > Reviewed-on: https://chromium-review.googlesource.com/1052012 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557181} TBR=bsheedy@chromium.org,vitaliii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 841103 Change-Id: I6c99f796ec56a02dbd448d0571832348bcd83d6f Reviewed-on: https://chromium-review.googlesource.com/1054349Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557651}
 - 
Toni Barzic authored
Leaving tablet mode on lid state changes is a workaround for the lid being erroneously detected as fully open at small lid angles, which could cause the device to be detected as in tablet mode while opening the lid. This workaround should not override tablet mode state if tablet mode switch is on - this is a reliable indicator that the device actually is in tablet mode. Overriding this state could be problematic on detachable devices if the keyboard is detached while the lid is closed. In that case, the device could report lid as open after entering the tablet mode, and subsequently, and unexpectedly leave the tablet mode. BUG=b/79327284 Change-Id: I31f2d31182122fc8a6a73e185360858e035118fe Reviewed-on: https://chromium-review.googlesource.com/1054370Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#557650}
 - 
Carlos IL authored
Renamed SSLErrorTabHelper to SecurityInterstitialTabHelper and moved it into components. Currently that TabHelper is only used for committed SSL interstitials, but the plan is to reuse it for safe browsing committed interstitials, hence the rename. Its unit tests were also modified to not depend on //chrome code. Change-Id: Iaede7d9e5075dcaa6fd2ff929563e59068bac079 Reviewed-on: https://chromium-review.googlesource.com/1053120 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#557649}
 - 
Nektarios Paisios authored
Cause behind P1 bug that prevented NVDA to read spin controls, i.e. <input type="number">. Broke NVDA, was not used by ChromeVox and Select to Speak, wasn't needed by VoiceOver and also doesn't work on Safari either. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 730965 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic59229d286bf1b0992253408a77730d662bc2876 Tested: Manually Reviewed-on: https://chromium-review.googlesource.com/1044709Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#557648}
 - 
https://pdfium.googlesource.com/pdfium.git/+log/95061379c945..80302c77a854 $ git log 95061379c..80302c77a --date=short --no-merges --format='%ad %ae %s' 2018-05-10 rharrison Use test_dir instead of 'pdfium' for source type 2018-05-10 thestig Add CPDF_Transparency. 2018-05-10 thestig Make GetTestDataDir() work in a non-standalone checkout. 2018-05-10 tsepez Fix destruction order in CPDF_Dibsource. 2018-05-10 npm Remove a completeness check from CJBig2_GRRDProc::DecodeTemplate0Opt Created with: roll-dep src/third_party/pdfium BUG=chromium:841513,chromium:840695,chromium:841200 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I579c4a7663af521bb842f5e0f309f2bcd71732f3 Reviewed-on: https://chromium-review.googlesource.com/1054263Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557647}
 - 
Jialiu Lin authored
This CL doesn't change existing behavior, but only refactor HashPasswordManager class such that it can keep track of multiple password hashes. This CL introduces a new struct PasswordHashData to replace SyncPassswordData. Migration from SyncPasswordData to PasswordHashData is in place so that we'll not lose already captured sync password. IsSyncPasswordHashSaved histogram enum is added to track this migration. SyncPasswordData will be deprecated after the transition period. Bug: 830998 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I50b52adcd1cf14a6bfddc74838019f3c7d287a99 TBR=jochen@chromium.org Change-Id: I50b52adcd1cf14a6bfddc74838019f3c7d287a99 Reviewed-on: https://chromium-review.googlesource.com/1036464 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#557646}
 - 
Dale Curtis authored
We shouldn't be crashing if a user attempts to put h264 content in a developer build that doesn't support proprietary codecs; we should instead just fail gracefully during decode. BUG=b/63115808 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2fc1321453a2ae160b86a379a724b7acefe3b45d Reviewed-on: https://chromium-review.googlesource.com/1054328Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#557645}
 - 
Victor Costan authored
BackgroundSyncContext's members background_sync_manager_ and services_ are documented to only be accessed on the IO thread. However, the BackgroundSyncContext destructor accesses them when running their destructors, even though it may be run on any thread (BackgroundSyncContext is RefCountedThreadSafe). These accesses are not threadsafe. This CL solves the thread safety issues by having the class' destructor run on the IO thread. Change-Id: Ib40c94987ee7cdfc58d513561493d4c8155b4b2d Reviewed-on: https://chromium-review.googlesource.com/1053404 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557644}
 - 
Caleb Rouleau authored
For desktop, have Chrome allocate the remote port itself by passing 0. For Android, have the adb_server allocate the port forwarding port itself by passing 0. Bug: chromedriver:2161, chromedriver:2400 Change-Id: I2eccc2979c116ca47909bb84b8c81c5fb5c4cd75 Reviewed-on: https://chromium-review.googlesource.com/994378Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#557643}
 - 
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0675e8b8e369..f24714c46c60 $ git log 0675e8b8e..f24714c46 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 perezju [soundwave] Implement --continue for timeseries 2018-05-09 benjhayden [dashboard] Add Google Surveys to alerts, report, group_report, speed_releasing. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I2adf1095944176286a4d0d995f58e6e84442a757 Reviewed-on: https://chromium-review.googlesource.com/1054250 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557642}
 - 
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9c5f77a1..98ce1809 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I839cccd9608412932a225ac6e96c0a4f2918fe1d Reviewed-on: https://chromium-review.googlesource.com/1053874Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#557641}
 - 
Katie D authored
Also registers the tts_handler to receive OnVoicesChanged callbacks from the TTS controller, so that when the settings page is first loaded, voices are populated properly. Bug: 839624 Change-Id: I7685a2f2341f84373b449ae453dee3d1fb8d8494 Reviewed-on: https://chromium-review.googlesource.com/1053114Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#557640}
 - 
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d31b2f674acc..024615e9752d $ git log d31b2f674..024615e97 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 egdaniel Revert "Add driver bug workarounds to GrCaps" 2018-05-10 egdaniel Revert "Driver bug workaround: disable_blend_equation_advanced" 2018-05-10 egdaniel Revert "Driver bug workaround: disable_discard_framebuffer" 2018-05-10 fmalita [skottie] Clean up AttachLayerContext 2018-05-10 enne Driver bug workaround: disable_discard_framebuffer 2018-05-10 mtklein rm SkColorSpace_New 2018-05-10 angle-skia-autoroll Roll third_party/externals/angle2/ a932b6b51..6110763fe (1 commit) 2018-05-08 enne Driver bug workaround: disable_blend_equation_advanced 2018-05-09 benjaminwagner Switch machine-type for Coverage tasks. 2018-05-10 reed use 64bit math in TArray realloc 2018-05-10 fmalita [skottie] Allow divide-by-zero in PolyStarAdapter::apply 2018-05-10 reed allow divide by zero 2018-05-10 fmalita Validate readByteArrayAsData size 2018-05-07 enne Add driver bug workarounds to GrCaps 2018-05-03 egdaniel Remove GrBackendObject and all related functions from Skia. 2018-05-10 fmalita Validate gradient DescriptorScope size during deserialization 2018-05-10 bsalomon Revert "Revert "Don't use GrRRectBlurEffect for large rects when highp is not full float"" 2018-05-03 egdaniel Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter. 2018-05-09 bungeman Add all SkPaint::Flags to Viewer app. 2018-05-09 robertphillips Fix clipping of SkMatrixImageFilter input (take 2) Created with: roll-dep src/third_party/skia BUG=chromium: 829614,chromium: 829614,chromium: 829614,chromium: 829614,chromium: 829614,chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I10d8ab894715912522758a757c4aa084f63e49e9 Reviewed-on: https://chromium-review.googlesource.com/1054215 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557639}
 - 
Daniel Murphy authored
TBR: steimel@chromium.org Bug: 841922 Change-Id: I5e79703e97153a4cd4d2346554901f24c895d334 Reviewed-on: https://chromium-review.googlesource.com/1054418Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#557638}
 - 
chrome://reset-passwordJialiu Lin authored
This CL shows chrome://reset-password upon password reuse in enterprise settings. When user clicks "Reset Password" button, it takes them to the change password page configured by admin or the default myaccount.google.com page. reset_password.mojom is added to handle change password event on chrome://reset-password page. Minor debugging in the html file. TBR = sdefresne@chromium.org Bug: 824501 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I10b9b61ed675c82cd80ffb88f15b76722073a57f Reviewed-on: https://chromium-review.googlesource.com/1050438 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#557637}
 - 
Pete Williamson authored
Ensures that test bots cover OfflinePagesSharing flag scenarios. Bug: 758733 Change-Id: Id73eebc0e9592318ed4d33b95dc169574bc0efc3 Reviewed-on: https://chromium-review.googlesource.com/1043349Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#557636}
 - 
Nick Harper authored
Too many places throughout the codebase assumed that an URLRequestContext would have a (non-null) ChannelIDService. When the base::Feature kChannelID is disabled, this results in a null ChannelIDService on the URLRequestContext, and results in crashes due to null derefs. Bug: 841730, 841685 Change-Id: Iece0f584d7c05e90ea16da2ea9319b66768ded33 Reviewed-on: https://chromium-review.googlesource.com/1054177Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#557635}
 - 
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d3f2c8e78346..e877b1776a14 $ git log d3f2c8e78..e877b1776 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 ehmaldonado gclient: Get rid of parsed_url. Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7130ec104ca053af5aa4be065bdfc0a0aa5c9315 Reviewed-on: https://chromium-review.googlesource.com/1054172 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557634}
 - 
Ned Nguyen authored
TBR=eyaich@chromium.org NOTRY=true # test covered by PRESUBMIT Bug: 840894,836446 Change-Id: Ie3c81037287b67781f39b058eb5303f17ed896d9 Reviewed-on: https://chromium-review.googlesource.com/1054412Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#557633}
 - 
David Grogan authored
New passes fast/writing-mode/table-hit-test.html and tables/mozilla_expected_failures/marvin* had been failing in LayoutNG because the captions were not centered above the table, for some reason. The rebased test fast/table/multiple-captions-display-expected.png failed due to differences on the edges of text inside the caption. New failure accessibility/table-caption.html fails because the js accessibility controller can no longer see the caption as a table child, for some reason. Making tables/mozilla_expected_failures/bugs/bug3166-16.html pass will need some digging. Legacy and NG before this patch centered the caption above the table. But after this patch, it is moved left. Further, hovering over the caption triggers a DCHECK in the hit testing stack, so maybe we need to set an offset after all. ng_physical_fragment.h(144)] Check failed: is_placed_. blink::NGPhysicalFragment::Offset() blink::NGPaintFragment::Offset() blink::NGBoxFragmentPainter::NodeAtPoint() blink::NGBlockFlowPainter::NodeAtPoint() blink::LayoutNGMixin<>::NodeAtPoint() blink::LayoutTable::NodeAtPoint() Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7fcb33e791a9f0d812674a5f7f63cb5964c02a6e Reviewed-on: https://chromium-review.googlesource.com/1050414 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#557632}
 - 
Theresa authored
BUG=833873 Change-Id: I3f00d9258e7b2167c0cadaa41fed2506409b9496 Reviewed-on: https://chromium-review.googlesource.com/1053794Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#557631}
 - 
mrefaat authored
It's more appropriate as the tabhelper handle urls not links. Bug: 841615 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f852766712545574a1d07eeaa21e871f064a97a Reviewed-on: https://chromium-review.googlesource.com/1053359 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#557630}
 - 
Matt Menke authored
Bug: 837776 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5adf6cbed89f755e7e25c3efdf326aab1c472d67 Reviewed-on: https://chromium-review.googlesource.com/1045365Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#557629}
 - 
Abhishek Arya authored
- Add test_suite.txt here to make it easily configurable. - Move styles in static dir. R=mmoroz@chromium.org,liaoyuke@chromium.org Change-Id: I8284b6f0ea225e8d0e937686fbc3f6b369b5e2b7 Reviewed-on: https://chromium-review.googlesource.com/1054386Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557628}
 - 
Pavol Marko authored
Add support for the forced initial enrollment check in AutoEnrollmentClient. This check uses a different identifier set, 8 byte hashes and a different message for the state download. The differences are abstracted by using two virtual classes with different implementations for FRE/initial enrollment checks: DeviceIdentifierProvider specifies the identifier set and hashes, and StateDownloadMessageProcessor understands fills state download requests and parses state download responses. Bug: 839353 Test: unit_tests --gtest_filter=*AutoEnrollmentClientTest* Change-Id: I83d041f568d84c42b9b8cf00a1e44955f9d5abe3 Reviewed-on: https://chromium-review.googlesource.com/1049929 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#557627}
 - 
Matthew Jones authored
Overtriggering of the peek-to-half event would cause the scrim to disappear when the device was rotated. This patch checks that the sheet state is <= hidden (as opposed to just <) when blocking the event's trigger. As an added precaution, the listener that sets the scrim alpha has an added check for whether the sheet is open. Bug: 840265 Change-Id: Ic3e0731be3525959898159e0610b3c49b9a04fa4 Reviewed-on: https://chromium-review.googlesource.com/1054210Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#557626}
 - 
John Rummell authored
Now that AesDecryptor supports 'cbcs' decryption, update the Clear Key CDM to do the same. BUG=658026,835009 TEST=modified browser_test passes Change-Id: Ie138d4b638d5d6493cb89368171adae5660486da Reviewed-on: https://chromium-review.googlesource.com/1053172Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#557625}
 - 
David Benjamin authored
CertDatabase is just a giant singleton observer list at this point, except for the Mac code which internally registers some notifier. Since URLRequestContext no longer assumes the platform verifier at this point, the Right Way to do this would probably be for CertVerifier to have an observer and, separately, for there to be an external way to tell a URLRequestContext to drop all client certificate identities. But, to start with, trim a bunch of unnecessarily duplicated code. Change-Id: I11b15b10a0eb4da0f528581da1c57dad9ebbc30d Reviewed-on: https://chromium-review.googlesource.com/619929 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557624}
 - 
Michael Thiessen authored
Bug: 841850 Change-Id: I0249210c8fe387a3732715be2650ce9aea5af800 Reviewed-on: https://chromium-review.googlesource.com/1054211Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#557623}
 - 
Mark Pearson authored
This enables the flag by default on Android. Bug: 787940 Change-Id: I550d6d22d629c0bcb62dacefaf32b5d8b24ced57 Reviewed-on: https://chromium-review.googlesource.com/1054170Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#557622}
 - 
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib317cffef2c44e2fa29cca1f8a62664e4c90b7c8 Reviewed-on: https://chromium-review.googlesource.com/1054260Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557621}
 - 
Xi Han authored
This CL is a precursor CL for https://crrev.com/c/969098. It simply contains a file renaming to keep log history: 1. content_main_runner.cc rename to content_main_runner_impl.cc 2. browser_main_runner.cc rename to browser_main_runner_impl.cc It allows to introduce content_main_runner_impl.h and browser_main_runner_impl.h which contain new methods without changing their interface in /content/public. Bug: 740677 Change-Id: I4e42bb594d65888b4358ac843b13837be26a5b7e Reviewed-on: https://chromium-review.googlesource.com/1042456 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#557620}
 - 
Reza.Zakerinasab authored
This change adds color management to ImageBitmapRenderingContext. Bug: 782383, 785389, 796226 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I653bc2e5d3a32f5211bd09c80ee35b6f4df6ad92 Reviewed-on: https://chromium-review.googlesource.com/973801Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557619}
 - 
Daniel Murphy authored
Bug: 840949 Change-Id: Ied53a2d1cccb0a0c474d8b9cfb76bad1a8d83987 Reviewed-on: https://chromium-review.googlesource.com/1050581 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#557618}
 - 
Changwan Ryu authored
This reverts commit e9c5bc10. Reason for revert: caused crbug.com/841489 Original change's description: > Don't show text selection popup menu if current selected text is cleared. > > If text selection clear action is just after selecting all text action in editable input box, > then the state of text selection in renderer is not correct, which causes the selection popup > menu will be incorrectly shown. > Fix this issue by checking selection state before popup text selection menu. > > Bug: 817712 > > Change-Id: I4dcda47d5f0fe5f20febc2e1def30574c6060724 > Reviewed-on: https://chromium-review.googlesource.com/940290 > Commit-Queue: Antoine Labour <piman@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Pedro Amaral <amaralp@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555099} TBR=boliu@chromium.org,haraken@chromium.org,changwan@chromium.org,piman@chromium.org,amaralp@chromium.org,zuojinglong@xiaomi.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 817712 Change-Id: I97f01cd58f23939066a2179a819d20534a60123f Reviewed-on: https://chromium-review.googlesource.com/1054112Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557617}
 - 
Dave Schuyler authored
This Cl removes the text_height parameter from the match cell ctor as suggested in https://chromium-review.googlesource.com/c/chromium/src/+/1048865 It further removes other unnecessary passing of text_height or font_list parameters. Bug: None Change-Id: Ifd6eaf9b113d09ff2e18b7e780ad50887e78e850 Reviewed-on: https://chromium-review.googlesource.com/1050869Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#557616}
 - 
Marijn Kruisselbrink authored
This is a reland of 6a1c56b9 Original change's description: > Get rid of FrameMsg_PostMessage_Params.is_data_raw_string. > > Instead use the helper method we already have to just convert a raw > string to a serialized string value encoded byte array on the browser > side. This gets rid of some special casing and possible confusion in > this codepath. > > Does requre moving string_message_codec to some non-android specific > location (even though this code is only really used on android), and for > that blink/common seemed like a sensible place. > > Bug: none > Change-Id: I4ebc70cb68a1c12ad57d3949a1ac606392f7c908 > Reviewed-on: https://chromium-review.googlesource.com/1053169 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557363} Tbr: kinuko@chromium.org Bug: none Change-Id: I75fafccb7c4c49c1729a3a6709e51874ba82da78 Reviewed-on: https://chromium-review.googlesource.com/1053068Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#557615}
 - 
Ian Kilpatrick authored
There should be no behaviour change in this patch. This introduces the "line layout opportunity concept" which has: - A line size. - A float line size. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib8667a7c0909116da8e89cb2e20d9df66a2c401d Reviewed-on: https://chromium-review.googlesource.com/1035617Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#557614}
 
 -