GitLab

BUG=523165

Review URL: https://codereview.chromium.org/1304943002

git-svn-id: svn://svn.chromium.org/blink/trunk@201009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/1308563002

git-svn-id: svn://svn.chromium.org/blink/trunk@201008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Background:
To disable scrolling (and pinch-zoom) during <video>-
fullscreen ScrollingCoordinator makes both viewports
unscrollable in updateAfterCompositingChangeIfNeeded().

Problem:
Currently only the outer viewport's scrollability-
setting is tested during fullscreen-video.

Solution:
Extend test case to also verify the inner viewport.

BUG=448738

Review URL: https://codereview.chromium.org/1287253005

git-svn-id: svn://svn.chromium.org/blink/trunk@201007 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, remove android's resource-request-callbacks-expected.txt,
which I missed when deleting the test in https://codereview.chromium.org/1288323006/

BUG=523091

Review URL: https://codereview.chromium.org/1309893002

git-svn-id: svn://svn.chromium.org/blink/trunk@201006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=514651
NOTRY=true

Review URL: https://codereview.chromium.org/1309593003

git-svn-id: svn://svn.chromium.org/blink/trunk@201005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1. Truncate trailing zeroes in doubles.
2. Ignore negative values in paddings.

BUG=501896

Review URL: https://codereview.chromium.org/1307813002

git-svn-id: svn://svn.chromium.org/blink/trunk@201004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To implement FOUC tests we need to be able to control both the
didReceiveData and the didFinishLoading callbacks to have precise
control over when resources finish loading.

This patch expands the interface of WebURLLoaderTestDelegate to delegate
all the steps called in WebURLLoaderMock::ServeAsynchronousRequest. It
also provides a default implementation of each one so tests don't need to
add each proxy method. It also allows this patch to avoid being multiple
steps to handle the Chromium changes.

The next patch in Chromium will update ServeAsynchronousRequest
to use the new methods.

BUG=521692
R=pdr@chromium.org

Review URL: https://codereview.chromium.org/1303953003

git-svn-id: svn://svn.chromium.org/blink/trunk@201003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously because one table cell may paint its collapsed borders
multiple times, we enclose all collapsed border drawings in a
ScopeRecorder.

However, actually a table cell paints each border only once. When it
paint collapsed borders multiple times, it just paint different borders
in different time.

Use display item type to distinguish the different borders to avoid
the ScopeRecorder.

Also revert https://codereview.chromium.org/1234463005 to invalidate
table cells with changed collapsed borders.

BUG=510492

Review URL: https://codereview.chromium.org/1306433002

git-svn-id: svn://svn.chromium.org/blink/trunk@201002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353746
TBR=
NOTRY=true

Review URL: https://codereview.chromium.org/1309903002

git-svn-id: svn://svn.chromium.org/blink/trunk@201001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up to https://codereview.chromium.org/1291613010/ where
I forgot to implement the referrerpolicy attribute for img tags as a
runtime-enabled feature.

BUG=490608

Review URL: https://codereview.chromium.org/1302403005

git-svn-id: svn://svn.chromium.org/blink/trunk@201000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After discussions w/ Moz and spec updates, modify the experimental
(behind a flag) IDBObjectStore/IDBIndex getAll()/getAllKeys() methods
to treat 0 the same as "not passed", and return as many results as
possible.

Also adds missing tests for IDBObjectStore.getAllKeys() and tweaks
the tests to avoid the deprecated assert_object_equals() function.

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/1303983002

git-svn-id: svn://svn.chromium.org/blink/trunk@200999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In web-platform-tests there's a move away from the generic (and
fragile, buggy) assert_object_equals(). Upstream, the cache storage
tests moved to dedicated assert_response_equals() (and friends);
mirror that in Blink.

R=jkarlin@chromium.org

Review URL: https://codereview.chromium.org/1295633003

git-svn-id: svn://svn.chromium.org/blink/trunk@200998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduce {next,previous}PositionOf() as replacement of {next,previous}() member functions in PositionAlgorithm

This patch introduces |{next,previous}PositionOf()| as replacement of
|{next, previous}()| member function in |PositionAlgorithm| template class
to simplify |PositionAlgorithm| class by isolating editing algorithm and
representation of a position for improving code health.

This patch also changes |PositionMoveType| as enum class and non-default
parameter to clear intention of each call sites. Though, we may want to drop
|CodePoint| movement.

Following patch will move them to "EditingUtilities.{cpp,h}".

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1305963003

git-svn-id: svn://svn.chromium.org/blink/trunk@200997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1309653002

git-svn-id: svn://svn.chromium.org/blink/trunk@200996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds support to the fetch() API for the integrity attribute, both
the setting of the attribute and the actual SRI enforcement.

For the regular integrity attribute on elements, this leaves in place
the checking of SRI in the Script element and Style element execution,
rather than integrating it more fully into the Resource Loader because
of technical complications. This may be worth doing in the future, but
will require some significant redesign of how Resource objects are
returned from the Memory Cache in ResourceFetcher::requestScript.

BUG=502361

Review URL: https://codereview.chromium.org/1279163005

git-svn-id: svn://svn.chromium.org/blink/trunk@200995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL implements the shadow tree cascade order proposed in [1].

Previously, in Blink, specificity would win over scope origin, even if the
scopes had an inner/outer scope relationship, and the order-of-appearance
was governed by the CascadeOrder type. Also, !important rules did not
apply in the reverse scope order, as the current spec says for inner/outer
scopes, and the proposal in [1] says apply between all shadow scopes.

What has been done is:

1. CascadeOrder is not used, as it represents order-of-appearance
   (Removal of CascadeOrder is not done here to make the CL smaller. Will
   be removed in a follow-up CL).

2. When collecting rules, sort after each scope instead of just after UA
   and Author since we had:

   UA important
   Author important
   Author
   UA

   and now we have (with A(n) appearing before A(n+1) in the tree-of-trees
   order):

   UA important
   Author scope A(n) important
   ...
   Author scope A(1) important
   Author scope A(1)
   ...
   Author scope A(n)
   UA

   The applyProperties code is hot, and I have made performance runs for
   the micro-benchmarks in Layout and CSS without consistent regressions.

3. Since the cascading order between scopes are just the inner/outer
   relationship in the composed tree (direction decided by !important),
   which is the same as the tree-of-trees order of the shadow trees,
   we can just traverse the DocumentOrderedList of scopes in the reverse
   order instead of doing calculation tricks for CascadeOrder values.

   Because of this, TreeBoundaryCrossingRules is now reduced to a
   DocumentOrderedList of scoping nodes, so the TreeBoundaryCrossingRules
   class is removed.

[1] https://lists.w3.org/Archives/Public/www-style/2015Jun/0303.html

BUG=452542, 455148, 487125

NOTRY=true

Review URL: https://codereview.chromium.org/1298173004

git-svn-id: svn://svn.chromium.org/blink/trunk@200994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=523403
NOTRY=true
TBR=eae

Review URL: https://codereview.chromium.org/1303363002

git-svn-id: svn://svn.chromium.org/blink/trunk@200993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Initial implementation of the requestIdleCallback API based on
the spec at https://w3c.github.io/requestidlecallback/.

This API is behind a flag and is not enabled by default.

BUG=514651
TBR=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1119683003

git-svn-id: svn://svn.chromium.org/blink/trunk@200992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896
NOTRY=true

Review URL: https://codereview.chromium.org/1310433002

git-svn-id: svn://svn.chromium.org/blink/trunk@200991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a race condition where both the main thread and the V8 background
parsing thread call fetchDataFromResourceBuffer. The current lock makes sure
only one thread will fetch data from teh resourceBuffer at a time, and the
queue they put it in is natively thread safe, but - if threads race in just
the right way - the order might be reversed.

Example:
- thread 1 acquires lock, fetches data from resource buffer.
- thread 1 gets interruped; new data arrives in the resource buffer.
- thread 2 acquires lock, fetches data from resource buffer
- thread 2 adds its chunks to the data queue
- thread 1 adds its chunks to the data queue
-> the chunks are now queued in the wrong order.

BUG=510825

Review URL: https://codereview.chromium.org/1286883004

git-svn-id: svn://svn.chromium.org/blink/trunk@200990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Provided interface in ChunkDemuxer/WebSourceBuffer to allow blink to
invoke "3.5.12 Coded Frame Eviction Algorithm"
https://w3c.github.io/media-source/#sourcebuffer-coded-frame-eviction

This allows us to detect when buffer is full, even after GC
and throw QuotaExceededErr exception as MSE spec prescribes.
See step #6 in section 3.5.4 at
https://w3c.github.io/media-source/#sourcebuffer-prepare-append
Related Chromium CL: https://codereview.chromium.org/1008463002/

BUG=421694

Review URL: https://codereview.chromium.org/1013923002

git-svn-id: svn://svn.chromium.org/blink/trunk@200989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1306003002

git-svn-id: svn://svn.chromium.org/blink/trunk@200988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 * Sync step documentation ('line position' -> 'line' and similar.)
 * Remove remnants of 'best position' and re-number steps.
 * Implement new cue dodging logic.

BUG=301580

Review URL: https://codereview.chromium.org/1306833003

git-svn-id: svn://svn.chromium.org/blink/trunk@200987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This disallows getUserMedia() from being used on insecure origins. Adds
a console warning message that the API call has failed because of this.

BUG=520765

Review URL: https://codereview.chromium.org/1284193003

git-svn-id: svn://svn.chromium.org/blink/trunk@200986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1304183003

git-svn-id: svn://svn.chromium.org/blink/trunk@200985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We normally use RELEASE_ASSERT for checking !isScriptForbbiden() because executing
a script in places where script execution is not allowed can lead to security issues.

Review URL: https://codereview.chromium.org/1304103002

git-svn-id: svn://svn.chromium.org/blink/trunk@200984 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This bot is new and has a lot of flakiness that needs
digging into. These were generated from
webkit-patch print-flaky-tests.

BUG=521764
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/1302373002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1304623002

git-svn-id: svn://svn.chromium.org/blink/trunk@200982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |inRenderedText()| to "VisibleUnits.cpp" from "Position.cpp"
to simplify "Position.cpp" for improving code health since it is used only in
"VisibleUnits.cpp"

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1309673002

git-svn-id: svn://svn.chromium.org/blink/trunk@200981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a regression from Blink r199364 where credentials are not
sent for same-origin webfont requests. This patch basically does the
same thing as HTMLImportsController::load(); set AllowStoredCredentials
flag only when the request is same-origin.

BUG=516192
TEST=http/tests/webfont/same-origin-credentials.html

Review URL: https://codereview.chromium.org/1267023004

git-svn-id: svn://svn.chromium.org/blink/trunk@200980 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1304043002

git-svn-id: svn://svn.chromium.org/blink/trunk@200979 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of [Editing][Codehealth] Replace Position::uptream/downstream to mostBackward/ForwardCaretPosition. (patchset #1 id:1 of https://codereview.chromium.org/1306743002/ )

Reason for revert:
This patch misused each other.
See:
 https://codereview.chromium.org/1310433004/

Original issue's description:
> [Editing][Codehealth] Replace Position::uptream/downstream to 
> mostBackward/ForwardCaretPosition
> 
> Position::upstream calls just VisibleUnit.cpp::mostForwardCaretPosition and also 
> downstream:
> https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/c
> ore/editing/Position.cpp&l=484&cl=GROK
> 
> This CL replaces it.
> We will replace all upstream/downstream and remove them.
> 
> BUG=518738
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200977

TBR=yosin@chromium.org,tkent@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518738

Review URL: https://codereview.chromium.org/1304133002

git-svn-id: svn://svn.chromium.org/blink/trunk@200978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

mostBackward/ForwardCaretPosition

Position::upstream calls just VisibleUnit.cpp::mostForwardCaretPosition and also 
downstream:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/c
ore/editing/Position.cpp&l=484&cl=GROK

This CL replaces it.
We will replace all upstream/downstream and remove them.

BUG=518738

Review URL: https://codereview.chromium.org/1306743002

git-svn-id: svn://svn.chromium.org/blink/trunk@200977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

mostForwardCaretPosition returns a most backward position and
mostBakwardCaretPosition returns a most forward position.
This is opposite meaning each other.

This CL fixes that.

BUG=518738

Review URL: https://codereview.chromium.org/1310433004

git-svn-id: svn://svn.chromium.org/blink/trunk@200976 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The WTF_PRETTY_FUNCTION takes the name of the class using the typename
given by the compiler. This gives the base class name for all
sub-classes. To make the dump name unique the, gcInfoIndex is appended
to the object name.

BUG=521490

Review URL: https://codereview.chromium.org/1303693005

git-svn-id: svn://svn.chromium.org/blink/trunk@200975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is partial revert of https://codereview.chromium.org/1060033002.

This CL unships Request.context because it was removed from the spec:
https://github.com/whatwg/fetch/issues/93

This CL
- removes Response.context from Request.idl, and
- updated/removed related Layout tests.

Underlying implementation is left unchanged to be reused for Response.type.

BUG=515786

Review URL: https://codereview.chromium.org/1292503002

git-svn-id: svn://svn.chromium.org/blink/trunk@200974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch by Jan Olaf Krems
https://gist.github.com/jkrems/5f08ab53c05d96356a1e

BUG=523124

Review URL: https://codereview.chromium.org/1303073002

git-svn-id: svn://svn.chromium.org/blink/trunk@200973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes a raw pointer in MainThreadTaskRunner.

BUG=509911
R=haraken@chromium.org, keishi@chromium.org, oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/1296243004

git-svn-id: svn://svn.chromium.org/blink/trunk@200972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |isVisuallyEquivalentCandidate()| to "VisibleUnits.{cpp,h} from
"Position.{cpp,h}" to consolidate |InlineBox| dependency to "VisibleUnits.cpp"
for ease of working them later.

This patch also gets rid of unused include directives from "Position.cpp".

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1304063002

git-svn-id: svn://svn.chromium.org/blink/trunk@200971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |computeInlineBoxPosition()| to "VisibleUnits.{cpp,h} from
"Position.{cpp,h}" and "VisiblePosition.{cpp,h}" to consolidate |InlineBox|
dependency to "VisibleUnits.cpp" for ease of working them later.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1303173002

git-svn-id: svn://svn.chromium.org/blink/trunk@200970 bbb929c8-8fbe-4397-9dbb-9b2b20218538