- 14 Aug, 2020 40 commits
-
-
Yicheng Li authored
Similar to IsWinNativeApiAuthenticator() and IsTouchIdAuthenticator(), add IsChromeOSAuthenticator() which is only compiled on ChromeOS. Bug: crbug:1115811, b:144861739 Change-Id: I80b88392e1c9edf501709ced7709db889370774b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357954 Commit-Queue: Yicheng Li <yichengli@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#798346}
-
Scott Violet authored
This makes it so icons there were downloaded more than 30 days ago are removed. This is done to prevent the database from indefinitely growing. BUG=1076463 TEST=covered by tests Change-Id: I9df9407124dd9364517bd31949ecf718fd7a9bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356050 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#798345}
-
Ben Blake authored
This change further implements the functionality of AutofillOfferManager. AutofillManager now accesses a singleton AutofillOfferManager via the AutofillOfferManagerFactory. AutofillOfferManager then prepares a request which is sent to the PaymentsClient to retrieve offer data. In further CLs, the data retrieved during these calls will stored and used. Change-Id: I384c95f26b9b3094d9b3387d467134ef5998396e Bug: 1093057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258154 Commit-Queue: Ben Blake <fiorito@google.com> Reviewed-by:
Anne Lim <annelim@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#798344}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 19c29702. With Chromium commits locally applied on WPT: c71b9857 "Portals: Prevent closing of the portal window." f99cd179 "[blink][wpt] Add more module evaluation order tests" c4e342f7 "[COOP] access reporting: use camelCase for attributes." e3ef31f6 "Fix typo s/Remove/Remote/." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I649ca9a9bc71719fbffe1a7300a04f4a5cbcfa4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357149Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798343}
-
Lei Zhang authored
This test occasionally triggers a fatal failure in DataDecoder::GetService(). Bug: 1115762 Change-Id: I12a46b8ac2f9e3805269e3c4fef3985e0e961147 Tbr: khmel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357617Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798342}
-
Alexander Cooper authored
testNonImmersiveStopsDuringImmersive is flaky because we receive a non- immersive rAF callback, while there is an immersive session. https://crrev.com/c/2354537 ensured that the frame loop will not be started back until the page has been notified that the session ends, but it is possible that a non-immersive frame has been scheduled already when the session returns. This change speculatively patches the test by allowing at most one frame to be received during an immersive session. If this removes the flakiness, a more thorough product fix will be investigated. Bug: 1116261 Change-Id: I11d8b06c2a9c80503c30a687da97922ef3a04c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355014 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#798341}
-
Anne Lim authored
Screenshot with feature enabled: https://screenshot.googleplex.com/tWdvKkwxU8G RTL Screenshot with feature enabled: https://screenshot.googleplex.com/QS1n2b9ytxr Screenshot with feature disabled: https://screenshot.googleplex.com/jtp4wPe9Ng1 Change-Id: I56896520e26fe877584850d37a1e3095317910dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327835Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Siddharth Shah <siashah@chromium.org> Reviewed-by:
-
Renjie Tang authored
Change-Id: I498e2f963f28f83ba3e90822d45b25d2af98c525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354837 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798339}
-
John Z Wu authored
This will allow clients to notify their users when a submitted username password combination is determined to be leaked. Change-Id: Ibcef0106c49084b2e9a5931b1c1970e13d58758b Bug: 1096281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303553 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#798338}
-
Kevin Babbitt authored
I think this is the lowest level where we can use the streaming tokenizer directly without severe complications. A CSS value can contain a custom property reference at any point, which necessitates switching from parsing using the property's grammar, to parsing as an unresolved value. That means either we have to buffer tokens at some point, or we have to rewind the stream back to the start of the value and repeat tokenization. I'm aiming towards the former because it's more compatible with existing code and less likely to cause perf regression. With that in mind, this CL also introduces CSSTokenizedValue to hold the token range plus a view on the original string, for consumption by the custom property handler in an upcoming CL. I've added a test to ensure the string is captured correctly in the presence of !important. Bug: 661854 Change-Id: Ic3bb882e0b766fc09d0c64e0dbee10690c475c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332374 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#798337}
-
Kai Ninomiya authored
Found while rolling new WebGPU tests into Chromium. Sometimes they output lines of only spaces (inadvertently, but still). Without this, m.group(1) is sometimes None, and this crashes. Bug: None Change-Id: I181289c2d913285272abc7312f1d4e21b00a8bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357932Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#798336}
-
Alexandr Rakov authored
This CL fix store rfh in bf cache when current navigation entry is replaced (e.g from JS window.location.replace(url)) because in this case we don't store navigation entry and we don't need store corresponding rfh in bfcache. Bug: 1002978 Change-Id: Iaa15e13c5cb7c0b063d0db7b6d2eb54bc604a755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247033 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Auto-Submit: Alexandr Rakov <alrakov@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#798335}
-
Maksim Sadym authored
Follow up after https://chromium-review.googlesource.com/c/chromium/src/+/2317956 Bug: 1090802 Change-Id: I58a849c2487b46aed5f3b68c610e17e69c36d726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353462 Commit-Queue: Maksim Sadym <sadym@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Auto-Submit: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#798334}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: I28ed9c686e52799b8b1efe159db1fb81443395f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352023 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#798333}
-
My Nguyen authored
ChromeOS release for extensions side from 13408.0.0 should have the new maps. Bug: b/162803395 Change-Id: I744986aaa6c0e275cd08127c2395dcc29d96fc05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342486 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#798332}
-
Scott Violet authored
This code is for testing, so it's allowed to use explicit colors/sizes. BUG=none TEST=none Change-Id: I36fc232b27a4938c670bb44e8abbc2815c78f8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357953Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#798331}
-
Tommy Li authored
Originally, we added an on-clobber entrypoint to ZeroSuggest guarded by a feature flag which applied to all page classifications. On further thought, it seems best to make this feature flag apply to the Contextual Web (OTHER) page classification only, as different page classifications may have different UI entrypoints to ZeroSuggest. Bug: 1106096 Change-Id: I376e0b22d1b23d202e729d7a133920d94d9708e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357209Reviewed-by:
-
Robert Ogden authored
This client warms up a renderer when a cross-origin navigation is likely. This is the first CL and just makes the classes, boilerplate, and some other common checks. Reference https://chromium-review.googlesource.com/c/chromium/src/+/2350145 for what the whole impl will look like. Bug: 1115259 Change-Id: I54996eaa7ed0edd5a8521dd4fffcbb4a3c2ecd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350238Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#798329}
-
Ryan Keane authored
This CL adds 4 new timing metrics to independently track the timing for each cast streaming type. Bug: b/162771649 Change-Id: Iee98037885921a5a315572574d0d790ee461c11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337417 Commit-Queue: Ryan Keane <rwkeane@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#798328}
-
Steven Bennetts authored
BUG=1103272 Change-Id: I9e07c2e8b1457d41a5934b60f9eaf5273e67e6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319341 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#798327}
-
Lei Zhang authored
In LoadingPredictorPrefetchBrowserTestWithBlockedLocalRequest, the PrepareForPageLoadWithPredictionForPrefetch test case is flaky. Bug: 1116599 Change-Id: I74e232f5628e3d412fa3239c8aca68435e27404b Tbr: falken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357931Reviewed-by:
-
Sebastien Lalancette authored
These histograms have been recently added to the codebase, and are now being added to histograms.xml to allow us to see them in UMA. These histograms are ultimately being logged inside: activity_service_histograms.mm Bug: 1093302 Change-Id: Ifa77dac2f9585b2efca70822c7c6ff05b239bbb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352912Reviewed-by:
-
Philip Jägenstedt authored
Bug: 1116105 Change-Id: I94ee08f6ca2d53523c5a9482a779f6c45f43a15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352740 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#798324}
-
Orin Jaworski authored
This CL adds a single language data set to serve as a minimal example of how to cover all aspects including JSON data, header, unit tests, etc. Bug: 893183 Change-Id: Iee33b87dbb331946652c64dbf9c1714c1c8879f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347972Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#798323}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Icf1145cf9360e8db97a08663e58bfa7a59599bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357416Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798322}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ic44c1d6a64e3321eefdb666d746701f659d81acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357950Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#798321}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b5bfc190..dca46604 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaba69bb289303d233231f2a5c012aa940033499f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357309Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798320}
-
Tibor Goldschwendt authored
This is now the preferred enum constant format. Change-Id: Ia6435efd9b3a2d35dac4624b1337628b9fa2c3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357949 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#798319}
-
Joel Hockey authored
Bug: 1113207 Change-Id: Ifab4a2be4c22765ed0a6ab54eaba58228636d201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355353Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#798318}
-
Daniel Classon authored
Add deep linking to the internet page, internet subpage, internet detail page, and internet known networks page. Adds several element getters to shared cr-components. Adds a method to Deep Linking Behavior to show deep link by element rather than by setting ID. Bug: 1084154 Change-Id: I8d26e1aa351b5a00df196c1710d8c337d6892cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330008 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798317}
-
John Z Wu authored
This will allow ios/web_view to provide password suggestions that match the site's requirements. Bug: 1022906 Change-Id: Ic7f36a926797df6803f3584f4d55050e4085c636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343674 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
-
Lei Zhang authored
PaymentRequestShowPromiseTest.UnsupportedPaymentMethod is flaky. Bug: 1116607 Change-Id: I0dc2d92a09e3bf3ed94bfe69b34a949fac36cbbf Tbr: rouslan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357753Reviewed-by:
-
William Lin authored
Previously, the documentation for the scopes parameter was lacking and the callback parameter name did not fully reflect its purpose. This CL renames the parameter to be more descriptive and adds additional documentation. Bug: 1100535 Change-Id: I6001d36a7701c6484f318fb6e983f1ef933da14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354525Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: William Lin <williamlin@google.com> Cr-Commit-Position: refs/heads/master@{#798314}
-
Thiemo Nagel authored
Add histogram definition for Network.Shill.WiFi.HiddenSSIDNetworkCount. BUG=b:163168922 Change-Id: I9d4bfed4e7ca69b50276cad2ff473d6452372579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351969 Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798313}
-
Klaus Weidner authored
For same-process iframes, propagate the Document-level IsXrOverlay flag, and use the correct element as the overlay layer. This moves the document->SetIsXrOverlay setters from xr_system to fullscreen to ensure it gets applied consistently. There are multiple documents that need updating when iframes are being used. (Handling out-of-process iframes needs additional logic that's being added in a followup CL.) Bug: 1101193 Change-Id: Icf80e65e1b927888c6140acbc998ed90d469b5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283823 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#798312}
-
Charlie Hu authored
Passing a non-boolean type Item to a boolean type feature in DocumentPolicyParser will cause DCHECK failure in structured header implementation. This CL fixes this issue. Change-Id: I6db4a4bee4181631b2ee209895176e44faa9d23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357512 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#798311}
-
Lei Zhang authored
The testAddressIconIsNotVisibleWhenAddressStoreEmpty test case is flaky. Bug: 1116043 Change-Id: Ibe1603dc8b11ff28558991fbc14193151df5895b Tbr: javierrobles@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358030Reviewed-by:
-
Gavin Williams authored
This change adds support for the new Print Preview destination SAVE_TO_DRIVE_CROS in PDFPrinterHandler. When the user chooses Save to Drive, PDFPrinterHandler opens the file picker defaulted to the user's Drive directory. Bug: 1112416 Change-Id: I0f00b95c0ca48d9c50f64052cc099791d9c07b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340516Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#798309}
-
Brian Osman authored
Bug: skia:10613 Change-Id: I41d5955848a2f0023052531147868cec92f3edd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356973 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#798308}
-
James Cook authored
Fix a bug where an existing user could auto-update to M85, get randomized into the SplitSettingsSync field trial, but end up with OS sync disabled. This results in apps, OS preferences, Wi-Fi configs and wallpaper not syncing. The root cause is that when we migrate their per-data-type sync prefs (e.g. apps -> OS apps, preferences -> OS preferences) we were not enabling the global OS sync feature pref. That pref has a "safe" default value of false, so OS sync was never enabled. This does not affect new users, because they see the OOBE sync consent dialog, which enables OS sync if the user opts in. This CL also fixes migration of the OS wallpaper sync pref, which should be set if the user was previously syncing both apps and themes. Some of the regression came from this CL, though migration wasn't quite right before either: https://chromium-review.googlesource.com/c/chromium/src/+/2197489 We noticed this in M85 because that's the first milestone that contains the SplitSettingsSync trial. Bug: 1116046 Test: added to unit_tests Change-Id: Ie40fc2b4bdc194a16b7b756c82f1e2bc258c60ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354724 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
