- 22 Aug, 2019 40 commits
-
-
Alex Danilo authored
Error panels were being displayed on 2 separate lines of text based on the false assumption that two sentences would be separated by a period '.' and space, resulting in the same line being displayed twice when only one sentence existed in the error message. Changes the text wrapping to use 'webkit-line-clamp' instead. Bug: 995444 Tests: Modified integration test --gtest_filter="*/FilesApp*transferDeletedFile" Change-Id: I36220a2e5e492dec37d8455d3767ceecddc31a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761895 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#689371}
-
Yang Guo authored
This is not being used anywhere. Change-Id: Id1decd061a6e0c3f59c1d830ffe7405ceeb3bdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764133Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#689370}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf2dc2c1e95f..ddd16494fd70 git log bf2dc2c1e95f..ddd16494fd70 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 tbosch@google.com Support disabling ccache for new wrapper. Created with: gclient setdep -r src/third_party/chromite@ddd16494fd70 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8d46ce5904d9eb5ff37d5e0f2f17deb5bc3ade7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764797Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689369}
-
Luciano Pacheco authored
Bug: 880130,880132 Change-Id: Ic8a5888315a7c2cebc7dcdc534381ededf5874e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763522 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/57f211b56a99..31316e16555f git log 57f211b56a99..31316e16555f --date=short --no-merges --format='%ad %ae %s' 2019-08-22 herb@google.com Only send font metrics if not already sent. Created with: gclient setdep -r src/third_party/skia@31316e16555f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:881505 Change-Id: Ie3b5a1576e66bc59778fc69ad78a3e6204b44735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764798Reviewed-by:
-
Yoshisato Yanagisawa authored
Since the value is overwritten by latter mixin, we should use goma-rbe-prod-ats instead of specifying goma-rbe-prod and goma-ats. Bug: 981433 Change-Id: I4f4ffd74f01a5c028e68c8a5c6e91506b6077917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763659Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#689366}
-
Luciano Pacheco authored
Remove flag usage from browser process and browser tests setting its value. After this CL it's only left the flag itself to be removed. Bug: 880132,880130 Change-Id: Ic605e176b9f1cfdefc0c0e8fe6a6cc52b41697e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762261 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL changes how to iterate |receivers_| for FlushForTesting in ReceiverSet. It snapshots the ReceiverIds first, then iterates over them instead of directly accessing to |receivers_| because it could be mutated during individual flush operations. The original CL is [1] for BindingSet. [1]https://crrev.com/c/514465 Bug: 955171, 978694 Change-Id: Ie35573b6d59ba103818f6ce3e3ea7ad85de512ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757649Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#689364}
-
Eric Willigers authored
Rename current_task_and_callback_ and pending_tasks_and_callbacks_ to current_install_ and pending_installs_. Rename MaybeStartNextInstallation to MaybeStartNext. This is in preparation for adding current_registration_ and pending_registrations_. PendingAppManagerImpl will have two queues, one for installs and one for service worker registrations. Bug: 1757716 Change-Id: I0095ef151dec41be1b67fba32c3eea631d39297e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763562Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#689363}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/103e407c01f1..bc63d7ac7438 Created with: gclient setdep -r src-internal@bc63d7ac7438 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic003e68d56447a989b08176f93df3e625c06cb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764796Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689362}
-
Hiroki Nakagawa authored
This CL removes an outdated TODO comment about exposing ApplicationCache interface to shared workers. The HTML spec no longer defines it: https://html.spec.whatwg.org/C/#application-cache-api Bug: n/a Change-Id: Ie80a3f4616aab99310fb1686ffa8cf539fc52682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763556 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#689361}
-
Yuki Shiino authored
Replaces X.make_copy(self) method with a global function make_copy(obj) in order to simply the codebase. make_copy creates a copy of IR or part of IR. IdlType, Proxy, and their subclasses support make_copy() method so that they don't create any copy. Bug: 839389 Change-Id: Ie98d1392c43ba2dcacf069d090c8831f83e1f58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763548Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#689360}
-
Hitoshi Yoshida authored
This CL follows a spec update https://github.com/heycam/webidl/pull/750 to set default null in dictionary. Bug: 984949 Change-Id: I38ce1ad33bf322e748b32021b24568cd8cb56d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763561 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689359}
-
Hiroki Nakagawa authored
In PopulateBinderMapWithContext(), callbacks for mojo receiver requests are bound with RenderFrameHost, and then added to the binder map indirectly owned by DedicatedWorkerHost. This is not safe because RenderFrameHost can be destroyed before the binder map and the callbacks, and that may result in dangling pointer access. To avoid it, this CL binds DedicatedWorkerHost with the callbacks, and makes it check if RenderFrameHost exists before proceeding with the operations. This is safe because DedicatedWorkerHost outlives the binder map and the callbacks. Bug: 936482 Change-Id: If32fbe142ad544e519a153082f1e1aadcab9f6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763514Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#689358}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 267c8107. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes rego@igalia.com: external/wpt/css/css-contain NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7f00a151c2a89b4b29ef05a7c1b2f9fdfe516d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763880Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689357}
-
Pratish Kumar authored
This CL introduces a logic to break the text runs whenever a link is found while generating the text runs in PDFiumPage::GetTextRunInfo(). A new method PDFiumPage::CalculatePageObjectTextRunBreaks() is introduced which pre-populates a set of text breakpoints according to the start and end char indices of links in the page. PDFiumPage::GetTextRunInfo() uses that pre-populated set to determine the text run boundary. This CL includes a unit test to verify the text tuns in a pdf page which has a link in between a text block. Bug: 981448 Change-Id: I2365dc84fa1e1206a58cd8fa4e918d660ce8bc00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714773Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Pratish Kumar <prkum@microsoft.com> Cr-Commit-Position: refs/heads/master@{#689356}
-
Nigel Tao authored
This runs the test with and without marking an app as a default app. Not much actually seems to depend on that bit being set. This means that the (existing) test isn't ideal, but as the added commentary says, it's probably better than nothing. Change-Id: Ic508abf972e3ae939963f22dc2f1f19d9b9ca555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732092 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689355}
-
Austin Tankiang authored
Bug: 993678 Change-Id: I75a1319b19cff076da6bfd7f31793d0fa8a7bab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757405Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#689354}
-
Takuto Ikuta authored
Currently, webkit_layout_tests on linux-rel took around 24 mins in slowest shards. e.g. https://ci.chromium.org/p/chromium/builders/try/linux-rel/172077 And this is the slowest test in linux-rel. So it is better to remove this modification. webkit_layout_tests on linux does not have large overhead, so this won't affect capacity requirement match. Instead, this will reduce wait time in builder and that may shrink capacity. NOTRY=true Bug: 868114 Change-Id: I0cbbaea215e52ae1d2f1d0c5b6249de263513587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763552 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#689353}
-
Chinglin Yu authored
This implements the jankiness profiler on ChromeOS. The ProfilePrivder observes jankiness through JankMonitor and then sends notification to each registered MetricCollector implementation class. The profiles are collected with the JANKY_TASK trigger event. Bug: 904785 Test: unit_tests. Change-Id: I699286541a6d892efe1e7e2ada47defbc57a1bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692209 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689352}
-
Yue Zhang authored
Currently, chrome crashes if user ungroups a tab right after closing the dialog. This is because that the recyclerView is cleared out when dialog hides and thus we lose reference to the item being ungrouped. This CL fixes this issue. Bug: 990702 Change-Id: If1322f2aaf704c7b6ab006f35200594d44d8317d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739344Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#689351}
-
Austin Tankiang authored
Bug: 993678 Change-Id: Idc11c9b6a9f87d6006dcad4f53a2dac23ce437cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757404Reviewed-by:
-
Findit authored
This reverts commit fd82f584. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 689336 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZkODJmNTg0Y2MzMDhkZDkxYWExMTIwNjNhODRhZDQ5ZWQ2YjhkYTMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/28411 Sample Failed Step: compile Original change's description: > Migrate hid.mojom and related classes to the new Mojo types > > This CL converts hid.mojom and related classes from old Mojo types > to the new types. Major changes are as below, > > - Apply PendingRemote to HidConnectionClientPtr. > - Replace InterfacePtr with mojo::Remote > - Replace mojo::Binding with mojo::Receiver > > Bug: 955171 > Change-Id: If4b686844272cd1763be50ff7620e00e1084a108 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761874 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#689336} Change-Id: I9444d50f890dfd4b84ecdf78bd8d7a78dd6c83f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764556 Cr-Commit-Position: refs/heads/master@{#689349}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/42c6af9182d2..57f211b56a99 git log 42c6af9182d2..57f211b56a99 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 bsalomon@google.com SK_API in src/gpu cleanup Created with: gclient setdep -r src/third_party/skia@57f211b56a99 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I124ccf89642e39a2fa496ff00a0be32d023ce191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764875Reviewed-by:
-
Jason Lin authored
This is a reland of bbe68ab3 This reland resolves the following issues: * CrostiniInstallerViewBrowserTest fails to pass MSAN * CrostiniInstallerTest is flaky Also note that the original description links to the wrong issue crbug.com/912638 instead of crbug.com/929571. Original change's description: > Factor non-ui logic out of CrostiniInstallerView > > The current CrostiniInstallerView contains a lot of non-ui logic such as > histogram recording and somewhat complex interaction with CrostiniManager. This > CL factors out the non-ui logic into new class CrostiniInstaller. This not only > makes the code cleaner, but also allows us to port the installer UI to WebUI > much more easily. > > > Bug: 912638 > Change-Id: Ie0195c8580518aa39e59aa539ef2fb614978776b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701024 > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Commit-Queue: Jason Lin <lxj@google.com> > Cr-Commit-Position: refs/heads/master@{#688021} Bug: 929571,995261,992298 Change-Id: I85809d7760ee99fa1100e303aadf04837db9666b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760640Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#689347}
-
Sven Zheng authored
This file is for live tests that needs src-internal checkout. Bug: 992565 Change-Id: I20ed30e17ccfe588dbc1df03ee82f2b8a613d658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764609Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#689346}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3418cf472b93..bf2dc2c1e95f git log 3418cf472b93..bf2dc2c1e95f --date=short --no-merges --format='%ad %ae %s' 2019-08-22 cjmcdonald@chromium.org parallel_emerge_new: Disable Portage vardb locks for boards 2019-08-22 cjmcdonald@chromium.org Make root-deps argument optional Created with: gclient setdep -r src/third_party/chromite@bf2dc2c1e95f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I32f563c86d924f2fb610fe1579604514e08892c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764874Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f52a5e29712d..88c370baef61 git log f52a5e29712d..88c370baef61 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 tsepez@chromium.org Pass owning reference to CFWL_Message to OnProcessMessageToForm() 2019-08-21 tsepez@chromium.org Make TranslateFWLMessage() own the message it is sending. 2019-08-21 thestig@chromium.org Rename |CFX_Break::m_Line| to |m_Lines|. Created with: gclient setdep -r src/third_party/pdfium@88c370baef61 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Icc7f8e11f9d40e84389af729e09002a53ba3ea9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764873Reviewed-by:
-
Maggie Chen authored
A DCHECK is triggered in GpuWatchdogThreadImplV2::Arm() during GPU initialization. Whenever there is an error, GpuInit::InitializeAndStartSandbox() exits earlier. watchdog_thread_->OnInitComplete() is not called in those cases and arm_disarm_counter_ gets messed up. A new class GpuWatchdogInit is created to call OnInitcomplete() in the destructor. OnInitComplete() will never be missed at the end of InitializeAndStartSandbox(). Bug:949839, 995372 Change-Id: I1a107df0ca48409ff2252260ea41de643fa39b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762879Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689343}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8ff63e09525..103e407c01f1 Created with: gclient setdep -r src-internal@103e407c01f1 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ifa5adfef6a34beb62fa9260d0352bd9cfbfafaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764872Reviewed-by:
-
John Chen authored
NOTRY=true TBR=crouleau@chromium.org Bug: chromedriver:2860 Change-Id: I70349540da8215d1be314cf8f0f3e2e73f91e903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764795Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689341}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I96e6757fb68166f99d0dbd8ac6be5ae1c7d7da0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763271 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#689340}
-
Mei Liang authored
This CL modifies incognito GTS to use the same color palette as Dark mode. In addition, this CLs add darker theme support for all tab group related UIs in incognito, except for TabSelectionEditor. Change-Id: Ic1517867cf90ac0550fd1bf15e91cd19c4231eab Bug: 960891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745619 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#689339}
-
Moe Ahmadi authored
Bug: 996516 Change-Id: I1d15cc85274698027896c21324cc1fd12648c962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764868 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#689338}
-
Esmael El-Moslimany authored
Bug: 996152 Change-Id: I3f2d09288393d251528badaa668f1317585e9eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764431 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#689337}
-
Gyuyoung Kim authored
This CL converts hid.mojom and related classes from old Mojo types to the new types. Major changes are as below, - Apply PendingRemote to HidConnectionClientPtr. - Replace InterfacePtr with mojo::Remote - Replace mojo::Binding with mojo::Receiver Bug: 955171 Change-Id: If4b686844272cd1763be50ff7620e00e1084a108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761874Reviewed-by:
-
Sam Goto authored
Sample: https://storage.cloud.google.com/chromium-translation-screenshots/d2da91cc316334522197c0b6cb4eb0c8dddc58f5 After doing one round of outreach, we learned quickly that the modal dialog was too disruptive for developers and an imposition on their flow. https://github.com/samuelgoto/sms-receiver#opt-in-ux The blocking nature of the modal assumes there is nothing else to be done, which quickly proved to be too strict for partners (e.g. some forms have first/last names input fields that can be entered while one waits for an OTP). In this CL, we move our implementation from a blocking UX to an unblocking UX, reusing the InfoBar visual language: https://github.com/samuelgoto/sms-receiver#unblocking-ux We debated for a while keeping both implementations in the code base, but decided against it due to the (a) maintenance cost involved, (b) memory / strings consequences involved, (c) code complexity introduced and (d) our intuition that the infobar is a strictly better UX than modal dialogs for this feature. This CL: - deletes the old modal dialog implementation (and its resources) - creates an info bar dialog implementation - removes the content/public/SmsDialog interface Bug: 994874 Change-Id: I1360de9fa0bb10f99df71684e6f617b7c0c4f5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751966 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#689335}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/18e21a5b..b91d75c9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I29f605db524a2e40068304593629be730c86cc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763879Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689334}
-
Kent Tamura authored
CacheControlMaxAge(), Age(), and CacheControlStaleWhileRevalidate() of ResourceResponse should return base::TimeDelta instead of double They are |delta-seconds| [1], and base::TimeDelta is more suitable than double. [1] https://tools.ietf.org/html/rfc7234#section-1.2.1 Bug: 988343 Change-Id: Ifa617cc52ded0e88710aba0ca0a458273bdf93f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757256Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#689333}
-
Rafael Cintron authored
In preparation to reuse the code in SwapChainFactoryDXGI for shared images, this CL renames classes to have more general purpose names: * SwapChainFactoryDXGI --> SharedImageBackingFactoryD3D * SharedImageBackingDXGISwapChain --> SharedImageBackingFactoryD3D * GLImageDXGISwapChain --> GLImageD3D * SwapChainFactoryDXGI --> SharedImageBackingFactoryD3D::IsSwapChainSupported * SwapChainFactoryDXGITest --> SharedImageBackingFactoryD3DTest Bug: 966580 Change-Id: Iffb511df7802a78e1ca3ceafd83fdb082b33a478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761438 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#689332}
-
