- 30 Aug, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fe2e9f99..a7cf9c5c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d012533a21bc0ce45753c9dc9190b7a4cf2d184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778666Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692273}
-
Regan Hsu authored
Bug: 998561 Change-Id: Ia4e9ca33ee7f30eb333ff479fd7d6e9075e995bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774958 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#692272}
-
Jun Mukai authored
This CL adds the home-launcher state changes in ShellTestApi, and so LauncherDragTest can conduct within tablet mode. As far as I tested, the input latency for dragging in tablet mode is not quite bad. It is 50-60msecs in scarlet; that is comparable to the latency of clamshell mode in nocturne. Bug: 995991 Test: interactive_ui_tests Change-Id: Ifd7d2694bdcf5a60eb295d11773df1eb73ec181b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775598 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692271}
-
Xing Liu authored
This test is failing on some Android builders. TBR=ricea@chromium.org Bug: 999647 Change-Id: I37858af2761542f27510a125436f5011c90cf42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779434Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692270}
-
Fergal Daly authored
This adds a failing test and fixes it by ensuring that we add an intersection observer not just to the revealed elements but go one further than that in each direction. Without that, it's possible to scroll all the way through a very large element without the ever triggering an intersection observer. More detailed explanation in bug. Bug: 983050 Change-Id: I2fa86fdb7cf58f463f716fd2f34f61b3f10bc0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772850Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#692269}
-
Donn Denman authored
Fixes some recently introduced resolve behavior problems with the Tap gesture when the CSLongpressResolve feature is enabled: 1) Tap should not be recognized (unless we're in the preserve-tap variation of the longpress experiment). 2) Tap should not resolve even when we're in the longpress variation when privacy-aggressive behavior is enabled. Adds automated tests. BUG=999448, 999663 Change-Id: I29d14c7666fdcd8ea286ae5d55c46e250e23c350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779301 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#692268}
-
Josh Nohle authored
To conform with the style of other DeviceSync v2 helper classes, send the ResultCode and the new ClientDirective (if one was sent) as individual callback arguments instead of bundling them in a CryptAuthDeviceSyncResult. We reserve the CryptAuthDeviceSyncResult to express the *final* result of the v2 DeviceSync flow. This is a stylistic clean-up; no logic is affected. Bug: 951969 Change-Id: I9cf32d1d2692c04721ccdb98da890db54b833739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778807Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#692267}
-
Josh Nohle authored
There is no benefit in passing the enum by reference. Furthermore, this change reduces the risk of segfaults by destroying the object that owns the ResultCode, for instance, in CryptAuthDeviceSyncerImpl::FinishAttempt. Bug: 951969 Change-Id: I8e835160865ef57182384dc2c74fa399dff406d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778405 Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Ioana Pandele authored
- Add a description - Change string - Change order - Only display for signed in users Bug: 986322 Change-Id: I47e7320f66caad5587348c4e63d0e565c54bf68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776541 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#692265}
-
Becca Hughes authored
As per UI review, make the action button ink drop round. We do this by subclassing image button and returning a custom ink drop. BUG=999708 Change-Id: Ib7067cb4a27b9a01c01eb397c80e665a23027224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778652Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#692264}
-
Alex Danilo authored
This reverts commit e919a379. Reason for revert: Flag was disabled for landing on 77 branch, so reverting this to enable it again for 78. Original change's description: > Disable feedback panels by default > > Bug: 999653 > Change-Id: I3c2a65fc04817a1ced86ecbd5157877a6ac07244 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778883 > Commit-Queue: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Austin Tankiang <austinct@chromium.org> > Auto-Submit: Alex Danilo <adanilo@chromium.org> > Reviewed-by: Austin Tankiang <austinct@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692200} TBR=adanilo@chromium.org,austinct@chromium.org Change-Id: I7860daf73b48f18f7c05fc9155f16f328c09d124 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779463Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#692263}
-
Adam Langley authored
Took me too long to figure out why all the tests were dropping three bytes from the beginning of messages. Therefore it's worth a named constant. Change-Id: I3b22d9c4e654dd67b6de9ef2cb3cbe4afb358c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776795 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#692262}
-
Dominik Röttsches authored
DWriteFontLookupTableBuilder related test appear flaky. The root cause is believed to be an inconsistent state of DWriteFontLookupTableBuilder due to testing-override methods on this class. Disable the tests until the full solution is in place. Bug: 996167 Change-Id: I68eebba031b6b865c8db4d884c07641ecd1dcc4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778605 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#692261}
-
Robert Ogden authored
Also will end up ignoring regexps, oh well. Bug: 999702 Change-Id: Id7e961b1ff9ac8948a2cd53f01e58164c0a79c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779178Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#692260}
-
Xianzhu Wang authored
This makes it clear that Layer will hold a reference to the input layer. Change-Id: I123bf6fc8c258116777207bdc53144b3e467248e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779020Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692259}
-
Eric Stevenson authored
This change was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: I494f4e3c9207aee8e0af9ee999bedf37c5a5b7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779148 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692258}
-
Adam Langley authored
The caBLE session key is a 32-byte, binary blob. Rather than hold it as a string, but the nonce as a byte-array, deal with both as bytes. Change-Id: I526bc12bceec65b4c2dcd29176733e82c227cfd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776794 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f06000e894cd..9e1c92c073c9 git log f06000e894cd..9e1c92c073c9 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 crouleau@chromium.org [Telemetry] Only skip stories with expectations.config. Created with: gclient setdep -r src/third_party/catapult@9e1c92c073c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:999375 Change-Id: Id9fa6a5a6bc20bd4edce0bfbc4b39f3bb4ae1ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779384Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692256}
-
Tommy Steimel authored
This CL adds new APIs to the AudioFocusManager to observe media sessions for a given identity. This allows the GMC to only observe for the current profile. This fixes an issue where media sessions from incognito windows and sessions from windows of other profiles would show up in the GMC dialog. Bug: 992463 Change-Id: Icd1247543f8d259ac0f370bdbda3a7c524089c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771937 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#692255}
-
Cici Ruan authored
Need change focus of window for ARC tast test. Bug: b/134981068 Test: Call the api to see if window focus is changed correctly. Change-Id: Icf1f0aebccb63b7052e55594d6c3754fbd0880ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769094 Commit-Queue: Cici Ruan <cuicuiruan@google.com> Auto-Submit: Cici Ruan <cuicuiruan@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#692254}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6d684b4c7991..18c9ac497117 git log 6d684b4c7991..18c9ac497117 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 capn@google.com Optimize non-solid polygon rasterization 2019-08-30 bclayton@google.com Implement non-solid polygon rasterization 2019-08-30 chrisforbes@google.com Don't use bitcast+float path for integer constant values Created with: gclient setdep -r src/third_party/swiftshader@18c9ac497117 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139872671,chromium:b/139872671 Change-Id: Ief6fbe2c426fac88ec95d1f6db74e0b85464b433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779381Reviewed-by:
-
Scott Violet authored
Without this weblayer_shell isn't built on any bots (for android). BUG=none TEST=none Change-Id: I93c58351d09ddb8667e68dc81dcc37075a735171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779014Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#692252}
-
Lukasz Anforowicz authored
We no longer need to support running with CORB disabled for *all* extensions: 1. The BypassCorbOnlyForExtensionsAllowlist feature has shipped in M73. 2. Distributing allowlisted extensions via field trial param does not apply to M77+ (according to the BypassCorbExtensionsAllowlist.gcl config). After this CL it is no longer possible to force a separate URLLoaderFactory (with disabled CORB) for *all* content scripts by launching Chrome with --disable-features=BypassCorbOnlyForExtensionsAllowlist After this CL it is still possible to avoid separate content script URLLoaderFactories by launching Chrome with --force-empty-corb-allowlist Bug: 846346 Change-Id: Ia1264b318dd8c389bf8cb58041dd503a4dca5b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774889 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#692251}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ece96d76d9d..8ef18d359b26 git log 4ece96d76d9d..8ef18d359b26 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 dragonbear@google.com Override operator delete for GrCCPathCache::Key 2019-08-30 egdaniel@google.com Just skip uninstantiated GrOps instead of delete them on flush. 2019-08-30 brianosman@google.com Pass SkPaint by const-ref to SkParticleDrawable Created with: gclient setdep -r src/third_party/skia@8ef18d359b26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I8265a37f804c83d7bf77d2d52491c3395bbb0378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779382Reviewed-by:
-
Eric Willigers authored
We now use subtraction when the length in a computed length-percentage calc is negative. Discussed in https://github.com/w3c/csswg-drafts/issues/3335 Change-Id: I24822de431059a97cf8f9203950b6d84de72180e Bug: 904805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777843Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#692249}
-
Sophie Chang authored
Bug: 996665 Change-Id: I02522a88ca45f53fe01381e6cb01c4a13aeeff7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779306Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#692248}
-
Eric Karl authored
Updates the cc RTree class to handle overflow: - GetBounds becomes GetBoundsOrDie and can only be called when has_valid_bounds(). - All other functions are unchanged, operating correctly, but less efficiently, when !has_valid_bounds(). Updates DisplayItemList to handle cases when !has_valid_bounds(). Bug: 988590 Change-Id: I8612c5e219a7aa9774fc24cb69372df975562bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777049 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#692247}
-
Etienne Pierre-doray authored
To ensure re-ordering of delayed tasks posted at the same time, sequence_num is used to give priority to the task that was first created. Change-Id: I97f429d23991259af43395d229cb76cb3fc0e93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778926 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#692246}
-
Renjie Tang authored
Roll src/net/third_party/quiche/src/ edeeb47d6..28315b77c (13 commits) https://quiche.googlesource.com/quiche.git/+log/edeeb47d60bc..28315b77c94c $ git log edeeb47d6..28315b77c --date=short --no-merges --format='%ad %ae %s' 2019-08-30 renjietang Automated g4 rollback of changelist 265940959. 2019-08-30 renjietang Automated g4 rollback of changelist 265958257. 2019-08-30 fayang gfe-relnote: In QUIC, send PING when TLP fires and no packet is created. Protected by existing gfe2_reloadable_flag_quic_fix_rto_retransmission3. 2019-08-30 zhongyi Explicitly cast QuicIetfTransportErrorCodes to uint16_t when forwarded to QuicStrCat. 2019-08-30 bnc Send Set Dynamic Table Capacity instruction. 2019-08-30 vasilvv Implement QUIC ALPN selection on the server side. 2019-08-29 quiche-dev Stop using the "LIFO" write scheduler. 2019-08-29 vasilvv Support session-specific ALPNs for clients, and specifying multiple ALPNs. 2019-08-28 nharper Limit the amount of incoming crypto data that will be buffered. 2019-08-28 quiche-dev LSC: Replace deprecated thread annotations macros. 2019-08-28 quiche-dev LSC: Replace deprecated thread annotations macros. 2019-08-28 bnc Remove deprecated unused QuicStreamSequencer::PrefetchNextRegion() method. 2019-08-28 fkastenholz Have framer store frame type currently being processed Roll src/third_party/quic_trace/src/ 8415c22f0..35d364f77 (10 commits) https://chromium.googlesource.com/external/github.com/google/quic-trace.git/+log/8415c22f0ca2..35d364f77a02 $ git log 8415c22f0..35d364f77 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 vasilvv Add missing build dependency 2019-08-28 vasilvv Capitalize method names 2019-08-28 vasilvv Run clang-format 2019-08-20 martenseemann fix calculation of transfer stats 2019-08-18 martenseemann update the example.qtr 2019-08-18 martenseemann add default cases for encryption level switch statements 2019-08-02 martenseemann output the encryption level and the size for more events 2019-04-29 martenseemann add support for packet number spaces 2019-04-29 martenseemann add support for CRYPTO frames 2019-04-29 martenseemann show the encryption level for received packets Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ifb466981af3c401d338109e72dc6142a79af7033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779017Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#692245}
-
chrome://os-settingschrome://chrome-urlsBailey Berro authored
- This change adds the chrome://os-settings url to the list of chrome urls on the chrome://chrome-urls page. Bug: 999340 Change-Id: I4cfd298acf2b92b39e68f953fb269454e15579d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776982 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Łukasz Anforowicz authored
This reverts commit e9c75cda. Reason for revert: https://crbug.com/999078 (Android-WebView-related crashes in Opera mini) Original change's description: > Stop special-casing single-frame NavigationEntryImpl::Get/SetPageState. > > This has has the following benefits: > - It forces us to consider data duplication across FrameNavigationEntry > and PageState/ExplodedFrameState (e.g. url and referrer today). The > CL makes the FrameNavigationEntry the authoratitative source of the > information. > - It is a prerequisite for persisting the |initiator_origin| of a > navigation inside ExplodedFrameState (see also > https://crrev.com/c/1679162). > > Because of the above, this CL changes the code so that: > - Calls to NavigationEntryImpl::GetPageState *always* go through > RecursivelyGenerateFrameState (before this CL this wasn't > true for single-frame pages). > - Calls to NavigationEntryImpl::SetPageState *always* go through > RecursivelyGenerateFrameEntries (before this CL this wasn't > true for single-frame pages). > > As a consequence of the changes above: > - Tests can no longer use an arbitrary string as the PageState > (although empty string as a PageState is still supported). > - The call to NavigationEntryImpl::SetPageState always (not just for > multi-frame pages) will drop old FrameNavigationEntries and create a > new tree of FrameNavigationEntries. > > Bug: 976055 > Change-Id: I132fffa26557a5903b8c3fbf703ca04808706e38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737488 > Commit-Queue: Richard Coles <torne@chromium.org> > Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690754} TBR=sky@chromium.org,creis@chromium.org,torne@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 976055, 999078 Change-Id: I0fffc26406d88e2cd258f0fb4d4d2ce2e45805d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778860 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#692243}
-
Adam Langley authored
r689248 introduced a crash when deleting cookies. To repo: 1) Go to some URL that sets cookies. (https://accounts.google.com does.) 2) Click the padlock in the URL bar to open a popup and select “Cookies” to open the cookies dialog. 3) Click “Remove” repeatedly. All the domains will disappear and, once the list is empty, clicking again will crash the browser. This occurs because collected_cookie_views.cc expects CollectedCookiesViews::OnTreeViewSelectionChanged to be called after the final (visible) tree-view element is removed. Without that, the buttons aren't made insensitive and can continue to be pressed (triggering a nullptr crash). With r689248, SetSelectedNode was called with the root node in that case rather than nullptr, and SetSelectedNode filters that out when the root node is not visible. This change attempts to restore the previous behaviour. Change-Id: If5c0acb3095e7026626667292ffec4de039669c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779342Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#692242}
-
John Abd-El-Malek authored
The latter didn't originally exist. This does mean that a NetworkContextClient is needed for uploads to work. NetworkContextClientBase is a base class provided in content/public for code which creates NetworkContexts to use (e.g. safe browsing, system network context). Change-Id: Idd6d4396c5a9c5a6503494fcd45aa87dae2a9221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777056Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#692241}
-
Bret Sepulveda authored
To avoid trying to automatically come up with a good default title, or forcing the user to name a group as soon as it's created, this patch makes groups have an empty title by default. To support a group having an empty title, this patch also does the following: * Use a differently-sized, circular header chip when there is no title. * Changes header chips with a title to be rounded, to match the empty header chips. * Initializes the group editor bubble with the current title, and allow the user to input an empty title (rather than using the old title). * Generates a descriptive name for groups in the tab context menu, which is: '"[Title of first tab in group]" and X other tab[s]'. Bug: 905491 Change-Id: I0f331a1938572b7283e0c2685126c30dc83c10dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769553Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#692240}
-
Amin Hassani authored
A few of the error code enum values were missing. This CL adds those. Also renamed the newly introduced download error code names to camel case like the rest of them. Bug: None Test: None Change-Id: I4ec732798812d56d2c4b91f258b28221dcbcdd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774101 Auto-Submit: Amin Hassani <ahassani@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#692239}
-
chrome://flags/#omnibox-on-focus-suggestionsMoe Ahmadi authored
- Adds a flag to chrome://flags to control omnibox::kOnFocusSuggestions. - Adds a variation to the flag entry that allows enabling zero-prefix suggestions in the NTP Realbox. Bug: 996516 Change-Id: Ia501cf6951a591130e9845c57e90f889b7b33c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775581 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#692238}
-
Antonio Rivera authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1771053 I missed one recently-added case. Test: cast_media_unittests passes Bug: b/139928913 Change-Id: Ifcaa595d16bd66b5cf745220ac6c96f87ea04907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779174 Auto-Submit: Antonio Rivera <antoniori@google.com> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692237}
-
Andrew Luo authored
The fact that the WebView Nougat bot stayed green meant that the test filter was not needed, so have deleted it. Also added a presubmit check. Change-Id: I0b18239cb102203120a77f19029fc6ae66f579c2 Bug: 997759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778982Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#692236}
-
Robert Ogden authored
Bug: 996870 Change-Id: If3c919a6898bc31270f8bdff924b54bfd664bf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779307Reviewed-by:
-
Joshua Peraza authored
726ab2a65539 Integrate Crashpad with Chrome OS db6f51d3fca8 fuchsia: Check results of Initialize() subcalls in ProcessReaderFuchsia 50aa576622fd Disable implicit fallthrough warning for zlib 1c7023875b74 [build] //zircon/public/fidl --> //zircon/system/fidl 7b5a55c3b188 Move whitelist ownership to ProcessSnapshotSanitized 10a1d2d87743 [fuchsia] Use the appropriate separator for FIDL library names b71f61f8e31f fuchsia: Defer initialization of memory map 23a1be41ce3a linux: refactor snapshotting into CaptureSnapshot() 80473094a4d2 linux, compat: add a memfd_create wrapper cd92fba233d3 linux: Move Cros crash handling to CrosCrashReportExceptionHandler Change-Id: I035a3ad1e3eed573a9c8871c096181baf4178ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779013Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#692234}
-
