- 13 Dec, 2011 40 commits
-
-
jar@chromium.org authored
[Karen Grunberg requested a speculative revert, because we are currently unable to complete a link of the canary. This change is working fine on the Dev branch, and did not impact the link over the weekend, but for lack of other items, this change is being reverted] This code should only have much of an impact on the XP platform, where thread teardown notification are not currently made. Provide an automatic fallback scan of the linker list of notifcation callbacks via DllMain. This fallback is ONLY used if there are no notifications coming via the linker list. This allows all existing code to continue working as it does today, and provides thread teardown notifcatino on XP even though we use the LoadLibrary call. It is a minimal change, suitable for pushing to other channels (beta? stable?). r=cpu BUG=103209 Review URL: http://codereview.chromium.org/8836003 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/8934006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114229 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
Revert "Redo r113722 - Add Pass(), which implements move semantics, to scoped_ptr, scoped_array...." This reverts commit r113922. Win Canary has been failing to link due to OOM since the weekend. While this was not the original cause, it might be making things worse. Speculatively remove for now. BUG=none TEST=none TBR=kareng Review URL: http://codereview.chromium.org/8932006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114228 0039d316-1c4b-4281-b951-d872f2087c98
-
dgozman@chromium.org authored
Not the final UI yet. Additional improvements: - file name is selected in save-as dialog at start; - new folder moved to context menu, button deleted. BUG=chromium-os:20168,chromium-os:22106,chromium-os:22105,chromium-os:22032,chromium-os:20547,chromium-os:20549 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113804 Review URL: http://codereview.chromium.org/8554003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114227 0039d316-1c4b-4281-b951-d872f2087c98
-
mkwst@chromium.org authored
After BrowsingDataRemover removes browsing data, it now triggers a chrome::NOTIFICATION_BROWSING_DATA_REMOVED, which uses the profile in which data was removed as it's |source|, and a struct containing the beginning of the removal's timeframe, and the removal mask (BrowsingDataRemover::NotificationDetail) as it's |details|. BUG=107202 TEST=BrowsingDataRemover unit tests. Review URL: http://codereview.chromium.org/8907015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114225 0039d316-1c4b-4281-b951-d872f2087c98
-
http://crbug.com/96010bruening@google.com authored
BUG=96010 TEST=Ran Release unit_tests BrowserAboutHandlerTest.WillHandleBrowserAboutURL and confirmed suppression is used and no errors reported; confirmed in Debug by hand with build that disables the DCHECK that kills child before this error is hit Review URL: http://codereview.chromium.org/8935005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114224 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
We should wait for signal connection, for each signal. Otherwise, 2nd call to OnConnected() may quit the message loop instead of OnTestSignal(). FWIW, the flakiness was introduced in crrev.com/111423 BUG=106796,107301 TEST=confirm the test no longer fails by: while true; do out/Release/dbus_unittests --gtest_filter=EndToEndAsyncTest.TestSignal || break ; done Review URL: http://codereview.chromium.org/8907010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114223 0039d316-1c4b-4281-b951-d872f2087c98
-
robert.nagy@gmail.com authored
BUG= TEST=compile Review URL: http://codereview.chromium.org/8912008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114222 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=107172 TEST=none R=ben@chromium.org,avi@chromium.org Review URL: http://codereview.chromium.org/8921032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114221 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
[ Re-land of 114076 http://codereview.chromium.org/8899015 ] This code was platform independent so could just be copied over into the platform independent file with no changes. Review URL: http://codereview.chromium.org/8927001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114220 0039d316-1c4b-4281-b951-d872f2087c98
-
erikwright@chromium.org authored
1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types. 2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'. BUG=87634 R=cbentzel@chromium.org Review URL: http://codereview.chromium.org/8929002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114219 0039d316-1c4b-4281-b951-d872f2087c98
-
steveblock@chromium.org authored
JavaBridgeDispatcherHost must be ref-counted because it is used with base::Bind. http://codereview.chromium.org/8834013 changed JavaBridgeDispatcherHost to also inherit from RenderViewHostObserver. The base implementation of RenderViewHostObserver::RenderViewHostDestroyed() deletes the object. This is unwanted in this class, so we provide an empy implementation of the method. Review URL: http://codereview.chromium.org/8929005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114218 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
BUG=98716 Review URL: http://codereview.chromium.org/8890075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114217 0039d316-1c4b-4281-b951-d872f2087c98
-
peter@chromium.org authored
This change replaces -rpath-link and an -L linking flag with --sysroot, which sets the compiler root directory for all headers and libraries. BUG= TEST= Review URL: http://codereview.chromium.org/8938003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114216 0039d316-1c4b-4281-b951-d872f2087c98
-
ivankr@chromium.org authored
With this option, the current user is always treated as owner and all signed settings are stored in memory without signing. All CrosSettingProviders now use a callback to notify CrosSettings observers. BUG=None TEST=StubCrosSettingsProviderTest.*; manual: see CL description Review URL: http://codereview.chromium.org/8899002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114214 0039d316-1c4b-4281-b951-d872f2087c98
-
marja@chromium.org authored
Reset the kWasRestarted pref upon successful restart. Set it only when restarting. Write the persistent preferences after setting it. The preference was introduced in http://codereview.chromium.org/8745015. BUG=106948 TEST=see bug Review URL: http://codereview.chromium.org/8937001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114213 0039d316-1c4b-4281-b951-d872f2087c98
-
pastarmovj@chromium.org authored
The check was trying to verify the current user is the owner when all it needs to check is if there is an owner already. This check was also blocking local owner from doing changes to the signed settings on first login and possibly is the cause preventing the managed settings from getting applied immediately too. BUG=chromium-os:24020,chromium-os:24007 TEST=As described in the bugs. Review URL: http://codereview.chromium.org/8921007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114212 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
TBR=timsteele@chromium.org BUG=none Review URL: http://codereview.chromium.org/8919015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114211 0039d316-1c4b-4281-b951-d872f2087c98
-
dubroy@chromium.org authored
BUG=chromium-os:22035 TEST=Manual. Review URL: http://codereview.chromium.org/8920003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114210 0039d316-1c4b-4281-b951-d872f2087c98
-
mflodman@chromium.org authored
When running the fake ui, behind the media stream flag, there is a missing check for available devices. Review URL: http://codereview.chromium.org/8883042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114205 0039d316-1c4b-4281-b951-d872f2087c98
-
marja@chromium.org authored
The implementation was removed by http://codereview.chromium.org/8820009. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8919003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114204 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114203 0039d316-1c4b-4281-b951-d872f2087c98
-
marja@chromium.org authored
BUG=NONE TEST=builds. Review URL: http://codereview.chromium.org/8873021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114201 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114200 0039d316-1c4b-4281-b951-d872f2087c98
-
ricow@chromium.org authored
TBR=erik.corry Review URL: http://codereview.chromium.org/8935003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114199 0039d316-1c4b-4281-b951-d872f2087c98
-
mazda@chromium.org authored
BUG=105204 TEST=Manual Review URL: http://codereview.chromium.org/8817018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114198 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114196 0039d316-1c4b-4281-b951-d872f2087c98
-
bashi@chromium.org authored
BUG=None TEST=Trybots TBR=kbr Review URL: http://codereview.chromium.org/8879054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114195 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
This change includes "mozzconf.h" in our copy of 'zconf.h' as we did before updating to zlib 1.2.5 to avoid symbol conflicts with sdch happening when we use supalink. BUG=none TEST=link Chromium with supalink. Review URL: http://codereview.chromium.org/8933001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114194 0039d316-1c4b-4281-b951-d872f2087c98
-
fischman@chromium.org authored
BUG=104579 TEST=built Debug & Release on desktop and verified test passes (after failing in Release on desktop before the change to RemoveFilter). Review URL: http://codereview.chromium.org/8934002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114193 0039d316-1c4b-4281-b951-d872f2087c98
-
dgrogan@chromium.org authored
BUG=106265 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114157 Review URL: http://codereview.chromium.org/8785013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114192 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
BUG=107294 TEST=none Review URL: http://codereview.chromium.org/8917027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114191 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
(the underlying issues have been resolved). BUG=None TEST=None R=maruel@chromium.org TBR (will see what the bots do and back out if there are issues). Review URL: http://codereview.chromium.org/8936003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114190 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Currently P224EncryptedKeyExchange uses two pieces of secret: password and session-specific key. They are combined and used together as one password. It is not really needed and the calling code can do it when neccessary. BUG=105214 Review URL: http://codereview.chromium.org/8903001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114189 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
r=rtenneti BUG=107051 Review URL: http://codereview.chromium.org/8899016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114188 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
BUG=105214 Review URL: http://codereview.chromium.org/8774031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114187 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
BUG=none TEST=AsyncHostResolver.* Review URL: http://codereview.chromium.org/8918029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114186 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
This reverts commit f0c9c12d. TBR=thestig@chromium.org BUG=103497 TEST=none Review URL: http://codereview.chromium.org/8929004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114185 0039d316-1c4b-4281-b951-d872f2087c98
-
fischman@chromium.org authored
This'll be revived or deleted shortly. BUG=104579 TEST=none Review URL: http://codereview.chromium.org/8936002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114184 0039d316-1c4b-4281-b951-d872f2087c98
-
fischman@chromium.org authored
This uses the GpuVideoDecodeAccelerator machinery (already written to enable ppapi to take advantage of OpenMAX HW where available) to decode <video> data. This increases idle CPU from 20% to 45% on one particularly large (internal) test video (red0.mp4), on an ARM crosbook. HW decode is done on a best-effort basis; if the GPU code doesn't know how to deal with a codec/profile we still fall back to ffmpeg for decode. Because the vast majority of chrome installs will be on HW with no video decode support (yet) we only attempt HW video decode on platforms we know have a shot at it. This is a copy of http://codereview.chromium.org/8686010/ PS#13 to work around rietveld losing the "status" for some files in the patch. BUG=104579 TEST=manual testing w/ video test matrix, trybots. Review URL: http://codereview.chromium.org/8922010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114183 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
Add a proper permission message. Update the API to be ChromeOS only BUG=None TEST=None Review URL: http://codereview.chromium.org/8757015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114181 0039d316-1c4b-4281-b951-d872f2087c98
-