GitLab

R=mmenke
BUG=446900

Review URL: https://codereview.chromium.org/837223007

Cr-Commit-Position: refs/heads/master@{#311412}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/55561f5..9ffdc0b

TBR=hayato@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/852713002

Cr-Commit-Position: refs/heads/master@{#311411}

BUG=448214

Review URL: https://codereview.chromium.org/847193003

Cr-Commit-Position: refs/heads/master@{#311410}

R=toyoshim
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/838113003

Cr-Commit-Position: refs/heads/master@{#311409}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/827093006

Cr-Commit-Position: refs/heads/master@{#311408}

There is no default layout, so if we don't initialize one then all the key
events will be ignored.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/848953002

Cr-Commit-Position: refs/heads/master@{#311407}

More surfaceless renderer to using the async SwapBuffers implementation.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/846283002

Cr-Commit-Position: refs/heads/master@{#311406}

BUG=414272

Review URL: https://codereview.chromium.org/804263005

Cr-Commit-Position: refs/heads/master@{#311405}

The scheduler should trigger it's deadline immediately if there's no
more work to be done in a given frame. This happens for instance when a
commit is aborted and there's nothing to draw.

BUG=432981

Review URL: https://codereview.chromium.org/822933004

Cr-Commit-Position: refs/heads/master@{#311404}

Review URL: https://codereview.chromium.org/851823005

Cr-Commit-Position: refs/heads/master@{#311403}

This has several benefits:
Makes the warning obvious at the place of the problem
Makes suppressing the warnings the same as suppressing compiler and lint warnings
Makes supporting findbugs as part of the build easier

TBR=rmcilroy, mef, boliu

BUG=431826

Review URL: https://codereview.chromium.org/793203002

Cr-Commit-Position: refs/heads/master@{#311402}

Per
https://uberchromegw.corp.google.com/i/clank/builders/instrumentation-volantis-clankium-lmp,
all spdy related tests have failed on volantis bot.

BUG=447837

Review URL: https://codereview.chromium.org/836033006

Cr-Commit-Position: refs/heads/master@{#311401}

This was originally intended to be shared code with another project but that
will no longer be the case.

BUG=303491

Review URL: https://codereview.chromium.org/853603002

Cr-Commit-Position: refs/heads/master@{#311400}

The early out was accidentally dropped in a refactor. Add it back here.
And also add unit tests for clear view.

BUG=448488

Review URL: https://codereview.chromium.org/846323002

Cr-Commit-Position: refs/heads/master@{#311399}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a7f1191..31b52b7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/806583004

Cr-Commit-Position: refs/heads/master@{#311398}

Almost any character is valid in a filename. The rest of the pattern
should be restrictive enough that we don't actually match anything that
we don't want.

BUG=427718

Review URL: https://codereview.chromium.org/849973002

Cr-Commit-Position: refs/heads/master@{#311397}

Change created by following existing patterns and reading:
http://www.chromium.org/developers/design-documents/ui-localization

BUG=448585,381246

Review URL: https://codereview.chromium.org/811193005

Cr-Commit-Position: refs/heads/master@{#311396}

Review URL: https://codereview.chromium.org/852643003

Cr-Commit-Position: refs/heads/master@{#311395}

BUG=447642, 443766
TEST=TrayIMETest.PerformActionOnDetailedView, TrayIMETest.HidesOnA11yEnabled, TrayIMETest.HiddenWithNoIMEs

Review URL: https://codereview.chromium.org/843603004

Cr-Commit-Position: refs/heads/master@{#311394}

Immediately deletes the Incognito profile's cookies from the cookie
jar as soon as Profile is notified that a profile has been deleted.
The CookiesFetcher will confirm the incognito profile is missing,
then schedule them for deletion.

Also does general cleaning and renaming to less confusing method names.

BUG=447267

Review URL: https://codereview.chromium.org/833533004

Cr-Commit-Position: refs/heads/master@{#311393}

BUG=426119

Review URL: https://codereview.chromium.org/852433002

Cr-Commit-Position: refs/heads/master@{#311392}

BUG=

Review URL: https://codereview.chromium.org/850833002

Cr-Commit-Position: refs/heads/master@{#311391}

Rejig the watcher to run a message loop on the main thread, and to
do the blocking wait on a dedicated background thread.

BUG=412384

Review URL: https://codereview.chromium.org/848033005

Cr-Commit-Position: refs/heads/master@{#311390}

BUG=303818,433583

Review URL: https://codereview.chromium.org/846543002

Cr-Commit-Position: refs/heads/master@{#311389}

Get all font unittests running with DirectWrite on Windows 7+

Fixes as per below:-
1. Remove the addition of the fLeading value when calculating the height for the font
   with DirectWrite. fAscent + fDescent is the height of the font and adding the fLeading
   value to it returns the spacing between lines which is not what we are looking for.

2. The FontListTest.Fonts_GetHeight_GetBaseline unittest has a condition which basically validates
   whether the difference between the font height and the baseline is different for Arial and Symbol
   fonts. This fails for DirectWrite and fails for GDI with font sizes like 50, etc. Replaced this check
   with a check for the font heights are different.

3. Reworked the PlatformFontWinTest.DeriveFontWithHeight test to ensure it passes for DirectWrite and GDI.

4. Ensure that the PlatformFontWin::DeriveFontWithHeight function honors the minimum font size constraint
   in all cases.

BUG=442010
R=msw

Review URL: https://codereview.chromium.org/853553002

Cr-Commit-Position: refs/heads/master@{#311388}

This change upstreams the DownloadManagerService and OMADownloadHandler class, along with java tests.

BUG=15902
R=dtrainor@chromium.org, jbudorick@chromium.org

Review URL: https://codereview.chromium.org/848803002

Cr-Commit-Position: refs/heads/master@{#311387}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/bb928a0..a7f1191

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/846303003

Cr-Commit-Position: refs/heads/master@{#311386}

Some component apps and extensions use private extension APIs to
communicate with their browser components. This CL adds the mojoPrivate
API as a way to use mojo directly from Javascript without needing to
create a private API.

BUG=448565,448569

Review URL: https://codereview.chromium.org/649003003

Cr-Commit-Position: refs/heads/master@{#311385}

Combined GetAnyChromePath and GetChromeSxSPath into one function that
takes a bool |is_sxs|. Avoids the need to have a wrapper function that
conditionally calls GetAnyChromePath or GetAnyChromeSxsPath.

BUG=428600

Review URL: https://codereview.chromium.org/685103004

Cr-Commit-Position: refs/heads/master@{#311384}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=derat@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/816973003

Cr-Commit-Position: refs/heads/master@{#311383}

Related code is also being updated to the new version of LaunchProcess.

BUG=417532

Review URL: https://codereview.chromium.org/846753002

Cr-Commit-Position: refs/heads/master@{#311382}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=groby@chromium.org

Review URL: https://codereview.chromium.org/803963005

Cr-Commit-Position: refs/heads/master@{#311381}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0fda955..55561f5

TBR=hayato@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/825953004

Cr-Commit-Position: refs/heads/master@{#311380}

Revert of Implemented explicit resizing from guestview. (patchset #6 id:120001 of https://codereview.chromium.org/847893002/)

Reason for revert:
Broke out of process PDF.

Original issue's description:
> Implemented explicit resizing from guestview.
>
> A guest can now be explicitly resized (in addition to autosizing) from guest_view.js, using the new |setSize| function. This new function combines autosizing and normal resizing, as described in: https://docs.google.com/document/d/1EJfmJSK0JJsxKptSRhepnsOOwvXJNv5nnJ1pZdjGDRQ
>
> BUG=434226
>
> Committed: https://crrev.com/681a4fc1d1ac77a17c69ba23fa6710a0e3aa206f
> Cr-Commit-Position: refs/heads/master@{#311286}

TBR=paulmeyer@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=434226

Review URL: https://codereview.chromium.org/800543005

Cr-Commit-Position: refs/heads/master@{#311379}

In working on importing a newer version of SQLite, I found that I could
not find a copy of the previous version.  This makes it harder to figure
out if we have any mods which need to be tracked or unwound.

This import should be a non-event, since most of the files are identical
to the files in third_party/sqlite/src/ , so git will just add a reference.

BUG=340757

Review URL: https://codereview.chromium.org/826543003

Cr-Commit-Position: refs/heads/master@{#311378}

Also, removing special case where certain metrics where summed instead of averaged since they are now handled in the dashboard by averaging, no longer making them special cases.

BUG=447588

Review URL: https://codereview.chromium.org/847273002

Cr-Commit-Position: refs/heads/master@{#311377}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/846153005

Cr-Commit-Position: refs/heads/master@{#311376}

Compile of app_list_unittests on toolkit-views enabled Mac regressed in
r311143 because it accessed aura::Window and there is no Aura on Mac
yet.

The MouseHoverToHighlight passes on Mac - it just needs to initialize
the event generator differently.

TapGestureToHighlight is disabled on Mac, since there are no touch
events on desktop Mac.

BUG=441573, 445520, 365977

Review URL: https://codereview.chromium.org/840373003

Cr-Commit-Position: refs/heads/master@{#311375}

This regressed in r311208.

AppListBackground constructor no longer takes two arguments.

BUG=365977

Review URL: https://codereview.chromium.org/789333004

Cr-Commit-Position: refs/heads/master@{#311374}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/841103003

Cr-Commit-Position: refs/heads/master@{#311373}