GitLab

2009-04-24  Fumitoshi Ukai  <ukai@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25257
        Use null for unspecified event listener attributes of XMLHttpRequest
        and XMLHttpRequestUpload in v8 binding.

        cf. http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
        An event handler attribute, unless otherwise specified, can either
        have the value null or be set to a Function object.
        Initially, an event handler attribute must be set to null.

        Test: fast/xmlhttprequest/xmlhttprequest-default-attributes.html

        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::ACCESSOR_GETTER): Changed to use v8::Null().
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
        (WebCore::ACCESSOR_GETTER): Ditto.

LayoutTests:

2009-04-24  Fumitoshi Ukai  <ukai@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25257
        Verify XMLHttpRequest has correct attribute value by default.

        * fast/xmlhttprequest/resources/xmlhttprequest-default-attributes.js: Added.
        * fast/xmlhttprequest/xmlhttprequest-default-attributes-expected.txt: Added.
        * fast/xmlhttprequest/xmlhttprequest-default-attributes.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42828 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber-stamped by Gustavo Noronha.

        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Reword the
        description of the enable-spell-checking property and correct the
        mentioning of the default language used.

git-svn-id: svn://svn.chromium.org/blink/trunk@42827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Speculative fix for leopard build-bot until I have a fix on leopard.

        * platform/mac-leopard/editing: Added.
        * platform/mac-leopard/editing/deleting: Added.
        * platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42826 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        <rdar://problem/6663836> CrashTracer: crashes in Safari at com.apple.WebCore • WebCore::reportException + 1513

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::reportException): Added a null check.



git-svn-id: svn://svn.chromium.org/blink/trunk@42825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein

        Currently working on a bug where a WebHistoryItem was being used after being dealloc'ed.
        I added this assertion to help catch the case as soon as it happens instead of random
        issues downstream.  Figured it's worth checking in by itself.

        * History/WebHistoryItem.mm:
        (core): ASSERT that the WebCore::HistoryItem inside this WebHistoryItem is supposed to have
          this WebHistoryItem as a wrapper.



git-svn-id: svn://svn.chromium.org/blink/trunk@42824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=23219

        Add support for transtions and animations of background-position, -webkit-background-size,
        -webkit-mask-position and -webkit-mask-size.

        Tests: transitions/background-transitions.html
               transitions/mask-transitions.html

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):
        Add a blend func for LengthSize.

        (WebCore::ensurePropertyMap):
        Add wrappers for the new properties.

        (WebCore::addShorthandProperties):
        Add a shorthand property for CSSPropertyBackgroundPosition to map to
        CSSPropertyBackgroundPositionX and CSSPropertyBackgroundPositionY,
        add CSSPropertyWebkitMask for CSSPropertyWebkitMaskPosition, and add
        CSSPropertyWebkitMaskPosition for CSSPropertyWebkitMaskPositionX and
        CSSPropertyWebkitMaskPositionY.

        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setBackgroundXPosition):
        (WebCore::InheritedFlags::setBackgroundYPosition):
        (WebCore::InheritedFlags::setBackgroundSize):
        (WebCore::InheritedFlags::setMaskXPosition):
        (WebCore::InheritedFlags::setMaskYPosition):
        (WebCore::InheritedFlags::setMaskSize):
        Add setters for the properties that can be animated now.

git-svn-id: svn://svn.chromium.org/blink/trunk@42823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein.

        Updating these pixel results to the generated results on Leopard.

        * platform/mac/editing/inserting/5510537-expected.checksum:
        * platform/mac/editing/inserting/5510537-expected.png:
        * platform/mac/editing/inserting/6703873-expected.checksum:
        * platform/mac/editing/inserting/6703873-expected.png:
        * platform/mac/editing/selection/select-all-iframe-expected.checksum:
        * platform/mac/editing/selection/select-all-iframe-expected.png:



git-svn-id: svn://svn.chromium.org/blink/trunk@42822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-24  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

        Test: editing/pasteboard/paste-blockquote-after-blockquote.html

        When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
        But we should only merge here if the selection start was inside a mail blockquote.  This prevents against removing a 
        blockquote from newly pasted quoted content that was pasted into an unquoted position.  If that unquoted position happens 
        to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs.
        (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
        * editing/ReplaceSelectionCommand.h:

LayoutTests:

2009-04-24  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

        * editing/pasteboard/paste-blockquote-after-blockquote.html: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42821 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Implement EditorClient::ignoreWordInSpellDocument,
        EditorClient::learnWord and EditorClient::getGuessesForWord. This
        enables the corresponding user actions.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::ignoreWordInSpellDocument):
        (WebKit::EditorClient::learnWord):
        (WebKit::EditorClient::getGuessesForWord):

git-svn-id: svn://svn.chromium.org/blink/trunk@42820 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Implement EditorClient::checkSpellingOfString; enabling spell checking
        to actually happen, this is the basis for other spelling functions.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::checkSpellingOfString):

git-svn-id: svn://svn.chromium.org/blink/trunk@42819 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Add enchant support for spell-checking-languages property to work
        properly.

        * GNUmakefile.am:
        * configure.ac:

WebKit/gtk

2009-04-24  Diego Escalante Urrelo  <diegoe@gnome.org>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Add spell-checking-languages property to WebKitWebSettings.

        * webkit/webkitprivate.h:
        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_finalize):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_spell_languages):

git-svn-id: svn://svn.chromium.org/blink/trunk@42818 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Add enable-spell-checking property to WebKitWebSettings and implement
        EditorClient::isContinuousSpellCheckingEnabled and
        EditorClient::toggleContinuousSpellChecking to allow the UI to
        enable check as you type spell checking.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::isContinuousSpellCheckingEnabled):
        (WebKit::EditorClient::toggleContinuousSpellChecking):
        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):

git-svn-id: svn://svn.chromium.org/blink/trunk@42817 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Hausmann.

        Added Qt-specific expected result for color conversion.

        This is to compensate the lack of color profile in Qt to do
        color conversion, hence CMYK 0,0,0,1 always give pure black (#000)
        instead of very dark black.

        * platform/qt/fast/canvas/set-colors-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42816 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber-stamped by Ariya Hidayat.

        Fix qdoc warning about link to QAction::isEnabled.

git-svn-id: svn://svn.chromium.org/blink/trunk@42815 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Ariya Hidayat.

        Added support for generating API docs in the Qt build using "make docs"

        Added code snippets and overview from the Qt sources references in the API docs.

git-svn-id: svn://svn.chromium.org/blink/trunk@42814 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein.

        Updating test to make it easier to see the blockquote in the results.

        * editing/pasteboard/paste-blockquote-into-blockquote-3.html:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@42813 bbb929c8-8fbe-4397-9dbb-9b2b20218538

tests that use it can find it.

* platform/mac/editing/deleting/resources/deletionUI-helpers.js: Renamed from LayoutTests/editing/deleting/resources/deletionUI-helpers.js.

git-svn-id: svn://svn.chromium.org/blink/trunk@42812 bbb929c8-8fbe-4397-9dbb-9b2b20218538

order to restore greenness to the world once more.

* wtf/Platform.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42811 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: svn://svn.chromium.org/blink/trunk@42810 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:  Remove a symbol that no longer exists.

git-svn-id: svn://svn.chromium.org/blink/trunk@42809 bbb929c8-8fbe-4397-9dbb-9b2b20218538

JavaScriptCore:

2009-04-23  Francisco Tolmasky  <francisco@280north.com>

        BUG 24604: WebKit profiler reports incorrect total times
        <https://bugs.webkit.org/show_bug.cgi?id=24604>

        Reviewed by Timothy Hatcher and Kevin McCullough.

        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * profiler/CallIdentifier.h:
        (JSC::CallIdentifier::Hash::hash):
        (JSC::CallIdentifier::Hash::equal):
        (JSC::CallIdentifier::hash):
        (WTF::):
        * profiler/HeavyProfile.cpp: Removed.
        * profiler/HeavyProfile.h: Removed.
        * profiler/Profile.cpp: No more need for TreeProfile/HeavyProfile
        (JSC::Profile::create):
        * profiler/Profile.h:
        * profiler/ProfileNode.cpp:
        * profiler/ProfileNode.h:
        * profiler/TreeProfile.cpp: Removed.
        * profiler/TreeProfile.h: Removed.

WebCore:

2009-04-23  Francisco Tolmasky  <francisco@280north.com>

        BUG 24604: WebKit profiler reports incorrect total times
        <https://bugs.webkit.org/show_bug.cgi?id=24604>

        Reviewed by Timothy Hatcher and Kevin McCullough.

        Made it so that most of the profiler functions now match the behavior of Shark. Most notably, in the
        heavy view, child nodes now represent the statistics of the root node. Each root node of heavy view
        displays flattened statistics for a particular function that ran during the profile, and each child
        of these root nodes represents a callpath that lead to it. Thus, the statistics for each of these child
        nodes should show how much of the root nodes values came from it. For example, if you had the following to
        stacks take place during the profile:

        A ->calls 1 times-> B ->calls 2 times-> C
        D ->calls 4 times-> C

        The tree for the C root node would look like this:

        C -> B -> A
          -> D

        The number of calls values would look like this:

        C (6) -> B (2) -> A(2)
              -> D (4)

        What this means is that "2 of the total 6 C calls came from B", "2 of the total C calls came from A", and
        "4 of the total C calls came from D".  Notice that the "A ->calls 2 time->" is completely ignored. This becomes
        particularly tricky during recursive calls, because each child note can represent multiple possible paths. This
        is the reason that we would get things like 40000% previously with recursion.

        This is also the way gprof works, and as close as we can get to Shark's behavior (Shark is not instrumented so it
        can't know exactly how many calls came from where, etc).

        * English.lproj/localizedStrings.js: Added "Average" for average times in the profile.
        * inspector/JavaScriptProfile.cpp:
        (WebCore::ProfileClass):
        * inspector/JavaScriptProfileNode.cpp:
        (WebCore::getParent):
        (WebCore::getHead):
        (WebCore::getCallUID):
        (WebCore::ProfileNodeClass):
        * inspector/front-end/BottomUpProfileDataGridTree.js: Added.
        (WebInspector.BottomUpProfileDataGridTree):
        (WebInspector.BottomUpProfileDataGridTree.prototype.focus):
        (WebInspector.BottomUpProfileDataGridNode):
        (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
        (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
        (WebInspector.BottomUpProfileDataGridNode.prototype._exclude):
        (WebInspector.BottomUpProfileDataGridNode.prototype._merge):
        (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid.prototype.insertChild):
        (WebInspector.DataGrid.prototype.removeChild):
        (WebInspector.DataGrid.prototype.removeChildren):
        (WebInspector.DataGridNode.prototype.set hasChildren):
        (WebInspector.DataGridNode.prototype.get hasChildren):
        * inspector/front-end/ProfileDataGridTree.js: Added.
        (WebInspector.ProfileDataGridNode):
        (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
        (WebInspector.ProfileDataGridNode.prototype.get data):
        (WebInspector.ProfileDataGridNode.prototype.createCell):
        (WebInspector.ProfileDataGridNode.prototype.select):
        (WebInspector.ProfileDataGridNode.prototype.deselect):
        (WebInspector.ProfileDataGridNode.prototype.expand):
        (WebInspector.ProfileDataGridNode.prototype.insertChild):
        (WebInspector.ProfileDataGridNode.prototype.removeChild):
        (WebInspector.ProfileDataGridNode.prototype.removeChildren):
        (WebInspector.ProfileDataGridNode.prototype.findChild):
        (WebInspector.ProfileDataGridNode.prototype.get averageTime):
        (WebInspector.ProfileDataGridNode.prototype.get averagePercent):
        (WebInspector.ProfileDataGridNode.prototype.get selfPercent):
        (WebInspector.ProfileDataGridNode.prototype.get totalPercent):
        (WebInspector.ProfileDataGridNode.prototype._save):
        (WebInspector.ProfileDataGridNode.prototype._restore):
        (WebInspector.ProfileDataGridNode.prototype._merge):
        (WebInspector.ProfileDataGridTree):
        (WebInspector.ProfileDataGridTree.prototype.get expanded):
        (WebInspector.ProfileDataGridTree.prototype.appendChild):
        (WebInspector.ProfileDataGridTree.prototype.insertChild):
        (WebInspector.ProfileDataGridTree.prototype.removeChildren):
        (WebInspector.ProfileDataGridTree.prototype.findChild.WebInspector.ProfileDataGridNode.prototype.findChild.sort.WebInspector.ProfileDataGridNode.prototype.sort._save):
        (WebInspector.ProfileDataGridTree.propertyComparator.comparator):
        (WebInspector.ProfileDataGridTree.propertyComparator.else.comparator):
        (WebInspector.ProfileDataGridTree.propertyComparator):
        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView):
        (WebInspector.ProfileView.prototype.set profile):
        (WebInspector.ProfileView.prototype.get bottomUpProfileDataGridTree):
        (WebInspector.ProfileView.prototype.get topDownProfileDataGridTree):
        (WebInspector.ProfileView.prototype.get currentTree):
        (WebInspector.ProfileView.prototype.set currentTree):
        (WebInspector.ProfileView.prototype.get topDownTree):
        (WebInspector.ProfileView.prototype.get bottomUpTree):
        (WebInspector.ProfileView.prototype.refresh):
        (WebInspector.ProfileView.prototype.refreshVisibleData):
        (WebInspector.ProfileView.prototype.refreshShowAsPercents):
        (WebInspector.ProfileView.prototype.performSearch.matchesQuery):
        (WebInspector.ProfileView.prototype.performSearch):
        (WebInspector.ProfileView.prototype._changeView):
        (WebInspector.ProfileView.prototype._focusClicked):
        (WebInspector.ProfileView.prototype._excludeClicked):
        (WebInspector.ProfileView.prototype._resetClicked):
        (WebInspector.ProfileView.prototype._sortProfile):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.showProfile):
        (WebInspector.ProfilesPanel.prototype.showView):
        (WebInspector.ProfilesPanel.prototype.searchMatchFound):
        * inspector/front-end/TopDownProfileDataGridTree.js: Added.
        (WebInspector.TopDownProfileDataGridNode):
        (WebInspector.TopDownProfileDataGridNode.prototype._populate):
        (WebInspector.TopDownProfileDataGridNode.prototype._exclude):
        (WebInspector.TopDownProfileDataGridTree):
        (WebInspector.TopDownProfileDataGridTree.prototype.focus):
        (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:

LayoutTests:

2009-04-23  Francisco Tolmasky  <francisco@280north.com>

        BUG 24604: WebKit profiler reports incorrect total times
        <https://bugs.webkit.org/show_bug.cgi?id=24604>

        Reviewed by Timothy Hatcher and Kevin McCullough.

        Changed profile.treeProfile to just profile, since these aren't generated in C++ anymore.
        Removed heavy-view test since heavy-view isn't an actual tree that is generated in C++ land anymore,
        but rather just a different display of the normal treeProfile in the JS data grid.

        * fast/profiler/heavy-view-expected.txt: Removed.
        * fast/profiler/heavy-view.html: Removed.
        * fast/profiler/resources/profiler-test-JS-resources.js: profiles[i].treeProfile -> profiles[i].treeProfile
        (printProfilesDataWithoutTime):

git-svn-id: svn://svn.chromium.org/blink/trunk@42808 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Use static functions (and a couple templates)
        to further reduce the amount of copy/paste code in SVGRenderTreeAsText

        No test changes, only code cleanup.

        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeNameValuePair):
        (WebCore::writeNameAndQuotedValue):
        (WebCore::writeIfNotEmpty):
        (WebCore::writeIfNotDefault):
        (WebCore::writeStyle):
        (WebCore::writePositionAndStyle):
        (WebCore::operator<<):

git-svn-id: svn://svn.chromium.org/blink/trunk@42807 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        - Windows build fix.  Mac only tests go in platform/mac

        * editing/deleting/deletionUI-borders.html: Removed.
        * editing/deleting/deletionUI-differing-background.html: Removed.
        * editing/deleting/deletionUI-minimum-size.html: Removed.
        * platform/mac/editing/deleting/deletionUI-borders.html: Copied from editing/deleting/deletionUI-borders.html.
        * platform/mac/editing/deleting/deletionUI-differing-background.html: Copied from editing/deleting/deletionUI-differing-background.html.
        * platform/mac/editing/deleting/deletionUI-minimum-size.html: Copied from editing/deleting/deletionUI-minimum-size.html.



git-svn-id: svn://svn.chromium.org/blink/trunk@42806 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Not Reviewed.

        Speculative Windows build fix II.

        * yarr/RegexInterpreter.cpp:



git-svn-id: svn://svn.chromium.org/blink/trunk@42805 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Not Reviewed.

        Speculative Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * runtime/RegExp.cpp:



git-svn-id: svn://svn.chromium.org/blink/trunk@42804 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        SVGRenderTreeAsText cleanup/code sharing.

        No test changes, only code cleanup.

        * rendering/RenderText.cpp:
        (WebCore::RenderText::firstRunOrigin):
        * rendering/RenderText.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeStandardPrefix):
        (WebCore::writeChildren):
        (WebCore::write):
        (WebCore::writeRenderResources):

git-svn-id: svn://svn.chromium.org/blink/trunk@42803 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber stamped by salty sea dogs Sam & Geoff.

        Enable YARR_JIT by default (where supported), replacing WREC.

        * wtf/Platform.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42802 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Removed some stray files that Geoff missed when rolling out changes.

        * svg/custom/resources/svg-fonts-in-text-controls.js: Removed.
        * svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.



git-svn-id: svn://svn.chromium.org/blink/trunk@42801 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-23  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff "Dread Pirate Roberts" Garen.

        Various small fixes to YARR JIT, in preparation for enabling it by default.

        * Correctly index into the callframe when storing restart addresses for
          nested alternatives.
        * Allow backtracking back into matched alternatives of parentheses.
        * Fix callframe offset calculation for parenthetical assertions.
        * When a set of parenthese are quantified with a fixed and variable portion,
          and the variable portion is quantified once, this should not reset the
          pattern match on failure to match (the last match from the firxed portion
          should be preserved).
        * Up the pattern size limit to match PCRE's new limit.
        * Unlclosed parentheses should be reported with the message "missing )".

        * wtf/Platform.h:
        * yarr/RegexCompiler.cpp:
        (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
        (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::Interpreter::matchParentheses):
        (JSC::Yarr::Interpreter::backtrackParentheses):
        (JSC::Yarr::ByteCompiler::emitDisjunction):
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::loadFromFrameAndJump):
        (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction):
        (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
        (JSC::Yarr::RegexGenerator::generateTerm):
        (JSC::Yarr::executeRegex):
        * yarr/RegexParser.h:
        (JSC::Yarr::Parser::):
        (JSC::Yarr::Parser::parseTokens):
        (JSC::Yarr::Parser::parse):
        * yarr/RegexPattern.h:
        (JSC::Yarr::PatternTerm::):
        (JSC::Yarr::PatternTerm::PatternTerm):

LayoutTests:

2009-04-23  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff "Dread Pirate Roberts" Garen.

        This test tries to force itself into PCRE; modify the
        test so that as well as dodging WREC it can also avoid
        YARR!

        * fast/js/resources/regexp-overflow-too-big.js:



git-svn-id: svn://svn.chromium.org/blink/trunk@42800 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        WebCore part of fix for <rdar://problem/6333461> REGRESSION 
        (r36864-r36869): Dragging stocks widget scrollbar drags the whole 
        widget

        * platform/Scrollbar.h:
        (WebCore::Scrollbar::isScrollbar):
        * platform/Widget.h:
        (WebCore::Widget::isScrollbar):

WebKit/mac:

2009-04-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/6333461> REGRESSION (r36864-r36869): 
        Dragging stocks widget scrollbar drags the whole widget

        Look for our new WebCore scrollbars in the WebHTMLView and add 
        proper Dashboard regions for them.

        * WebView/WebView.mm:
        (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
        (-[WebView _addScrollerDashboardRegions:from:]):



git-svn-id: svn://svn.chromium.org/blink/trunk@42799 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/6808109> "Deletion UI" is not available for many
        portions of HTML content

        This patch makes the deletion UI show up in some new situations:
        1) If a block's background color is different from its parent's
        2) If a block has a background image.
        3) If a block has a single visible border.
        However the block must now not only be at least a minimum width and
        height, but also exceed a minimum area.  In practice this has led to
        much better element selection. 

        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement):

LayoutTests:

2009-04-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/6808109> "Deletion UI" is not available for many
        portions of HTML content

        This patch makes the deletion UI show up in some new situations:
        1) If a block's background color is different from its parent's
        2) If a block has a background image.
        3) If a block has a single visible border.
        However the block must now not only be at least a minimum width and
        height, but also exceed a minimum area.  In practice this has led to
        much better element selection.

        * editing/deleting/deletionUI-borders.html: Added.
        * editing/deleting/deletionUI-differing-background.html: Added.
        * editing/deleting/deletionUI-minimum-size.html: Added.
        * editing/deleting/resources: Added.
        * editing/deleting/resources/deletionUI-helpers.js: Added.
        (debug):
        (determineDeletionUIExistence):
        * platform/mac/editing/deleting/deletionUI-borders-expected.txt: Added.
        * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
        * platform/mac/editing/deleting/deletionUI-minimum-size-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42798 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42797 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        fixed <rdar://problem/6822479> Assertion failure after Reset Safari in new history-writing code

        Reviewed by Oliver Hunt

        * History/WebHistory.mm:
        (-[WebHistoryPrivate data]):
        Return nil immediately if there are no entries; this matches a recent Windows-platform fix.



git-svn-id: svn://svn.chromium.org/blink/trunk@42796 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Fix for <rdar://problem/6788905> REGRESSION (41928?): hang in Position::upstream
        https://bugs.webkit.org/show_bug.cgi?id=25312

        I was unable to reproduce the problem, but I'm pretty sure this will fix it.

        * rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
        Since VisiblePosition doesn't ensure the offset is good, we shouldn't pass max int as an offset.



git-svn-id: svn://svn.chromium.org/blink/trunk@42794 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42793 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-23  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25313
        Missing scroll bars in GMail.

        Test: fast/overflow/overflow-y-scroll.html

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::updateScrollbars): Added check for the ScrollbarAlwaysOn
        scroll mode.

LayoutTests:

2009-04-23  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.
        https://bugs.webkit.org/show_bug.cgi?id=25313
        Missing scroll bars in GMail.

        * fast/overflow/overflow-y-scroll-expected.txt: Added.
        * fast/overflow/overflow-y-scroll.html: Added.

WebKit/mac:

2009-04-23  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25313
        Missing scroll bars in GMail.

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView updateScrollers]): Added check for the ScrollbarAlwaysOn
            scroll mode.

git-svn-id: svn://svn.chromium.org/blink/trunk@42791 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42790 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Geoffrey Garen.

        Fix <rdar://problem/6821992>

        Add a new m_inDestroy member variable. Set it to true when in destroy, and have all NPRuntime functions return false
        when m_inDestroy is true.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        (WebKit::NetscapePluginInstanceProxy::destroy):
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::invokeDefault):
        (WebKit::NetscapePluginInstanceProxy::construct):
        (WebKit::NetscapePluginInstanceProxy::getProperty):
        (WebKit::NetscapePluginInstanceProxy::setProperty):
        (WebKit::NetscapePluginInstanceProxy::removeProperty):
        (WebKit::NetscapePluginInstanceProxy::hasProperty):
        (WebKit::NetscapePluginInstanceProxy::hasMethod):
        (WebKit::NetscapePluginInstanceProxy::enumerate):



git-svn-id: svn://svn.chromium.org/blink/trunk@42789 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Justin Garcia.

        - fix <rdar://problem/6081309> Mail crash when pressing down arrow in
          some messages in WebCore::canHaveChildrenForEditing

        Test: editing/selection/extend-by-line-anonymous-content-crash.html

        * editing/visible_units.cpp:
        (WebCore::previousLinePosition): Null-check node. If p is not an
        editable position, then closestLeafChildForXPos() may have returned a
        non-editable box, and in particular one belonging to anonymous content.
        If node is 0, fall back on RenderObject::positionForPoint, which
        finds the closest position in non-anonymous content.
        (WebCore::nextLinePosition): Ditto.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createVisiblePosition): Fixed a typo.

LayoutTests:

        Reviewed by Justin Garcia.

        - test for <rdar://problem/6081309> Mail crash when pressing down arrow
          in some messages in WebCore::canHaveChildrenForEditing

        * editing/selection/extend-by-line-anonymous-content-crash-expected.txt: Added.
        * editing/selection/extend-by-line-anonymous-content-crash.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42788 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Maciej.

        Fix for <rdar://problem/6789879> REGRESSION (42464): Hitting assertion when loading message in Mail + TOT WebKit
        
        Make the Mac platform the same as all the other platforms.  Instead of (incorrectly) marking a FrameView for layout
        when its underlying document view changes, just mark the outermost frame view for layout when the WebView's size changes.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _frameOrBoundsChanged]):
        (-[WebHTMLView addSuperviewObservers]):
        * WebView/WebView.mm:
        (-[WebView _boundsChanged]):
        (-[WebView removeSizeObservers]):
        (-[WebView addSizeObservers]):



git-svn-id: svn://svn.chromium.org/blink/trunk@42787 bbb929c8-8fbe-4397-9dbb-9b2b20218538