- 07 Mar, 2019 40 commits
-
-
chrome://usb-internalsNancy Li authored
This change added 'Device' tab to the chrome://usb-internals page, and can display all the real devices that connected to the machine. Bug: 928923 Change-Id: Ie1f3c2dcea69dabdfb43ea5dbe1ae516573cd694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1473710 Commit-Queue: Nancy Li <nancyly@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638712}
-
Mugdha Lakhani authored
This removes all checks for feature flags, removes the feature flags themselves, and updates any affected tests. Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-iAATJCpcNY Bug: 704729 Change-Id: I69bfd29787ad5d3299991cfa1b77f33c597a8e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508092 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638711}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/356474278798..3cfa438106ff git log 356474278798..3cfa438106ff --date=short --no-merges --format='%ad %ae %s' 2019-03-07 cferris@google.com Update for new function malloc_init. Created with: gclient setdep -r src/third_party/perfetto@3cfa438106ff The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4fd6e5089a3b43ce1ee44291e416efc5522c864b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509133Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638710}
-
Jun Mukai authored
When the draggable_regions->getBounds() has smaller width than the widget's width, the inset decreases the top regions of the widget but inversion is computed against draggable_regions width, so it misses some additional client areas asides the draggable regions. Instead, the inversion needs to be computed against the areas decreased by the inset. Bug: 939094 Test: manually Change-Id: Ia1b509b6ec5cf1ba10b44919b1da73eb03942608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509097 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#638709}
-
Robert Liao authored
This reverts commit 4f9a19f1. Reason for revert: Suspected in causing webkit_layout_test failures https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/9784 * media/video-played-collapse.html * virtual/video-surface-layer/media/video-played-collapse.html Original change's description: > AudioService: Fixes for loopback underruns/timing issues. > > Fixes a "choppy audio" issue on platforms with certain audio timing > parameters/scenarios. Investigation on crbug.com/934770 led to the > realization that three related problems needed to be addressed: > > 1. Fix the "gap" detection in audio::SnooperNode to check in BOTH > directions, not just one direction; and on both the input and output > flows. This accounts for the case where a device-switch in > audio::OutputController results in a sudden drastic shift in the delay > timestamps. > > 2. Add automatically-increasing capture delay logic to > audio::LoopbackStream to ensure the reads from all nodes' delay buffer > will never result in underrun. > > 3. Increased the accuracy of media::FakeAudioWorker/OutputStream by: a) > addressing a subtle source of error in task scheduling delay math due to > integer truncation; b) exposing timestamps to worker callbacks that > allow FakeAudioOutputStream to provide a |delay| and |delay_timestamp| > that behaves just like a real AudioOutputStream. This "lessens the blow" > of a device-switch to SnooperNode. > > Bug: 934770 > Change-Id: Ia75f18b2be3ad905f27d6ad882df9632764bb81c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504981 > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Max Morin <maxmorin@chromium.org> > Reviewed-by: Oskar Sundbom <ossu@chromium.org> > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638427} TBR=dalecurtis@chromium.org,miu@chromium.org,braveyao@chromium.org,maxmorin@chromium.org,ossu@chromium.org Change-Id: I845f547c60481ebde0ae24d1a83d59f2f750f7e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509365Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638708}
-
Victor Vasiliev authored
Merge internal change: 237089889 R=rch@chromium.org Change-Id: I8051e8cb9260833d678884a0affcb272ada8cd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507194 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#638707}
-
Philip Rogers authored
Due to existing regressions, this patch disables BlinkGenPropertyTrees. For completeness (to prevent another http://crbug.com/935195), tested: +------------------------------------------------+-----------+------------+ | flag | pre-patch | post-patch | +------------------------------------------------+-----------+------------+ | no flag | BGPT on | BGPT on* | | --enable-features=BlinkGenPropertyTrees | BGPT on | BGPT on | | --disable-features=BlinkGenPropertyTrees | BGPT off | BGPT off | | --enable-blink-features=BlinkGenPropertyTrees | BGPT on | BPGT on | | --disable-blink-features=BlinkGenPropertyTrees | BGPT off | BGPT off | +------------------------------------------------+-----------+------------+ * This is due to the finch field trial testing config. content/child/runtime_features.cc now checks for experimental web platform features because the BlinkGenPropertyTrees flag is fully controlled by the feature default in third_party/blink/common/features.cc and would be disabled in web tests (formerly layout tests) without this check. Bug: 836884 Change-Id: I590e1b7c697c7c70cf3c4c5121483b2dd76c74df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505836Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638706}
-
John Delaney authored
These deps(introduced by https://crrev.com/74efc1ddfa7c8) are causing some builds to flake because the mojom headers are being exported before the mojom c++ sources are generated. Moving the mojom dep to public deps will prevent this from occuring. See bug for more info. Bug: 939044 Change-Id: I9f0c6d2a5bf0f1c7f7d016b1170e8c2c5d2d02c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506765 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#638705}
-
Dmitry Titov authored
Writing timestamp before the actual reporting may actually result in skipping the reporting and waiting another week before the next opportunity. Move the timestamp writing to the after the reporting was actually done. Bug: 939213 Change-Id: I540d1780ed95c361959732655796270e95787dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507393Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#638704}
-
Marco Paniconi authored
https://chromium.googlesource.com/webm/libvpx.git/+log/d64e328624e0..8256c8b297c8 $ git log d64e32862..8256c8b29 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 marpan vp9-rtc: Improve mode check on flat blocks in screen mode 2019-03-06 marpan vp9-denoiser: Bias to last for golden long term 2019-03-04 johannkoenig add -Wmissing-prototypes Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I4e4b198174b59f023a7e1e399785adeed12d58dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508602Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#638703}
-
Donn Denman authored
Updates the requests that we send to the server to use the next higher API level for Coca, when enabled by the Definitions Feature. We will use this to activate contextual definitions. This API level supports returning the full search URLs from the server, so we don't need to build them from scratch on the client. These new search URLs get passed through the system, and is the only thing touching most of the files in this CL. We also update our Field Trial support for Contextual Search to allow a Feature-param on the Definitions Feature to specify the Coca integration level so we can have multiple finch-controlled experiment arms that control server-functionality. We plan to use this for different triggering levels for Definition cards. BUG=936695 Change-Id: I0666d07000447a9cfb4be5a2344d29c24c47f4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501759 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638702}
-
Tien Mai authored
Bug: 939353 Change-Id: I8e4486cc471164b0586076361b2155b8bdc7bc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508772Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#638701}
-
Natalie Chouinard authored
This internals page is used to surface debugging information useful to developers of the NTP Interest Feed. This CL surfaces the current Feed content, including suggestion titles, URLs and other metadata. https://screenshot.googleplex.com/gGGcX0BZkYM Bug: 913126 Change-Id: I48dd63698229f43bb1671a0035e7c0b6cf34559a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506539 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638700}
-
Elly Fong-Jones authored
Bug: None Change-Id: I47934cdb696aca8e697f7c461495fb67edf4a894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508784 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#638699}
-
Drew Davenport authored
Before https://crrev.com/c/1363676, a logic bug ensured that all Chrome OS devices would exit the gpu process on context loss. It turns out that this workaround was necessary for AMD chromebooks to pass the dEQP-EGL.functional.robustness.reset_context.shaders.infinite_loop.* tests. BUG=b:123606754 TEST=pass dEQP-EGL on grunt Change-Id: I34f2d601cc0643cdae568955830e56ac3164f851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504304 Commit-Queue: Drew Davenport <ddavenport@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Auto-Submit: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#638698}
-
Elly Fong-Jones authored
Bug: None Change-Id: Ia33fbcb45db07ff825df129abcd8a5e23c1eda08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509234 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638697}
-
Elly Fong-Jones authored
Bug: 839986 Change-Id: Ib7d6a38a6b62d467b299d5f06b840d308fcb6ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508787 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#638696}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fff41430adb0..cb039b04e175 Created with: gclient setdep -r src-internal@cb039b04e175 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: I1721de6ed48dace03583dd2d7d9850091a62259e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508992Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638695}
-
Josh Nohle authored
In CryptAuthKeyCreatorImpl, elements of a flat_map were being erased while the flat_map was still being iterated through. This caused a container overflow ASAN error in http://crrev.com/c/1504121. Verified locally that this CL fixes the ASAN error seen in http://crrev.com/c/1504121, using the same gn args as the linux_chromium_chromeos_asan_rel_ng builder. Bug: 899080 Change-Id: I6f25d795545548ed108e95e2e1ec70f6de20941b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507314Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#638694}
-
Bo Liu authored
Presentation is not yet hooked up for android webview. Currently it is leaking a little bit of memory for every new compositor frame submitted. Just clear that map for now. Bug: 939381 Change-Id: I992835d4b2e68ea97ae8baaf435e29298ec2dc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508892 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#638693}
-
Thomas Guilbert authored
CreateRenderer(HostedRendererType) was left in after Create*Renderer was added, in order to prevent breaking the internal ChromeCast build. This CL cleans up the leftovers and should be submitted after Chromecast interal code switches to CreateCastRenderer() Bug: 936528 Change-Id: I29ee8104099485ed32a22aec9ccd6cff5cd63771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493082Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#638692}
-
Ken MacKay authored
Allow updating the patterns that the redirector matches to mixer streams without removing and re-adding the redirector. Bug: internal b/123626919 Test: cast_audio_backend_unittests Change-Id: I4f79d9d1c1c95ba213bc1396d9d708fd8bb037bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506670Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#638691}
-
Evan Stade authored
Clear touch screen devices after each test so that touch screen configuration doesn't interfere with the next test's setup. Specifically, having a touch screen device causes the virtual keyboard to be enabled before Shell is done initializing. Bug: 939177 Change-Id: I8e24cc9ab2f425cdc8d9a3b4d11b0a4e1fd6d9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507250Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638690}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ccc29087522a..699655f07b93 git log ccc29087522a..699655f07b93 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 benjhayden@chromium.org Fix spa tests. Created with: gclient setdep -r src/third_party/catapult@699655f07b93 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=sullivan@chromium.org Change-Id: I9e9fb60c0c27e63225659cb611a6c13a972d4239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508912Reviewed-by:
-
Antonio Gomes authored
This is a follow up of https://crrev.com/c/1496217 TBR=jbroman@chromium.org BUG=891908 Change-Id: Ib3a86b00c39ee0c0cc7081fbd87038d3a03c8cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509192Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#638688}
-
John Chen authored
Clean up code that has become obsolete due to decomission of ChromeDriver waterfall. Change-Id: Ifbdb43872111ec3e575ec6e4aa1b28b76b663756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509095 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#638687}
-
Richard Knoll authored
This makes sure that we only allow up to 30 scheduled notifications and handles the case when we update an existing notification with a scheduled one. Bug: 891339 Change-Id: Ifb884367d71f9156abf303d8330364f671e3afb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505503 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Reid Kleckner authored
This reverts commit 281e80c3. Reason for revert: New test fails in official builds: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/104341 https://ci.chromium.org/p/chrome/builders/ci/ToTWin64/3351 Original change's description: > Add tests that lookalike interstitial decisions are shared with incognito. > > This CL adds tests to verify that a decision to bypass the lookalike > interstitial made in the main profile does not affect incognito and vice > versa. > > Bug: 927924 > Change-Id: I238e2e263db42c1434b9190de007aa775129417e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506458 > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638329} TBR=meacer@chromium.org,jdeblasio@chromium.org Change-Id: I68dbe18b841f4022ae0b533402d1f7fe1fa377b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509333Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#638685}
-
Charlie Harrison authored
This re-lands this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1503614 Which was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1504597 There's one additional change, which is to ensure that windows runtime_libs are available as data_deps. This omission was causing failures on win_chromium_dbg_ng. Bug: 938020 Change-Id: Id0196d86097f938d046c7936e619d1c7cf8174c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506124Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#638684}
-
Lily Chen authored
Previously we accumulated NEL policies forever until they were wiped out by a browser restart. This CL introduces a maximum policy limit, beyond which eviction of expired and/or least recently used policies is triggered. A last_used field is added to the policies in order to find the stalest policy to evict. Bug: 930301 Change-Id: Ifebfc64c19a4228e8830f62c52e83bc06790cba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474530 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#638683}
-
Caitlin Fischer authored
Making a new branch and CL to resolve issues with git and try jobs. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1498614 The utils for making various LabelFormatters sometimes favor std::set over std::vector so that poorly formed forms, e.g. forms with duplicate fields, do not interfere with processing later on. Sets allow us to safely assume that there is just one of a particular ServerFieldType or FieldTypeGroup. It is worth noting that ContactFormLabelFormatters store their FieldTypeGroups while AddressFormLabelFormatters do not. This is because address forms are guaranteed to have ADDRESS_HOME and NAME; however, contact forms could have NAME and PHONE_HOME, EMAIL, or both PHONE_HOME and EMAIL. It is useful for a ContactFormLabelFormatter to know which subset of FieldTypeGroups correspond to its fields. Change-Id: I6164081759848b263c3d9dd5cfcda190388a3d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506116 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#638682}
-
Majid Valipour authored
I can review changes for anything scroll snap related. 🧐 Change-Id: Ia6c794e6bc6b91588cfe7fb8c133c253e2a04c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497388Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638681}
-
Nicolás Peña Moreno authored
Bug: 939100 Change-Id: Ia8b7bd430ece375a14569d86482b38c9ad461fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506877Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#638680}
-
Istiaque Ahmed authored
Dispatcher is expected to receive messaging IPCs for main thread and not worker threads. Add the check to Dispatcher::OnDeliverMesage, similar to what existed for other messages, e.g. Dispatcher::OnDispatchOnDisconnect. Bug: None Test: No visible changes expected. Change-Id: I0c11b302b9d9610b1f8792ebf2a385e0aec9fb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508601Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638679}
-
Istiaque Ahmed authored
The render process id param became obolete and unused at some point, remove it. Bug: None Test: No expected change, internal cleanup only. Change-Id: I422242473c0118692e010909c8380971f01812cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508600Reviewed-by:
-
Robert Liao authored
BUG=939406 TBR=robertma@chromium.org Change-Id: I49024a8fad4b64cce2bf31d963b1ba1d80b32670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508581Reviewed-by:
-
Scott Violet authored
Renames in_set_bounds_from_server to is_server_setting_bounds, which is hopefully a bit easier to understand. BUG=none TEST=none Change-Id: Ic972be85123dc234fa98baee4d2d602bbcc84a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507324 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#638676}
-
Greg Kerr authored
This adds additional resource access to the V2 GPU sandbox to address crashes. Bug: 915934 Change-Id: Icf346f03e32523549e5cb9c0806dce1a51794da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506390 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#638675}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/45faa0849352..ec255730a818 git log 45faa0849352..ec255730a818 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 bclayton@google.com Reactor: Add address-of operator on reference types. Created with: gclient setdep -r src/third_party/swiftshader@ec255730a818 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126330097 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I1304317d6ebd954f85b3fccede912dffe6539326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508833Reviewed-by:
-
Bruno Santos authored
Bug: 930922 Change-Id: I86eaed2c769f16ac21bcb7d4ee1f96dd01243f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506876Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638673}
-
