- 23 Jul, 2019 40 commits
-
-
Christopher Gunadi authored
By default, root access to Crostini is allowed. This experimental user policy and pref will be used to control whether user root access to Crostini is allowed. The functionality for this will be hidden behind a feature flag. This CL only contains initial definition for the policy and pref, along with wiring them together. Bug: 983997, 983998 Change-Id: I629885b0423264b668de577e71c3c396a74c9d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702369 Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#679934}
-
Benoît Lizé authored
From the finch experiment (see linked bug), this saves .7-5MB of memory per renderer on Windows and Android, at a cost of ~0.01% of idle time main thread CPU. As a consequence, enabling it by default. Metrics note: The impact it not expected to be seen in the reported metrics, see the bug for details. This may even be reported as a slight memory regression, which is expected. In this CL: - Enable periodic decommit by default - Update the unit tests accordingly. The feature is not removed yet, to leave the possibility to disable it on the M77 branch. Bug: 942512 Change-Id: Ia673c55a62e0c273645dc783bbde2f9458a72d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712563Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#679933}
-
Jan Wilken Dörrie authored
Provides convenience templates that dispatch to correct type in winrt system, as well as helpers for copy, equality and comparison. BUG=728870 TBR=gab@chromium.org, robliao@chromium.org Change-Id: I3d4f19471778d5a25c13a30ea9203add0aadb4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695407 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#679932}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie723315d2dd022bbb428d5706824f5a33b4622fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679931}
-
Yasmin authored
Bug: 986327 Change-Id: Ia2f987d65a4e09c1d368552a729ada79901c43ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713167Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#679930}
-
Michael van Ouwerkerk authored
Bug: 976311 Change-Id: Ib3dc2d0e3d47ca2452749f912f8ffc2a687b6861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709580 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
danakj authored
R=dcheng Bug: 912193 Change-Id: Ic61fec531ad323dfe174930deb9dc9ec64c46b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713704 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#679928}
-
Stephane Zermatten authored
This change implements AutofillAssistantFacade.createDirectActionHandler based on AA. This implements two direct actions list_assistant_actions and perform_assistant_action. list_assistant_actions lists available direct actions, as returned by Controller:GetUserActions. If needed, it creates a controller and calls Controller::Track to wait for the first set of scripts to be available. perform_assistant_action executes a direct action, which comes down to finding the user action whose name matches and then performing it on the controller. Performing an action with no name triggers the autostart logic in Controller::Start. The implementation takes care of loading the DFM, if necessary, and runs onboarding as necessary or when asked explicitly by the caller. Bug: b/134741524 Change-Id: I29bbc7b535f7007b4552cd523722cd97e47c5a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699607 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#679927}
-
Sergio Villar Senin authored
They're much better placed there than directly under platform/ Bug: 919385 Change-Id: I9583741da31e28217a9f331322ca8246984b94eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713190 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#679926}
-
Yi Su authored
WebFramesManager is a sub component of WebStateImpl, it should be an ivar like NavigationManager instead of WebStateUserData like FindInPageManager. Converting it to ivar will remove unnecessary "static_cast" in WebFramesManagerImpl, improve testabibiliy and decouple it from WebStateImpl. Bug: 956516 Change-Id: Icb3d91c1f7c42350ca5ed22f5a5aab88de9ffabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710310 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#679925}
-
Richard Knoll authored
This makes sure that we clear any existing text of the omnibox icon when switching to a different tab. Bug: 986053 Change-Id: I2036547046edae1d2869ab7d512ade92e8cab9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712670Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#679924}
-
Monica Basta authored
The part of DICE population isn't migrated because they are in an inconsistent state between the chrome and gaia accounts. In this CL, we compute the reason of inconsistency and upload it to UMA. We need this histogram to measure how the population to be migrated to DICE will be affected by the transition. The reason of inconsistency will derive the actions needed to migrate to DICE and how the user will be affected. We only record this metric to UMA if account consistency method is kDiceMigration. Bug: 983983 Change-Id: I85815e4fd18ea1fd86000a186c0e3b29e8cc30a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700209 Commit-Queue: Monica Basta <msalama@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#679923}
-
Juan Antonio Navarro Perez authored
The catapult CL: https://chromium-review.googlesource.com/c/catapult/+/1713628 is changing slightly some messages in run_benchmark's command line interface. This CL adjusts the test expectations so they match the new interface, but keeps these tests disabled for now. After the catapult CL above lands, the tests can be re-enabled. TBR=crouleau@chromium.org Bug: 928275 Change-Id: If2f9f70862a923a67dcc534ab25433fbc4f2f7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713629Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#679922}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0c0d6d8e6b38..f9010f590b1d git log 0c0d6d8e6b38..f9010f590b1d --date=short --no-merges --format='%ad %ae %s' 2019-07-23 dberris@chromium.org Pinpoint: Host Dashboard static files too Created with: gclient setdep -r src/third_party/catapult@f9010f590b1d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:986704 TBR=skyostil@google.com Change-Id: Iffa50f75cba89aec2ce846670afda9e3f2c0d8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714770Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/07b5be3bc5df..4e3b218e9695 git log 07b5be3bc5df..4e3b218e9695 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 cwallez@chromium.org Introduce a format table in the OpenGL 2019-07-23 jiawei.shao@intel.com Fix missing header in OpenGLFunctions.cpp Created with: gclient setdep -r src/third_party/dawn@4e3b218e9695 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: Ife6097ff8a5331e3a0eb6da7bdcca3d33ea1e28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714277Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium baa61ee0. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" ee7626e7 "Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 3d7a663b "[webnfc] Change NDEF{Record,Message} to be IDL interface type" fa84fe7b "Implement QueuingStrategies in C++" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I66b73cfb9e0faf92720ced9f63ce07c9b17a5d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714676Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679919}
-
Anton Bikineev authored
This relands 51bb0bd3 as flaky failures in webgl tests were caused by aecfa837. Bug: 967258 Change-Id: Icf2e5d050e763e112471f5ac1897a3e24f6c9006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713525Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#679918}
-
Yuki Shiino authored
Stops scripts depending on web_idl module's internals, and makes scripts only use public API of web_idl module. Fixes (probably was missing) dependencies of build settings, also refactors gn files (less distributed). Bug: 839389 Change-Id: I54df6a2cbf92dc1efe5a1cac9427d067e114f329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710235Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#679917}
-
Richard Knoll authored
This takes the device scaling into account when drawing the progress bar in the omnibox icon. Bug: 986265 Change-Id: Ib01c2496b86b9ab2860d1ad826ab8e67ed11b8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712572Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit bd0cae50. Reason for revert: Cause failures in DirectCompositionSurfaceTest.* Builder: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Debug%20%28NVIDIA%29?limit=200 First build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Debug%20%28NVIDIA%29/22377?blamelist=1#overview-tab Crash example: Test 'DirectCompositionPixelTest.DCLayersDisabled' completed with the following status(es): 'CRASH','CRASH','CRASH' Test 'DirectCompositionPixelTest.DCLayersDisabled' had the following logs when run: ================================================================================ [ RUN ] DirectCompositionPixelTest.DCLayersDisabled Received fatal exception EXCEPTION_ACCESS_VIOLATION Backtrace: RtlAcquireSRWLockExclusive [0x774C4188+24] base::internal::LockImpl::Lock [0x72EEA36A+106] (o:\base\synchronization\lock_impl_win.cc:36) base::Lock::Acquire [0x73AA4B5A+26] (o:\base\synchronization\lock.h:50) base::internal::BasicAutoLock<base::Lock>::BasicAutoLock [0x73AA4663+35] (o:\base\synchronization\lock_impl.h:84) gl::VSyncThreadWin::RemoveObserver [0x73B41033+51] (o:\ui\gl\vsync_thread_win.cc:84) gl::DirectCompositionSurfaceWin::Destroy [0x73B2089A+42] (o:\ui\gl\direct_composition_surface_win.cc:406) gl::DirectCompositionSurfaceWin::~DirectCompositionSurfaceWin [0x73B1DF75+37] (o:\ui\gl\direct_composition_surface_win.cc:185) gl::DirectCompositionSurfaceWin::~DirectCompositionSurfaceWin [0x73B217D5+37] (o:\ui\gl\direct_composition_surface_win.cc:184) base::RefCounted<gl::GLSurface,base::DefaultRefCountedTraits<gl::GLSurface> >::DeleteInternal<gl::GLSurface> [0x0137B3B2+50] (o:\base\memory\ref_counted.h:356) base::DefaultRefCountedTraits<gl::GLSurface>::Destruct [0x0137B377+23] (o:\base\memory\ref_counted.h:323) base::RefCounted<gl::GLSurface,base::DefaultRefCountedTraits<gl::GLSurface> >::Release [0x0137B351+49] (o:\base\memory\ref_counted.h:347) scoped_refptr<gl::DirectCompositionSurfaceWin>::Release [0x013BD545+21] (o:\base\memory\scoped_refptr.h:298) scoped_refptr<gl::DirectCompositionSurfaceWin>::~scoped_refptr [0x013BD525+37] (o:\base\memory\scoped_refptr.h:210) scoped_refptr<gl::DirectCompositionSurfaceWin>::operator= [0x013BD7E8+40] (o:\base\memory\scoped_refptr.h:230) scoped_refptr<gl::DirectCompositionSurfaceWin>::operator= [0x013BE275+69] (o:\base\memory\scoped_refptr.h:224) gl::`anonymous namespace'::DestroySurface [0x013BE12A+250] (o:\ui\gl\direct_composition_surface_win_unittest.cc:66) gl::`anonymous namespace'::DirectCompositionSurfaceTest::TearDown [0x013BBA1F+127] (o:\ui\gl\direct_composition_surface_win_unittest.cc:128) gl::`anonymous namespace'::DirectCompositionPixelTest::TearDown [0x013C95A3+67] (o:\ui\gl\direct_composition_surface_win_unittest.cc:602) testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x0141637B+107] (o:\third_party\googletest\src\googletest\src\gtest.cc:2507) testing::Test::Run [0x014162F1+257] (o:\third_party\googletest\src\googletest\src\gtest.cc:2532) testing::TestInfo::Run [0x01416DCD+253] (o:\third_party\googletest\src\googletest\src\gtest.cc:2701) testing::TestSuite::Run [0x01417A6D+301] (o:\third_party\googletest\src\googletest\src\gtest.cc:2827) testing::internal::UnitTestImpl::RunAllTests [0x01421415+1013] (o:\third_party\googletest\src\googletest\src\gtest.cc:5284) testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x01420FF0+112] (o:\third_party\googletest\src\googletest\src\gtest.cc:2505) testing::UnitTest::Run [0x01420E44+292] (o:\third_party\googletest\src\googletest\src\gtest.cc:4873) RUN_ALL_TESTS [0x0172FC3F+15] (o:\third_party\googletest\src\googletest\include\gtest\gtest.h:2453) base::TestSuite::Run [0x0172F26F+143] (o:\base\test\test_suite.cc:316) base::internal::FunctorTraits<int (base::TestSuite::*)() __attribute__((thiscall)),void>::Invoke<int (base::TestSuite::*)() __attribute__((thiscall)),(anonymous namespace)::GlTestSuite *> [0x013DDCBC+28] (o:\base\bind_internal.h:499) base::internal::InvokeHelper<0,int>::MakeItSo<int (base::TestSuite::*)() __attribute__((thiscall)),(anonymous namespace)::GlTestSuite *> [0x013DDC0F+79] (o:\base\bind_internal.h:599) base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)() __attribute__((thiscall)),base::internal::UnretainedWrapper<(anonymous namespace)::GlTestSuite> >,int ()>::RunImpl<int (base::TestSuite::*)() __attribute__((thiscall)),std::__1:: [0x013DDB65+85] (o:\base\bind_internal.h:672) base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)() __attribute__((thiscall)),base::internal::UnretainedWrapper<(anonymous namespace)::GlTestSuite> >,int ()>::RunOnce [0x013DDA14+84] (o:\base\bind_internal.h:641) base::OnceCallback<int ()>::Run [0x01737480+80] (o:\base\callback.h:99) base::`anonymous namespace'::LaunchUnitTestsInternal [0x01735358+440] (o:\base\test\launcher\unit_test_launcher.cc:158) base::LaunchUnitTests [0x01735168+232] (o:\base\test\launcher\unit_test_launcher.cc:354) main [0x013DC8CB+171] (o:\ui\gl\test\run_all_unittests.cc:78) invoke_main [0x01839F5E+30] (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78) __scrt_common_main_seh [0x0183A0C7+343] (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288) __scrt_common_main [0x0183A19D+13] (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331) mainCRTStartup [0x0183A1A8+8] (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17) BaseThreadInitThunk [0x740E8654+36] RtlGetAppContainerNamedObjectPath [0x774E4A77+311] RtlGetAppContainerNamedObjectPath [0x774E4A47+263] Original change's description: > gpu: Sync to primary monitor's vblank (windows) > > DWM composition is limited to primary monitor's refresh rate. Prior to > GPU vsync we would use DWM composition rate to drive begin frames. > > With GPU vsync we started using per monitor vblank to limit begin frames > in case primary monitor had higher refresh rate, but this might be > causing draw duration and omnibar latency regressions. MS platform team > also suggested syncing to primary monitor only. In any case the correct > approach would be to further limit begin frames based on event queries > from 2 frames back. > > This CL makes the GPU vsync begin frames sync to primary monitor, and > also makes the vsync thread a singleton since it doesn't have per-window > state any more. > > Bug: 953970 > Change-Id: Id3d3f043cb847172b1d6ba4bd38b087ceb2d8631 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711215 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679832} TBR=zmo@chromium.org,sunnyps@chromium.org Change-Id: If4a762325952dd33283bf41a13321e759de51025 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713510Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#679915}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53ed763ca009..e22412aeb9a3 Created with: gclient setdep -r src-internal@e22412aeb9a3 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Change-Id: I4f1fe72f2b941b34e424330267178eb94a1e4e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714767Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679914}
-
Lowell Manners authored
The test now includes a back navigation, and validates that the URL is properly updated. I found while working on navigation code that I was able to subtly break the behavior without failing any tests, this closes the gap I found. Bug: 976697 Change-Id: Ib739b5e2e21665f7877db7d708fbfceaff141d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700057 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#679913}
-
Henrique Ferreiro authored
After the IdentityManager code restructing into public and internal APIs was fixed in https://crbug.com/952788, this CL fixes both build dependencies and presubmit checks in //ios. TBR=jochen@chromium.org Bug: 970268 Change-Id: Id51b9a1f69bc8b62d3e66e8f53ed302c69511233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710313 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#679912}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/76b75c40a1e2..3855447d93eb git log 76b75c40a1e2..3855447d93eb --date=short --no-merges --format='%ad %ae %s' 2019-07-22 greg@lunarg.com Bindless Instrument: Make init check depend solely on input_init_enabled (#2753) 2019-07-22 kevin.petit@arm.com Validate storage class OpenCL environment rules for atomics (#2750) 2019-07-22 51214578+jmacnak-nv@users.noreply.github.com Allow LOD ops in compute shaders with derivative group execution modes (#2752) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3855447d93eb The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Change-Id: I38e09cd951848e766dcf97800bbb7404f9f09b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714678Reviewed-by:
-
Leon Han authored
This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit interfaces, and updates the baseline of relevant wpt tests. http://w3c.github.io/web-nfc/#dom-nfcreadingevent The corresponding spec changes were introduced in https://github.com/w3c/web-nfc/pull/179 https://github.com/w3c/web-nfc/pull/227 BUG=520391 Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#679910}
-
Anders Hartvoll Ruud authored
This CL implements the StyleCascade, which can take any number of incoming CSS declarations, prioritize them according to criteria defined in css-cascade, and apply the output of the cascade to ComputedStyle. Example: const CSSPropertyName& name = ...; const CSSValue* value1 = ...; const CSSValue* value2 = ...; StyleCascade cascade(state); cascade.Add(name, value1, Priority(Origin::kAuthor)); cascade.Add(name, value2, Priority(Origin::kUA)); cascade.Apply(); // value1 is applied, value2 is ignored. Brief Overview of the StyleCascade ================================== The StyleCascade contains a HashMap from CSSPropertyName to StyleCascade::Value, which represents the current set of cascaded values. New values can be added to the cascade, using StyleCacade::Add, and the incoming value will either be accepted (become the new cascaded value for that property), or rejected, depending on its Priority. Once all values have been added, a call to StyleResolver::Apply will resolve dependencies between the values in the cascade (e.g. var()-references), and apply the final values to the ComputedStyle. The various parts which together constitute the StyleCascade are: -------------------------------------------------------------------- Value One Value is stored for each property in the StyleCascade's HashMap. -------------------------------------------------------------------- Priority Each Value contains an inner CSSValue and a Priority. The Priority is a composite of origin, importance, tree order and 'cascade order'. -------------------------------------------------------------------- Resolver A stack-allocated object which exists during an Apply call. Its main job is to handle cycles in the dependencies between cascaded values. -------------------------------------------------------------------- Animator An object passed to the Apply call which knows how to apply values that are undergoing interpolations. -------------------------------------------------------------------- Filter A kind of secondary cascade required to resolve situations where values must be applied in the order of appearance because they share the same field on ComputedStyle. -------------------------------------------------------------------- Each of the above represents an inner class of StyleCascade. Please see the documentation for each individual class for a more detailed explanation. Changes in this CL ================== (Note that this section is intended as a reference; when reading the code and find some part of it that you want to learn more about, it might be explained here). * StyleResolver: the application of low-priority properties has been separated into a separate function. All functions that begin with "Cascade" are new, and represents new code. * StyleBuilder: The DCHECK which checks that initial/inherit is not applied has been removed. Previously, initial/inherit were *only* transported via CSSCustomPropertyDeclaration (hence we never expected to see the "real" initial/inherit values here). However, we now *also* support applying the real initial/inherit and unset values for custom properties. This makes dependency resolution more neat, as we can simply apply 'unset' in all cases where something is 'invalid at computed-value time' [1]. * MatchedProperties: This class gained a new 'tree_order' field, in order to implement cascading of declarations from different shadow trees correctly. See comment for details. * CustomProperty: The most important change here is that we now absolutize the value during CustomProperty::ApplyValue, like we're supposed to. Previously we would use ComputedStyle as a "buffer" for unresolved and un-absolutized variables, and then resolve them later once all the unresolved variables were added to the ComputedStyle. Now, unresolved variables exist in the StyleCascade only, and only *final and absolute* values enter ComputedStyle. Another change here is the handling of the CSSInvalidVariableValue. (This class exists on master already, but was unused). This value is applied by the StyleCascade for custom properties that are in a cycle. We can not use 'unset' in this case, since applying 'unset' means we may get a value from the parent style or the initial style, and properties in cycles should not get any value at all. * CSSPendingInterpolationValue: This is a "placeholder" value for properties with active interpolations. It does not carry the actual interpolation, but instead represents an interpolation effect that *will* be applied in the future. See comment near 'Animator' in style_cascade.cc for details. * CSS[VarCycle,]InterpolationType: where we would previously use CSSVariableResolver to resolve dependencies, we now use the StyleCascade (via CSSInterpolationEnvironment). * CSSDefaultInterpolationType: this interpolation type was actually missing CSSVariableResolver resolution on master, so the resolution via StyleCascade is new. CSSDefaultInterpolationType handles "interpolation" between values that can't be interpolated. This includes keyframe animations of unregistered custom properties from e.g. '--x:var(--y)' to '--x:var(--z)'. We would previously not resolve those var()-references in CSSDefaultInterpolationType at all; we'd simply apply the value 'var(--y/z)' as-is, with the reference unresolved, and then hope that something else would resolve the reference in-place on ComputedStyle later. However, since it's no longer allowed for custom properties to exist in an unresolved state on ComputedStyle (see bullet point for CustomProperty), we must now resolve the value here. * animation_test_helper.cc is unfortunately doing a "stand-alone" style resolution outside the normal code paths, plus a "manual" application of ActiveInterpolations on top of that. There is not really anything wrong with this, except that it results in some unattractive boilerplate code in the form of TestAnimator. Interpolations must now be applied through the StyleCascade. In order to create a valid CSSInterpolationEnvironment, it needs a reference to a StyleCascade::Resolver, and such instances are only created only during StyleCascade::Apply calls. This is to force the use of a single StyleCascade::Resolver instance, which in turn ensures proper cycle detection along the code path that can re-enter StyleCascade via StyleAnimator -> InvalidatableInterpolation::ApplyStack. (This complicated re-entrant behavior was already there with CSSVariableResolver, but we'd sometimes use a separate CSSVariableResolver instance, which is error prone as each instance has its own cycle detection state). Anyway, since EnsureInterpolatedValueCached does not register animations in the normal way (see nearby TODO), we can't use StyleAnimator to extract the ActiveInterpolations, and hence we need the TestAnimator to apply the interpolations. There's nothing very wrong there, it's just ... verbose. * CSSVariableReferenceValue: The previous DCHECK here is invalid, as there is no way for callers to know whether a CSSParserContext is present or not. The cascade code path tries to get the context from the CSSVariableReferenceValue more eagerly, hence our existing tests exercised the DCHECK. (The old code path didn't, accidentally. A crash on master was discovered because of this, see issue 986710 for more information. Cycle Detection & Reentrancy with Interpolations ================================================ Ideally I would have like to propagate the cycle state as a return value from the StyleCascase::Resolve functions, however, this is too difficult to do because of how InvalidatableInterpolation::ApplyStack (itself called from StyleCacade::Apply via the Animator) re-enters the StyleCascade via the public StyleCascade::Resolve function. We need to detect cycles that cross this boundary, hence the cycle state is stored on the Resolver itself. See also the issue regarding a const violation that happens in relation to this reentrancy [6]. Note that this (const violation & reentrancy) is not new behavior; we do the same thing on master with CSSVariableResolver, and fixing it is not in scope for this CL, or even the StyleCascade project as a whole. Testing ======= This CL adds a virtual test suite with the prefix virtual/cascade. The test suite consists of (exactly) 800 tests (at the time of last run). Note that, at the time of writing, *all* tests are passing (not just tests in the virtual test suite). However, since I can't add all the tests to the virtual test suite, I've added a carefully chosen subset. Note also that the expectations added here are inherited from the main expectations, and not unique to the CSSCacade feature. Phase 1 ======= The StyleCascade project has three phases. Two preparatory CLs have landed previously (addressing the visited-link issue, and removing the special code for overriding effective zoom on foreignObject). This CL completes Phase 1. Phase 1 involves cascading: * CSSPropertyPriority::kResolveVariables * CSSPropertyPriority::kAnimationPropertyPriority * CSSPropertyPriority::kHighPropertyPriority * Animation effects for custom properties. Additionally, this CL uses a separate StyleCascade instance for the animation effects of standard properties. This was originally not planned until Phase 3, however it is more convenient to do this right away, since it then allows us to DCHECK that the CSSVariableResolver held by CSSInterpolationEnvironment is unused if the CSSCascade feature is enabled. Phase 2 ======= Phase 2 involves cascading the remaining CSSPropertyPriority: * CSSPropertyPriority::kLowPropertyPriority In order to do that, we must find a solution to these issues: * Eliminate CachedUAStyle, which caches intermediate partial ComputedStyle state in order to figure out if the author applied a style which would disable default -webkit-appearance behavior. * A way to deal with css-logical properties. This will probably be the the StyleCascade::Filter introduced in Phase 1, although it would need to be ribbonized [3]. Phase 2 also involves: * Getting performance to an acceptable level. * Enabling the feature. * Removing obsolete code paths: (Apply* functions in StyleResolver, CSSVariableResolver, and more). Phase 3 ======= Phase 3 involves having animation effects for standard properties participate in the main StyleCascade. This is hard, as StyleAdjuster is standing between the main cascade and the animation cascade. This phase will fix the bugs regarding cascade order of animation effects [4] and responsive 'em' units in the base computed style [5]. References ========== [1] https://drafts.csswg.org/css-variables/#invalid-at-computed-value-time [2] https://drafts.csswg.org/css-scoping/#shadow-cascading [3] https://crbug.com/985043 [4] https://crbug.com/552085 [5] https://crbug.com/437689 [6] https://crbug.com/985023 Bug: 947004 Change-Id: I8c3af4859fe176cbe46b5d211a48c7117cd9ef28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605418Reviewed-by:Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#679909}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: I0dac03563ad4d5e620131f8fa10d337071754313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1240303Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#679908}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8a8a2710f861..0c0d6d8e6b38 git log 8a8a2710f861..0c0d6d8e6b38 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 dberris@chromium.org PinpointScheduler: Post cancellation comments Created with: gclient setdep -r src/third_party/catapult@0c0d6d8e6b38 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:977488 TBR=skyostil@google.com Change-Id: Ic0db440ac23640f61e94d3941b8a621c9bb67092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714131Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2ac9503910ee..85ef3eab9407 git log 2ac9503910ee..85ef3eab9407 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4bcccabe..54f75614 (679778:679885) Created with: gclient setdep -r src/third_party/webrtc@85ef3eab9407 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I69cb1278cf0b8ae1e0a971f4d30f703941bb245d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714672Reviewed-by:
-
Matt Menke authored
This histogram was added 4 years back to investigate what was causing excessive disk writes to the HttpServerProperties cache, and is no longer needed. Bug: 904672 Change-Id: I3ee4405bb537e19220558f47f7e646b1f911f2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707029Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#679905}
-
Yi Su authored
Currently there is a DCHECK in WebState::~WebState that checks all ScriptCommandCallbacks are removed by calling WebState::RemoveScriptCommandCallback. This DCHECK is only useful for those clients that live shorter than WebState, and for other clients (mostly tab helpers) this DCHECK is unnecessary. Here is a doc about this: https://docs.google.com/document/d/1scLiCVBSE46i_9UrwpF-fyhS13AQqJ0penSu09xuqLw/edit?usp=sharing Use base::CallbackList for WebState::AddScriptCommandCallback can make the API contract simpler. Clients that call WebState::AddScriptCommandCallback need to store the base::internal::CallbackListBase::Subscription object in their classes. When the Subscription is destroyed with the class before WebState is destroyed, it will unregister ScriptCommandCallback automatically, so the ScriptCommandCallback will not be invoked on destroyed class. If client class is destroyed after WebState being destroyed, nothing will happen. Remove WebState::RemoveScriptCommandCallback as clients can reset their subscription if they want to stop receiving JS messages. Bug: 956516 Change-Id: I62a66f4521a8f4004a8dacc4313bc17b7ef986ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702427 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
-
Sergio Villar Senin authored
They're much better placed there than directly under platform/ Bug: 919385 Change-Id: I8e466604d42b7a3a66025b74cebe35310faae391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713164Reviewed-by:
-
Christopher Lam authored
This CL adds more constraints to the Web App testing system. Web App unit tests will now be notified when they attempt to alter subsystems outside of the correct part of the lifecycle (between construction and Start()). This CL now also requires all tests to call Start() on the provider manually before accessing any WebAppProvider subsystems. Bug: 973324 Change-Id: I60db6562f0b478fa6ce074014397220488e3f549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703535 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#679902}
-
Juan Antonio Navarro Perez authored
The option has been broken for a long time; there is no test coverage for it, so it has lead to code rot. Bug: 985725 Change-Id: Ibf16b7a07cb4eebed85cdfe98f72821d4b88b9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709579Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#679901}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c76bf2a3b565..fc854c30fb5c git log c76bf2a3b565..fc854c30fb5c --date=short --no-merges --format='%ad %ae %s' 2019-07-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9ec3f51d11d9..02407743bd72 (12 commits) 2019-07-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@fc854c30fb5c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:None TBR=borenet@google.com Change-Id: Iaa1f1be59b11e67d02979ed1382899c16291e0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714117Reviewed-by:
-
Nigel Tao authored
This fixes `browser_tests --enable-features=AppServiceAsh --gtest_filter="WebAppUiServiceMigrationBrowserTest.SettingsSystemWebAppMigration"`. It fails before and passes after this commit. Note that `browser_tests --gtest_filter="WebAppUiServiceMigrationBrowserTest.SettingsSystemWebAppMigration"`, without AppServiceAsh enabled, passes both before and after this commit. BUG=826982 Change-Id: If924768e8c599c9053d5bf9ae64a9561f828f7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708691Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#679899}
-
Matt Falkenhagen authored
GcmApiTest.* tests are failing at HeaderModificationDelegateOnUIThreadImpl::ProcessRequest when NavigationLoaderOnUI is enabled. Bug: 978617 Change-Id: Ie483c0b392a4c706848dbbcb14726b31c82f8e72 TBR: kinuko No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714392Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#679898}
-
Adam Rice authored
Implement CountQueuingStrategy and ByteLengthQueuingStrategy in C++. Implementing in WebIDL leads to some changes in semantics: 1. highWaterMark is now a getter on the prototype rather than an property on each object. This is because adding properties directly on objects is not usual practice in WebIDL, and is problematic to implement in Blink. 2. size() is now a function returned by a getter. This is because a methods in WebIDL must be called with |this| set to a valid object of the appropriate type, but size() is called with |this| set to undefined. See https://github.com/whatwg/streams/issues/1005 for more discussion. These aren't expected to change behaviour of code in the wild, but the count-queuing-strategy.any.js and byte-length-queuing-strategy.js tests detect it. Also add tests that subclassing of CountQueuingStrategy and ByteLengthQueuingStrategyworks works properly. A previous iteration of this change broke it. Bug: 981333 Change-Id: Ifc18a469a58f73d54563ca549a1c8db0e001303b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692108Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#679897}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f680135e592..53ed763ca009 Created with: gclient setdep -r src-internal@53ed763ca009 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tinazwang@google.com,horo@google.com,yigu@google.com Change-Id: Ic42a7c63ab8a095c297574223dbac353a327540c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714115Reviewed-by:
-
Leon Han authored
The corresponding spec changes were introduced in: https://github.com/w3c/web-nfc/pull/240 BUG=520391 Change-Id: I50ff37d69ef1e79c32682493d3133f639226aac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684664 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
-
