- 28 Feb, 2019 40 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I6fbc60e4354ec4b4b05c6de41dce01f98022c0c0 Reviewed-on: https://chromium-review.googlesource.com/c/1492394Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#636307}
-
Nate Fischer authored
No change to logic. These tests are passing in a local run. Tested with 74.0.3718.0. R=jam@chromium.org Bug: 923938 Test: android_webview/tools/run_cts.py \ Test: -f=CookieManagerTest.testRemoveCookies \ Test: :WebViewTest.testSetDownloadListener Change-Id: Id7358b04cda1c43769add8e4a792560742cd08a0 Reviewed-on: https://chromium-review.googlesource.com/c/1489424 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#636306}
-
Alex Danilo authored
Change https://chromium-review.googlesource.com/c/chromium/src/+/1457884 removed the read only check on the current directory model which had the side effect of making the 'delete' button visible when choosing the 'Recent' folder in FilesApp. This CL fixes the regression by reinstating that check. Bug: 935345 Tests: Added testing for delete button in existing integration test. Change-Id: I8e89afd8918778057526671e42d8d776051bc6b9 Reviewed-on: https://chromium-review.googlesource.com/c/1491736Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636305}
-
Yuke Liao authored
This CL adds "-mllvm" and "-limited-coverage-experimental=true" cflags to the code coverage compiler wrapper because they're critical for reducing the size of the generated binaries. Bug: 933512 Change-Id: I0d61a36b71605fc160fea164f280206084afe302 Reviewed-on: https://chromium-review.googlesource.com/c/1493383 Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636304}
-
Justin Cohen authored
Set -fno-experimental-isel until until https://llvm.org/PR40887 is fixed. Otherwise, debugging on a device has buggy stepping logic. Bug: 910200 Change-Id: I8e0df10de27403342d85d61672cc356644d49694 Reviewed-on: https://chromium-review.googlesource.com/c/1492044 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#636303}
-
Darwin Huang authored
Minor maintenance change. sqlite 3.27.2 update changes: https://sqlite.org/releaselog/3_27_2.html Bug: 936195 Change-Id: Ib62aa775afcda18b24f0fd5d2b90b38864b137b2 Reviewed-on: https://chromium-review.googlesource.com/c/1493389 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636302}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2f1dad229d8b..87c513372ff3 git log 2f1dad229d8b..87c513372ff3 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 dhanyaganesh@chromium.org CIDB: Extend the bot_hostname length from 80 to 160 2019-02-27 evanhernandez@chromium.org cros branch: Ensure projects in manifest exist. 2019-02-27 evanhernandez@chromium.org cros branch: Checkout in temp dir by default. 2019-02-27 evanhernandez@chromium.org cros branch: Do not create local branches. 2019-02-27 mikenichols@chromium.org commands: Remove topology usage to simplify authentication 2019-02-27 dhanyaganesh@chromium.org upload_prebuilts.py: Add Gerrit's autosubmit feature (again) 2019-02-27 dgarrett@google.com cbuildbot_launch: Clean .cache. 2019-02-27 bpastene@chromium.org Revert "cros_chrome_sdk: Fetch the chromeos-base/tast-* packages when entering the SDK." Created with: gclient setdep -r src/third_party/chromite@87c513372ff3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: If81eaaa7910cdcbc3ec6558bcf2acd043a7f773d Reviewed-on: https://chromium-review.googlesource.com/c/1492993Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636301}
-
Sammie Quon authored
Test: manual Bug: 936282 Change-Id: Ie9202b3f997e5c3b7d6214958b6d39eb4ffce412 Reviewed-on: https://chromium-review.googlesource.com/c/1493086Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#636300}
-
yoshiki iguchi authored
This CL adds code to move toast when VK appears not to over-wrap them. Bug: 928208 Test: manual Change-Id: I9b099ffa712be9aaf0f25285d838361d277c1a69 Reviewed-on: https://chromium-review.googlesource.com/c/1477561Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow) <oshima@chromium.org> Auto-Submit: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#636299}
-
John Rummell authored
If a pre-provisioned origin ID is not available when requested, it may be possible to use an empty origin ID instead. However, for privacy reasons the user will be prompted to confirm that this is OK. Updating the code to check if MediaDrm will work with an empty origin ID, and if so prompt the user before returning the empty origin ID. BUG=917527 TEST=new unit_tests pass Change-Id: I18cbb03cd91ac63d29f7a104d3a14ec9a3268ce9 Reviewed-on: https://chromium-review.googlesource.com/c/1481802 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#636298}
-
chrome://tracingSebastien Marchand authored
This removes all the PostTask / Timer logic from trace_event_system_stats_monitor and make it use SystemMonitor instead. This simplify the trace_event_system_stats_monitor code and will make it possible to add more system metrics to the system_stats tracing category (the goal is to replace some of these raw numbers by some more useful ones as they're currently really easy to misinterpret) Change-Id: I6ea2ab5c4f12f329b5f28d3b84ab48efb57710d3 Reviewed-on: https://chromium-review.googlesource.com/c/1446772Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#636297}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/32b0f6739fa5..5fb83a97087d git log 32b0f6739fa5..5fb83a97087d --date=short --no-merges --format='%ad %ae %s' 2019-02-27 ehsann@google.com Allow NonWritable to target struct members. (#2420) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@5fb83a97087d The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1e11137f3d29f0313976d643c74ea7f0c1d48f39 Reviewed-on: https://chromium-review.googlesource.com/c/1492852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636296}
-
Wez authored
NetworkChangeNotifier's constructor would spin the calling message-loop to wait for the interface list and routing table to be returned, rather than letting them be retrieved asynchronously, or using synchronous IPC to capture them. This could result in unrelated I/O being processed mid-construction, leading to issues. We switch NetworkChangeNotifier to kick-off an initial fetch of the interface list, but to allow that to complete asynchronously. Change-Id: Ib718ff0f781e0fd16e06d9ff8258164b03c44468 Reviewed-on: https://chromium-review.googlesource.com/c/1491907 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636295}
-
Doug Arnett authored
We want to use the first Cacao optimization in a matching PageHint that is enabled on the client. This handles checking for the basic enabled state of the optimizations in order. The overall context should have already confirmed the host is not blacklisted and has acceptable scheme. Bug: 936205 Change-Id: I71610db3c204e82292c7bee4fed302643514ae73 Reviewed-on: https://chromium-review.googlesource.com/c/1491903 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#636294}
-
Joey Arhar authored
Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=930043#c10 Bug: 930043 Change-Id: I6b47bedfed778a81202c1cc9364e603483556019 Reviewed-on: https://chromium-review.googlesource.com/c/1493090Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#636293}
-
Joey Arhar authored
Bug: 780163, 853068 Change-Id: I5cb0001fbbfc800d5c99ac761fa58f353a698823 Reviewed-on: https://chromium-review.googlesource.com/c/1471217Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#636292}
-
Alex Danilo authored
Remove the flag and all associated usage of it. This feature is now enabled by default, so the flag is redundant and can be removed. Also changed the 'touchstart' event listener to be passive to suppress warning in DevTools (and follow best practice). Bug: 934467 Change-Id: Ibac3a9ef267028a63ba8c04e21e2a4742e04c100 Reviewed-on: https://chromium-review.googlesource.com/c/1490354 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636291}
-
Ryan Sturm authored
This will now include plaintext, SVG, etc. It was previously limited to HTML and XHTML. Bug: 936496 Change-Id: I5fc05ac99361e391918d2b8bafdb25836a2f256a Reviewed-on: https://chromium-review.googlesource.com/c/1492434 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#636290}
-
Eric Karl authored
Add an |interop_backing_factory_| for Android and fix a typo in SharedImageBackingFactoryAHB. R=vikassoni Change-Id: I8759ab8a54cb9bf3ff19c3a225c3f4dbf7e3dde5 Reviewed-on: https://chromium-review.googlesource.com/c/1493380 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#636289}
-
Chris Blume authored
There is currently synchronization between the transition from Vulkan to OpenGL and vise versa. However, we also need to allow synchronization between 2 separate OpenGL contexts, for example. This CL allows this extra synchronization. Bug: 930294 Change-Id: I48cfdbb6e1cd7a1d51090f701df7e8da0642f6a6 Reviewed-on: https://chromium-review.googlesource.com/c/1482552 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#636288}
-
Jun Cai authored
This CL changes ChannelPosix::WriteNoLock() to send limited number of handles at a time so that it won't overflow the |cmsg_buf| buffer that is used at mojo::SendmsgWithHandles(). Bug: 935357 Change-Id: I9df239763d5976022564881b8da81acfa6d61f1c Reviewed-on: https://chromium-review.googlesource.com/c/1489104 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#636287}
-
Bill Orr authored
Oculus headers and OculusRenderLoop had to be updated. This also Remove previous fix that changed warnings for device/vr. Bug: 936459 Change-Id: I8869eb75969ec3845be2bba0f8d55c268943c92f Reviewed-on: https://chromium-review.googlesource.com/c/1493437Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636286}
-
Dan Beam authored
R=thestig@chromium.org BUG=883049 Change-Id: I2dc81de46b816debcb8e31042c4078e91331e258 Reviewed-on: https://chromium-review.googlesource.com/c/1492977 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#636285}
-
chrome://proximity-authKyle Horimoto authored
The crash occurs when trying to dereference a null pointer. This fix simply returns early if debug information is not present. Bug: 936635 Change-Id: I034ba93d2fb027dd379f684393c1368b11a73e7c Reviewed-on: https://chromium-review.googlesource.com/c/1493513 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#636284}
-
Ryan Hansberry authored
This change previously landed at crrev.com/c/1484495, but was reverted at crrev.com/c/1491658 because of a test failure. This relands the original CL with a fix for the test. Patch 4 is the original CL, and Patch 5 is the fix. Text of the original CL: This is a necessary change now that Polymer 2 is enabled. Previously, Multidevice and Smart Lock pages were being informed of an authToken change by their child element passwordPrompt, but that is no longer bubbling up to the parent. Now, explicitly bind to the authToken of passwordPrompt as a property, and use it when the dialog close event is fired. As a consequence of this, the authTokenChanged() callbacks in both parents is unnecessary and has been removed. Bug: 934987 Change-Id: Iae34ae9677fe555264c9a59b05f4b9f184fad324 Reviewed-on: https://chromium-review.googlesource.com/c/1492362 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#636283}
-
Ryan Sturm authored
Lite Page Server Previews over records data use when it attempts to record data savings. Instead, only the savings should be recorded. This also changes the data usage site breakdown code to use Virtual URL (the one in the omnibox) instead of the actual host for the sake of improving UI and tracking HTTPS Lite Page Previews more accurately. Bug: 936577 Change-Id: Ib7dfe8afeea0b277ac065d58c02b2962a4ab6c94 Reviewed-on: https://chromium-review.googlesource.com/c/1492428 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#636282}
-
Antonio Gomes authored
R=haraken@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: Ibd1f71f7b7eaed5051b7a44abdae737ffd21b2e3 Reviewed-on: https://chromium-review.googlesource.com/c/1491833 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#636281}
-
Luciano Pacheco authored
Add role="group" to tree children so Chromevox reads the depth level of each sub-tree correctly. Fix cr.ui.TreeItem to set aria-expanded the same as expanded attribute, for Files app we set expanded=true before setting hasChildren, which was causing aria-expanded to be always false. Add unittest for DirectoryTree to check for aria-expanded and role=group. Bug: 888671 Change-Id: I5b99a720a59f051d551655f1aab86effa15d5d89 Reviewed-on: https://chromium-review.googlesource.com/c/1490366Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#636280}
-
Dominic Mazzoni authored
Previously the image annotation code only handled OCR results from the server. Now that captions and labels are hooked up, expose those image annotation strings too. Bug: 905419 Change-Id: I88542054c49ba252d5bc13d0024054059b8f5123 Reviewed-on: https://chromium-review.googlesource.com/c/1492475Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#636279}
-
Sidney San Martín authored
- Adds Widget::SetFullscreenAuxiliary(), which sets NSWindowCollectionBehaviorFullScreenAuxiliary and lets the dragging window exist in another window's fullscreen space. - Sets that flag when tab dragging starts, clears it when dragging ends, and makes the new window fullscreen if the source was fullscreen. Bug: 883910 Change-Id: I8889135320a0fb26abff9b546c5f5444ba6f4486 Reviewed-on: https://chromium-review.googlesource.com/c/1484491 Commit-Queue: Sidney San Martín <sdy@chromium.org> Auto-Submit: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#636278}
-
Hector Carmona authored
See bug for screencast. Bug: 934487 Change-Id: I091960d22f606d0b1a8ec92156f16ac5284f5cc7 Reviewed-on: https://chromium-review.googlesource.com/c/1490754Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#636277}
-
Fabio Tirelo authored
It was originally reverted for failing on Mac10.10 and Mac10.11 Revert commit: 8c27018b Original change's description: > [AF] GoogleBlue50 as Autofill's field preview bg color > > This basically reverts the experimentation scaffolding introduced by > crrev.com/1174710, and makes GoogleBlue50 the field preview bg color > for Autofill and Autocomplete. > > Bug: 935991 > Change-Id: Id821f57c5a2954d502ca241e4414fd452cc501ce > Reviewed-on: https://chromium-review.googlesource.com/c/1489173 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636103} Bug: 935991 Change-Id: Ie33344a4a3364eb3de0603de64876c1be579daf4 Reviewed-on: https://chromium-review.googlesource.com/c/1492734 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#636276}
-
Simon Que authored
Bug: 915568 Change-Id: I917d801b38c8afd1ac29af67bdd9d704e53514d9 Reviewed-on: https://chromium-review.googlesource.com/c/1491739 Auto-Submit: Simon Que <sque@chromium.org> Reviewed-by:
smut <smut@google.com> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#636275}
-
Becca Hughes authored
The CloseNewestToExitConcurrentPlayback histogram was not being recorded because of a race condition between closing the tab and becoming inaudible and the web contents being destroyed. This changes the metrics to check if a web contents was recently audible instead of whether it is currently audible. BUG=936196 Change-Id: Ie3c1d8bbb0e11b099acbc2c163aeedf4b1c9d58f Reviewed-on: https://chromium-review.googlesource.com/c/1490494Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#636274}
-
Dale Curtis authored
This will help understand how frequently Shaka packager is used in the wild. If usage is high enough we may add a UKM to figure out whom it's most popular with. BUG=927952 Change-Id: I144fa524fd2450e5fdd31f9baa24a9bc7b6bfbee Reviewed-on: https://chromium-review.googlesource.com/c/1464921 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#636273}
-
Owen Rodley authored
Change-Id: I20b544417028bc2d4ab770329b1c5d8fd2b55b49 Reviewed-on: https://chromium-review.googlesource.com/c/1493333 Auto-Submit: Owen Rodley <orodley@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#636272}
-
Christian Biesinger authored
Now that we correctly compute the "intrinsic" cross size (really the unstretched cross size), we no longer need both versions of the cross_size. The algorithm only needs the unstretched size, so repurpose cross_axis_size for that purpose and remove the other one. The fixes to the intrinsic cross size were made in https://crrev.com/c/1483946 and https://crrev.com/c/1484582. Also renames CrossAxisIntrinsicExtentForChild to CrossAxisUnstretchedExtentForChild to more clearly reflect its purpose. I removed the TODO in the ng flexbox implementation because the difference between the two sizes only matters if we avoid a layout, but we don't do that in NG yet. (The NG cross size is always pre-stretching) Change-Id: Iec8f4b63b5d897373b8ccc0b1d9e4ee4d19cffbf Reviewed-on: https://chromium-review.googlesource.com/c/1492832 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#636271}
-
Eliot Courtney authored
Bug: b/121299293 Test: unit test Change-Id: I92241ad40f16f11dadf92ef8d2bb5e848a05131f Reviewed-on: https://chromium-review.googlesource.com/c/1460642 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#636270}
-
Tetsui Ohkubo authored
This CL replaces shelf_globe.icon by properly resized one. Also, it turned out kTrayIconSize is 16, while the intended size here was actually 20x20, so the new icon is 20x20. TEST=manual BUG=931107 Change-Id: Iea5fd4f5e1b51bacf0ce8927d60afb52daa6a93c Reviewed-on: https://chromium-review.googlesource.com/c/1491231Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#636269}
-
Thomas Guilbert authored
This CL removes HostedRendererType, in favor of using one CreateRenderer method per media::Renderer type. Follow up CLs will focus on removing the indirections that were necessary to support HostedRendererType. Bug: 936116 Change-Id: I570ddc8dd5b2c3a168a9cdd9bbbf97ff99ef0dd2 Reviewed-on: https://chromium-review.googlesource.com/c/1490211Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#636268}
-