- 12 Nov, 2019 40 commits
-
-
Sara Kato authored
crrev/c/1159176/ removed usage of this function, but did not remove it. This CL performs clean up to remove this unused function. Test: none (clean-up) Bug: none (clean-up) Change-Id: I27294b205347df3f632c2842b87486ec132f4afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904553Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#714427}
-
Arnaud Mandy authored
Consolidating constant value of kMeanGravity by declaring it in src/base, instead of having it in many places in the code. Bug: 1020501 Change-Id: Ie52e05834530280528a8f126f4099deac5afeb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899373Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#714426}
-
Miyoung Shin authored
This change converts BeforeUnloadControl mojom interface client in components to use BrowserInterfaceBroker. Since MimeHandlerViewGuest is a WebContentsObserver, a static helper function is used to register its binder. Bug: 936482 Change-Id: If7d60be6d20307a11028ef5b682fa373cc8033b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895099 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#714425}
-
Peng Huang authored
This CL adds VulkanInfo in GPUInfo, and then send it to browser process with GPUInfo. And it will be serialized to binary data and pass to about:gpu page for displaying. This CL adds a vulkan_types.mojom generated from vulkan header file. The structs in that files have many fields. It increases binary size. The increasing is expected. Bug: 887018 Change-Id: I2725326091ef47c3034939b3970d0e5bbaf6dc3f Binary-Size: Size increase is unavoidable (see above) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868832Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714424}
-
Jiajun Ou authored
The primary use case is to allow opening CWVWebView from WKWebView on window.open(). Background: https://docs.google.com/document/d/1IjJho7tGNp8azsA075VWBowrsi0m4lHAQarCvfF286I/edit#heading=h.bj843njsw7va Design doc: https://docs.google.com/document/d/1cVySp7_L-kRqP2Q_R3YrS8d7XsbVqTjUbb7UhIMni0k/ Change-Id: I95753c511affaa91f355cf9e75d336933850d854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864750Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Jiajun Ou <garzonou@google.com> Auto-Submit: Jiajun Ou <garzonou@google.com> Cr-Commit-Position: refs/heads/master@{#714423}
-
Oleh Lamzin authored
Use correct shill::kErrorResultNotSupported instead of NetworkDeviceHandler::kErrorNotSupported to handle failure to change USB Ethernet MAC address source. BUG=b:143695438 TEST=unittests TEST=manual verify on device that we handling correct error Change-Id: Ida9103e28857c795c33c7311509bce95fd2f5f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908540Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#714422}
-
Trent Apted authored
test_api.js depends on a bunch of JS libraries that appear in many lists. This CL consolidates those dependencies to two places: - js2gtest.gni, and - A JsTestApiConfig class declared in chrome/test/base/js_test_api.h Note not all lists captured the axs_testing.js dependency, but this change uses the same dependency list in all locations for consistency. TBR=aboxhall@chromium.org (mechanical change) Bug: 1000989 Change-Id: If6e0716c03e42783a2d3529baa70475a9d305045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900512 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#714421}
-
Kuo Jen Wei authored
Focus to play video/confirm button when entering video/photo review result page. Restore to camera view default focus when leave review page. Bug: 1020239 Test: Navigate entering/leaving review result page by chromevox and verify all related function works correctly. Change-Id: I784b08667bdfbaceb4e6c1956051801311a23199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906451 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#714420}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3943.1-1572873357-benchmark-80.0.3961.0-r1 to 80-3904.92-1573478033-benchmark-80.0.3964.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I488e9588bfde8da09f0d6902c9440e50b983b6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714419}
-
Morten Stenshorne authored
When entering a child that establishes a new formatting context, we passed the wrong fragmentainer block-offset. We passed an initial estimate, even excluding margins. Positioning new formatting context children is complicated, and, in addition to the margin, there are things like floats and clearance to consider. Pass the block-offset of the layout opportunity when creating a constraint space for such a child. This means that we'll now (as a side-effect) force the BFC block-offset for all new formatting context children, but this seems harmless, and it does seem better than adding yet another parameter to CreateConstraintSpaceForChild(). Change-Id: I49256d7bd87f55088b72d27475d0d42e8d43c3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901070Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#714418}
-
Hirokazu Honda authored
Chromium should query a driver its supported H264 profiles. Thanks to this CL, Chromium can know the truly supported profiles in advance. Bug: 970152 Test: Check h264 profiles queried with driver patches Change-Id: Ib387fdd9d5e606fa58d3a0f67734b6e42aac12a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903240Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#714417}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5eb17d38f7f7..c85c137c5de6 git log 5eb17d38f7f7..c85c137c5de6 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 thestig@chromium.org Roll third_party/icu/ 2ecd66c69..88ea42af7 (8 commits) 2019-11-12 thestig@chromium.org Roll third_party/zlib/ ddebad26c..f4f46747b (4 commits) 2019-11-12 thestig@chromium.org Roll third_party/libjpeg_turbo/ 38c693569..bc1357852 (2 commits) 2019-11-12 thestig@chromium.org Roll third_party/depot_tools/ e90e5fe20..79d4f9950 (165 commits; 37 trivial rolls) 2019-11-12 thestig@chromium.org Roll third_party/catapult/ 830565958..3992f6564 (132 commits) 2019-11-12 tsepez@chromium.org Add embedder tests using page rendering flags. 2019-11-12 tsepez@chromium.org Add command line flags to pdfium_test for rendering flags. 2019-11-11 thestig@chromium.org Roll third_party/freetype/src/ 5a1a79c0e..3aaae716b (7 commits) 2019-11-11 awscreen@chromium.org [FXCRT] Fix overflow for CFX_FloatRect::GetOuterRect() 2019-11-11 tsepez@chromium.org Remove unused private RENDER_* definitions. 2019-11-11 tsepez@chromium.org Remove unused CBC_ReedSolomonGF256Poly::Multiply() (scalar form) Created with: gclient setdep -r src/third_party/pdfium@c85c137c5de6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1019026 Change-Id: Ic79a822205650bc42b3aa7a9b872200a64fa2537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910785Reviewed-by:
-
Antonio Gomes authored
.. by calling PeerConnectionDependencyFactory::GetWebRtcWorkerThread directly. This is now possible, after [1], where peer_connection_dependency_factory.cc|h is moved to Blink. [1] https://crrev.com/c/1805159 Note that to match the actual return type (base::SingleThreadTaskRunner) the PCDF method is renamed to GetWebRtcWorkerTaskRunner(). BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I56d4dd2720150cd86a85d98c8cfae1dfd9c711ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806846 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714415}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3943.1-1572866479-benchmark-80.0.3961.0-r1 to 80-3943.1-1572866479-benchmark-80.0.3964.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I35fdb8f7241fc0e4c8e6670866bdf6f7bc6ac0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911151Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/64e07f445a10..8cbb33c0d04b git log 64e07f445a10..8cbb33c0d04b --date=short --no-merges --format='%ad %ae %s' 2019-11-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e2cf3bc0..38612283 (714186:714324) 2019-11-11 terelius@webrtc.org Simplified throughput estimator 2019-11-11 mbonadei@webrtc.org RTC_EXPORT RTCStatsMember::StaticType and VideoFrame::Builder. 2019-11-11 yvesg@webrtc.org Expose NetEqDecodingTest for re-use in chromium tests. Created with: gclient setdep -r src/third_party/webrtc@8cbb33c0d04b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:1002973 Change-Id: I62353011af23116b741dd7871bc69a845eed478a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910747Reviewed-by:
-
Ben Joyce authored
This is necessary for androidx.browser. Androidx.browser provides the Android APIs that allow us to support Custom Tabs and Trusted Web Activities - it's basically the new version of custom_tabs_client. Since androidx.browser is an Android API, it must adhere to their API guidelines, which involves using ListenableFuture instead of accepting Callbacks(see b/138381050) Bug: 1016484 Change-Id: I1f0dde3533b6b03c5976ea85397d25e509600917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872642Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#714412}
-
Kazuki Takise authored
We want to control the visibility of a window in overview mode from the Android side. The actual scenario we have so far is: We want to hide the Netflix home (non-video) window if the video is in PIP mode because selecting the Netflix home window in the alt-tab cycler kills PIP, which is a bit confusing and may not be the user's intention. See b/129367828 for more details. BUG=b:143789289 TEST=PIP'd Netflix and confirmed the netflix home window is not listed in the alt-tab cycler. Change-Id: Iee4aac66c54646972a030cf3a00a138cf5762896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905302 Auto-Submit: Kazuki Takise <takise@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
-
Olivier Robin authored
These files include test code that triggers presubmit warning. As these files will never be compiled in the prod application, exclude them from these tests. Change-Id: I00f58dd9a3510617485ba655009307a8d6c95dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906209Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714410}
-
Kuo Jen Wei authored
ResolutionEventBroker was designed for aggregating a set of resolution related callbacks passing to all deep nested resolution related components. After several refactor works, all resolution related function will be moved into ConstraintsPreferrer and this broker is no longer needed. Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I92f0b22b4d645155862f506347752d48e8b63714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883470 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This reverts commit e5f79808. Reason for revert: crbug.com/1023761 Original change's description: > Reland: chrome_repack_locales: compress .pak files on Chrome OS > > Chromite changes to deploy locales/*.pak.gz files has landed. > > NOTE: This CL depends on the following chromite change (which copies > .gz locale files to the Chrome OS image): > https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1903536 > > Original CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1883292/ > > Original reviewer: > TBR=agrieve@chromium.org > For trivial change to resource_bundle.cc: > TBR=sky@chromium.org > > Bug: 1017864 > Change-Id: I384f1c2d0a2771e9121723ce8d10519f1ac1af9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906944 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714328} TBR=stevenjb@chromium.org,sky@chromium.org,agrieve@chromium.org Change-Id: Icbf01b3424729ed7502994c08e026a42e41e9f32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017864, 1023761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911349Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#714408}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb88ee1e..29cbe0b3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I81ade7232ae40878cf2552d16abe6999038aa61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911243Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714407}
-
Morten Stenshorne authored
Simplifies the code. Follow-up to CL:1903193 Change-Id: If5e068a96de44aa938fd3ab83496f1ca757d2dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908538Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/503d196f2b70..9da287fd0264 git log 503d196f2b70..9da287fd0264 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 timvp@google.com Output Swiftshader version to logcat Created with: gclient setdep -r src/third_party/swiftshader@9da287fd0264 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/142828252 Change-Id: I29cd11ba8ab6ebd81bfdf12f9633b71a72048e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911142Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iddd6b433567b76e263357551287095c05bd07215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911662Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 80-3943.1-1572866479-benchmark-80.0.3954.0-r1 to 80-3943.1-1572866479-benchmark-80.0.3961.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I4342179d871c3bb2278c1eff54ceacdc828bf8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910781Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d0a87cb7e91..faf13a0c3fdc Created with: gclient setdep -r src-internal@faf13a0c3fdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1018879,chromium:None,chromium:None,chromium:1023055 Change-Id: I37001a1fa1a9bd69b4c038fc1f3a929f4d1b6914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911284Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714402}
-
Ionel Popescu authored
Since in the time picker each column has the list of cells doubled we can start with each column scrolled to the middle in order to allow scrolling up. The new behavior is validated by time-picker-appearance-wheel.html and other existing tests. Bug: 1021343 Change-Id: I65b04f3f1fec79c2efc75f54a7798726c6ab1200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907522 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#714401}
-
John Abd-El-Malek authored
Change-Id: I61b804afe6c19ed399095d68aa6a6d76da71d945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908926 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
"NeedsHackForTextControlWithFontFamily" behaviour was removed: https://chromium-review.googlesource.com/c/chromium/src/+/1019405/ And TextBlockLogical{Width,Height} was simply dead. :) This shouldn't change any behaviour. \o/ Change-Id: Ia267e88593cea94606b6f286058a4be887c01bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909267 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#714399}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/52f8e51c..fb88ee1e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I88c7ef274a3b773e444f7fe5c8237dc2fbc4316e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911240Reviewed-by:
-
Ken Rockot authored
This eliminates redundancy in LocalStorageContextMojo ands hides some implementation details that were being unnecessarily exposed to e.g. DOMStorageContextWrapper. This is part of the preparation to move the implementation into the Storage Service. Bug: 1000959 Change-Id: Ie94ff8a3948a02561aac67dcbea024d70c4a434e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900918 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#714397}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2c237069. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 15c6f4fb "Add Web Platform Tests for the Split Cache" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dtapuska@chromium.org: external/wpt/uievents foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy jsbell@chromium.org: external/wpt/resources mcasas@chromium.org: external/wpt/mediacapture-record mkwst@chromium.org: external/wpt/mixed-content external/wpt/upgrade-insecure-requests nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events rego@igalia.com: external/wpt/css/css-grid skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I4b58bae1435a1f27fd19e60813dd0ac3da504120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911241Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714396}
-
Carlos Caballero authored
Allocators must return memory that is aligned at least as strictly as std::max_align_t. So make sure we do not ask for more, otherwise we risk getting misaligned memory in heap allocations. For more context, see discussion in https://crrev.com/c/1648176/18/base/task/promise/dependent_list.h#61 Change-Id: I91d69844e9a83899f3a9453f0e060a9779b40028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810960Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#714395}
-
Ian Kilpatrick authored
The first-tier OOF-cache attempts to skip all the OOF sizing and positioning work required, as the other cache simply compares the constraint spaces which can be (relatively) expensive to determine. This first-tier cache works by comparing the available-size given to the OOF-positioned descendant. If equal we can skip the OOF-positioned sizing and positioning steps. This mostly worked, however had an issue where the containing-block may have added/removed a borders/scrollbars, but the available-size given remained the same. This resulted in an incorrectly positioned OOF-positioned node. This fix disallows the first-tier cache when borders/scrollbars are present. This is sufficiently rare that this cache still has a relatively high hit-rate and is still relative cheap to calculate. Bug: 1013866 Change-Id: I71d41d2c4b47bcff6412f395db2deabf2f6f3a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891768 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#714394}
-
Keishi Hattori authored
This reverts commit 3ee16746. Reason for revert: HeapTests are failing crbug.com/1023716 Original change's description: > [Fuchsia] Stop enabling shadow-call-stack explicitly > > shadow-call-stack is enabled by default on Fuchsia now, so we no longer > need to enable it explicitly. > > Bug: 821951 > Change-Id: I221bc557bf93dfd5bf7c1659f7f8dfc32129c6b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898631 > Commit-Queue: Wez <wez@chromium.org> > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714312} TBR=wez@chromium.org,sergeyu@chromium.org Change-Id: I7e8467363407c8ce1738ae83f31e7c543d3e9144 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911066Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714393}
-
Evan Stade authored
Bug: none Change-Id: I2fddbc42b7a42e4c312c30dbd533fe92a6fb7d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910876Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#714392}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I9d4cd05623b53d3499e002de2e51ca9bb88afc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911640Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714391}
-
Manu Cornet authored
This is used (and will be used more) to give observers updates about the home launcher position (within the animation / drag) and not just updates about what the expected target position is, so the new name is a little more informative. It's hard to predict what the "target" position is anyway, since during a drag the user can easily go back and forth. This is a pure rename (plus some comment updates) and has no expected user-visible impact. Change-Id: I8eb8d039e3cc33a43a4fa9760dcb332e15a83e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910768Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714390}
-
Ken Rockot authored
This doesn't need to exist anymore; it wraps two separate sequences (one "primary" and one for "commit") yet DOM storage implementation now only uses one of them. It's effectively a thin wrapper around a SequencedTaskRunner which provides no additional functionality. Bug: 1000959 Change-Id: I178a9ee254232cc73b0b89e1ed2c588b23266ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900538 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Finnur Thorarinsson authored
This will control whether we show contact images in the UI. Later, it will also control whether we pass these images down to the web page. Bug: 1020564, 860467 Change-Id: Idbed174e9d53a1bee591eb50864cd8a571f71b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905986Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#714388}
-
