- 12 Jul, 2020 8 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I17d95ca97886aebb0660a96437650ca1b21709da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294120Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787559}
-
Henrique Ferreiro authored
Migrate the legacy IPC message DragMsg_TargetDrop to the TargetDrop Mojo message in blink.mojom.FrameWidget. To support this operation, this CL adds blink.mojom.DragData, a Mojo type representing the same data as blink::WebDragData, and a typemap. This typemap is a temporary measure to work around the fact that several methods using WebDragData cross the content/Blink boundary and cannot use the Mojo type directly. In the future, WebDragData may be completely replaced by its Mojo version. Bug: 1039255 Change-Id: Ide4dd659ac967cf976db04b86eff111b5b9ef336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232326 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#787558}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594500413-23898500688365ee2b0a27ce10dc945f770ec5d9.profdata to chrome-win32-master-1594508311-dccd93c4c196cb8796a4d7220705fe11404f334f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@google.com Change-Id: Ia6de1e04f38d84aa8ad00292809f223b4035a0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294116Reviewed-by:
-
David Bokan authored
This moves the pixel testing browser test utility functions added in plugin_power_saver_browsertest into the common browser test utilities. The generalized version now reuses functions used in cc pixel testing. We also replace the test-specific rebaseline flags with a more generally usable --rebaseline-pixel-tests flag in base/switches.h. Bug: 956675 Change-Id: I16080b9fe94e100e4d93ecdd364fecb507526a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610844 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#787556}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594488534-5360eaaf2d691f2f8a252fb94cc41a81a788abfa.profdata to chrome-mac-master-1594508311-8e68a6d33842d7b4a4e26524f3566e401808706a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I2bdd49fe2d5186c0b58e25f3ae358d0007a02ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294117Reviewed-by:
-
Henrique Ferreiro authored
Add test for https://crrev.com/c/2274631. Originally, BitmapCursorFactoryOzone::GetDefaultCursor() returned nullptr both for an invisible cursor (CursorType::kNone) and when no default cursor was available. The fix above changed the method's return type to base::Optional. This test checks that requesting and invisible cursor returns nullptr instead of base::nullopt. Bug: 1099873 Change-Id: I7b027eb7ad0bf904e25217451b79ad6858977e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292438Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/904d0654fcb0..849ec68a3029 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I9c8d241adfb0a4268c0ed62d1f5fc784f690feee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292311Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787553}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594491344-023bad20c7ab79bc38ff3b59339c58283db324d5.profdata to chrome-win32-master-1594500413-23898500688365ee2b0a27ce10dc945f770ec5d9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic93c5449d3844afa353b0b692509bf2ba19cf7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294113Reviewed-by:
-
- 11 Jul, 2020 32 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5660b5ffcf1b..904d0654fcb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I0ba5e44e104a2cf22ffdaacd273e16ed9c545865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294025Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594486534-dd6a566d79547a08ad4eca61f870544cb2392cdc.profdata to chrome-win32-master-1594491344-023bad20c7ab79bc38ff3b59339c58283db324d5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I3f12b72e5b4ff529a0dfab316a5a5186691d49f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294022Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5db7db673d89..5660b5ffcf1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I32d28600b01458d3bebe849f4ec3d0f5b8ef1283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294016Reviewed-by:
-
Sammie Quon authored
This reverts commit 44052b91. Causes crash. Sample: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38062 Original change's description: > overview: Animate the clip header while the window animates. > > This was previously animated after the main animation for performance > reasons. With the improvements to overview, we think we run this > animation at the same time as the window animation, and add it to the > exit animation as well. > > Since we now need to animate removing clipping (clip rect = gfx::Rect()), > this CL adds an observer which first animates the clip rect to the size > of the layer, and the removes the clip. Otherwise the animation will > contract hide everything before reshowing on the last frame. To help > with this, windows with no clip in overview will have a clip the size > of the window (visually equal to no clipping). This will avoid us > changing to and from real no clip (clip = gfx::Rect()) which would > make the logic more confusing and we would need to create more self > deleting observers. > > Also refactors some logic so that this clipping, and the aspect ratio > clipping (clips windows that will open in splitview so they have the > same ratio as a splitview window), so they share more code. > > Test: manual > Change-Id: I900f9a1801f9dd2e9847101e4c52d54f0ba41292 > Fixed: 952158, 1103621 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277331 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#787412} TBR=afakhry@chromium.org,sammiequon@chromium.org Change-Id: I12b85a9b3087df4480c4ed7d206660a383a5fcd9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294021Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#787548}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594482382-c5bc16b056deec1b1c90118abbf9f1683bffed2f.profdata to chrome-win32-master-1594486534-dd6a566d79547a08ad4eca61f870544cb2392cdc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I260152ad3460b811bc8a65e11cc2638d2cab23fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294014Reviewed-by:
-
Peter Kasting authored
This directory claims to be the sole, canonical source for this code, so tracking changes in the README serves no real purpose. Remove the existing ones and add the directory to the PRESUBMIT exclusion list. While there, this removes the long-gone third_party/WebKit directory from the exclusion list and alphabetizes the list. Bug: none Change-Id: I9e2ab3145ea28c473a2e1c3424b4914ccc14ee30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294017 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#787546}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594467127-5f5b46b0336980bb51e98fa88baff8f974d8cda6.profdata to chrome-win64-master-1594488534-c293410398dc6a1a1669c393f48eabe245b91351.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I93e4a9e00bc49bc4044726b738e2dd61abaf9bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294013Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594467127-c558d25c899012e396c017c18319aca1c33d8f79.profdata to chrome-mac-master-1594488534-5360eaaf2d691f2f8a252fb94cc41a81a788abfa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I2d9110412a10c9d3557138e7a285688f4269b809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293891 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Renjie Tang authored
The least_unacked parameter is no longer used. Bug: 960141 Change-Id: Ibdd382697cf1714a7d07674a7ef288ffab09ca3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293010Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787543}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d8b6c9a5c5e..5db7db673d89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I48a24da24ee36764e1bb5fd9e0e172059e0d18c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293887Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/906d48a7e828..1ee5d1c0bb68 2020-07-11 johnkslang@users.noreply.github.com Merge pull request #2330 from ShabbyX/optimize_for_angle If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I570e1cfccd2e9f9a6a7e10b004119b71b8f2553c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293888Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie151a6c9fcdc7d000cab7c0dfa97bfc6590459f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293889Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594475719-e9e89ce34c47d5af6c60d7b24c546d0556c826d2.profdata to chrome-win32-master-1594482382-c5bc16b056deec1b1c90118abbf9f1683bffed2f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia563fd9d6f12668390e517a3adc58db02b482a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293886Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 87ef3266. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I7e0aa8e7584abd40cb0fe4074f4b78351d07a0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293198Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787538}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/032808f2f85d..0d8b6c9a5c5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ibcb4608b0db412fa5e900551029d776dc045e5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293883Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594472046-6dc0d1af60656f25967748b12911e3781d503174.profdata to chrome-win32-master-1594475719-e9e89ce34c47d5af6c60d7b24c546d0556c826d2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I332049c2e526febf391ed5134fb53b5d10e7165d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293884Reviewed-by:
-
Steve Kobes authored
SetterCallback was once only passed to helpers as bound parameters, but crrev.com/786442 made it a class member to accommodate the conversion to OnceCallback. This increased complexity and brittleness, as it is tricky to ensure that setter_callback_ is reset in the right places. Now that DoAccept and other helpers store their async state in class members instead of bound parameters (an evolution that began with the introduction of callback_ in crrev.com/579394), there isn't a good reason for SetterCallback to exist. This patch removes SetterCallback in favor of directly tracking output pointers, and introduces helpers to pass the socket result and run the completion callback, which make the code simpler and cleaner. Bug: 1007815 Change-Id: I0065c18a8af3f6b8e993d9dd2432ff5b7d1093e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287893 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#787535}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594465117-481e1ab03eb0fff4c461bc49f127d501a3fe65bb.profdata to chrome-win32-master-1594472046-6dc0d1af60656f25967748b12911e3781d503174.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id194d1096dc7b381aff9167f063226ca872e450f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293878Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cc01f396d505..032808f2f85d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I73ee3ee175df6bf31fc156ba1bc5c77a01d7a498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293879Reviewed-by:
-
Sharon Yang authored
Refactor AccessibilityBridgeBrowsertests so FakeSemanticsManager and FakeSemanticTree are now in separate files. This is so they can be reused in upcoming unit tests. Test: AccessibilityBridgeTest Bug: fuchsia:53033 Change-Id: Ib2d1e81cd617183856b3da7473d71fdc70c20786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290753 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787532}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594446929-f6e2388f181bbd0647c519bdebf48572c0ed43f3.profdata to chrome-win64-master-1594467127-5f5b46b0336980bb51e98fa88baff8f974d8cda6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6eb8c4e21cd753c94f7d99ac8cec74f7ddc1bf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293877Reviewed-by:
-
Xianzhu Wang authored
The base tests are rebaselined recently. The difference of the flag-specific baselines are about some slight layout differences or white space differences. Change-Id: I863aa92874dde653076ef1a2b38f177ca9136b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293574Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#787530}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 40e9f1b1. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mlamouri@chromium.org: external/wpt/mediasession NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I2a83f4c09ac72923940be6da202e63d3df744398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293855Reviewed-by:
-
Adam Langley authored
CTAP2 has a quirk where the credential information in an assertion response is optional if the allow list has exactly one entry. We believe that Windows always returns the credential ID so this change removes the code that tried to fill it in if missing. Additionally, I'm not sure that an empty credential ID is completely invalid, so the old code might have gone wrong in that case. Change-Id: Ic29b9b04acc8c6827fe9b51d35ad9e926d6fb72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293454 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#787528}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/507a15961061..cc01f396d505 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ifef7be35f75bfd48ba90a1880dde452800cbfb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293840Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594454033-4f0e03fbbb76873d63fbbbcbf3322e6202b3b7bf.profdata to chrome-win32-master-1594465117-481e1ab03eb0fff4c461bc49f127d501a3fe65bb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,sebmarchand@google.com,jeffyoon@google.com Change-Id: I6a1d529785e87d414867d125084c3582d49b3fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293480Reviewed-by:
-
Jan Krcal authored
This CL flips UI elements on top of dark colored background in the user menu to white color so that these elements are readable. Bug: 1099286 Change-Id: I481c96b6cf566a31d418d24a13a5985fc95e5fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289974 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#787525}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iec7a20912f11d5f4cf24b9bbca9181f33a1be422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292920Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787524}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594446929-aecfc1550f49bfcf4ced22f744009c30fb5ba4c7.profdata to chrome-mac-master-1594467127-c558d25c899012e396c017c18319aca1c33d8f79.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I69f14134a04306b923ee1252ed6cb384c8354331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293874Reviewed-by:
-
Yuki Shiino authored
Just tidies core/frame/screen.idl, which is abusing [MeasureAs]. [Measure] is the right one in these cases. Change-Id: I98d4e2a01c795b88564ba41ed29653af17a45ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291799Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#787522}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594446929-8ae7ea483fa8cc8fe001dc93a283d746be5c9ca5.profdata to chrome-win32-master-1594454033-4f0e03fbbb76873d63fbbbcbf3322e6202b3b7bf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I04fe1db64f2e93b1930eb396d011be09e24a4077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293835Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0daee3cdeae5092d7be62de0ad99133207384060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293836Reviewed-by:
-
