GitLab

Cleaning up weak_ptr_factory destruction order in "src/remoting" module.
WeakPtrFactory should remain the last member so it'll be destroyed
and invalidate its weak pointers before any other members are
destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/551393003

Cr-Commit-Position: refs/heads/master@{#294331}

BUG=413002

Review URL: https://codereview.chromium.org/564563002

Cr-Commit-Position: refs/heads/master@{#294330}

BUG=370433
TEST=None
R=sky@chromium.org
TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/562693002

Cr-Commit-Position: refs/heads/master@{#294329}

BUG=411415
TEST=covered by unit tests.

Review URL: https://codereview.chromium.org/562003002

Cr-Commit-Position: refs/heads/master@{#294328}

This pulls in the following changes:

1195796 Ensure x86_64 perlasm output ends with a newline.
f7768e4 Test SHA-256 and SHA-384 CBC-mode cipher suites.
71dad68 OPENSSL_EXPORT SSL_CTX_set_keylog_bio.

BUG=none

Review URL: https://codereview.chromium.org/565503002

Cr-Commit-Position: refs/heads/master@{#294327}

Move embedded extension options guest view files from
chrome/browser/guest_view/extension_options/ to
extensions/browser/guest_view/extension_options. Also add a
ExtensionOptionsGuestDelegate in chrome/ to handle certain tasks, like
opening tabs and handling context menus, which cannot be run from
within extensions/.

This move makes the extension_options codebase more consistent with the
other guest views, which are organized similarly.

BUG=409316

Review URL: https://codereview.chromium.org/556563003

Cr-Commit-Position: refs/heads/master@{#294326}

Makes the clock offset estimator more accurate and reacts faster.
This comes from issue 519163002 (but without the tracing.)

Review URL: https://codereview.chromium.org/556693002

Cr-Commit-Position: refs/heads/master@{#294325}

IDR_STATUS_TRAY_ICON_PRESSED is only used in unit testcases. So we remove
this so that it should not endup in pak files.

BUG=367339

Review URL: https://codereview.chromium.org/464163003

Cr-Commit-Position: refs/heads/master@{#294324}

When the enrollment is in progress, the button shows "Enrolling..." and is
disabled.

Also made BrowserOptionsHandler an observer of ConsumerManagementService, so
that the settings page is updated when the enrollment state is changed.

BUG=chromium:353050
TEST=unit_tests

Review URL: https://codereview.chromium.org/493613002

Cr-Commit-Position: refs/heads/master@{#294323}

R=estade@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/439313004

Cr-Commit-Position: refs/heads/master@{#294322}

Revert of Simplify test locales in ui_unittests Framework (patchset #1 id:1 of https://codereview.chromium.org/552963002/)

Reason for revert:
Bizarrely, this is causing valgrind on Snow Leopard to pick up a
bunch of leaks from allocations within system libraries.
Reverting while I figure out how best to fix that.

BUG=413034

Original issue's description:
> Simplify test locales in Mac's ui_unittests Framework
>
> Mac creates a mini-framework in `ui_unittests Framework` so that ui
> tests can get a resource bundle without depending on the Chrome
> framework.
>
> The way it generated locale information was causing build flakes since
> two instances of repack_locales.py could be writing to
> out/../gen/repack. Tests always use en-US, so instead just do what iOS
> does and copy ui_test.pak to en.lproj/locale.pak and roll it into the
> mini-framework bundle.
>
> BUG=410468
>
> Committed: https://crrev.com/bac8fafd3d056f1277c2fdf44d2a66ca19252e54
> Cr-Commit-Position: refs/heads/master@{#294052}

TBR=avi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410468

Review URL: https://codereview.chromium.org/560993004

Cr-Commit-Position: refs/heads/master@{#294321}

The API is for ensuring the files are downloaded in local storage, and wad used in two places in Files.app.

The first is mounting ZIP. We don't need to care about it. We can mount ZIP
without downloading it in advance.

The second is selecting files in the file select dialog. We can download files
when fileManagerPrivate.selectFiles(s), and UI shows the progress correctly. But
previously, if downloading is cancelled, the API is regarded as success and it
passes the selected file inforamtion to the browser. The CL handles the case and
has the API report an error if the downloading is cancelled.

BUG=326082
TEST=delete cache, open the file in the file select dialog. Also cancel uploading in the dialog.

Review URL: https://codereview.chromium.org/557223003

Cr-Commit-Position: refs/heads/master@{#294320}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/552323003

Cr-Commit-Position: refs/heads/master@{#294319}

Often, we don't need all the  bookmarksBridge#BookmarkModelObserver
events. Especially, it's common to skip listening on extensive
bookmark changes. So make it built-in and also provide fall-back
implementations so that listeners don't have to implement all the
stub methods.

BUG=386785

Review URL: https://codereview.chromium.org/552743002

Cr-Commit-Position: refs/heads/master@{#294318}

Introduce new chrome.easyUnlock APIs for getting the sign-in challenge and using it to sign in the user.

BUG=401636

Review URL: https://codereview.chromium.org/552893002

Cr-Commit-Position: refs/heads/master@{#294317}

- change "More/Fewer options" -> "More/Fewer settings"
- change "More/Fewer settings" button background color to #f6f6f6

BUG=397741

Review URL: https://codereview.chromium.org/553843003

Cr-Commit-Position: refs/heads/master@{#294316}

BUG=411426

Review URL: https://codereview.chromium.org/559973002

Cr-Commit-Position: refs/heads/master@{#294315}

BUG=397019

Review URL: https://codereview.chromium.org/555423002

Cr-Commit-Position: refs/heads/master@{#294314}

I thought that this was fixed (Linux Valgrind had passed the content test) but it turns out that the failure is flaky so I need to run it a few times to be sure.  Fix again and run the tests a few times to make sure they work.

If after submitting it's still not fixed I'll suppress it and fix it instead of reverting.

Reverted CL: https://codereview.chromium.org/543093003

BUG=392621

Review URL: https://codereview.chromium.org/559003002

Cr-Commit-Position: refs/heads/master@{#294313}

BUG=404836

Review URL: https://codereview.chromium.org/556083004

Cr-Commit-Position: refs/heads/master@{#294312}

Followup to CL 506043002: remove unneeded c++11 enum scope for
consistency (and since we haven't officially switched to c++11 yet).

BUG=398355

Review URL: https://codereview.chromium.org/560993002

Cr-Commit-Position: refs/heads/master@{#294311}

R=vitalyp@chromium.org
BUG=393873
NOTRY=true

Review URL: https://codereview.chromium.org/559273002

Cr-Commit-Position: refs/heads/master@{#294310}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/564503002

Cr-Commit-Position: refs/heads/master@{#294309}

BUG=413044

Review URL: https://codereview.chromium.org/556323004

Cr-Commit-Position: refs/heads/master@{#294308}

This CL fixes and issue where the experimental app list would not
reset to the start page on Windows and Linux.

BUG=412227

Review URL: https://codereview.chromium.org/552743005

Cr-Commit-Position: refs/heads/master@{#294307}

Add my email in src/authors file

R=kouhei@chromium.org
BUG=

Review URL: https://codereview.chromium.org/561663002

Cr-Commit-Position: refs/heads/master@{#294306}

BUG=405859
TEST=manual

Review URL: https://codereview.chromium.org/542623002

Cr-Commit-Position: refs/heads/master@{#294305}

media::BufferedResourceLoader needs HTTP protocol and header information
in the HTTP responses so that it can properly detect live streams and
whether Range: headers are supported. This patch provides the missing
functionality needed by the media code.

Review URL: https://codereview.chromium.org/566453002

Cr-Commit-Position: refs/heads/master@{#294304}

Prevents looping, soundless videos from preventing system sleep if they're
in a background tab. We don't want soundless videos in the main tab to
allow sleeping as they'll impact the muted video + captions use case.

Reworks WebContentsImpl to track active media players and whether the
attached WebContents is visible. When visible and there's an active video
player, it will create a power save blocker. One blocker is shared for all
active media players for simplicity.

Reworks AudioStreamMonitor to handle the PowerSaveBlocker for audio
such that one is only created when non-silent audio is present.

To prevent splitting power blocking duties across chrome/ and content/,
AudioStreamMonitor now lives in content/.  WebContents exposes a
WasRecentlyAudible() method for the existing tab audio indicator.

BUG=43667,367785
TEST=manual.

Review URL: https://codereview.chromium.org/478543003

Cr-Commit-Position: refs/heads/master@{#294303}

This patch wraps the debug on start checkbox on service worker internals page into a label element
to allow clicking on the text near the checkbox as well as the checkbox itself.
R=horo

Review URL: https://codereview.chromium.org/558353002

Cr-Commit-Position: refs/heads/master@{#294302}

https://chromium.googlesource.com/chromium/blink/+log/9d49ffe0fa4d942757e3ed296fb8653f1b812ae5..ed7de93f3c7434f11196f45486e9cda62e52a21d
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/558383002

Cr-Commit-Position: refs/heads/master@{#294301}

Move app.window section of _api_features.json and _permission_features.json from chrome/common/extensions/api to extensions/common/api

BUG=387288

Review URL: https://codereview.chromium.org/546683002

Cr-Commit-Position: refs/heads/master@{#294300}

https://skia.googlesource.com/skia/+log/d9ec549071581d9d1dc2e5fac3163305ae935a39..97bf60ff7f3dd7d6e782b706ec94efb2b414b27e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/566443002

Cr-Commit-Position: refs/heads/master@{#294299}

It's not launched nor are there plans to do so. The last commit
was Dec, 2012 and there was a thread about removing it on chromium-dev in May.

My immediate use-case is to quelch the periodic idle wakeups
due to the performance monitor, but at this point, simply removing it seems
preferable to digging in to fix the timer.

BUG=411488,130212

Review URL: https://codereview.chromium.org/547063003

Cr-Commit-Position: refs/heads/master@{#294298}

 This CL removes redundant widget created by Activity, and use NativeAppWindow instead.

Activity APIs needs to some cleanup and I'll look into it once hashimoto-san finished app_window transition.

step3 will replace ChromeAppNativeWindowViews with athena's impl.

BUG=410448

Review URL: https://codereview.chromium.org/558243002

Cr-Commit-Position: refs/heads/master@{#294297}

This gets 3 views_unittests passing:
 - ViewTargeterTest.HitTestCallsOnView,
 - ViewTest.CanProcessEventsWithinSubtree,
 - ViewTest.GetEventHandlerForRect.

These were failing because the size of the RootView was being reset to
the Widget size when first added. This happened because NativeWidgetMac
was not ensuring the RootView was set up properly immediately after a
call to Widget::Init() for all Widget types (i.e. those without a
NonClientView).

When there _is_ a NonClientView, Widget::Init() calls SetContentsView()
which would eventually trickle down to
NativeWidgetMac::ReorderNativeViews(), which is where NativeWidgetMac
would set up the root view.

BUG=378134

Review URL: https://codereview.chromium.org/559873002

Cr-Commit-Position: refs/heads/master@{#294296}

Simplify QuicUnackedPacketMap's RemovePreviousTransmissions by always
removing all old transmissions.

When truncated acks start arriving, they don't stop until least_unacked
is raised, which takes an entire RTT, so this is the eventual effect of
all those truncated acks.  Instead, remove all of them the first time.

Merge internal change: 74881713
https://codereview.chromium.org/556103002/

Discard old packets from the QuicSentPacketManager which are only
present for RTT purposes(typically acks) when the map exceeds 200 packets.

Merge internal change: 74814618
https://codereview.chromium.org/551223002/

Fix a flaky QUIC end_to_end_test when the socket was suddenly unwritable
and the connection closed, but CanWrite returned true.

Merge internal change: 74798317
https://codereview.chromium.org/550703003/

Fix a crash bug in QuicUnackedPacketMap when truncated acks arrived.

Merge internal change: 74792668
https://codereview.chromium.org/554993002/

Send an ack when it 20 packets have been received since the last ack was
sent.

This allows the peer to discard data from the SentPacketManager.

Merge internal change: 74741188
https://codereview.chromium.org/555653002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/561513003

Cr-Commit-Position: refs/heads/master@{#294295}

Noto Sans CJK {Japanese,Korean,Simplified Chinese,Traditional Chinese}
are renamed Noto Sans CJK {JP,KR,SC,TC} to make their names
future-proof (to work around the length restriction on another
platform).

We want to minimize the potential confusion (on the
part of developers) due to this name change
by adding the fonts with new names in the trunk and Chrome OS 38 branch
asap.

This CL will be landed  along with the corresponding Chrome OS CL to
actually update the font files and a Skia CL.

Skia CL: https://codereview.chromium.org/554943002/
CrOS CL: https://chromium-review.googlesource.com/217290

BUG=412151
TEST=Once the fonts are updated on Chrome OS, Noto Sans CJK {SC,JP,KR}
fonts are used in {zh,ja,ko}.wikipedia.org. They can be checked with
DOM Inspector.
TEST=`data:text/html,<span style="font-family:sans-serif;"
lang="ja">&#x4E00;</span>` uses 'Noto Sans CJK JP`.
TEST=Same as above with lang={ko,zh-CN,zh-TW} and font="Noto Sans CJK
{KR,SC,TC}" as indicated in the DOM Inspector.

Review URL: https://codereview.chromium.org/551963003

Cr-Commit-Position: refs/heads/master@{#294294}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/546303003

Cr-Commit-Position: refs/heads/master@{#294293}

Flickering no longer evident on Note 3 Device.

BUG=317928

Review URL: https://codereview.chromium.org/560123002

Cr-Commit-Position: refs/heads/master@{#294292}