- 31 Aug, 2016 40 commits
-
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/4d9df422c340..fc9b11358a47 $ git log 4d9df422c..fc9b11358 --date=short --no-merges --format='%ad %ae %s' 2016-08-31 npm Move maxNumDataBytes and maxNumEcBytes calculation to fix crash 2016-08-31 tsepez Make CPDF_ColorState have a CFX_ColorStateData rather than inheriting TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2298603005 Cr-Commit-Position: refs/heads/master@{#415732}
-
fdoray authored
- Remove unused function GetStartupTemperature() - Move GetHardFaultCountForCurrentProcess() to the anonymous namespace. This cleanup is a first step toward refactoring startup_metric_utils. BUG=580207 Review-Url: https://codereview.chromium.org/2283073002 Cr-Commit-Position: refs/heads/master@{#415731}
-
chrome://flagswychen authored
BUG=642599 Review-Url: https://codereview.chromium.org/2296903003 Cr-Commit-Position: refs/heads/master@{#415730}
-
jlevasseur authored
BUG=none TEST=unit tests Review-Url: https://codereview.chromium.org/2295983002 Cr-Commit-Position: refs/heads/master@{#415729}
-
flandy authored
This replaces the 1D sliders for X offset and Y offset. BUG=639095 Review-Url: https://codereview.chromium.org/2292583002 Cr-Commit-Position: refs/heads/master@{#415728}
-
zmo authored
BUG=642227 TEST=gpu_unittests R=qiankun.miao@intel.com CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2297663005 Cr-Commit-Position: refs/heads/master@{#415727}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/b14b6aaa26cda052c59eb2908943353e24213bb0 Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/6911b067504584996204cf0b2535508ac4207106 Make rebase and sync the default for Gerrit updates. (andybons@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=602906 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2299523005 Cr-Commit-Position: refs/heads/master@{#415726}
-
agrieve authored
First attempt: https://codereview.chromium.org/2243343004/ Reason for reland: Now ignores placeholder .so files The goal is to have a single script that reports all .apk size related metrics. * Uses method_count.py to get dex info. * Already had static initializer logic, but now shows it even without --so_with_symbols_path. * Tweaks the static initializer count logic to sum up rather for all .so files rather than report the same metric repeatedly. TBR=rnephew@chromium.org,amineer@chromium.org BUG=609365 Review-Url: https://codereview.chromium.org/2294093006 Cr-Commit-Position: refs/heads/master@{#415725}
-
gayane authored
context used to be used by PrivacyPreferencesManager.getInstance (removed in https://codereview.chromium.org/2105183002) method called from FirstRunGlueImpl.acceptTermsOfService (removed in https://codereview.chromium.org/2248243002). Both of these is not true anymore so there is no need passing context around. Review-Url: https://codereview.chromium.org/2298243003 Cr-Commit-Position: refs/heads/master@{#415724}
-
johannkoenig authored
Since there does not appear to be an overlapping way to specify an empty 'backup' string, use .bak and remove the file afterwards in accordance with the wisdom of stackoverflow. Review-Url: https://codereview.chromium.org/2295903003 Cr-Commit-Position: refs/heads/master@{#415723}
-
nick authored
This is done in preparation for mojoifying this enum; mojo only generates 'enum class' enums. TBR=jam@chromium.org BUG=627852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2248873002 Cr-Commit-Position: refs/heads/master@{#415722}
-
Christian Biesinger authored
We need to set the capacity, not the size, to children_.size() because otherwise the following append() calls will not do the right thing. R=eae@chromium.org, ikilpatrick@chromium.org, glebl@chromium.org BUG=635619 Review URL: https://codereview.chromium.org/2295233002 . Cr-Commit-Position: refs/heads/master@{#415721}
-
bsheedy authored
Add setup for new test slave "Android VR Tests'. Corresponding buildbot/infra related changes can be reviewed at https://codereview.chromium.org/2293803004 BUG= Review-Url: https://codereview.chromium.org/2255873002 Cr-Commit-Position: refs/heads/master@{#415720}
-
thestig authored
These flags are on-by-default and no longer passed in as of https://codereview.chromium.org/2292173002 Review-Url: https://codereview.chromium.org/2270433002 Cr-Commit-Position: refs/heads/master@{#415719}
-
bnc authored
* Send out SETTINGS_HEADER_TABLE_SIZE = 64 kB in the initial SETTINGS frame on each HTTP/2 connection. * Immediately notify HpackDecoder about the change so that it allows the encoder to update the dynamic table size up to this limit. It is safe to do so before receiving the SETTINGS ACK, because the new limit is larger than the default 4 kB. In fact, a server following RFC 7540 Section 6.5.3 word-by-word might already use the larger limit before sending an ACK. BUG=642784 Review-Url: https://codereview.chromium.org/2300683002 Cr-Commit-Position: refs/heads/master@{#415718}
-
jlevasseur authored
Take copies, not referrences, when passing data to another thread in the WatchingParams. BUG=none TEST=unit tests Review-Url: https://codereview.chromium.org/2289333002 Cr-Commit-Position: refs/heads/master@{#415717}
-
jlevasseur authored
When a StartupTimeBomb instance deletes itself, it may schedule a future task to complete the deletion, and this future task must not reference the destructed instance. BUG=none TEST=unit tests Review-Url: https://codereview.chromium.org/2296793003 Cr-Commit-Position: refs/heads/master@{#415716}
-
joedow authored
This change introduces a new authenticator class which handles two scenarios: - Connection policy validation (i.e. do the details of the connection match the current policies set on the machine) - Interactive connection validation (i.e. prompt the user to allow the connection to be established) The first scenario is typically synchronous but the second is async, therefore this validation mechanism must handle both. The new authenticator class wraps another, functional authenticator to provide a level of validation before allowing the wrapped authenticator to take over. BUG=617185 Review-Url: https://codereview.chromium.org/2277553002 Cr-Commit-Position: refs/heads/master@{#415715}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/7b849c1efa09d26a9131400261e9ec25ea42c028 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/9c526af4f649b33e3a1351dd9c9bbe6fdb7122da lightweight builds archiving for mac and win64. (miimnk@google.com) depot_tools: https://crrev.com/f3458f046e0b77a71422c5664c6a00be17845c5d Roll recipe dependencies (MANUAL). (iannucci@chromium.org) recipe_engine: https://crrev.com/09345f9dcf4d2744f66d64766fd349ddf04f04ce Cancel PYTHONUNBUFFERED when unbuffered is explicitly set to False (iannucci@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=604452,635641 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2298163003 Cr-Commit-Position: refs/heads/master@{#415714}
-
bungeman authored
The documentation comment for FontConfigIPC::makeTypeface is now somewhat confusing because it is about the previous signature of this method. Previously this method returned SkTypeface* and the ownership of the reference was ambiguous in the code but specified by the documentation comment. Now the code specifies the ownership semantics explicitly by returning a smart pointer, so the comment is no longer needed. Review-Url: https://codereview.chromium.org/2295273002 Cr-Commit-Position: refs/heads/master@{#415713}
-
paulmeyer authored
Revert of Fragment blocks with non-visible overflow as normally when printing. (patchset #1 id:1 of https://codereview.chromium.org/2298193002/ ) Reason for revert: Suspected cause of "virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-correctness.html" failures in webkit_tests on "WebKit Linux (dbg)" bot. example: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/9099 Original issue's description: > Fragment blocks with non-visible overflow as normally when printing. > > Splitting scrollbars into multiple fragmentainers is only problematic in > interactive media. We don't need to impose any such pagination restrictions > when printing, since printing is non-interactive, > > BUG=641983 > > Committed: https://crrev.com/53d4d7aff8e25eae2ece5bbf5a53eec940871fa8 > Cr-Commit-Position: refs/heads/master@{#415645} TBR=eae@chromium.org,mstensho@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641983 Review-Url: https://codereview.chromium.org/2300763002 Cr-Commit-Position: refs/heads/master@{#415712}
-
atotic authored
It tests whether ResizeObserver is kept alive by: - direct javascript reference - observing a live element. BUG=612962 Review-Url: https://codereview.chromium.org/2272163003 Cr-Commit-Position: refs/heads/master@{#415711}
-
twellington authored
BUG= Review-Url: https://codereview.chromium.org/2298303002 Cr-Commit-Position: refs/heads/master@{#415710}
-
thestig authored
Review-Url: https://codereview.chromium.org/2297273002 Cr-Commit-Position: refs/heads/master@{#415709}
-
xiyuan authored
Forward ScrollEvent/MouseWheelEvent to the hosting widget so that it is processed and reaches the containing ScrollView. Also not forward touch events to ArcCustomNotificationView since a View is not supposed to receive touch events. This gets rid of the NOTREACHED() warning in chrome log. BUG=b/31115616 BUG=642501 Review-Url: https://codereview.chromium.org/2291193003 Cr-Commit-Position: refs/heads/master@{#415708}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/21ce1a68bb9f..4d9df422c340 $ git log 21ce1a68b..4d9df422c --date=short --no-merges --format='%ad %ae %s' 2016-08-31 tsepez Make CPDF_GraphState have a CPDF_GraphStateData instead of inheriting. TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2291343003 Cr-Commit-Position: refs/heads/master@{#415707}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/dcb82a6eedd3de602c008dca3d69489df036cbc7 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/7b787b8642623e39eafce83595c187660528af9f Revert of It's time to bring subprocess42 to depot_tools. (patchset #1 id:1 of https://codereview.chromium.org/2291223003/ ) (tandrii@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=635641 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2298923002 Cr-Commit-Position: refs/heads/master@{#415706}
-
jeffcarp authored
BUG=614963 Review-Url: https://codereview.chromium.org/2280283002 Cr-Commit-Position: refs/heads/master@{#415705}
-
flandy authored
This move allows the BezierEditor to also be used in Sources panel. BUG=642782 Review-Url: https://codereview.chromium.org/2299473002 Cr-Commit-Position: refs/heads/master@{#415704}
-
agrieve authored
It was never added to histograms.xml BUG=642287 Review-Url: https://codereview.chromium.org/2298513002 Cr-Commit-Position: refs/heads/master@{#415703}
-
rnephew authored
BUG=639315 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2272993003 Cr-Commit-Position: refs/heads/master@{#415702}
-
samuong authored
These tests assume that no extension background pages have loaded at the start of the test, but for some reason DevTools is reporting these earlier than it used to. It's valid to have these background pages in the window list, so I've removed the assertions. BUG= TBR=stgao@chromium.org Review-Url: https://codereview.chromium.org/2299723002 Cr-Commit-Position: refs/heads/master@{#415701}
-
yiyix authored
In the current code base, a float number is used when users try to control the volume slider by using keyboard. It increases/decreases the volume by 0.1 (or 10%) after each press. In the CL2281173002, it accidentally changed this increment to an integer, so the volume either jumps to silent or max. BUG=631775 Review-Url: https://codereview.chromium.org/2297833002 Cr-Commit-Position: refs/heads/master@{#415700}
-
melandory authored
Adds new message field to the Password Scpecific proto and implements clearing of the data in case custom passphrase is turned on. The population of the metadata is not implemented in this CL. BUG=638963 Review-Url: https://codereview.chromium.org/2278333002 Cr-Commit-Position: refs/heads/master@{#415699}
-
msw authored
WorkAreaChanged -> DisplayObserver::OnDisplayMetricsChanged. ShelfAlignmentChanged -> ShellObserver::ShelfAlignmentChanged TODO: Add checks for matching Display id? (didn't happen previously) Notify ShelfLayoutManager of alignment changes before ShellObserver. (to replace RootWindowControllerObserverImpl's apparent intent) Add default empty DisplayObserver function impls. BUG=NONE TEST=No behavior changes. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2295003002 Cr-Commit-Position: refs/heads/master@{#415698}
-
paulmeyer authored
There are two problems here: 1) The GuestViewBase received a FindReply while its WebContents was in the process of being destroyed. This patch adds a check in WebContentsImpl::NotifyFindReply to prevent this. 2) During destruction of GuestViewBase, there is a period of time when there is no owner WebContents, but attached() still returns true. This patch ensures that that attached() will return false as soon as |owner_web_contents_| is cleared. BUG=642733 Review-Url: https://codereview.chromium.org/2300663002 Cr-Commit-Position: refs/heads/master@{#415697}
-
rogerta authored
BUG=634156 Review-Url: https://codereview.chromium.org/2282673003 Cr-Commit-Position: refs/heads/master@{#415696}
-
jmadill authored
This bot is currently FYI-only, and adding the test will allow us to add the correct suppresions in ANGLE. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2273393002 Cr-Commit-Position: refs/heads/master@{#415695}
-
wangxianzhu authored
When the viewport has fixed background, we may create a dedicated GraphicsLayer (CompositedLayerMapping::m_backgroundLayer) for the root background. Previously we used PaintLayerPaintingRootBackgroundOnly and PaintLayerPaintingCompositingForegroundPhase flags when painting the layer. The second flag was necessary before we refactored viewport background painting into ViewPainter, because we needed the layout objects of the document element or the body element to paint the viewport background. Now we need only the root layer to paint root background. BUG=595839 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2294313002 Cr-Commit-Position: refs/heads/master@{#415694}
-
rdevlin.cronin authored
MessagingBindings contains the custom bindings for extension messaging, but most of the implementation is buried in an "ExtensionImpl" class in an anonymous namespace. Apart from being a misleading name (I think this dates back to the chrome.extension API), this makes the code hard to read. Since I'm making changes here for crbug.com/642380, clean up the code here with no behavior changes. Make MessagingBindings (which previously just had static methods) encompass ExtensionImpl, and remove some unneeded includes. BUG=642380 Review-Url: https://codereview.chromium.org/2295753003 Cr-Commit-Position: refs/heads/master@{#415693}
-