- 30 Jul, 2019 40 commits
-
-
Andrew Grieve authored
Bug: 988500 Change-Id: I3fc313404d84a089fbb2650ec588ad5cb58ed2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723799Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#682244}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces OnAccessTokenInvalidated in O2ATMtest to test that InvalidateAccessToken triggers OnAccessTokenInvalidated from |delegate_|. Bug: 967598 Change-Id: I8c1433646b1e765b072baf20f69ab5f2374e3b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724152Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#682243}
-
Himanshu Jaju authored
Bug: 982229 Change-Id: I3d0f19b55dc6dc07c6ad427d670aaa2db0a9af2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718410 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682242}
-
Tomasz Śniatowski authored
https://chromium-review.googlesource.com/c/chromium/src/+/1647268 moved the "current downloaded clang" stamp file, which causes inconsistencies to appear when switching between branches or bisecting across the stamp file move and any clang update. As a partial workaround, remove the old stamp file if it's on disk so in case the user switches back to before the stamp file move, the script always downloads the correct version of clang. Otherwise the script might see an old stamp file and incorrectly assume it doesn't need to download, leaving the user with a broken state (wrong clang). There is no need to handle the opposite case (when the old script downloads clang and notes it in the old stamp file) because the new stamp file location is inside the directory that's clobbered by the download process in either case. Bug: 988933 Change-Id: I9d37996a9b1b3e9375b269eea36e6884a1edfb00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724679Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Cr-Commit-Position: refs/heads/master@{#682241}
-
Nico Weber authored
Moving these constants out-of-line means that the dep on build:branding_buildflags doesn't have to be in public_deps. No behavior change. Bug: 961769 Change-Id: I070afcb39d23eee6a1cf0c40e49c064ddc01b353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724665Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#682240}
-
Eero Häkkinen authored
This mojo method is not needed any more because the remove operation was removed from the spec. Bug: 968553 Change-Id: I44591c9a3f198390f5ff69b928c2f70d35fdecf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722547Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#682239}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e78b7c05..6e5d9dba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idb4dd8b97e9dc493b1d03153ce972d029c6484d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724608Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682238}
-
Colin Blundell authored
This CL adds documentation of how the various core internal classes support the public IdentityManager API surface. The target audience is engineers looking to maintain/change/enhance the implementation of IdentityManager (e.g., members of the signin team). Bug: 970295 Change-Id: I73c13120ec38c791b8b2f973c026c8fca47148d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722935Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682237}
-
Lutz Justen authored
This reverts commit b223de22. Reason for revert: Breaks branded Chrome OS build: ../../chromeos/services/assistant/media_session/assistant_media_session.cc:144:28: error: no member named 'encountered_error' in 'mojo::Remote<media_session::mojom::AudioFocusManager>' ../../chromeos/services/assistant/media_session/assistant_media_session.cc:149:44: error: no member named 'BindNewPipeAndPassReceiver' in 'media_session::mojom::AudioFocusManagerProxy' because of assistant_media_session.cc. Note that this file only compiles with gn arg is_chrome_branded = true. I think audio_focus_remote_->BindNewPipeAndPassReceiver() has to be audio_focus_remote_.BindNewPipeAndPassReceiver(), but I couldn't figure out how to fix encountered_error(). See also https://chromium-review.googlesource.com/c/chromium/src/+/1725553 Original change's description: > Convert services/media_session services to new Mojo types (6/n) > > The primary goal of this CL is to convert usage of |functions| of > interface AudioFocusManager and port dependent files to adopt new > implementation. > > Bug: 955171 > Change-Id: I2c8f269b2b36034b9ebc5beb1aef56ee3db691b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715367 > Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682154} TBR=oshima@chromium.org,kinuko@chromium.org,rockot@google.com,abhijeet@igalia.com Change-Id: Ie5a8b1652ddf623b21a903334713944122013e15 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171, 988971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725890 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#682236}
-
Carlos Caballero authored
MessagePumpType is used in other places (eg base/thread.h). Moving it to its own file will simplify include dependencies. Bug: 891670 Change-Id: I214342da0d6833e0ad324cd4d58c08a0233f7c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718806 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#682235}
-
Rayan Kanso authored
Metrics collected - Blink API usage - Database operation status - Event dispatch status - Category of added content - User click - Blocked registration attempts - Number of registered entries Bug: 973844 Change-Id: I3950779e429d5537fa1d78a837737e56727a4a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720817 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
gogerald authored
[StartSurface] Return to home surface when clicking the back button and the explore surface is showing Bug: 982018 Change-Id: I8d92b1234061869c4fc8c920eb1be8bf2f44db58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724659Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#682233}
-
Gabriel Charette authored
It only had two callers and it'll become error prone once ScopedTaskEnvironment's MOCK_TIME mode always mocks TimeTicks::Now(). TimeDelta based TimedWait()'s will remain real-time-all-the-time but TimeWaitUntil() could be passed TimeTicks::Now() + TimeDelta::FromSeconds(1) but wait forever or return right away because Now() is mocked and is effectively a random value compared to system time. Context for MOCK_TIME : https://chromium-review.googlesource.com/c/chromium/src/+/1707870 This also enabled an opportunity to clean up the implementations to invoke TimeTicks::Now() even less than before. All system calls for waiting are based on delta. So we always use the initial |wait_delta| and we only need to lookup Now() if the API can spuriously return too early and |wait_delta| isn't Max(). R=kylechar@chromium.org Bug: 905412 Change-Id: Ic73ee7ea286d023d2adee624478ff650f94767a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708841Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#682232}
-
Stepan Khapugin authored
Bug: 799488 Change-Id: I194be9c4ea34f966b819285b16d38fe9116bedd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719007 Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#682231}
-
Egor Pasko authored
Record sample-per-attempt enum histogram to allow following what kind of retries are happening, all in one histogram. This allows knowing separately: * whether loading succeeded * which process it happened in (browser/child) * whether loading at fixed address was attempted * whether it was a retry Not recording the status for loading the crazylinker's library because we did not change that code there recently. One tiny awkwardness turned out to be necessary: buffering the samples until the process type is known (moved to a separate class). I tried to make the process type to be known earlier, at loading time, instead of library initialization, but it turned out not to be possible because webview zygote loads the library without knowing the process type, and then later initializes the library with the newly arrived info (presumably after forking). Bug: 981599 Change-Id: If8fbb0ea6c51b3caaf2b7ad2b2303d3c5105a939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713640 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#682230}
-
Antonio Gomes authored
BUG=704136,919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Id08f26f45029023a6a2eab9f6df2d93f9108c8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724552 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#682229}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e6092f3bc901..e671a6937e36 git log e6092f3bc901..e671a6937e36 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 bclayton@google.com Fix ICD generation on windows. Created with: gclient setdep -r src/third_party/swiftshader@e671a6937e36 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I360516da110ec4af329cd9caee161935891f20e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682228}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/34f8bd8c4850..7b57c5bb770f git log 34f8bd8c4850..7b57c5bb770f --date=short --no-merges --format='%ad %ae %s' 2019-07-30 cwallez@chromium.org Check bindgroup validity first in SetBindGroup Created with: gclient setdep -r src/third_party/dawn@7b57c5bb770f The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I534da582a9b1e489af000212d34152cafe2e5d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725356Reviewed-by:
-
Antonio Gomes authored
BUG=704136,919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I2cb8fa3240c81253a0324f237b751e5f8f09c896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724556Reviewed-by:
-
Leo Zhang authored
Move all the ime-related paths to constants, and share these paths across the different components. Bug: 837156 Change-Id: I067d6b03b81df7cfce8240558c796ab7d1a3edb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715678Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
-
Robbie Gibson authored
Bug: 976678 Change-Id: I8ea0b009d1aa8c928215292e4aa377097a66fbcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716753Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#682224}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2f01e42cf4f3..1157607f2f54 git log 2f01e42cf4f3..1157607f2f54 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 linxinan@chromium.org chromite: add compiled proto files from test_platform Created with: gclient setdep -r src/third_party/chromite@1157607f2f54 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1138689246176f23c0dc597750986933ea16cbad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725247Reviewed-by:
-
Dan Elphick authored
Change-Id: I398ff513479ffc26dc1117b4a1a35b37b30c5b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704759 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Balazs Engedy authored
TL;DR: Only browsing contexts that are same-origin with the top-level context should be able to request the "notifications" permission; but once an origin has obtained the permission, it should see its state as granted, and be permitted to use the related APIs both in first and third party contexts (in the latter case, regardless of the permission state for the top-level origin). In more detail, a cross-origin subframe that had not been granted the NOTIFICATIONS permission previously (in a first-party context) should see the permission as "denied" through all of `Notification.permission`, `pushManager.permissionState`, and `permissions.query`; not be able to prompt for the permission; and not be able to register Push API subscriptions or use the Web Notification API. A cross-origin subframe that had been granted the NOTIFICATIONS permission previously (in a first-party context) should see it as "granted", through all of the above-mentioned API surfaces; and be able to register Push API subscriptions and use the Web Notification API. This CL achieves this by explicitly turning off permission delegation for CONTENT_SETTINGS_TYPE_NOTIFICATIONS. Bug: 987654 Change-Id: Ie7d7dd7da7c9a4630b09a54ba215c883511feb50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720831 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#682221}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0624ed94. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode" 40adbd62 "Rename traits and mojo directory in //skia/public" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: skobes@chromium.org: external/wpt/css/css-scroll-anchoring smcgruer@chromium.org: external/wpt/css/css-position NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ifa298eb5d0107178312f603f8bdd879afc592cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724706Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682220}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9addf0cb8cee..70cded6ac635 git log 9addf0cb8cee..70cded6ac635 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 9559cdbdf011..ac3d131054ac (4 commits) 2019-07-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 7fc868349143..f04f1f93a70f (1 commits) Created with: gclient setdep -r src/third_party/angle@70cded6ac635 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None,chromium:None Change-Id: I3b823feb0a47766528fc63f8e8376b8df80bc3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725246Reviewed-by:
-
Marian Fechete authored
This CL enables support for requiring a billing postcode in the Payment Request, based on a flag in the service proto. If the flag is set to false (default), then a postcode is not required to complete a Payment Request. If the flag is set to true, and the billing address doesn't contain a postcode (based on regional settings), an error message is shown and the flow cannot be continued. Bug: b/133731582 Change-Id: Ie6f0199b9dc558d642f1bc4c1dd4faf301d6d512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722940 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#682218}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bfd47a6a..e78b7c05 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic24e0f65d302b032345d06aa9298fe432b349be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724643Reviewed-by:
-
Pauline Leitao authored
BookmarkNodes currently have no GUID or ID consistent across different clients and that remains stable throughout the lifetime of the bookmark. This CL thus introduces such a GUID. This will allow for the insertion of logic geared towards avoiding bookmark duplicates when synced across different devices and also potentially substitute other identifier fields later on. GUIDs are randomly generated for each added bookmark, with the exception of BookmarkPermanentNodes, for whom hard-coded GUIDs are used instead. Objectively, this CL does the following: 1. Introduces an immutable GUID to the BookmarkNode and a corresponding key to the persisted JSON object, in order to allow for encoding/decoding. 2. Changes BookmarkNode constructors to always take in an ID and GUID to be set to the newly created node. 3. Changes the BookmarkPermanentNode constructor to assign hard-coded GUIDs to PermanentNodes (stored in a map) based on their Type. Bug: 978430 Change-Id: I77909f33e24b454f026d5566f64cb731a08f2b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676167Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Pauline Leitao <psivieroleitao@google.com> Cr-Commit-Position: refs/heads/master@{#682216}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It updates the type for scopes with ScopeSet for OnAccessTokenInvalidated from OAuth2AccessTokenManager::Delegate to keep consistency. Bug: 967598 Change-Id: Ic5163c4ce12bc9eba43b46ff13b6bb43b72c7309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725477Reviewed-by:
-
Anders Hartvoll Ruud authored
We changed the name of PropertyDescriptor once @property was added to the spec to avoid confusion with the at-rule descriptors. This CL is not a web-facing change that's strictly necessary, but it's nice to align the naming with the spec. R=futhark@chromium.org Change-Id: I49dbecae5bdccd06e8c75f2c01405d103dbc44f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724522Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#682214}
-
Anna Malova authored
The bug was introduced when aw_browser_context prefs were splited up into profile-specific vs global. media_drm_storage is supposed to be profile-specific. Bug: 986965 Change-Id: I29b20f8e77fbe0a3dfa3472ac963bbb096fe3a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720240 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#682213}
-
Anders Hartvoll Ruud authored
This is a more careful version of rajendrant's CL [1] which doesn't assume that we always have an animating element. [1] https://crrev.com/c/1642949 Change-Id: I931bb55522dcdbf90fa10e2009e57ff1bdb88f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724680Reviewed-by:
-
Victor Hugo Vianna Silva authored
Aiming at having an over approximation for the grouping of requests in HistoryUiFaviconRequestHandler, we record whether an icon was already present in the thumbnail database when downloading an on-demand icon. Bug: 985706 Change-Id: Iea71714d81d7f4669b37ec0613e3ffb708e75012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709576 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Idan Raiter authored
When loadValue is a "load", we make a new GPUColor and convert it to a dawn type. However, the conversion tries to access the rgba components of the color, which triggers checks such as has_r_ (since the color hasn't been set). Bug: 877147 Change-Id: Iec24f35a94beb0e17d17d4d7c9f7ac5175c949e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724584 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#682210}
-
Adam Rice authored
Add a callback argument to WebSocket Send() for string and ArrayBuffer. The callback will be called when the send completes, if it happens asynchronously and the callback is non-null. The callback is not used yet. It will be used by the WebSocketStream implementation. The methods return SENT_SYNCHRONOUSLY if they were able to send the data over mojo synchronously, as in that case the callback will not be called. The Blob Send method hasn't been changed, as it won't be used by WebSocketStream. See design doc for WebSocketStream at https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit BUG=983030 Change-Id: Ia7f3147a49e8bc55f8ead63e611a395124118959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718445 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#682209}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It moves InvalidateAccessTokenImpl from OAuth2AccessTokenManager to protected since it's only used from child classes. It also cleans up invalid TODO messages. Bug: 967598 Change-Id: Id4cd6855c4dfc96d5edb668341bf0277ce8ad6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723850Reviewed-by:
-
Lutz Justen authored
Expects timeout on Win 7 for external/wpt/referrer-policy/strict-origin-when-cross-origin/ attr-referrer/same-origin/http-http/img-tag/keep-origin-redirect/ same-insecure.http.html virtual/blink-cors/external/wpt/referrer-policy/ strict-origin-when-cross-origin/attr-referrer/same-origin/http-http/ img-tag/keep-origin-redirect/same-insecure.http.html virtual/not-omt-sw-fetch/external/wpt/referrer-policy/ strict-origin-when-cross-origin/attr-referrer/same-origin/http-http/ img-tag/keep-origin-redirect/same-insecure.http.html TBR=estark@chromium.org BUG=chromium:988890 TEST=None Change-Id: I1f11fa9168933bcf00ce519393631f5009920fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725633Reviewed-by: -
Makoto Shimazu authored
Bug: 937175 Change-Id: I6f909cbd2bf85d3cbe5192fd13d4438676a6af99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725552 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#682206}
-
David Jean authored
A simple change for opening discussion about UMA for Startup time goal: appLaunchTime is used (in metrics_mediator.mm) to fill the following existing metrics: "Startup.ColdStartWithExternalURLTime" "Startup.ColdStartWithoutExternalURLTime" appLaunchTime is set in main_controller, which in the simulator, runs about 0.09 seconds later than IOSChromeMain::InitStartTime(), the first call in main(). I couldn't find any use of IOSChromeMain::StartTime() so I retyped it to a base::TimeTicks and used it as a replacement value in main_controller. If there is something/someone currently tracking the two metrics above, then they will get slightly bigger from now on. If it is not acceptable, then we can look at creating parallel Startup metrics. Bug: 988395 Change-Id: Ie3e7d4d1c0f9931a5f760c6fcd5a06ceaa4a0ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722538 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#682205}
-
