- 08 Aug, 2018 40 commits
-
-
Rune Lillesveen authored
TBR=jamescook@chromium.org Bug: 872267 Change-Id: I8ff0cf1d3615bb73c04b5342a96c24f0c914fe75 Reviewed-on: https://chromium-review.googlesource.com/1167294Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581559}
-
Rouslan Solomakhin authored
Roll libaddressinput dep from: d955c63ec7048d59dffd20af25eeec23da878d27 To: d7ed8e2f3f35ce9a3aafdfdc48745ceab66e7229 The new version of libaddressinput does not have the locality (e.g., city) field for JP, so the existing autofill profiles are being migrated to merge the existing locality field into the street address line. TBR=vitaliii Bug: 869942 Change-Id: I1e5859c49408490c9816840917c4b648b664a975 Reviewed-on: https://chromium-review.googlesource.com/1152068Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581558}
-
Takuto Ikuta authored
Directory dependency to pyproto/google seems not necessary for unit_tests and interactive_ui_tests Bug: 869348 Change-Id: I6380754639a8e4713bf8a380f2050a0422987dd4 Reviewed-on: https://chromium-review.googlesource.com/1167146Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#581557}
-
Maks Orlovich authored
URLFetcher will stop working in the browser process with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. Bug: 865015 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I248ff39534aeab11be4a60826edf7e89256ad2dc Reviewed-on: https://chromium-review.googlesource.com/1138795Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#581556}
-
Joe Mason authored
Also add missing functions to chrome_cleaner/os needed by IPC unit tests. R=proberge Bug: 830892 Change-Id: Ibc9f4e919264d2e54cbc9808574639abb879b63e Reviewed-on: https://chromium-review.googlesource.com/1161283 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
-
Peter Wen authored
Removing gsennton@ as OWNERS since he's moved on to a new team. This makes it clear that some of these directories need more OWNERS. Bug: None Change-Id: I02f083aa9bb5597a65c8414d9d63150be77aeca8 Reviewed-on: https://chromium-review.googlesource.com/1160862Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581554}
-
Allen Bauer authored
TBR=estade@chromium.org Bug: 838152 Bug: 856492 Change-Id: Ie16b4fd47d3e0f614a0f793300539729c905e5a0 Reviewed-on: https://chromium-review.googlesource.com/1162664 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581553}
-
Majid Valipour authored
Remove "animation-worklet-' prefix from layout tests. The tests are inside AW directory so the prefix is just visual clutter. I kept it for tests that check something about the worklet itself. Note: There was a legacy unused animationworklet/visual-update-expected.html file that this patch replaces now. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I67a36d7d5913b1394108b8a1731cc660d74f99ad Reviewed-on: https://chromium-review.googlesource.com/1165271Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#581552}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1c8b8e83632..c2342031f4d9 git log c1c8b8e83632..c2342031f4d9 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 kwiberg@webrtc.org Remove rtc::{Make,Wrap}Unique and their header file + unit tests 2018-08-08 nisse@webrtc.org Tolerate out of order samples to SendProcessingUsage2::FrameSent. 2018-08-08 sakal@webrtc.org Add unit tests for hardware video codecs. 2018-08-08 crodbro@webrtc.org In video_quality_test, maintain capturer startup within CPU timing interval. 2018-08-08 srte@webrtc.org Move SimulatedNetwork class to separate file. 2018-08-08 magjed@webrtc.org Make internal video decoder factory more resilient to incorrect usage 2018-08-08 nisse@webrtc.org Delete RTPReceiverStrategy::OnNewPayloadTypeCreated and related code. Created with: gclient setdep -r src/third_party/webrtc@c2342031f4d9 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:842613,chromium:b/112299470 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I28e1ed26bb573b94df5a3643b6a095fdb2bffdb5 Reviewed-on: https://chromium-review.googlesource.com/1167124Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581551}
-
Ramin Halavati authored
Preferences related to Certificate Transparency are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I5971f1aa34f0a6f3b47f2a8ba0234e7d00d31738 Reviewed-on: https://chromium-review.googlesource.com/1166832Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581550}
-
Calder Kitagawa authored
pkotwicz@ pointed out that res/mipmap is actually an alias for res/mipmap-mdpi. This resulted in all icons being way too large and appear with some fidelity issues. In testing I believed these larger icons to be correct but in reality they should have been smaller. To fix this we could move the icons into the mipmap-nodpi folder. However, this prevents them from scaling even when aliased. i.e. if on an xxhdpi device all we have is an mdpi icon the following scenario occurs; drawable-*dpi/ has no valid splash_icon.xml so we fall back to the mipmap-*dpi/app_icon.xml here we find that only the mdpi icon is available. One would think this then scales up to an appropriate size on drawable-xxhdpi but instead Android refuses to scale it as it is in the mipmap-nodpi as the double lookup does not change the fact it is nodpi. pkotwicz@ then suggested we use Scale XML resources, these solve the problem but require the minting server to manually compute the scaling at mint time. Instead I propose the following solution: - Restore the state for app_icon.png files prior to CL https://chromium-review.googlesource.com/1128256 - Introduce a single splash_icon.xml in drawable-xxxhpdi. This will reference mipmap/app_icon and essentially be identical to the current behavior of just using the app_icon (this is just a placeholder). - Add a boolean to the metadata of the AndroidManifest.xml indicating whether we were able to package larger images on the server. (This is so xxhpdi can use these images rather than only using the slightly larger xxxhdpi icon). - Use ApiCompatibilityUtils#getDrawableForDensity(). This gives us the image for a specific density or scales the nearest available one if there isn't one available. This allows us to control which size of image we show. We can then impose the following lookup scheme based on the current device density. Tested on xhdpi, hdpi and xxhdpi running N, O, P | Current Density | App Icon Density for Splash Icon | | mdpi | xhdpi | | hdpi | xxhdpi | | xhdpi | xxxhdpi | | xxhdpi | xxxhdpi or larger if provided | | xxxhdpi | xxxhdpi or larger if provided | Bug: 819755 Change-Id: I40fe68375782b29d082193aae0ab1c1af0ae49f2 Reviewed-on: https://chromium-review.googlesource.com/1150297 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581549}
-
Boris Sazonov authored
This CL disables flaky testToolbarSwipeNextTabNone from org.chromium.chrome.browser.TabsTest on Android M arm64-v8a devices. The patch was created by donnd@ in https://crrev.com/c/1166300. TBR=yusufo@chromium.org Bug: 871554 Change-Id: I9d2844de9ce688013cbd985a060b5ef098cc0cff Reviewed-on: https://chromium-review.googlesource.com/1167189Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#581548}
-
Owen Min authored
MachineLevelUserCloudPolicy enrollment is setup by platform policy. It's not trivial on Mac as it requires additional software. Add a secondary simple token setup way. When the MachineLevelUserCloudPolicyToken policy is not setup. Read the enrollment token from file. /Library/Google/Chrome/MachineLevelUserCloudPolicyToken on Chrome. /Library/Application Support/Chromium/MachineLevelUserCloudPolicyEnrollmentToken on Chromium TEST: 1) Open Chrome, make sure MachineLevelUserCloudPolicyToken is not set via via chrome://policy. Close Chrome. 2) Edit /Library/Google/Chrome/MachineLevelUserCloudPolicyEnrollmentToken to fill a random string. (For Chromium it's /Library/Application Support/Chromium/MachineLevelUserCloudPolicyEnrollmentToken) 3) Open Chrome, verify the error dialog displayed. 4) Replace the string in 2) with a valid enrollment token. 5) Click "Relaunch Chrome". Chrome is closed and opened with browser window. Bug: 871523 Change-Id: I51e111b1f40be2677b7820f0352d4be48c192c32 Reviewed-on: https://chromium-review.googlesource.com/1164387Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581547}
-
Gauthier Ambard authored
This CL updates the buttons used by the ConsentBump to have the same buttons as the other screens, taking example on the Infobars. It is also using two buttons for the secondary view as using one button create a visible flash. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5b17e3891c91399ec18da6054ce1951b4c2f13e9 Reviewed-on: https://chromium-review.googlesource.com/1165358 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581546}
-
Marc Treib authored
After sign-out, it's not meaningful to keep the last auth error or any access token (or requests for one) around. This was causing a UI glitch, where after signing out and signing in to a different account, we'd temporarily show an auth error the belonged to the previous account. Bug: 839834, 854579 Change-Id: I1dac8d5cef020555119e49dbfdf46fc26e5a8c85 Reviewed-on: https://chromium-review.googlesource.com/1164953 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581545}
-
Robert Ma authored
This CL skips all the testharness tests with the extra property "jsshell" set to true when parsing the WPT manifest. These tests are generated from .any.js files with the optional "jsshell" global scope. They are intended to run in a JavaScript shell; when running in a browser, they behave the same as the default variant (i.e. the window scope, .any.html). Besides, the generated test names for the jsshell variant have the same basenames as the default varaint (*.any.js and *.any.html respectively), which breaks our infra. Bug: 871950 Change-Id: I9f8e81251550399a5d6566b49998aa79209dcf34 Reviewed-on: https://chromium-review.googlesource.com/1166332 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#581544}
-
Rune Lillesveen authored
BackgroundTest.NavigationEscapesEdit fails on linux-chromeos-dbg. TBR=dtseng@chromium.org Bug: 872258 Change-Id: I4dc957a290bebb4cfa9d60c0a5240100de111240 Reviewed-on: https://chromium-review.googlesource.com/1167057Reviewed-by:
-
Mikel Astiz authored
This fixes a regression introduced in https://chromium-review.googlesource.com/1152812 due to an accidental behavioral change that dropped a notification to observers when the sync setup UI is opened (i.e. SyncServiceCrypto::OnPassphraseAccepted() always notified observers prior to the offending patch). This patch reverts that behavioral change. Bug: 870256 Change-Id: If51618607c85aee806f982680b5eb83b77b5c615 Reviewed-on: https://chromium-review.googlesource.com/1166904 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#581542}
-
Michael Lippautz authored
Bug: chromium:843903 Change-Id: Ibdb5830029ee33ab04b450d6841dcb3d4862ad41 Reviewed-on: https://chromium-review.googlesource.com/1166915Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581541}
-
Nico Weber authored
I got this wrong in https://chromium-review.googlesource.com/c/chromium/src/+/1166429 TBR=dpranke@chromium.org Bug: none Change-Id: I4df8100ceece574176b1d45ff61e2709bdd4f2fd Reviewed-on: https://chromium-review.googlesource.com/1167202Reviewed-by:
-
Peter Kasting authored
Bug: 871619 Change-Id: I23704ee0321317cb8459c6ad6e80fc3d59a6c705 Reviewed-on: https://chromium-review.googlesource.com/1166035 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#581539}
-
Peter Kasting authored
This is a non-functional cleanup change. Bug: none Change-Id: I0c0221ab3c1a30260229fc1a194f6b45da92e474 Reviewed-on: https://chromium-review.googlesource.com/1166545 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/20714bdf90f3..f5402004c4a6 git log 20714bdf90f3..f5402004c4a6 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 robertphillips@google.com First version of incremental topological sort 2018-08-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 b983a4b28b83..c93eeaab1526 (1 commits) Created with: gclient setdep -r src/third_party/skia@f5402004c4a6 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I8761d82eb72f59a08cb1cdcdbf2043e36d6c043b Reviewed-on: https://chromium-review.googlesource.com/1167123Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581537}
-
Andreas Haas authored
I replace the old version of wasm-module-builder.js in the layout tests with the current version in v8/test/mjsunit/wasm/wasm-module-builder.js. This version contains features I need for new tests, and bug-fixes. R=mlippautz@chromium.org Change-Id: I3f6e40af6d168ebbba4c7074196979255a8cb078 Reviewed-on: https://chromium-review.googlesource.com/1167044 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581536}
-
Oscar Johansson authored
When building using jumbo, files gets merged and constants with the same name may end up in the same namespace/scope and conflict. This commit solves the issue by renaming the constants to something more file specific. Bug: 871163 Change-Id: Ic4973b976597dbc097897406951ae8c2cbdf6430 Reviewed-on: https://chromium-review.googlesource.com/1163505 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581535}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/692b2b85cb67..b4b8aa6ebe72 git log 692b2b85cb67..b4b8aa6ebe72 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 fmayer@google.com Merge "Add out-of-tree build for libunwindstack." Created with: gclient setdep -r src/third_party/perfetto@b4b8aa6ebe72 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I91a460e4933f6750e5d1fe6c9deb0858b7a8df8c Reviewed-on: https://chromium-review.googlesource.com/1167122Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581534}
-
Vasilii Sukhanov authored
Bug: 869343 Change-Id: I41925fe4b045f8489c11986ecefee0ebd5f624c0 Reviewed-on: https://chromium-review.googlesource.com/1160537Reviewed-by:
-
Jérôme Lebel authored
When the user taps on the cell, the view controller send the command to its local dispatcher. The local dispatcher is set by the coordinator. This dispatcher is the coordinator. The web page is opened by the coordinator by sending a new tab command to the <ApplicationCommands> with the right URL. Google services settings, to open the page: https://drive.google.com/open?id=1LXEG_mreWastYVZaBaVQ5uIBztQmYfC2 The "Manage synced data" page: https://drive.google.com/open?id=1H9A9Gme-jWQi91y4asaMy1KEtERBw111 Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b13c99b7922281f9c834644a77601ba4718d97f Reviewed-on: https://chromium-review.googlesource.com/1163521 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#581532}
-
Lutz Justen authored
Refactors BrowserPolicyConnectorChromeOS a bit, so that a few methods, in particular GetDeviceAffiliationIDs(), work for Active Directory managed devices as well. Adds code to UserActiveDirectoryPolicyManager, so that it sends user affiliation IDs to ChromeUserManager. Together, these two changes make sure user affiliation gets handled properly for Active Directory managed devices. BUG=chromium:865969 TEST=cros_run_unit_tests --board=amd64-generic --packages authpolicy Change-Id: Ib9e2c844e1da52c5e70e6079d5b67848b1b396ad Reviewed-on: https://chromium-review.googlesource.com/1145319 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581531}
-
Rayan Kanso authored
Bug: 780025 Change-Id: I255b9a793b62c3688a7079d705759f437492f7c9 Reviewed-on: https://chromium-review.googlesource.com/1157010Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#581530}
-
Friedrich Horschig authored
When Chrome is backgrounded (e.g. by pressing home or locking the device), its state is properly preserved but wasn't restored before this CL. With this CL, this is done now. This fixes issues like the keyboard accessory being permanently dismissed or keeping a state that should have been reset (most notably the generation button). Bug: 856039, 870238 Change-Id: I5543fb5b7dc8cfbe690d7df9a6ddb47346928704 Reviewed-on: https://chromium-review.googlesource.com/1160481 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581529}
-
Eric Willigers authored
Feature Policy support for EME shipped in M64 https://chromium-review.googlesource.com/696944 BUG=689802 Change-Id: I03a3f706a4492bbb2e4112dce66d68281fe172b3 Reviewed-on: https://chromium-review.googlesource.com/1166619Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
gogerald authored
Since launch is approved on stable channel Bug: 775647 Change-Id: I60f193aa12fa811715f194edfcfac523b2e19350 Reviewed-on: https://chromium-review.googlesource.com/1163626Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#581527}
-
Oscar Johansson authored
When building using jumbo, files get merged and more options are presented for the compiler. When using the operator overload << in PasswordRequirementsSpec, the compiler gets too many options and will fail before reaching the correct operator overload. The issue solved by forward declaring the operator overload in the files that uses it. Bug: 869381 Change-Id: I3d0226c9e12b1e64b3359a1efb2f9948a24e61b6 Reviewed-on: https://chromium-review.googlesource.com/1160228Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#581526}
-
Saman Sami authored
This feature is on in M68, and M69 also has this switch just in case. Remove it in M70. Bug: 813929, 771337 Change-Id: Id411c324a136bc7321912e2dac6f2eb5ca0892ca Reviewed-on: https://chromium-review.googlesource.com/1162265Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#581525}
-
Rune Lillesveen authored
Sometimes causes Mac10.10 testing to fail. TBR=sahel@chromium.org Bug: 872242 Change-Id: I15b712b498c7398999a21b34c7406a163181cf2e Reviewed-on: https://chromium-review.googlesource.com/1167048Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cbcf8cb1..36315c26 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id4e3b7d1eecb19ba40507ad39db997df33b7f3f8 Reviewed-on: https://chromium-review.googlesource.com/1166891Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581523}
-
John Lin authored
A use case is when user clicks on the save pages in the Recently tab. Bug: 843161 Change-Id: I29f4962faf6ba35698598bf3f635e99da6098a47 Reviewed-on: https://chromium-review.googlesource.com/1163509 Commit-Queue: John Lin <chuanl@google.com> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#581522}
-
Nico Weber authored
The bot shows up on https://ci.chromium.org/p/chromium/g/chromium.memory/console but not on build.chromium.org while all other bots on chromium.memory are visible. This seems like an oversight. Bug: none Change-Id: I14834f4393a651a883741ecad7563eb978548d3d Reviewed-on: https://chromium-review.googlesource.com/1166429Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581521}
-
Greg Thompson authored
Previously, the UpgradeDetector notified observers that the "low" annoyance level had been reached after only one hour for canary and dev channels (the so-called "unstable" channels). This was to entice users of such to relaunch earlier than is the case for beta and stable (the so-called "stable" channels). This is all well and good for the color changes to the app menu, but is a bit too aggressive when it also triggers the relaunch recommended bubble or the relaunch required dialog. This change makes the relaunch notifications follow the beta and stable schedule for all channels. This is accomplished by the following modifications: - A new "very low" annoyance level has been introduced to the UpgradeDetector's "update avisory system". This fires for desktop Chrome one hour after an update is detected. It is unused on Chrome OS, where the "low" annoyance level is fired the moment an update is detected. - There is no longer any notion of "unstable" channels in the desktop implementation of UpgradeDetector (UpgradeDetectorImpl), so "very low" is always issued after one hour, and "low" is always issued after two days (again, desktop Chrome only; barring use of the RelaunchNotificationPeriod policy setting). - AppMenuIconController now takes care of updating the menu when it observes "very low" or "low" based on Chrome's channel. BUG=869757 Change-Id: I1deef28b3986de239df00fe1e806d4404f28fd11 Reviewed-on: https://chromium-review.googlesource.com/1162162 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
