GitLab

UX requested this minor change in advance of a user-study focused on getting direct usability feedback for the new UI changes.

Bug: 850981
Change-Id: I1a673fd16bcc1ed736eb35399839ec653a5fb51d
Reviewed-on: https://chromium-review.googlesource.com/1092793
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565689}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id3ceb16cc07aec0ad376494315db77959806570a
Reviewed-on: https://chromium-review.googlesource.com/1091973Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565688}

Part 1: https://chromium-review.googlesource.com/c/chromium/src/+/1066304

This change picks up from the above CL and adds hooks into the GPU process to
coordinate its CATransaction with the browser's on request (e.g. for resize).

New GPU IPCs let the browser process, via CATransactionObserver, begin a
transaction and then end it while in the post commit phase of its
CATransaction. This makes compositor changes display atomically with changes in
the browser process. It also fixes the window frame jank described in the above
CL when the GPU process assigns new IOSurfaces as CALayer contents.

I think this is because the two CATransactions happen as one from the window
server's point of view: in a test app, committing the two transactions like
this significantly reduced the time to commit.

Bug: 837660
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib5b2a3a3cae76640cc9872b7f265cb3bd13143a4
Reviewed-on: https://chromium-review.googlesource.com/1077047Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565687}

Move pathological_mobile_sites into the rendering folder and refactor to
inherit from the RenderingStory class

Bug: 849392
Change-Id: Ie34cda5845f73b133e9d1df34430eede20f2d670
Reviewed-on: https://chromium-review.googlesource.com/1089383
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#565686}

Bug: 790277, 790274, 790292, 790281, 790269
Change-Id: I48e7869ce0974c36149a18653c39c0c7c2ff5502
Reviewed-on: https://chromium-review.googlesource.com/1092041
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565685}

Bug: 849538
Change-Id: Ib04c020dbc50aae398255654f5404fd8904a5326
Reviewed-on: https://chromium-review.googlesource.com/1092232Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565684}

Bug: 838650
Change-Id: Ibda5c05eafda372ecd56e35f3814efeedac86f56
Reviewed-on: https://chromium-review.googlesource.com/1083940
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565683}

Bug: 753851
Change-Id: Id457ec00228fe6a5592719c47491087e979bd5b2
Reviewed-on: https://chromium-review.googlesource.com/1077600
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565682}

Change-Id: If62a55a7c407096cc89af6df245acc4d9dec32d3
Reviewed-on: https://chromium-review.googlesource.com/1091932Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565681}

The renderer sends a RendererIsBloated event to the GRC service.
The GRC turns the event into a PageIsBloated signal and sends the
signal to the tab manager in the browser process. The tab manager
then reloads the bloated tab.

Subsequent CL will add a notification from the tab manager to the
web contents, so that it can show an inforbar after the reload.

Bug: 835806
Change-Id: I23d0987094f1c6864534abeb57f8cce3273172ff
Reviewed-on: https://chromium-review.googlesource.com/1073419
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565680}

Added the icons for the native SMB client to the theme, this changes
the icon under the "Add New Services" menu in the Files app to the
correct one. Updated the URLs in smb_provider.cc accordingly.

BUG=chromium:842753
TEST=verified on test device (cave board)

Change-Id: Id4f835f0ea167707c34f35b9022c6f685ce2f958
Reviewed-on: https://chromium-review.googlesource.com/1077548Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Adolfo Higueros <adokar@google.com>
Cr-Commit-Position: refs/heads/master@{#565679}

Bug: 849870
Change-Id: Ib51b8fbb51c107e4cd31910b4c342e8c2186402b
Reviewed-on: https://chromium-review.googlesource.com/1091462
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565678}

Bug: 783309
Change-Id: I4572bf52fb31840cdb6006d8821bc29c2fd071f3
Reviewed-on: https://chromium-review.googlesource.com/1079567
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565677}

The switch will be deleted in a follow-up CL.

Bug: 826257
Change-Id: I288e4bc5050714357c10b2d04e95586e23df44f4
Reviewed-on: https://chromium-review.googlesource.com/1089057
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565676}

Currently Undo/Redo are not added when there are menu items before it.
This was to deal with autocorrect/selected text items. However, when
we add Emoji as a menu item, we still want Undo/Redo to show. This
patch makes an exception for this.

Test: Is tested in crrev/1090408
Bug: See crrev/1090408
Change-Id: I960e064e2829e97b61e6fa8be31091dd6f671f24
Reviewed-on: https://chromium-review.googlesource.com/1092214
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565675}

After upstream change r334036, LSan started printing a warning to stdout,
breaking the test expectations.

Bug: 850867
Change-Id: I9a5857a3175f7520ffe448f41fb260d5722c62d4
Reviewed-on: https://chromium-review.googlesource.com/1092740
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565674}

This change:
1) Adds focus rings to the tab-close button
2) Moves the new tab button to last in the TabStrip's focus order if it is not
   in LEADING position so that the keyboard focus order within the TabStrip is
   correct

Positioning the ring for the tab-close button requires some finesse: the tab
close button has its margins adjusted, but the focus ring only needs to draw
around the visible part of the button.

Bug: 848299
Change-Id: I226683d3a8829f5a88e9bf102b4c8ba4ecfae459
Reviewed-on: https://chromium-review.googlesource.com/1091131Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565673}

TBR=jbudorick@chromium.org

Change-Id: Ie11ee477222ea041c0f5d558306d52b3b83c2c32
Reviewed-on: https://chromium-review.googlesource.com/1093267Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565672}

Fix a copy/paste error in the previous CL.

Bug: 849846
Change-Id: I32440d9c8a8e8879f262d6e3b8b51547301fcec2
Reviewed-on: https://chromium-review.googlesource.com/1093271
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565671}

This reverts commit b1d35c01.

Reason for revert: Speculative revert did not fix problem.

Original change's description:
> Revert "Fix browser menu button flood fill effect always originating from center"
> 
> This reverts commit 25016613.
> 
> Reason for revert: Speculative revert for
> virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-click-hyperlink.html
> failure under WebKit Linux Trusty (dbg) .
> 
> Original change's description:
> > Fix browser menu button flood fill effect always originating from center
> > 
> > The MenuButton::PressedLock used to be always created with a null
> > event from MenuController::Run() causing it to eventually call
> > AnimateInkDrop() with a null event, which then used to clear
> > the inkdrop host's `last_ripple_triggering_event_` which is
> > used as the point from which the flood fill is generated.
> > 
> > This CL passes the current located event (if any) to
> > MenuButton::PressedLock.
> > 
> > BUG=819878
> > 
> > Change-Id: I4fb18ab73f60c75af3bce948f44ac41a8c6683b8
> > Reviewed-on: https://chromium-review.googlesource.com/1089495
> > Reviewed-by: Trent Apted <tapted@chromium.org>
> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#565538}
> 
> TBR=tapted@chromium.org,afakhry@chromium.org
> 
> Change-Id: Ib3c0639e217e4e62d6c8a1aa004eda721e318c4f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 819878
> Reviewed-on: https://chromium-review.googlesource.com/1092249
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Commit-Queue: Samuel Huang <huangs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565654}

TBR=huangs@chromium.org,tapted@chromium.org,afakhry@chromium.org

Change-Id: I6a7b6243c363699a3d7620190409022ba8d58a03
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819878
Reviewed-on: https://chromium-review.googlesource.com/1093354Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565670}

The automatic password generation is still not launched. I checked that the Views prompt works all right on Mac. We are gonna invest time only into the Views UI. Let's make it simpler.

Bug: 832676
Change-Id: Ic8bff3d267579df976072cfde762f73054747190
Reviewed-on: https://chromium-review.googlesource.com/1088607Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565669}

- Base layout parent computed style on traversing the DOM instead of the
  layout tree.
- Moved top layer check for ::backdrop to CanGeneratePseudoElement().
- Moved CanHaveGeneratedChildren() to layout tree building. This means
  we may generate pseudo elements which may not generate boxes for their
  pseudo elements, but the boxes will still not be created.

First-letter is still relying on layout objects. Will address that
later.

Bug: 836126
Change-Id: I4f283a09db597bc44d1b32d1007b4aa65e83f2e0
Reviewed-on: https://chromium-review.googlesource.com/1092692Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565668}

The BookmarkModelObserverTask added a bookmark model observer
on a background thread, which is not allowed.

In both cases of Remove and Update, there is no need for listening
to the observer as we can just track whether we are updating the
bookmark node internally.  This is consistent with how
AddBookmarkTask already worked.

BUG=838988

Change-Id: I43bf054b70e78907a99ba2a11fac62df0af6bc67
Reviewed-on: https://chromium-review.googlesource.com/1089497Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565667}

This ensures that the memory and clang tot bots run the same tests as the
main waterfall bots.

Everything running on the main waterfall must be tested with clang/tot too
to make sure compiler updates don't break anything. This change makes it
impossible for things to get out of sync (on linux).

No behavior change, the chromium_linux_gtests and chromium_linux_clang_gtests
were identical already.

Also rename chromium_linux_clang_and_gl_gtests to chromium_linux_and_gl_gtests
and add a comment for it.

Bug: 843511
Change-Id: Idf95d837cdae5247d2011c85f2c19961d29bd195
Reviewed-on: https://chromium-review.googlesource.com/1093062Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565666}

This fixes an issue where the section header was being duplicated on collapse/expand.

Whenever we collapse and expand a section on iOS10, a sectionHeaderFooterView is added
on top of the existing one. This causes the sectionHeaderViews to stack on top of each
other leading to bad UI and test failure.

More info on the bug link.

BUG = 850814

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I743d4dff1c81d389f3313fda4d0c92a202fb4b5e
Reviewed-on: https://chromium-review.googlesource.com/1092233
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565665}

Fixes the tests broken by enabling the refresh location bar, introducing
helpers as necessary.

Bug: 834345, 821821
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifb767a192c3f4d3f35bf4714768352a83d4a1d99
Reviewed-on: https://chromium-review.googlesource.com/1070147
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565664}

Bug: 850464
Change-Id: I06e41f5f1d06d4397182b57883543d8a9e0680bf
Reviewed-on: https://chromium-review.googlesource.com/1093063Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565663}

The reason for this crash is when a window is destroying, it's still
regarded as an "activatable" window in MRU window list and is then
put in overview by SplitViewController::OnWindowDestroying(), which
will then cause crash when trying to adjust its bounds in overview.
(Currently the crash is only observed on Chrome built on linux
workstation, not reproducable on real devices)

To fix this, we observe OnWindowDestroyed() instead of
OnWindowDestroying() in SplitViewController.

Bug: 835925
Change-Id: Ieda91eb3f8ab12e2120365b0804a30aeef8d8f2f
Reviewed-on: https://chromium-review.googlesource.com/1091534
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565662}

R=dmazzoni@chromium.org

Change-Id: I8598961fa8007bac98164dfe4ce96cf52e655a5e
Reviewed-on: https://chromium-review.googlesource.com/1091148Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565661}

BUG=749785

Change-Id: Id9e7bf25b421199bdb0f6b0dc41d617792a64bbb
Reviewed-on: https://chromium-review.googlesource.com/1093019Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565660}

Some states were not reset after successful fling.

Test: manual
Bug: 850806
Change-Id: I826501e6921163b9f5eaa36dd7a1c6d5de940e94
Reviewed-on: https://chromium-review.googlesource.com/1092152Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565659}

The Android horizontal tab switcher is currently using the same
clipping/visibility logic as the existing overlapping tab switcher. This logic
is largely unnecessary and is in fact causing a bug in RTL mode when we try to
clip a tab from the left side as it goes off-screen (ContentLayer doesn't
properly support clipping the live layer in this case).

This CL splits up the visibility/clipping logic for the overlapping and
non-overlapping tab switchers. For the non-overlapping tab switcher, the only
logic we need is a performance optimization to only draw at most four tabs,
based on which tab is currently centered.

Bug: 849930,831359
Change-Id: Ia000e91b91615acf9f6b071b2d501ee55da231cc
Reviewed-on: https://chromium-review.googlesource.com/1091164Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565658}

When iframe upgrades were moved out of crrev.com/c/1067846 and into
crrev.com/c/1086005, some non iframe specific code was also moved by
mistake, this is that code, along with the tests.

Change-Id: I41aece313c1dd6504e9a27bb85fb810c975e8167
Reviewed-on: https://chromium-review.googlesource.com/1091184Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565657}

This adds frame pausing when new frames are created.

This also changes the browsertests to use the infobar.

Bug: 835895
Change-Id: I79d92bd91ad0482f41a26b0f1ceaddd88d798abb
Reviewed-on: https://chromium-review.googlesource.com/1091496
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565656}

Update the 'value' member variable of the DrmProperty class to be a uint64_t
since this is the type expected by the DRM APIs.

Bug: None
Test: Chrome on Ozone-DRM
Change-Id: I51fe25d1d70e0ffbeda72312b8910c1dd8d41527
Reviewed-on: https://chromium-review.googlesource.com/1091317Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565655}

This reverts commit 25016613.

Reason for revert: Speculative revert for
virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-click-hyperlink.html
failure under WebKit Linux Trusty (dbg) .

Original change's description:
> Fix browser menu button flood fill effect always originating from center
> 
> The MenuButton::PressedLock used to be always created with a null
> event from MenuController::Run() causing it to eventually call
> AnimateInkDrop() with a null event, which then used to clear
> the inkdrop host's `last_ripple_triggering_event_` which is
> used as the point from which the flood fill is generated.
> 
> This CL passes the current located event (if any) to
> MenuButton::PressedLock.
> 
> BUG=819878
> 
> Change-Id: I4fb18ab73f60c75af3bce948f44ac41a8c6683b8
> Reviewed-on: https://chromium-review.googlesource.com/1089495
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565538}

TBR=tapted@chromium.org,afakhry@chromium.org

Change-Id: Ib3c0639e217e4e62d6c8a1aa004eda721e318c4f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819878
Reviewed-on: https://chromium-review.googlesource.com/1092249Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565654}

This reverts commit 53e1a9c3.

Reason for revert: This appears to cause compile to fail on several Android builder bots, e.g. https://ci.chromium.org/buildbot/chromium.webrtc.fyi/Android%20Builder/16413

Original change's description:
> Created @TraceEvent annotation and corresponding processor
> 
> When a method has the @TraceEvent annotation, it will be transformed to include
> TraceEvent.begin() and TraceEvent.end() at the start and end of the method.
> The function body is moved to a new helper method, while the old function's new
> body looks like the following:
> ```
> TraceEvent.begin("Foo.bar");
> try {
>     wrappedByTraceEvent$bar();
>     TraceEvent.end("Foo.bar");
> } catch (Throwable e) {
>     TraceEvent.end("Foo.bar");
>     throw e;
> }
> ```
> 
> Used the following code to test building various methods:
> ```
> @TraceEvent
> public static void basic() {}
> 
> @TraceEvent
> public void takesArguments(boolean arg1, long arg2, float arg3) {}
> 
> @TraceEvent
> public int returnsPrimitive(int arg1, byte arg2, Object arg3, TraceEvent arg4) {
>     return 10;
> }
> 
> @TraceEvent
> public Object returnsObject(char arg1, short arg2, double arg3) {
>     return null;
> }
> 
> @TraceEvent
> public int throwsError() throws Exception {
>     throw new Exception();
> }
> ```
> 
> Bug: 818267
> Change-Id: I11127203662bf84de4a890da29a09676e760e621
> Reviewed-on: https://chromium-review.googlesource.com/1066173
> Commit-Queue: Tiger Oakes <tigero@google.com>
> Reviewed-by: Biao She <bshe@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565624}

TBR=bshe@chromium.org,agrieve@chromium.org,estevenson@chromium.org,tigero@google.com

Change-Id: I211510f4d7e1d301ad8982f5190972730ddbec1f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 818267
Reviewed-on: https://chromium-review.googlesource.com/1092248Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565653}

This simplifies history backend tests where some page transitions types
were created with FromInt(GetQualifier(TYPED)), which is equivalent to
simply using PAGE_TRANSITION_LINK directly (as the qualifier bits are
all zero). However, semantically these tests make more sense using
TYPED transitions in these cases (although the outcome of the tests
work either way).

This is followup work from comments on crrev.com/c/1048826.

Change-Id: Ief02ad7fde7a92f05ebaf9b30ad58886cc5d1672
Reviewed-on: https://chromium-review.googlesource.com/1091273Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565652}

This will visualize the world default favicon for collections that use FaviconLoader.

Bug: 847795

Change-Id: I0d0b3cfacd79bcf0510bed3b98397cc00ee57c6d
Reviewed-on: https://chromium-review.googlesource.com/1089882Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565651}

- only disables the "spellcheck" section when spellchecking is disabled
  by policy, but not if disabled by the user;
- disables the context menu entry if spellcheck is enforced by policy.

This is a second attempt at landing this. The first attempt was reverted
due to the CrSettingsLanguagesPageTest.Spellcheck test failing.

Bug: 814318
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8f3da717f63ca00eedd82deff8fdbe6d60b10e34
Reviewed-on: https://chromium-review.googlesource.com/1091175Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565650}