- 13 May, 2019 40 commits
-
-
Roman Sorokin authored
Follow-up to CL:1564085 Bug: 934224 Change-Id: I8291ed461528d6f31ee5167289740296fea29cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583779Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659057}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e247b5b70db9..f1e3609c24ce git log e247b5b70db9..f1e3609c24ce --date=short --no-merges --format='%ad %ae %s' 2019-05-13 thakis@chromium.org angle: Stop setting secondary_source. Created with: gclient setdep -r src/third_party/angle@f1e3609c24ce The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947060 TBR=syoussefi@google.com Change-Id: Iab188e181f9879f748410478711d70ac2a096026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610153Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659056}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/617d801ff762..b3f6654a5402 git log 617d801ff762..b3f6654a5402 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 egdaniel@google.com Remove mutex in GrVkSemaphore Created with: gclient setdep -r src/third_party/skia@b3f6654a5402 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Ia86f40c798d47a8f46b7d4401e4c061144558940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610155Reviewed-by:
-
Richard Knoll authored
When opening the inline reply text view by clicking on the "Reply" button, we get a LocatedEvent to start the ripple effect from. When this is triggered via key press, after focusing the button, the event is not a LocatedEvent and we hit a CHECK. This fix shows the default ripple instead if we activate via keyboard. Bug: 961233 Change-Id: I1f6488f9ce240b9c2cec07ff7342faa75781635a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602507Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#659054}
-
Sylvain Defresne authored
Change the API to receive a base::Value instead of the deprecated class base::DictionaryValue (the implementation already check the type of the passed value so does not assume base::Dictionary type). Change the API to receive the base::Value by reference instead of pointer as there is only one caller and it already check that the pointer is non-null before calling NTPCatalog::create. Use the base::Value::Find{String,List}Key methods instead of the base::FindKeyOfType method as it reduce the complexity of the implementation. Bug: 646113 Change-Id: Icc3a484619786d5afcf0733ef01c07904635d481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609780 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Justin DeWitt <dewittj@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659053}
-
Richard Townsend authored
This reverts commit 82b6a7c1. Reason for revert: Breaks the build for Windows on Arm. Original change's description: > Sort Win SDK versions by version sorting rules > > This should have no practical effect on current data but version > numbers need to be sorted so that 1.12 is higher than 1.9 and > the current code didn't do that. > > Change-Id: Ie993d2c103b6f16453c8b03336484c3b05a0097b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605980 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Daniel Bratell <bratell@opera.com> > Cr-Commit-Position: refs/heads/master@{#659016} TBR=bratell@opera.com,brucedawson@chromium.org Change-Id: I126df32184965a97fd3397db61c1ecde1c2681e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609787 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#659052}
-
Randy Rossi authored
Eliminating more duplicate chromecast code by moving automation_internal_custom_bindings.* and automation_ax_tree_wrapper.* into /extensions/renderer Patch Set 1 is baseline for moved/deleted files Bug: 837773 Test: Chrome official build + samus ChromeOS build, ran ChromeVox Change-Id: I0ea12a800528cfc9c22ad1356765a330b9622e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593792Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659051}
-
kylechar authored
You can no longer no disable VizDisplayCompositor feature on Windows or Mac so anything platform specific there is effectively dead code. Bug: 936425 Change-Id: Iadc74ac6447f980929535bec7024ae754364aaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602283Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#659050}
-
Owen Min authored
Move UploadChromeDesktopReport mock function to policy::MockCloudPolicyClient so that it can be re-used. Bug: 956237 Change-Id: I58eaae0def68766e3ba4ae1acb254034af5688e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606587Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659049}
-
Alex Loiko authored
This change is required to let Chrome encode and decode multistream Opus audio. It adds WebRTC multistream Opus decoders and encoders as non-advertised codecs to the audio codec factory. The WebRTC default audio codec factory has contained the multistream opus encoder/decoder since April 25 and April 8 respectively. The multistream encoders have been tested in WebRTC. Bug: webrtc:8649 Change-Id: Ie350ab2e052edfd7f18dfa4c67bb397dfa541d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609782Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Alex Loiko <aleloi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659048}
-
John Budorick authored
This is a reland of crrev.com/c/1604471 Bug: 961548 Change-Id: I3cf8d892f0f5f3dad43751dbcc78031ed52ac616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607102 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#659047}
-
Peter Kotwicz authored
Android throws an IllegalStateException when Activity#setRequestedOrientation() while the activity is translucent. This CL: - Delays setting the screen orientation in WebappActivity till the activity's translucency is removed - Adds a method to SplashscreenObserver to notify that translucency was removed. NOPRESUBMIT=true BUG=957835 Change-Id: I5971ec6b97f6ad50f71dd6e87f3fd19ecb7681db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589105 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#659046}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/18a6625221e4..0379d8cfeac1 git log 18a6625221e4..0379d8cfeac1 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 titovartem@webrtc.org Change a way, how receive stream is determined in DefaultAudioQualityAnalyzer. 2019-05-13 sprang@webrtc.org Remove deprecated SetRates/SetRateAllocation from VideoEncoder. Created with: gclient setdep -r src/third_party/webrtc@0379d8cfeac1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibd970cbd9f1e23cfa1a326611765b934dbf329de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610148Reviewed-by:
-
Elly Fong-Jones authored
Since the hold-to-quit message is delivered by a borderless window, VoiceOver does not announce its presence; we need to explicitly announce its message here so screenreader users know why their quit command is not immediate. Bug: 957356 Change-Id: I7df32194175decffe8f97a02644d5b7dfc9aba0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606380 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#659044}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/649b2ae0..4894cb22 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I160f83f4a1621ab9604c8d2deb03b3752d55c58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610142Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659043}
-
Vladimir Levin authored
This patch adds two more perftests, which change the outer size of all of the locked elements. This is an important test to ensure that the self layout is dirty, meaning that each element needs to be reached for layout. However, it also needs ensure not to recurse into the subtree. This also adds an absolute position test that has 3 abs pos children in each locked element, to ensure we also don't lay those out. Sample run: https://pinpoint-dot-chromeperf.appspot.com/job/14f2210bcc0000 Total test runtime: 31sec R=chrishtr@chromium.org, fergal@chromium.org, rakina@chromium.org Bug: 958894 Change-Id: I367310e97afb5bf45077151bbf27411a5bd22694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603207Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#659042}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 82b6a7c1. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I4577778c802ae087805ed1258fad7bad870783af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610137Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659041}
-
proberge authored
The parameterized tests have a lot of combined parameters. This change aims at low-hanging fruits by splitting the tests to remove parameters that are irrelevant on some code paths. A more thorough cleanup should follow to remove some parameters. There are now 353 tests with "UwS" in their name, down from >1023. Bug: 960988 Change-Id: Ia15b4c6a7d201b56abaa91edc2d60e15dbb2776c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606202Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#659040}
-
Sigurdur Asgeirsson authored
This allows inheriting directly from the interface to ensure compile failure when the interface is extended. Most users will inherit from the GraphObserverDefaultImpl, however. Change-Id: If1b50674a2debf0f78da2fedd741c4311e7cbb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605507 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#659039}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6fcb54784f85..aa3f478c06dc git log 6fcb54784f85..aa3f478c06dc --date=short --no-merges --format='%ad %ae %s' 2019-05-13 fmayer@google.com Merge "Document where to find userdebug blacklist." Created with: gclient setdep -r src/third_party/perfetto@aa3f478c06dc The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I49b0f88f9a477b44836d8bd3fabb3de2076fd027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610138Reviewed-by:
-
Mihai Sardarescu authored
This CL makes the sign-in tests more resilient: * it clears the sign-in state on setup * it commits pref changes on tear down to make sure that clearing the last sign-in account is actually written to disk. Bug: 961728 Change-Id: I833f3c888312c4a38ed13fa6bd9373989cf6dbb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605914 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#659037}
-
Ehsan Karamad authored
MimeHandlerViewContainerManager::DidLoad is used to notify the renderer that PostMessageSupport can be active and forward messages. The current logic activates the first PostMessageSupport with a matching URL. This should be the first PostMessageSupport that is *not* active and has a matching URL. TBR=wjmaclean@chromium.org Bug: 957373 Change-Id: Ic2925b593081ec5ac83d6950a1f57243d2b41e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608820Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#659036}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56a200add45f..5864997e8422 Created with: gclient setdep -r src-internal@5864997e8422 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: I0bcaaefd41c35a266df8fc5be376436abb7f4c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610139Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659035}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7bc76b45a4b9..617d801ff762 git log 7bc76b45a4b9..617d801ff762 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 reed@google.com Reland "Reland "remove legacy 255-biased colormatrix"" Created with: gclient setdep -r src/third_party/skia@617d801ff762 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Iffcc8db10f50078f8cfb30ef0c753f4b7a7db9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610002Reviewed-by:
-
Edin Kadric authored
button if the list is empty. Bug: 962334 Change-Id: Id8515c0caf92deb6743226d05287fb816a91353c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608804 Commit-Queue: Edin Kadric <edinkadric@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#659033}
-
Roger Tawa authored
The new linker reports fatal errors during the build on windows when duplicate strings resources are defined. Both installer_utils and gaiacp use generate_embedded_i18n.gni to generate their strings which causes them to use overlapping string resource IDs. However, tests don't need to link with gaiacp strings, so this CL reduces the test dependencies on gaiacp. Add a dependency to installer/util:strings to tests that need it. browser_tests, interactive_ui_tests, and related tests that use ChromeTestLauncherDelegate need to have the installer's strings since they adjust Windows firewall rules. Bug: 958955 Change-Id: I51659aab3b79bda81d1583e7e75feaa11269d3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602732Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#659032}
-
Christian Dullweber authored
Add tracing for tasks executed by StoragePartition to figure out why deletions sometimes don't finish. Bug: 932083 Change-Id: I105fe2e246ceeaa5cba36f213f87b531353d2468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595871 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659031}
-
Mikel Astiz authored
After some back and forth, we've concluded that there's too much risk involved in assuming most clients have already migrated to prefs, i.e. cache GUID and birthday populated. As middle ground, we keep considering the values in prefs the authoritative ones, but if empty, we populate them from the sync directory. This adds some complexity, but allows us to defer the more aggressive turndown (disable migration), which in addition can now be guarded behind a feature toggle. Bug: 923285 Change-Id: I11c4814dae1810c34c1473af36ace9a1b517067f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609242 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#659030}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/46afbf9481fb..18a6625221e4 git log 46afbf9481fb..18a6625221e4 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 sprang@webrtc.org Fix typo in rtp_sender.h 2019-05-13 srte@webrtc.org Adds route changes in event logs. 2019-05-13 sprang@webrtc.org Distinguish between missing packet and send failure. 2019-05-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f9876c44..7da20dc3 (658883:658985) 2019-05-13 phensman@webrtc.org Update visibility for java targets in sdk/android 2019-05-13 nisse@webrtc.org Make the output_period_ms argument to StartRtcEventLog optional 2019-05-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 48b83dda..f9876c44 (658736:658883) 2019-05-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b149f494..48b83dda (658619:658736) Created with: gclient setdep -r src/third_party/webrtc@18a6625221e4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I74ef228140f96b3697c90794fc966eb8d19bd45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609998Reviewed-by:
-
Mikel Astiz authored
The situation where a cache GUID is known but no birthday is problematic and can easily lead to sync protocol violations. In order to avoid that, we persist both atomically in ProfileSyncService::OnEngineInitialized(). This reverts the changes in https://chromium-review.googlesource.com/c/chromium/src/+/1583879 with additional changes. Bug: 923285 Change-Id: Ic198c69c9e53bcd1030e824063dac5338f166b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604272 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This makes them visible as heading when using heading navigation in assistive technology. They are logically headings, but are using div instead of h2 and I am somewhat afraid to make them h2 :) Bug: 957368 Change-Id: I5978a49dfa8a4c2725fd491228e5eee9e01e032d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604348 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#659027}
-
Madeleine Barowsky authored
The current yuv_decoding JPEG decoding Telemetry story is misleading for two reasons: it does not decode to or render from YUV (see crbug.com/921875) and it uses canvas.toDataURL to create random test images each time, which means encoding duration is also measured. Furthermore, the test flashes rapidly and could potentially trigger photosensitive epilepsy. Because YUV decoding and rendering is in progress for WebP (crbug.com/900264), we would like holistic and consistent measurement of the performance between YUV and RGB decoding. The YUV decoding feature is being implemented for GPU rasterization first. Later, we will do the same for JPEG (crbug.com/919627). This CL replaces the existing story with four new ones: * WebP GPU rasterization that does not disable YUV * WebP GPU rasterization that disables YUV (hence is RGB) * JPEG GPU rasterization that does not disable YUV (is RGB for now) * JPEG GPU rasterization that disables YUV (hence is RGB) These ImageDecodingStory tests draw 10 pastel-colored squares from hard-coded base64 data and at a relatively slow rate. Bug: 944756 Change-Id: Id46817eb300b3c6f3681ccf331ba23f67bbdfef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536460Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659026}
-
Mikel Astiz authored
This is a reland of 956715c7 Original change's description: > Fix sync protocol violation about birthday requirements > > The sync (store) birthday can only be empty during the very initial > interactions with the server, when control datatypes are downloaded, > after enabling sync (or the user signing in, for sync-the-transport > mode). > > If, during startup, the birthday is empty, we should throw away all > sync metadata and redownload everything. One way to do so is to > regenerate the cache GUID, which datatypes detect as mismatch and > leads to all sync metadata being cleared. > > As can seen in newly added tests, the scenario seems hard to > reproduce, but we have server-side evidence that some users run into > this issue (and would even DCHECK-fail for DCHECK-enabled builds). > > Bug: 923285 > Change-Id: If9e4807a086001931fd65f3e12a1ab53c4a33c9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599456 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658540} Bug: 923285 Change-Id: I38101a4e534d80a6cf4d29dbdaeac078e4c03212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607806Reviewed-by:
-
Peter Wen authored
3.5 Canary 13 is now available on gLinux. Tbr: agrieve@chromium.org Bug: 620034 Change-Id: I75194c28f6ba8e2511b276134308b3f8f8ba5074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610140Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659024}
-
Carlos Caballero authored
Also provide a Handle class that is safe to use from any thread. This class can then be reused by the IO thread. Bug: 863341 Change-Id: I129c6481e79bf87b95bcf641a91258a878ec5cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598811 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#659023}
-
arthursonzogni authored
For RenderWidgetHostImpl created on behalf of the browser process, replace raw pointers by std::unique_ptr. Currently, the owners of the RenderWidgetHostImpl are: 1. The RenderViewHostImpl. In this case the main RenderFrameHostImpl "borrows" the RenderWidgetHostImpl from it. 2. The local-root RenderFrameHostImpl. For RenderWidgetHostImpl created on behalf of the renderer process, they continue to use raw pointers and to self-destroy via IPC. Bug: 545684, 950969 Change-Id: If08e8634d7b329cae42b2101307a54750bfb61f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559186Reviewed-by:danakj <danakj@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#659022}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b48fcfc9759..56a200add45f Created with: gclient setdep -r src-internal@56a200add45f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: I73b4190ef212f701e6e590686e5bbbec666e2f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609653Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/782cc0e47030..6fcb54784f85 git log 782cc0e47030..6fcb54784f85 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 treehugger-gerrit@google.com Merge "ftrace_controller debug print: support >64 cpus (bitset is 128 wide)" Created with: gclient setdep -r src/third_party/perfetto@6fcb54784f85 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I1c1c9c2616fe497488e70bb330deead19769695d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609650Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ff395373a925..e33ee3bd7c70 git log ff395373a925..e33ee3bd7c70 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 perezju@chromium.org [Telemetry] Remove fallback code for old (or no) tracing support 2019-05-13 dberris@chromium.org SheriffRedux: Wire up HTTP Tests Created with: gclient setdep -r src/third_party/catapult@e33ee3bd7c70 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947675,chromium:953181 TBR=skyostil@google.com Change-Id: I0a83794feb2977d28e752a4994869ce51b762ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609646Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/512e74e0..649b2ae0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib0edc0f548495c7bf14af4573da40daabbb911af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609857Reviewed-by:
-
