- 06 Jun, 2014 40 commits
-
-
acolwell@chromium.org authored
> Eliminate MediaPlayer & MediaPlayerClient abstractions(rate, setRate and other APIs) > > BUG=350571 > > Chromium side patch for this is https://codereview.chromium.org/303403002/ > > Review URL: https://codereview.chromium.org/304353005 TBR=srirama.m@samsung.com Review URL: https://codereview.chromium.org/320053003 git-svn-id: svn://svn.chromium.org/blink/trunk@175711 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
amikhaylova@google.com authored
BUG=376194 Review URL: https://codereview.chromium.org/312143003 git-svn-id: svn://svn.chromium.org/blink/trunk@175709 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@chromium.org authored
There's no connection between being visible and z-order lists. There's no reason to mark the z-order list as dirty when changing visibility status. Review URL: https://codereview.chromium.org/320593004 git-svn-id: svn://svn.chromium.org/blink/trunk@175708 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
http://src.chromium.org/viewvc/blink?view=revision&revision=175681 BUG=313438 TBR=rob.buis@samsung.com Review URL: https://codereview.chromium.org/311193011 git-svn-id: svn://svn.chromium.org/blink/trunk@175707 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
The previous version of this test generated non-deterministic results due to the way console messages are generated. Specifically, the test case was constructed while parsing might not yet be complete, but the act of constructing the test case generated console messages. If a console message is generated with no specified line number, Document::internalAddMessage attempts to attach a line number, but one of the conditionals for doing so is whether the Document is still parsing making the output non-deterministic. To get around that, the test has been rewritten to only run once the document is finished loading. BUG=381451 R=japhet@chromium.org Review URL: https://codereview.chromium.org/314393002 git-svn-id: svn://svn.chromium.org/blink/trunk@175706 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@chromium.org authored
This code evolved and grew over the years, but it seems to be trying to compute something very simple. Review URL: https://codereview.chromium.org/307933010 git-svn-id: svn://svn.chromium.org/blink/trunk@175704 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
BUG=369375 TBR=sandersd@chromium.org Review URL: https://codereview.chromium.org/321603002 git-svn-id: svn://svn.chromium.org/blink/trunk@175702 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
TBR=falken@chromium.org Review URL: https://codereview.chromium.org/319233002 git-svn-id: svn://svn.chromium.org/blink/trunk@175701 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ajuma@chromium.org authored
This allows expanding the GPU rasterization trigger for a field trial. The expanded trigger is <meta name="viewport" content="width=device-width, minimum-scale=1.0"> BUG=380454 Review URL: https://codereview.chromium.org/309593007 git-svn-id: svn://svn.chromium.org/blink/trunk@175699 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eae@chromium.org authored
Fix bug in Element::scrollWidth/scrollHeight where the scroll offset was truncated to an integer value before being adjusted for zoom. TEST=fast/sub-pixel/clientwidth-matches-scrollwidth-for-float.html BUG=381039 Review URL: https://codereview.chromium.org/319633004 git-svn-id: svn://svn.chromium.org/blink/trunk@175698 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jbroman@chromium.org authored
This is simpler, and marginally more efficient (as it avoids setting up the paint in a default state only to immediately overwrite it). GraphicsContext::setupShader is declared but never defined, so its declaration has been removed while here. BUG=381750 Review URL: https://codereview.chromium.org/311193009 git-svn-id: svn://svn.chromium.org/blink/trunk@175697 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mkosiba@chromium.org authored
Looks like after Blink r175269 the moment where the test runner grabs the text dump may occur after the quick-fail timer. I've only been able to repro it once out of about 40 invocations so I can only speculate that the navigation which we cancel in beforeunload is somethimes delaying the test's completion long enough for the deadman's switch to fire. Since the order of events is correct even in the failing case it's relatively simple to make the test pass regardless of whether the test runner grabs the text dump before or after the timer fires. BUG=380151 Review URL: https://codereview.chromium.org/319673002 git-svn-id: svn://svn.chromium.org/blink/trunk@175696 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
falken@chromium.org authored
BUG=381827 TBR=jsbell NOTRY=true Review URL: https://codereview.chromium.org/314413002 git-svn-id: svn://svn.chromium.org/blink/trunk@175695 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@chromium.org authored
CompositingUpdateAfterStyleChange does the same thing as CompositingUpdateAfterCompositingInputChange. There's no reason to have two enums. Also, I've inlined FrameView::updateCompositingLayersAfterStyleChange because that function just contained a redundant null check. BUG=332248 Review URL: https://codereview.chromium.org/321573002 git-svn-id: svn://svn.chromium.org/blink/trunk@175694 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
falken@chromium.org authored
BUG=381827 TBR=jsbell Review URL: https://codereview.chromium.org/314413002 git-svn-id: svn://svn.chromium.org/blink/trunk@175693 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ajuma@chromium.org authored
This makes CompositingReasonFinder::requiresCompositingForAnimation take a RenderStyle* rather than a RenderObject*. Review URL: https://codereview.chromium.org/317013005 git-svn-id: svn://svn.chromium.org/blink/trunk@175692 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@chromium.org authored
This function was written in a confusing way. R=ojan@chromium.org Review URL: https://codereview.chromium.org/324513003 git-svn-id: svn://svn.chromium.org/blink/trunk@175691 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
alokp@chromium.org authored
The hint is now per page instead of per layer. BUG=367202 Review URL: https://codereview.chromium.org/312203002 git-svn-id: svn://svn.chromium.org/blink/trunk@175690 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sanjoy.pal@samsung.com authored
BUG=None Review URL: https://codereview.chromium.org/311263009 git-svn-id: svn://svn.chromium.org/blink/trunk@175689 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jochen@chromium.org authored
BUG=368095 R=vogelheim@chromium.org,dcarney@chromium.org,adamk@chromium.org Review URL: https://codereview.chromium.org/317213004 git-svn-id: svn://svn.chromium.org/blink/trunk@175688 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dgozman@chromium.org authored
Before, if we had not enough space and clipped the page height, resizing width will also reset height to the clipped size. BUG=none Review URL: https://codereview.chromium.org/321513004 git-svn-id: svn://svn.chromium.org/blink/trunk@175687 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
timvolodine@chromium.org authored
multi-event type targets. This patch performs a significant refactoring of the DeviceSensorEvent{Controller,Dispatcher} and related classes. It provides new Base classes to allow simple implementation of APIs involving multi-event type non-window targets (e.g. Battery Status API). Additionally it makes the implementation of existing event-based APIs (device_orientation, device_light) simpler and more compact. In particular the following new classes have been added: * DeviceEventControllerBase and DeviceEventDispatcherBase (derived from by the Battery Status API). * DeviceSingleWindowEventController is more specific and contains functionality necessary for single-event type window target APIs (used by Device Motion/Orientation and Device Light APIs). BUG=122593, 360068 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175661 Review URL: https://codereview.chromium.org/315573002 git-svn-id: svn://svn.chromium.org/blink/trunk@175686 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dongseong.hwang@intel.com authored
Most subclasses of WebFrameClient assume that the destructor of WebFrameClient is virtual. Currently, CreateChildCounterFrameClient class in WebViewTest.cpp is in trouble because of this. BUG=N/A Review URL: https://codereview.chromium.org/320583002 git-svn-id: svn://svn.chromium.org/blink/trunk@175685 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
Breaks incremental builds. BUG=381391 TBR=peter@chromium.org Review URL: https://codereview.chromium.org/312423006 git-svn-id: svn://svn.chromium.org/blink/trunk@175684 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
srirama.m@samsung.com authored
BUG=350571 Chromium side patch for this is https://codereview.chromium.org/303403002/ Review URL: https://codereview.chromium.org/304353005 git-svn-id: svn://svn.chromium.org/blink/trunk@175683 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
bokan@chromium.org authored
This patch applies the pinch viewport offset to selection handle coordinates when passing the coordinates into Blink. This fixes the case where selection handles would appear in the wrong place while being manipulated while pinched in or when the ChromeOS on-screen keyboard is showing. BUG=376332 Review URL: https://codereview.chromium.org/319643002 git-svn-id: svn://svn.chromium.org/blink/trunk@175682 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rob.buis@samsung.com authored
The SVGElementInstance tree has been removed from SVG2: http://www.w3.org/TR/SVG2/changes.html#structure This patch removes it completely. The exact naming of the various trees after removing the instance tree is still under discussion and will be implemented in a follow-up patch. BUG=313438 Review URL: https://codereview.chromium.org/272523002 git-svn-id: svn://svn.chromium.org/blink/trunk@175681 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
c.shu@samsung.com authored
The effort needs to be done in 3 steps: 1. Create the runtime flag interface in blink; 2. Enable the flag for Android from chromium even it does not do anything in blink; 3. Replace compile time guard with runtime flag in blink and remove ENABLE_FAST_MOBILE_SCROLLING in gyp file. This is the 1st set of changes. BUG=381391 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175621 Review URL: https://codereview.chromium.org/321473002 git-svn-id: svn://svn.chromium.org/blink/trunk@175679 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pmarch@chromium.org authored
Cleaning WebDOMActivityLogger interface. Deprecating old methods. Fixing assignment of ActivityLogger to V8PerContextData. BUG=366916 Review URL: https://codereview.chromium.org/315373002 git-svn-id: svn://svn.chromium.org/blink/trunk@175678 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
This reverts r175672. It breaks the browser_tests compile on Linux (and probably everywhere). ../../third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp:103:74: error: no member named 'push' in namespace 'WebCore::EventTypeNames' m_workerGlobalScope->dispatchEvent(PushEvent::create(EventTypeNames::push, data)); TBR=mvanouwerkerk@chromium.org Review URL: https://codereview.chromium.org/314373002 git-svn-id: svn://svn.chromium.org/blink/trunk@175677 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
adamk@chromium.org authored
This avoids allocating a v8::Function to wrap Blink microtask callbacks, which allows us to avoid entering a v8::Context to enqueue tasks. ScriptRegexp is now the only use of the v8::Context stored in V8PerIsolateData. Review URL: https://codereview.chromium.org/319753004 git-svn-id: svn://svn.chromium.org/blink/trunk@175676 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
BUG=381730 TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/322553002 git-svn-id: svn://svn.chromium.org/blink/trunk@175675 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
chrishtr@chromium.org authored
Review URL: https://codereview.chromium.org/318753008 git-svn-id: svn://svn.chromium.org/blink/trunk@175674 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
Revert of Generalize and refactor DeviceSensorEvent* architecture to support multi-event type targets. (https://codereview.chromium.org/315573002/) Reason for revert: Triggers assert in fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html Original issue's description: > Generalize and refactor DeviceSensorEvent* architecture to support > multi-event type targets. > > This patch performs a significant refactoring of the > DeviceSensorEvent{Controller,Dispatcher} and related classes. > It provides new Base classes to allow simple implementation of > APIs involving multi-event type non-window targets (e.g. Battery > Status API). Additionally it makes the implementation of existing > event-based APIs (device_orientation, device_light) simpler and > more compact. > > In particular the following new classes have been added: > * DeviceEventControllerBase and DeviceEventDispatcherBase > (derived from by the Battery Status API). > * DeviceSingleWindowEventController is more specific and > contains functionality necessary for single-event type window > target APIs (used by Device Motion/Orientation and Device Light > APIs). > > BUG=122593, 360068 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175661 TBR=ch.dumez@samsung.com,abarth@chromium.org,jochen@chromium.org,tkent@chromium.org,timvolodine@chromium.org NOTREECHECKS=true NOTRY=true BUG=122593, 360068 Review URL: https://codereview.chromium.org/315023006 git-svn-id: svn://svn.chromium.org/blink/trunk@175673 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mvanouwerkerk@chromium.org authored
BUG=350394 TBR=peter@chromium.org,dominicc@chromium.org,jochen@chromium.org,michaeln@chromium.org,kinuko@chromium.org Review URL: https://codereview.chromium.org/320503005 git-svn-id: svn://svn.chromium.org/blink/trunk@175672 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ager@chromium.org authored
I think we need to bite the bullet and change the semantics of our weak collections. These leaks are really hard to notice when you are programming. See crbug.com/381629 which is the bug report I have filed for tracking that. R=erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com BUG=381629 Review URL: https://codereview.chromium.org/317203005 git-svn-id: svn://svn.chromium.org/blink/trunk@175670 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
apavlov@chromium.org authored
R=dgozman BUG=381184 Review URL: https://codereview.chromium.org/322483004 git-svn-id: svn://svn.chromium.org/blink/trunk@175669 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
BUG=378778 Review URL: https://codereview.chromium.org/313083005 git-svn-id: svn://svn.chromium.org/blink/trunk@175668 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dgozman@chromium.org authored
BUG=none TBR=pfeldman@chromium.org Review URL: https://codereview.chromium.org/314303005 git-svn-id: svn://svn.chromium.org/blink/trunk@175667 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
noel@chromium.org authored
No change in behavior, no new tests. BUG=258324 Review URL: https://codereview.chromium.org/18099004 git-svn-id: svn://svn.chromium.org/blink/trunk@175666 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-