- 10 Mar, 2020 40 commits
-
-
Roman Aleksandrov authored
Bug: 1051856 Change-Id: Iea7cb5bb26d887d48285058676a55b1ab1b47d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085051Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#748638}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/343d4f6f1870..dbb56a1d4859 git log 343d4f6f1870..dbb56a1d4859 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 johnkslang@users.noreply.github.com Merge pull request #2105 from jeffbolznv/nonunif Created with: gclient setdep -r src/third_party/glslang/src@dbb56a1d4859 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I98a38f8ea39f2cad4a04c8de60aef28ed0e9d479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096516Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748637}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0b38974f. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" f21f4b76 "Reland "Origin policy: implement window.originPolicyIds"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3bf1417972fc944b632a95189ef5990c15f5b359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096377Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748636}
-
Peng Huang authored
This is a reland of 00861a81 Original change's description: > VulkanSwapChain: Use VK_KHR_incremental_present for better performance. > > Bug: 1059598 > Change-Id: I4ec9ae96b97606d4e64d6ce8874471b00586def8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094235 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748280} TBR=vasilyt@chromium.org Bug: 1059598 Change-Id: I4f5154125f5c1a23bd9f696c2ec7223aa8405999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095147Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748635}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/137991396d03..a2cb93d8b965 git log 137991396d03..a2cb93d8b965 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 srte@webrtc.org Revert "Wire up internal libvpx VP9 scaler to statistics proxy" Created with: gclient setdep -r src/third_party/webrtc@a2cb93d8b965 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibd370f0d237e7f64be0cd53b3cf9737a8b00e4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096212Reviewed-by:
-
Rohit Agarwal authored
not supported types. ParameterSet should throw IllegalArgumentException when we add a parameter of a type which is not supported in the getAcceptableTypes method. However, it throws an ArrayStoreException because the type definition of ACCEPTABLE_TYPES is of type Set<Class<?>> and when we invoke the toArray method of the Set class we define the type as String. This CL fixes that and specifies the correct type which is Class in the toArray method. It also adds unit tests. Bug: 1059752 Change-Id: Ia54b0d3acd2e2813a618ad87b97f10a443e64fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093595Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#748633}
-
Peng Huang authored
With https://chromium-review.googlesource.com/c/chromium/src/+/2088343, SkiaOutputSurfaceImpl::Reshape() can create SkSurfaceCharacterization on viz thread without waiting on GPU thread Reshape(), so we don't need the forced Resahpe(). Bug: 1041949 Change-Id: I93030d2c7dca9f66183f661b95868fad957af6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094252 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#748632}
-
Takuto Ikuta authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/0ac28472d073..cc958279ffd6 $ git log 0ac28472d..cc958279f --date=short --no-merges --format='%ad %ae %s' 2020-03-10 tikuta client: remove --extra-variable flag from isolate.py 2020-03-03 tikuta client: update isolated 2020-03-02 jbudorick run_isolated: expand list of caches to touch. 2020-02-26 jbudorick run_isolated: touch requested named caches. 2020-02-25 tikuta client: use print to write to stdout 2020-02-19 tikuta client: check retcode of isolated execution 2020-02-18 jwata [swarming] fix tools.clear_cache_all 2020-02-18 tikuta client: increase verbosity during isolated download 2020-02-06 tikuta client: use go isolated in win10 or non-windows 2020-02-04 tikuta client: update isolated 2020-02-03 tikuta client: update oauth2client from 1.5.2 to 2.0.0-post1 2020-01-31 tikuta client: use request_uuid 2020-01-31 tikuta client: apply yapf to client/tests/swarming_test.py Created with: roll-dep src/tools/swarming_client Change-Id: I97a72e906fd998681f883ee94126148645502bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096164 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#748631}
-
Wayne Kung authored
Add NVMe self-test routine to cros_healthd. The routine launches self-test with a period of time(short/extended). Bug: b:146513388 Test: 1. chromeos_unittests --gtest_filter =CrosHealthdServiceConnectionTest.* 2. unit_tests --gtest_filter =DeviceCommandRunRoutineJobTest.* Change-Id: I61b512891620fbb0c8ee945061148bf69a72dd00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050145 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#748630}
-
Andy Paicu authored
This reverts commit 5252635d. Reason for revert: crbug.com/1060107 Original change's description: > Add OAuth token to download protection pings > > For users who have enhanced protection enabled, and are not incognito, > attach an OAuth access token to download protection pings to improve > the quality of verdicts. > > Bug: 1051679 > Change-Id: I8cdfd3392c10cd9d7b81cd5f036e8ccf179b6ade > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092944 > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748499} TBR=drubery@chromium.org,xinghuilu@chromium.org Change-Id: I115614a660b666a2efb93fd82a02e2c6d4d8045d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1051679, 1060107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096557Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748629}
-
Monica Basta authored
Bug: 1043128 Change-Id: I61dae8ca57cb194beab845974db9f97399a8182f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095126Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#748628}
-
Fredrik Söderquist authored
When the instance lists grow to a sizable length, checking for and removing instance time with a kScript origin can take significant time in some cases - especially when there are no such instance times present at all. Add a bitmask encoding which origins are present in the list, and then use that to avoid redundant scans (in RemoveWithOrigin) when possible. Bug: 1039243 Change-Id: I7008927338508f08e8b416822fbe52073a86da1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089706 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748627}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/abcc536b6207..e18f749d97e8 git log abcc536b6207..e18f749d97e8 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader b44162fdbb25..8be72df60462 (1 commits) 2020-03-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 4c027048d88b..dd3d91691f1e (3 commits) Created with: gclient setdep -r src/third_party/angle@e18f749d97e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ic21bc3c3cdc9641c3d91b56122fe85c4853a6935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096210Reviewed-by:
-
Takashi Sakamoto authored
Bug: 1050069 Change-Id: Ifef194cf1d21f1a7bcecfadf753c1e52f0c39ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071188Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#748625}
-
Wayne Kung authored
Add NVMe wear-level routine to cros_healthd. The routine examines weal level against desired threshold. Bug: b:146513388 Test: 1. chromeos_unittests --gtest_filter =CrosHealthdServiceConnectionTest.* 2. unit_tests --gtest_filter =DeviceCommandRunRoutineJobTest.* Change-Id: I3ba7ea651e3c134caa5a7c0253241e7c19ca6601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050215 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by: -
Vidhan authored
Bug: 959105 Change-Id: I03db99cc259456ac273b715fdadbca5793f1f693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023496Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#748623}
-
Finnur Thorarinsson authored
The tests have changed a tiny bit and I can't repro the failure locally, despite repeated attempts. Bug: None Change-Id: I527562805cbe66bf3052d945fafac73206549e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095120 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#748622}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ed3bbe90..40d81599 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iec2caf9f4e225cf3f1f5d1a9da7e6e2cbe011a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093532Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748621}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a12175c2a7a9..0c4a3c2503a6 git log a12175c2a7a9..0c4a3c2503a6 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 yyanagisawa@chromium.org Roll out new goma client binary VERSION=194 Created with: gclient setdep -r src/third_party/depot_tools@0c4a3c2503a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib12731304a61703516d8692ff9b911f6d075dbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096211Reviewed-by:
-
Eric Seckler authored
On a specific bot, only the first story seems to fail consistently. This has led to disabling stories one-by-one, in the hope that the bot would turn green again. Since it didn't, keeping these stories disabled doesn't seem to make sense. Thus, reenabling them. The bot will stay red until we figure out what's causing the trace data loss. TBR=sadrul@chromium.org NOTRY=true Bug: 1059767 Change-Id: I19d85ba812234c6a511a3a8bc3dcd430789a9047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093230Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#748619}
-
Oriol Brufau authored
The test was failing in legacy layout. BUG=929098 Change-Id: Ic96be044bfe1483c505ab38b44f87ce68dd7a045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094992Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#748618}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8a44af5cbad5..80f8325046b9 git log 8a44af5cbad5..80f8325046b9 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-03-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5c8f724b..7f81408a (409 commits) 2020-03-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0c9b6abde90c..abcc536b6207 (12 commits) 2020-03-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b44162fdbb25..8be72df60462 (1 commits) Created with: gclient setdep -r src/third_party/skia@80f8325046b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I35f7bde864f4592210556f7a369af5ecb7bc31f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096205Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85edfc8c8341..ed60bec01fc7 git log 85edfc8c8341..ed60bec01fc7 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-10 szuend@chromium.org Revert "Move ContentProvider.js and StaticContentProvider.js to text_utils." 2020-03-10 joselea@microsoft.com Move ContentProvider.js and StaticContentProvider.js to text_utils. 2020-03-09 changhaohan@chromium.org use "alias_for" from css_properties.json5 to get canonical css property names Created with: gclient setdep -r src/third_party/devtools-frontend/src@ed60bec01fc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1039620 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ida25179483c451bd820376b7950224cc87368a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096207Reviewed-by:
-
Tanmoy Mollik authored
Replace ChromeSigninController with IdentityManager in AssistantHeaderCoordinator Bug: 1058989 Change-Id: I928b5c41f7a74aa2f410bce72c8a0bae1672adca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089784Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Jose Lopes authored
Deal with some remaining base::Bind calls in the media/ directory that have not yet been dealt with by the CLs that have replaced base::Callback with once or repeating callbacks. Change-Id: I4005e2ec2255f5545c87470d39abde2e42d6ae5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089859 Commit-Queue: Jose Lopes <jabolopes@google.com> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748614}
-
Mirko Bonadei authored
Bug: 1059349 Change-Id: I451873d552b6fe0ca6cd481385042bf37a05fbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095717Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#748613}
-
Jochen Eisinger authored
Bug: 1057547 Change-Id: I295cea546021e421e0b72b5486d07a24fe3f0565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094128 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#748612}
-
Rushan Suleymanov authored
This patch removes mutex from AllStatus class and introduces SyncStatusObserver instead of getting of status directly from AllStatus from different threads. AllStatus becomes single-threaded now. Status for debugging is stored in SyncEngineImpl. Bug: 1058773 Change-Id: Ib1d30d5ff6bc5bc5e1f24e94499de949f1e2e053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089695 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#748611}
-
Anastasiia Nikolaienko authored
Child users cannot add secondary accounts to ARC. Show an error screen. Screenshot: https://crbug.com/1043108#c17 Bug: 1043108 Change-Id: If38ec58af9c2b214d74e72ae0cf2ea9d3063ac52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087681 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#748610}
-
Andy Paicu authored
This reverts commit 01d497a6. Reason for revert: crubg.com/1060091 Original change's description: > Safebrowsing radio toggle addition to the security page > > Adding a new collapsible radio toggle to the security page that includes a third safebrowsing option (enhanced), with more thorough explanations for this third option and the already available standard and disabled options. > > Bug: 1032584 > Change-Id: I6e4732ae464120d3d264b141dbb172aa125f9824 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088851 > Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> > Auto-Submit: Sean Harrison <harrisonsean@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748394} TBR=dpapad@chromium.org,aee@chromium.org,harrisonsean@chromium.org,sauski@google.com Change-Id: I4859d2ed5db2352f4d64f014c5154d66b0825c4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095127Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7f96787e8a3..3310ddd30e3b Created with: gclient setdep -r src-internal@3310ddd30e3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iabf3b2c5e4675c433a7be6002260a147c49154fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096206Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748608}
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in some sub-directories of chrome/browser to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - chrome/browser/ui/webui This CL has no behavior changes. Bug: 1001360 Change-Id: I69d11e6e247ef9ff77aa09cf05bda2c5fbe890e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094900Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#748607}
-
Ulan Degenbaev authored
Bug: 1049093 Change-Id: I830afdbcd712e892053edd263170d67996be40a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095306Reviewed-by:
-
Fredrik Söderquist authored
Add a simple wrapper class for the Vector<SMILTimeWithOrigin> representation of an instance list, and move all list mutating operations to it. This will allow easier tracking of which "origins" are present in the list, and thus avoiding certain operations in some cases. This will be added in a follow-up CL. Bug: 1039243 Change-Id: Iac126f0f6628696fea436514dcab5d824c1dc588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089765Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch rebaselines paint/invalidation/* where "geometry" or "full" are turned to "disappeared" and "appeared" because FragmentItem does not implement re-use yet. When we implement re-using, we will re-review them. For now, rebaselining these failures allows us to review other failures more carefully. TBR=yosin@chromium.org, wangxianzhu@chromium.org Bug: 982194 Change-Id: I0d324c6f51399401704940f01c2509557d4cae0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096317Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#748604}
-
Maria Kazinova authored
Initially a few iOS saving tests were based on checking the LogManager messages. Now more testing methods are mocked and implemented, so these tests can also be rewritten. Bug: 598672 Change-Id: Id0860d2946ea6b9912c1a95efb66ad1e2fb971f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094986Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#748603}
-
Monica Basta authored
As part of friendly settings, the 'Manage Data from chrome sync' title is changed. Bug: 1043128 Change-Id: I2b3a79e6adbf297fe853a151a4132db12af018e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095013Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#748602}
-
Gauthier Ambard authored
This CL is a Reland of crrev.com/c/2071938 This CL makes sure that the animations of the RecentTabs are disabled when the recent tabs aren't presented when BVC is contained. The original CL wasn't working because the updates weren't prevented when the class was instantiated. If the user is signed in, the first presentation is trying to update the TableView even if it wasn't shown yet. Fix it by preventing updates in -init. Bug: 1038034 Change-Id: Id2ec3e63dd78a014a87abf91ec99fe001b27df4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095116Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748601}
-
Noel Gordon authored
Bug: 1035691 Change-Id: I63f075c71a288bc88455ff4f7ac5cccff9af7cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094854Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#748600}
-
Kei Nakashima authored
|MoveTo| didn't work correctly when moving the target node before itself/its next node. Also added DCHECKs, which check if the target node is not anchor and if two given node is both in-use list. Change-Id: I60442f1d706a072eaeca9bc83eaaee9d60b0c853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096316 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
