- 13 Aug, 2014 40 commits
-
-
viettrungluu@chromium.org authored
Cleanup: Forward declare MojoApplicationHost in render_process_host_impl.h, instead of including the header. R=sky@chromium.org Review URL: https://codereview.chromium.org/469803002 Cr-Commit-Position: refs/heads/master@{#289383} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289383 0039d316-1c4b-4281-b951-d872f2087c98
-
jww@chromium.org authored
(Re-commit of https://codereview.chromium.org/418133012/) Currently, if a user clicks 'proceed' through an SSL interstitial, their only way to revoke this decision is to restart their browser session. This commit provides an explicit button in the page info to revoke this decision if the user is using the remember certificate error decisions experiment. Since decisions are remembered across browser restarts for these users, it's important to provide them with a mechanism to revoke their decision later. BUG=262615 NOTRY=true TBR=tedchoc@chromium.org,rsesek@chromium.org,jam@chromium.org,pkasting@chromium.org Review URL: https://codereview.chromium.org/473643002 Cr-Commit-Position: refs/heads/master@{#289382} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289382 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=403528 TBR=enne@chromium.org Review URL: https://codereview.chromium.org/476443002 Cr-Commit-Position: refs/heads/master@{#289381} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289381 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
NOTRY=true TBR=hclam@chromium.org Review URL: https://codereview.chromium.org/467423002 Cr-Commit-Position: refs/heads/master@{#289380} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289380 0039d316-1c4b-4281-b951-d872f2087c98
-
dtrainor@chromium.org authored
Broke Android Tests (dbg) > Battery Status API: implementation for Linux. > > Implementation of the Battery Status API for the Linux platform. > Implementation uses DBus to talk to org.freedesktop.UPower service > to obtain battery information. > > BUG=122593 > TEST=http://jsbin.com/battery-status-test (manual) > TBR=brettw@chromium.org > NOTRY=true > > Review URL: https://codereview.chromium.org/436683002 TBR=timvolodine@chromium.org Review URL: https://codereview.chromium.org/472643002 Cr-Commit-Position: refs/heads/master@{#289379} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289379 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
BUG=none TBR=tbreisacher@chromium.org Review URL: https://codereview.chromium.org/472613003 Cr-Commit-Position: refs/heads/master@{#289376} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289376 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289375} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289375 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
2fd7b0b Disable exceptions for the pdfium targets, now that pdfium:28 is done. d4e406e Remove try/catch block d38a35e Treat null Parent as no Parent for dictionary objects 9fa56b7 Fix missing or broken include guard macros in pdfium headers. 87708e1 For a CPDF_Color object, when set a new pattern to it, disconnect its link with the old pattern fda0d42 When normalize coordinate, return instead of assert() when divide BUG=382988,402260,402437,pdfium:28,82385 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/469603003 Cr-Commit-Position: refs/heads/master@{#289374} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289374 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
BUG=402903 R=yoz@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/462103003 Cr-Commit-Position: refs/heads/master@{#289373} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289373 0039d316-1c4b-4281-b951-d872f2087c98
-
timvolodine@chromium.org authored
Implementation of the Battery Status API for the Linux platform. Implementation uses DBus to talk to org.freedesktop.UPower service to obtain battery information. BUG=122593 TEST=http://jsbin.com/battery-status-test (manual) TBR=brettw@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/436683002 Cr-Commit-Position: refs/heads/master@{#289372} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289372 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Cr-Commit-Position: refs/heads/master@{#289371} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289371 0039d316-1c4b-4281-b951-d872f2087c98
-
reillyg@chromium.org authored
This class stores criteria for selecting USB devices. A device can be matched by its vendor and product IDs, and the interfaces that it implements. BUG=346953 TBR=satorux@chromium.org Review URL: https://codereview.chromium.org/462753002 Cr-Commit-Position: refs/heads/master@{#289370} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289370 0039d316-1c4b-4281-b951-d872f2087c98
-
guohui@chromium.org authored
BUG=403018 R=oshima@chromium.org Review URL: https://codereview.chromium.org/475533002 Cr-Commit-Position: refs/heads/master@{#289369} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289369 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
BUG= R=piman@chromium.org Review URL: https://codereview.chromium.org/453163002 Cr-Commit-Position: refs/heads/master@{#289367} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289367 0039d316-1c4b-4281-b951-d872f2087c98
-
pshenoy@chromium.org authored
This fixes a bug in displaying blink changelog if the range contains git hash and displays better error message in case of ValueError from json.loads. BUG=None NOTRY=True Review URL: https://codereview.chromium.org/463243002 Cr-Commit-Position: refs/heads/master@{#289363} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289363 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
Also stop shadowing modules names like `file` as local variables and otherwise adhere to the Python style guide: https://google-styleguide.googlecode.com/svn/trunk/pyguide.html R=tbreisacher@chromium.org BUG=393873 TEST=pydoc checker.py processor.py Review URL: https://codereview.chromium.org/475493002 Cr-Commit-Position: refs/heads/master@{#289361} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289361 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
This updates the includes in base but leaves a forwarding header for the rest of the project for now. R=yzshen@chromium.org Review URL: https://codereview.chromium.org/468253002 Cr-Commit-Position: refs/heads/master@{#289360} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289360 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
NOTRY=true Review URL: https://codereview.chromium.org/458403002 Cr-Commit-Position: refs/heads/master@{#289358} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289358 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
> Revert 288954 "[Sync] Don't synchronously stop datatypes that en..." > > Reason for revert: see crbug.com/403098 > > > [Sync] Don't synchronously stop datatypes that encounter errors > > > > The datatype logic may be operating unders assumptions that break when > > the type is stopped from under it, possibly triggering crashes. > > > > BUG=402595,403098 > > > > Review URL: https://codereview.chromium.org/462863002 > > TBR=zea@chromium.org > > Review URL: https://codereview.chromium.org/467923002 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/471683002 Cr-Commit-Position: refs/heads/master@{#289357} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289357 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
> Revert 288557 "[Sync] Use OnSingleDataTypeUnrecoverableError for..." > > Reason for revert: see crbug.com/403098 > > > [Sync] Use OnSingleDataTypeUnrecoverableError for all errors > > > > This removes the disable callback from all datatype controllers as well > > as the DisableDataType method from the PSS, in favor of > > OnSingleDataTypeUnrecoverable error (which now accepts a SyncError). > > > > BUG=368834,403098 > > TBR=bauerb@chromium.org > > > > Review URL: https://codereview.chromium.org/436733002 > > TBR=zea@chromium.org > > Review URL: https://codereview.chromium.org/465113002 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/469073002 Cr-Commit-Position: refs/heads/master@{#289356} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289356 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
> Revert 288464 "[Sync] Cleanup datatype configuration error handl..." > > Reason for revert: see crbug.com/403098 > > > [Sync] Cleanup datatype configuration error handling. > > > > The FailedDataTypeHandler is now informed immediately of failures, including > > datatype errors, and is therefore authoritative source for all errors. As such, > > partial success is no longer tracked and the various ModelTypeSets for error > > types in configure results are removed. > > > > BUG=368834,403098 > > > > Review URL: https://codereview.chromium.org/420633002 > > TBR=zea@chromium.org > > Review URL: https://codereview.chromium.org/468643002 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/469803004 Cr-Commit-Position: refs/heads/master@{#289354} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289354 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
Speculatively reverting because the CL may be causing the find_bugs step on the Android builder to fail http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/63828/steps/findbugs/logs/stdio TBR=jww NOTRY=TRUE Review URL: https://codereview.chromium.org/469003004 Cr-Commit-Position: refs/heads/master@{#289353} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289353 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
The old resources had too much bottom padding, and the radius of the bottom corners was incorrect There is a small related code change that fixes the size of the button here: https://codereview.chromium.org/460233003/ Screenshots: https://drive.google.com/open?id=0B1B1Up4p2NRMd214MHJSbzlUcFk&authuser=1 BUG=395798 R=oshima@chromium.org Review URL: https://codereview.chromium.org/462043003 Cr-Commit-Position: refs/heads/master@{#289352} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289352 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
in r286141. TBR=miket@chromium.org Review URL: https://codereview.chromium.org/465273003 Cr-Commit-Position: refs/heads/master@{#289351} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289351 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
TBR=ben@chromium.org Review URL: https://codereview.chromium.org/469053002 Cr-Commit-Position: refs/heads/master@{#289350} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289350 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
. Change the text color. . Change the default background color. . Make the fonts normal. . Add a 1px border at the bottom. BUG=401569 R=mukai@chromium.org Review URL: https://codereview.chromium.org/471503003 Cr-Commit-Position: refs/heads/master@{#289348} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289348 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
Favicons is known to have issues that trigger errors. Until those are resolved the error uploading should be reduced. Disable for now. BUG=384552 NOTRY=true Review URL: https://codereview.chromium.org/470653003 Cr-Commit-Position: refs/heads/master@{#289346} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289346 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
- remove file mojo_view_manager_lib_unittests.gtest-drmemory.txt R=oshima@chromium.org, bruening@chromium.org BUG=403177 NOTRY=TRUE Review URL: https://codereview.chromium.org/467333003 Cr-Commit-Position: refs/heads/master@{#289345} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289345 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
BUG=none NOTRY=true Review URL: https://codereview.chromium.org/464113002 Cr-Commit-Position: refs/heads/master@{#289344} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289344 0039d316-1c4b-4281-b951-d872f2087c98
-
rdsmith@chromium.org authored
BUG=None R=jar@chromium.org Review URL: https://codereview.chromium.org/414563002 Cr-Commit-Position: refs/heads/master@{#289343} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289343 0039d316-1c4b-4281-b951-d872f2087c98
-
brandonsalmon@chromium.org authored
It makes more sense to try to open the entries first rather than create them, since they will usually only not exist the first time. Review URL: https://codereview.chromium.org/465633003 Cr-Commit-Position: refs/heads/master@{#289342} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289342 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#289340} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289340 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/b2721f7372652496e1b1ec722883904caa8134a8..fbd3576a18799da88988ef26fa9bce09e8ebba37 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel TBR=bsalomon@google.com BUG= Review URL: https://codereview.chromium.org/467293002 Cr-Commit-Position: refs/heads/master@{#289339} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289339 0039d316-1c4b-4281-b951-d872f2087c98
-
skare@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/447673004 Cr-Commit-Position: refs/heads/master@{#289338} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289338 0039d316-1c4b-4281-b951-d872f2087c98
-
ckehoe@chromium.org authored
Review URL: https://codereview.chromium.org/459903006 Cr-Commit-Position: refs/heads/master@{#289337} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289337 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
Previously, if you allowed an extension on all urls, the checkbox disappeared, which was obviously very bad. Fix it. BUG=402958 Review URL: https://codereview.chromium.org/463983002 Cr-Commit-Position: refs/heads/master@{#289336} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289336 0039d316-1c4b-4281-b951-d872f2087c98
-
evy@chromium.org authored
Two fingers: up is go to top, down is read from here, left is browser back, right is browser forward. Three fingers: up and down map to page up/down. Four fingers: up is home page, down is refresh. Three/four finger left/right mappings to be added to the CL soon! BUG=387304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288857 Review URL: https://codereview.chromium.org/429633002 Cr-Commit-Position: refs/heads/master@{#289334} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289334 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
this reverts the revert of the revert of the revert > Revert 289154 "Revert 289067 "Use RE string pattern matching for..." > > > Revert 289067 "Use RE string pattern matching for blacklist stri..." > > > > Reason for revert: uninitialize memory access > > > > http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/29469/steps/memory%20test%3A%20content/logs/stdio > > > > > Use RE string pattern matching for blacklist strings. > > > > > > Including cpu_brand, gl_vendor, gl_renderer, gl_extension, driver_vendor, > > > and machine_model_name. > > > > > > BUG=396578 > > > TBR=piman@chromium.org > > > TEST=gpu_unittests > > > > > > Review URL: https://codereview.chromium.org/452293002 > > > > TBR=zmo@chromium.org > > > > Review URL: https://codereview.chromium.org/465163002 > > TBR=oshima@chromium.org > > Review URL: https://codereview.chromium.org/468223002 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/475453002 Cr-Commit-Position: refs/heads/master@{#289328} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289328 0039d316-1c4b-4281-b951-d872f2087c98
-
jkarlin@chromium.org authored
This will be needed for request/response blobs in the ServiceWorkerCache. BUG=392621 Review URL: https://codereview.chromium.org/459003002 Cr-Commit-Position: refs/heads/master@{#289326} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289326 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
TEST=InterceptorTest.BypassInterceptor* R=abarth@chromium.org,raymes@chromium.org BUG=none Review URL: https://codereview.chromium.org/467243002 Cr-Commit-Position: refs/heads/master@{#289325} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289325 0039d316-1c4b-4281-b951-d872f2087c98
-