- 02 Dec, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b97a24a009a1..2e3be5648a9f git log b97a24a009a1..2e3be5648a9f --date=short --first-parent --format='%ad %ae %s' 2019-12-02 reed@google.com Reland "fix sense of ifdef for deprecated method" Created with: gclient setdep -r src/third_party/skia@2e3be5648a9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I460c2bfc02aec683c5c7711ab50b0ede38178b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720617}
-
Charlene Yan authored
Bug: 1027426 Change-Id: I22940610369f88a933c85860dcd6aa97defcb8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941191Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720616}
-
Peter Boström authored
This function is dead since r715492. Bug: None Change-Id: I22fef49eed2d5e084630b7e94cbbf57056635462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945921 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#720615}
-
Ayu Ishii authored
Bug: 1007716 Change-Id: I89645eb8831a0f28a762c84e092b866e96bea1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939846Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#720614}
-
Sebastien Marchand authored
The |tabs_used_in_bg_| field wasn't properly set for the (rare) cases where the site data reader is available synchronously. Change-Id: Ida586be452cff80e74088df6d081bfc79899b26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943535 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#720613}
-
Ken MacKay authored
Change-Id: If92e2b949ae2792b1cde8b56bd394654897b76e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945956 Auto-Submit: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720612}
-
Elly Fong-Jones authored
This change fixes a bug in the extension error bubble in which that bubble shows two "Details" buttons. This was ultimately caused by the fact that GlobalErrorWithStandardBubble defined this method: virtual bool ShouldUseExtraView(); When this method returned true, GlobalErrorBubbleView was supposed to: 1) Not have a Cancel button, even if there was Cancel button text 2) Add a button in the extra view slot whose text was the Cancel button text 3) Call the GlobalErrorWithStandardBubble back via the cancel pressed method when that extra button was pressed This was used to add a "Details" button to extension errors. Unfortunately, the condition in (1) led to code like this: if (!ShouldUseExtraView() && has_cancel_text) AddCancelButton(); which looks like a bug, and so in 74eb4979 I "corrected" it in the obvious manner. That led to there being two cancel buttons in this instance. :( This change: 1) Adds first-class support to GlobalErrorWithStandardBubble for a "details" button slot, independent of the cancel & accept buttons 2) Migrates ExtensionErrorUIDefault to use that mechanism 3) Removes GlobalErrorWithStandardBubble::ShouldUseExtraView Bug: 1024995 Change-Id: I31fe6a7a1d64f0bca2d7abd524650954b4579286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933205Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#720611}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/27076e27131f..7724a9414f89 git log 27076e27131f..7724a9414f89 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 zakerinasab@google.com Merge "Add Vulkan memory tracker config to trace config" Created with: gclient setdep -r src/third_party/perfetto@7724a9414f89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: If02c245ccb8fa4132b651fc0a982f78dad061b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946446Reviewed-by:
-
Caleb Rouleau authored
We now only define shard_num and shard map location in bot_platforms.py. Bug: 902089 Change-Id: I101743f3a4aaa2291d2dba03d7338d9dbe03798c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941273 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#720609}
-
Mohamed Amir Yosef authored
Bug: 1012203 Change-Id: I5f10793d64cc6a5b64908387dab26e722abf275e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943236Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#720608}
-
Ayu Ishii authored
Bug: 1007749 Change-Id: Ifd172b7913f2f50c5513c446db7e14731f965039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941055Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#720607}
-
Daniele Castagna authored
After crrev.com/c/1915021 that connects the ambient light readings from powerd to the color transform matrix, we can enable ambient color light by default. This CL additionally removes the flag in about://flags since it does not have any effect on most of devices where ambient color is not supported. Bug: 1021193 Change-Id: I2f4b7c57b99e84cc2cf713bb92924b9d57d2d579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938627Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#720606}
-
Caleb Rouleau authored
After this change, all Telemetry perf testers will use shard maps, so it will be easier to do some cleanups. Bug: 902089 Change-Id: I141614659a3b46aa9b67932f28d4f2a817ae3110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941287 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
kylechar authored
If SkiaRenderer is missing a texture during draw it tries to allocate an equivalent fallback texture of the correct size and attributes. This doesn't work for externally allocated textures. Currently ImageContextImpl::CreateFallbackImage() creates a GrBackendTexture of type k2D instead of kExternal. This triggers a later SkASSERT in GrTextureProxy::onValidateSurface(). When SkAsSSERTs are disabled it still doesn't draw anything. Just skip drawing the fallback texture by proving a null SkPromiseImageTexture instead. Bug: 1029522 Change-Id: I6f370694116e8a47e8885492f1365783c046db65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946627Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#720604}
-
Victor Costan authored
Change-Id: Id118c5a81446635f02fc23ae25ffd007ec400c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945330 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#720603}
-
Alfonso Garza authored
I'm not entirely sure why this fixes the issue, but after a couple hours it was all I was able to come up with. Interestingly, if I move the line inside the picker's init, the issue remains. https://screenshot.googleplex.com/UzOWW6uOVRE.png https://screenshot.googleplex.com/XPG9EPkODoP.png Bug: 1028090 Change-Id: I8b6ce7135356c863aa396b238ce9a51b0dac26f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940955Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Auto-Submit: Alfonso Garza <alfonsogarza@google.com> Cr-Commit-Position: refs/heads/master@{#720602}
-
Doug Arnett authored
Bug: 1014148 Change-Id: Ib60bc2d53649ad869f5fd121687ba4931d15efa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940493Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#720601}
-
Etienne Bergeron authored
This CL is fixing the memory leak describe here: https://bugs.chromium.org/p/chromium/issues/detail?id=974239 Without this patch, tasks to check the file existence can be queued for the same download without being executed. This can lead to terrible scenario with billion of tasks queued. This CL is adding a set to keep track of the current pending download queries. This way, there can not be two pending tasks at the same time for each download item. Bug: 974239 Change-Id: I52fb23ce50ba8542ed262552dd7f9aaaa5589548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946783Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#720600}
-
Jarryd authored
Allow passing a URL parameter to specify the sort method to be used upon page load. This will be used by a storage pressure notification which optionally navigates the user to all sites. The all-sites page will be sorted by storage, when the user is forwarded here from a storage pressure notification. example usage: chrome://settings/content/all?sort=data-stored Bug: 997258 Change-Id: I4ccc547c2dc4aad974f06debd6e0d4e461e4a0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865259 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#720599}
-
Dominique Fauteux-Chapleau authored
Change-Id: I32fbf0e9e9b7cb1642b044ecc2a2dae1636c34d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944270Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#720598}
-
Demetrios Papadopoulos authored
The --chrome_pass Closure compiler flag is only needed for code that relies on cr.js (cr.define(), cr.exportPath() and friends). For JS code that has migrated to JS modules --chrome_pass is not necessary. Explicitly removing --chrome_pass not only makes type-checking faster, but also ensures that eventually we don't depend on this pass at all. Note that using |is_polymer3| also opts out a js_type_check() target from --chrome_pass, but without the new |uses_js_modules| there is no easy way for non-Polymer code to opt-out. Note: With this change any JS code that uses JS modules must specify either |uses_js_modules| or |is_polymer3| attributes. Bug: 1028829 Change-Id: I4e019770e36ac460402123c5413be6c95e32fef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938248Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#720597}
-
Dominic Mazzoni authored
Later when experimental tagging support has landed we'll be able to add an additional test asserting that PDFs are tagged when the right command-line flag is passed. Bug: 607777 Change-Id: I5030456efeb0b005d7153eb8c9e36050d6051c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927974Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#720596}
-
Jun Mukai authored
The window system can handle mouse events without them, but this causes a weird conditions like the ones reported in the bug. More specifically, - sending a new mouse event enables the mouse event automatically - on enabling mouse events, NativeCursorManagerAsh can set the last mouse location to an unexpected location https://cs.chromium.org/chromium/src/ash/wm/native_cursor_manager_ash.cc?sq=package:chromium&g=0&l=158 - further MouseMove / Press / Release / Click APIs can be affected by this. Bug: 1028413 Test: tast run ui.OverviewScrollPerf ui.WindowResizePerf Change-Id: I93628663444b405501129a96d32889478dba7a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940713Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#720595}
-
Tim van der Lippe authored
The flag usage has been removed from devtools-frontend [1]. [1]: https://crrev.com/c/devtools/devtools-frontend/+/1942288 Change-Id: I1436bc8be3258c84a86be9d86df9434647fca180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942336Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#720594}
-
Kevin McNee authored
Now that the flags for browser plugin have been removed, we remove the code to support browser plugin from the guest view JS implementation. Bug: 533069 Change-Id: Ida04f0ce856d0f318835d6369558a3e38cac47e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943579Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
-
Mark Brand authored
The calls to BelongsToCurrentThread appear to be no-ops at the moment, and assume that they were intended to be DCHECKS, so a quick CL to fix. Change-Id: I33a6c8e05312b528d5a4e89fd18a0cff6281cd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762238 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720592}
-
Elly Fong-Jones authored
This test doesn't work on Mac and probably won't ever be made to work. Issue 899286 obscured this test breakage from us, also. Bug: 1028239 Change-Id: I9f9865ba7ea4fd626fe50298e60c772876b0439b Tbr: raymes@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943473Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#720591}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=mfoltz@chromium.org Bug: 891670 Change-Id: I1678e50cd81155739b1493f68de637bc781abcb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943186 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#720590}
-
Brandon Wylie authored
Change-Id: I7b613853896b4090bf1cd00cdeb6d986c9add676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926807Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#720589}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6d4b96eb..be74b8b6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I87065f503e8e28af5a2d58a7938f8b5542bd70df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946626Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720588}
-
Sorin Jianu authored
These virtual functions were used by the ActionRunner, which has been refactored in CL 1929863. Bug: 1027395 Change-Id: I43091b984fc28555234fdbe11366ea91c225a7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931383 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#720587}
-
Evan Stade authored
This is a reland of e38327e1 FindIt automatically reverted this CL but it looks like a false positive Original change's description: > Spellcheck cleanups > > Introduce a build flag for the remote spelling service, and stop > compiling/instantiating SpellingServiceClient on platforms that > don't use it (Android). Also try to reduce the number of platform > ifdefs in spellcheck code, in favor of buildflag usage. Reduce > the amount of code that's compiled but never used by removing > several SpellCheckHostImpl methods on mac/win. > > Also remove a couple of obsolete includes. > > Change-Id: I5697a5d3f891f69159d5bba855ee72e11a3ca8be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927412 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Bo <boliu@chromium.org> > Auto-Submit: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718338} TBR=boliu@chromium.org,rouslan@chromium.org Change-Id: Iffed71cfbe5d512db1a054364598445b00672a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946825Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#720586}
-
Richard Knoll authored
All sharing features for selected text should be in the same group. They should also be below the entry for "Copy" as that is a more frequently used option. Screenshots of the effects: https://imgur.com/a/TInzym5 Bug: 1028981,1009998,1028995 Change-Id: I9f06a4e90c1d4bc18d8e3820ecf8e47dde40777e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940267Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#720585}
-
Lambros Lambrou authored
The native-messaging host does a permission-check by launching a child process. This CL ensures that the child is launched with stdin/stdout redirected to dev/null, since they are used by the native-messaging host to communicate with the website. The native-messaging host actually duplicates the file-descriptors for stdin/stdout, and uses these FDs instead of the original. It also unfortunately closes the original FDs. Whenever stdout is closed, LaunchProcess cannot launch any child process. This CL addresses this problem by manually redirecting stdout. A future CL will fix the native-messaging host so that it does not close FDs 0 and 1, which could potentially lead to unexpected behavior. Bug: 1029858 Change-Id: I7d626e9e4817159ec955b66d2338c07a73c9549a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946827 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#720584}
-
Daniel Murphy authored
This reverts commit 3b866120. Reason for revert: Causing failures with webrtc.RTCPeerConnectionAccelUsed.dec_vp8 Bug: 1029856 Original change's description: > media/gpu/v4l2: abstract request logic in V4L2 framework > > Currently, the request creation and submission logic are handled > inside the decoder's backend. > This patch moves the request handling inside the V4L2 framework and > provides new classes to abstract the request creation and submission. > > BUG=chromium:1009921 > TEST=tast video.DecodeAccelVD.h264* on veyron_minnie-kernelnext > TEST=tast video.DecodeAccelVD.vp8* on veyron_minnie-kernelnext > TEST=tast video.DecodeAccelPerf.vp8* on veyron_minnie-kernelnext > TEST=tast video.DecodeAccelPerf.h264* on veyron_minnie-kernelnext > > Signed-off-by: Francois Buergisser <fbuergisser@chromium.org> > Change-Id: Idacff87aa4324c26b287ce2617398c51dee2721a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918794 > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Commit-Queue: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720402} TBR=acourbot@chromium.org,fbuergisser@chromium.org Change-Id: I2b418ec4d718b81f7bc74f254c82e4772fc9f280 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1009921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946923Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#720583}
-
James Cook authored
The SplitSettingsSync feature makes it possible to independently sync Chrome apps (via browser sync) and ARC apps (via OS sync). The app list data model and UI code can handle references to missing apps (for example, on Chromebooks that don't support ARC++ the app list data model may have references to ARC++ apps from sync, but the UI gracefully hides them). I initially tied the APP_LIST data type to OS apps. However, the user can end up in an odd state if we sync Chrome apps without syncing the app list metadata. For example, a user could disable OS sync, enable browser sync, install some Chrome apps, move them around in the app list, set up a new Chromebook, then discover that the apps are in the wrong order or are not pinned to the shelf. Ensure we sync the metadata if either browser apps or OS apps are being synced. Bug: 1013466 Test: added to sync_integration_tests Change-Id: Iddc13a978bb84259fadf91fe5fd9454606ba650d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931098 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720582}
-
Kalvin Lee authored
This change modifies the PpdProvider class to follow the conventions required by the presubmit checks. The changes are trivial and will cause no behavioral changes. They pave the way to moving the implementation of this class into a "deprecated" source file. Bug: 1025995 Change-Id: I6bb71439e519a7a71c7e8f87639b6f4719b3be96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935046Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#720581}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/37c0baa6b7b4..33ae3e65534f Created with: gclient setdep -r src-internal@33ae3e65534f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1017165 Tbr: jbudorick@google.com Change-Id: I52f2c289b43652a825642252aa522357f82e4ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946441Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720580}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8adeb1cc5a26..ebec004c878f git log 8adeb1cc5a26..ebec004c878f --date=short --first-parent --format='%ad %ae %s' 2019-12-02 eseckler@chromium.org telemetry: Increase timeout for trace collection further. Created with: gclient setdep -r src/third_party/catapult@ebec004c878f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029465 Tbr: nuskos@google.com Change-Id: Id7f91a9834300166f598193b0209535f6b623e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946445Reviewed-by:
-
Kalvin Lee authored
This change modifies the CUPS IPP backend to suppress papers whose vendor IDs are not meant for users' eyes - i.e. the "custom_min" and "custom_max" sizes that CUPS incidentally exposes. Bug: 1026938 Change-Id: I047844030e7f7a161bda32755754494567e7734c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935173Reviewed-by:
-
