- 19 Nov, 2020 40 commits
-
-
Alex Turner authored
Currently, only typeface digests (i.e. the output) are included. We now include two likely lookup values: where the family name or the PostScript name were looked up with default FontSelectionRequests. While there will be many input digests that map to the same typeface, this should handle a good chunk. We also remove the duplicate signed integer copy of the typeface digest, leaving only the unsigned version. Bug: 1150480 Change-Id: I7f36061b5da4022984a908ba9988258094e9c5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548311Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829242}
-
Wolfgang Beyer authored
This is a reland of 2c942cf7 Revert is at https://crrev.com/c/2545724 Original change's description: > [DevTools] Introduce `Page.DocumentOpened` CDP event > > Send a `Page.DocumentOpened` event via CDP when an iframe's content is > edited via JS. Writing to an iframe's document via JS is not considered > a navigation, therefore no `Page.Navigated` CDP event is emitted. But > since writing to an iframe's document can change attributes which > DevTools needs to be informed about, the `Page.DocumentOpened` event is > emitted instead. Previously only a refresh of DevTools would let > DevTools know about changes to an iframe caused by JS manipulation of > said iframe. > > Example (see http://doc/1gczarAME7AATGHwqm_IDqcGFlOM6DLAoX9rqetv4Rx0): > There is a 'frameNavigated' event for the initial load of an iframe. > If there is a 'document.write' for this iframe right away, there is no > 'frameNavigated' event for this iframe at all. > > Frontend CL: https://crrev.com/c/2507793 > (needs to be merged first, this will fix the failing tests, which fail > because the frontend cannot handle unknown CDP events) > > Bug: chromium:1140540, chromium:1140481 > > > Change-Id: I92a659b7ab8b1cb7ae50e28df40b8ca9b0bf8c86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498482 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Wolfgang Beyer <wolfi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828122} Bug: chromium:1140540 Bug: chromium:1140481 Change-Id: I4fce7b9511e61e15a52c11971ea9be7560da2e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545011Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829241}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=romanarora@chromium.org Bug: 1145565 Change-Id: Ic27dc466d5f152cb73a2f767720032eb6bf02597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548021 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#829240}
-
Hwanseung Lee authored
Use enum class instead of enum for Widget::MoveLoopEscapeBehavior. enum class is more type safety. Bug: 940736 Change-Id: I93a798be271d83179a86cb778a772b2ed70a4872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547229 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#829239}
-
Abigail Klein authored
widgets. Bug: 1068752 AX-Relnotes: Expose posinset and setsize to VoiceOver for native Change-Id: Ic4d0d598a537eeb9a6917cc867986b0b27574e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544962 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#829238}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011190600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/diLwXTxdRV6cbd18SoCniJNniVTvHD4wv7-x_eVBHkkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/150642729,b/167996979,b/171674574 Tbr: media-app@grotations.appspotmail.com Change-Id: Id2500f8da17055220fa4f0df4b4d144c27cfcb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549155Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829237}
-
Sorin Jianu authored
This is a follow up for https://chromium-review.googlesource.com/c/chromium/src/+/2495332 The idea is that passing input parameters by const references, when possible is still the C++ style. I don't recall what the specific issue was when the code did not build in the original CL. At any rate, this change does not affect the lifetime of any of the parameters, since the binding of the references in callbacks is always by value, unless the caller specifies std::ref of std::cref. Bug: 1147094 Change-Id: I47c9aef89ddbeea386e6efb9f8ae42d3385c3601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547430Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829236}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605765502-afac6c1491dbda42eb7f9fa994b3ce280c680afd.profdata to chrome-linux-master-1605786790-1f9152a71727d792e23874dce2b7f267f3ebd366.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I41055d04ab92d30f2dd7e6f9a02853a42f69ebe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549152 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829235}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c151f873e4ab..6abd28db911a 2020-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 169d0c7f8a7b to ec5cd38a0ca6 (2 revisions) 2020-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bb96f79d0e15 to 282aa417236a (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I16dc9b9cb05809c7739310ddb1a245caf858d088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549149Reviewed-by:
-
Chris Sharp authored
value of * The default policies for ContentSettings are implemented with the * wildcard, so if the allow or block list also defines *, the behavior becomes undefined as there are two rules with the same value. Change-Id: If279c8a4ad74c36d63cd2860be2949dfe6fedd03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547309 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#829233}
-
Harry Cutts authored
As requested on https://crrev.com/c/2487253, this CL adds a note to summaries of the input-related Chrome OS-only histograms. This isn't necessarily an exhaustive set. Bug: none Change-Id: Ie73176bd2eecb669ca6eeb0c2eb6e6e7140668ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548389 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#829232}
-
Olga Sharonova authored
There are some concerns about increased audio rendering glitches in Beta finch experiment (go/mac-rt-thread-finch). They may be caused either by the renderer side RT audio thread being descheduled since it's made "preemptible", or by multiple RT audio threads competing for CPU since we relaxed their deadlines. This CL is exposing the controls to allow for further experimentation around that as needed. The plan is to backmerge this to M88 and to run an 3-leg M88 experiment with "preemptible" set to false and true in experiment groups.. Meanwhile, there is 1% M87 stable experiment to confirm positive effects on Meet we've observed in M87 Beta. Bug: 1132225 Change-Id: I7a79f5a0317814ff16252e0d88db8d61d5af599c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546712 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#829231}
-
Mingjing Zhang authored
Revert "Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`."" This reverts commit b8a64dcd. Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_OutOfView is failing consistently on "Android FYI SkiaRenderer Vulkan (Pixel 2)" https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20SkiaRenderer%20Vulkan%20%28Pixel%202%29/b8863213321775995088 Original change's description: > Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." > > This reverts commit 85d844e3. > > Reason for revert: reland initial commit with disabled flaky test. > > Original change's description: > > Revert "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`." > > > > This reverts commit 114bc6ab. > > > > Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown is failing consistently on linux-chromeos-rel: > > > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42849 > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42850 > > > > Original change's description: > > > Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > > > > > 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`. > > > 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered. > > > 3. Set `hide_scrollbars` to avoid artificial scrollbars. > > > 4. Set `record_whole_document` to force the whole page to be rendered. > > > 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight". > > > > > > Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37 > > > > > > Screenshots: > > > > > > - Before: https://i.imgur.com/yt6WZRx.png > > > - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars. > > > - Patchset #3: > > > * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view. > > > * https://imgur.com/MXpgHOl > > > * https://imgur.com/haxemcr - not aligned with the node. > > > * https://imgur.com/RbdlYVT > > > - Patchset #18: > > > * https://imgur.com/EWUmn0O > > > * https://imgur.com/DUrQ1yF > > > * https://imgur.com/cT5oBSi - perfectly aligned. > > > * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended). > > > > > > Bug: 1003629 > > > Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876 > > > Commit-Queue: Maksim Sadym <sadym@chromium.org> > > > Auto-Submit: Maksim Sadym <sadym@chromium.org> > > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#827440} > > > > TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sigurds@chromium.org,sadym@chromium.org > > > > Change-Id: Iaa9b6ee9f5584adbb4a521808e2d201834a6a6dc > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1003629 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538543 > > Reviewed-by: Scott Little <sclittle@chromium.org> > > Commit-Queue: Scott Little <sclittle@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827505} > > TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sclittle@chromium.org,sigurds@chromium.org,sadym@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1003629 > Change-Id: I2d394d77d0235762c61449ff8e90573de4c0c5d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545524 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Maksim Sadym <sadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829147} TBR=wangxianzhu@chromium.org,caseq@chromium.org,sadym@chromium.org Change-Id: I2422b2560d10910cd90290c5647eb068743ac682 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550242Reviewed-by:
Mingjing Zhang <mjzhang@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829230}
-
Mike West authored
This reverts commit 39053ccc. Reason for revert: `PermissionBubbleBrowserTest.HasLocationBarByDefault` started failing in https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/57303 (and other Mac bots at the same time). Failures look like https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863201444294046496/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/Deterministic_failure:_PermissionBubbleBrowserTest.HasLocationBarByDefault__status_CRASH_/0. Original change's description: > Add PermissionChip feature to fieldtrial_testing_config.json. > > As a prerequisite to landing cr/339683181. > > Bug: 1134294 > Change-Id: I95a0774957c5ba1cae28faad5916865f50e5a8d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510054 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829185} TBR=bcwhite@chromium.org,bsep@chromium.org,olesiamarukhno@google.com Change-Id: I6e8f9f26c972e5681e69a909653d2d88a6184a40 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550184Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#829229}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/745ab6e3c09a..a3db6c585a2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mkwst@google.com Change-Id: Iad1527932ff1f1cf7a0650bd7f7d41bdfcc60432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549148Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1a5d5109644a..4d79f96b5ec9 2020-11-19 yangguo@chromium.org [ts] Typecheck ProfileLauncherView.js 2020-11-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-19 jacktfranklin@chromium.org TypeScriptify ui/ContextMenu.js 2020-11-19 wolfi@chromium.org Update DevTools protocol 2020-11-19 aerotwist@chromium.org TypeScriptify LiveHeapProfileView.js 2020-11-19 alcastano@google.com Breakpoint on Trusted Type violation (Devtools) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1139949,chromium:1142804 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic9165e61488df5403e8681ba4fa95f2e74f1ffdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549147Reviewed-by:
-
Clemens Arbesser authored
Currently, trigger scripts can't support going from CCT to regular tab. This CL introduces a way to gracefully fail instead of crash when this happens after a trigger script was started. This CL also adds missing handling for the cancel-forever use case. Bug: b/171776026 Change-Id: I7a7e13b99f09cb48bd19b391acea462d84b0e3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549961 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829226}
-
Gabriel Charette authored
As discussed @ https://chromium-review.googlesource.com/c/chromium/src/+/2537140/2#message-db3a48fe7ae821111e603331a10c74c7701a4d5e Useful to see the flow of Quit's in browser tests (with --enable-tracing="*") Example trace: https://snipboard.io/7R8aXC.jpg R=altimin@chromium.org Change-Id: I74369e939f566da35fb50c714445cd7ef7ef6431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538176 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829225}
-
Takashi Toyoshima authored
As some of methods in blink::cors:: are not used any more, this patch removes them from the Blink. Bug: 1053866 Change-Id: If3565084c20ba805d8b7d6a253366d67599c121f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550141 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#829224}
-
Wez authored
Allow config-data to specify soft quotas for the CDM and browsing data directories used by the main web.Context used to host Cast applications. Both CDM and browsing data will be persisted to cache storage, since applications must generally tolerate their being erased. To avoid causing the cache to be purged by writing too much data to it, browsing data is persisted only if a quota is supplied, for the Context to try to adhere to. Bug: 1071393, 1148334 Bug: b/154204041 Change-Id: I194c6509318ad162aaae2bc88862c87c7235dd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536879 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#829223}
-
shivanigithub authored
This CL adds metrics to see the number of cache hits if the blink memory cache was per-document. Bug: 1129860 Change-Id: I8d9b969c0540b5e72b7b3343cbbfb5daeefe88b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543684Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#829222}
-
Wei Lee authored
This reverts commit c946338b. Reason for revert: Reland after fixing browser tests Original change's description: > Revert "Reland "[CCA] Run CCA as SWA by default"" > > This reverts commit 074c395f. > > Reason for revert: > > This patch landed in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21376, where three ~related `browser_test` items began failing consistently: > > * SystemFeaturesPolicyTest.DisableCameraAfterInstall > * SystemFeaturesPolicyTest.DisableCameraBeforeInstall > * ExtensionPolicyTest.ExtensionInstallBlocklistComponentApps > > These failures are really verbose, but it looks like the core is: > > ``` > ../../chrome/browser/policy/extension_policy_browsertest.cc:401: Failure > Value of: registry->enabled_extensions().GetByID(extension_misc::kCameraAppId) > Actual: false > Expected: true > ``` > > > > Original change's description: > > Reland "[CCA] Run CCA as SWA by default" > > > > This reverts commit 5dec0310. > > > > Reason for revert: LKGM update: crbug.com/1148527 > > > > Original change's description: > > > Revert "[CCA] Run CCA as SWA by default" > > > > > > This reverts commit 46b6fd15. > > > > > > Reason for revert: > > > > > > camera.CCAUISmoke.fake is failing on chromeos-eve-chrome and camera.CCAUI* is listed as test coverage for this CL, so I am speculating that it is the cause. See: > > > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11136 > > > > > > Original change's description: > > > > [CCA] Run CCA as SWA by default > > > > > > > > Bug: b/172345161 > > > > Test: tast run [DUT] camera.CCAUI* > > > > Change-Id: I10484c9263f3e4c560028aef272cd3db88c47b31 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509834 > > > > Commit-Queue: Wei Lee <wtlee@chromium.org> > > > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > > Auto-Submit: Wei Lee <wtlee@chromium.org> > > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#825657} > > > > > > TBR=ortuno@chromium.org,wtlee@chromium.org > > > > > > Change-Id: I5464fbcd7f1a03cd157122ad66c6ee13ad111630 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: b/172345161 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529360 > > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > > Commit-Queue: Henrik Boström <hbos@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#825818} > > > > TBR=hbos@chromium.org,ortuno@chromium.org,wtlee@chromium.org > > > > Bug: b/172345161 > > Change-Id: Ie6d18656a2b247d8eec260319594e7355337c5af > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547645 > > Reviewed-by: Wei Lee <wtlee@chromium.org> > > Reviewed-by: Shik Chen <shik@chromium.org> > > Commit-Queue: Wei Lee <wtlee@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#829079} > > TBR=shik@chromium.org,hbos@chromium.org,ortuno@chromium.org,wtlee@chromium.org > > Change-Id: I31ad4e34332a5c54a0a4bd2c2f98dfe7e6544016 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b/172345161 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549842 > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829154} TBR=shik@chromium.org,hbos@chromium.org,ortuno@chromium.org,mkwst@chromium.org,wtlee@chromium.org # Not skipping CQ checks because this is a reland. Bug: b/172345161 Change-Id: I752d3919a2e7de9a43c2e8271b7f8e83509db84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549203Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
-
Vasiliy Telezhnikov authored
The histagram is expiring and we didn't use it as UMA for quite a while. This CL makes it LOCAL_HISTOGRAM instead of UMA_HISTOGRAM to be able to use in telemetry runs. Bug: 1140046f Change-Id: Ic15517035ca11fd6626632d38cf202b5e0600d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486115Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829220}
-
Morten Stenshorne authored
Missing part of https://chromium-review.googlesource.com/c/chromium/src/+/2538266 I wish that linux_layout_tests_layout_ng_disabled were triggered a bit more often, but since it isn't, things like this are bound to happen. TBR=atotic@chromium.org Bug: 958381 Change-Id: I0570151bf2081d4b0e14d42036e340f3ab2e5af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549945Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#829219}
-
Michael Lippautz authored
Instead of relying on a non-GCed type for Oilpan, use a different type in the garabge-collected world and split the traits based on the allocator. All PA relevant types are provided in list_hash_set.h, whereas the garbage collected specializations are provided by heap_allocator.h. Switching to a regular GCed type for Oilpan allows for removing special handling in various traits. The following are removed: - HeapAllocator::Malloc; - Custom support for TraceListHashSetValue; - Custom support for trace traits; Bug: 1056170 Change-Id: I74e913a2b63e60e62018bb1303dd3345058b1ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547240 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#829218}
-
Morten Stenshorne authored
TBR=ikilpatrick@chromium.org Change-Id: I52af661d52fbdb2a02a6dbc289c107a4a8619258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550201Reviewed-by:
-
Nick Diego Yamane authored
BUG=1148021 R=msisov@igalia.com Change-Id: Id3d0a8c9ea41c421cd4ae633709372e12a77c2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546980 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#829216}
-
Alice Wang authored
This CL breaks the dependency link between the signin package and incognito_interstitial package so that signin package will only depend on account_picker package and account_picker handles everything with incognito_interstitial for the web sign-in flow. Bug: 1149852 Change-Id: Ia4633989d9f66f35770249ddc96bd22183043f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544886Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829215}
-
Tanmoy Mollik authored
Use AccountManagerTestRule to add accounts on the device to check that Signin Promos for that account is shown. Currently the tests just check generic promo. Bug: 1100895 Change-Id: Iea2f61943ca0c3545a02d95b812cac1a28ecbca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519456 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#829214}
-
Viktor Semeniuk authored
This change adds Password Edit feature for iOS to testing config. Bug: 1137475 Change-Id: I73e8f5daa44cdda5fc4c24bc37b57767f698e9e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545927Reviewed-by:
-
Fredrik Söderqvist authored
The RespectImageOrientationEnum and ImageClampingMode arguments are not used, so there's no need to pass them to this function. Drop them at the callsites and simplify. Also fix the Draw() declaration to mirror the definition for the names of some arguments. Ditto for DrawInternal(). Change-Id: Ie705162d9b984e2a9cc32628a109a7e1dc091bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549922 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#829212}
-
Saurabh Nijhara authored
The browser tests related to download directory policy are moved to a separated file. Bug: 1002483 Change-Id: I52ecbbc65bdc43b62c1ad4d13149084f0382bed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547443 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829211}
-
Hiroki Nakagawa authored
Bug: 1149226 Change-Id: I48391f13e88a5cd772cb2bb79db01dcd54ea6285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549021Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#829210}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605743960-03e8e3c00d664b0272fc9bec8fbd6eb12ca9ed48.profdata to chrome-win64-master-1605765502-3ccba7e07e5cf94b5756f4641a727d60a578a62b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I87eccf43297863457c8e96790f5bdd6111985291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549281Reviewed-by:
-
Benoit Lize authored
The thread cache has a hard limit on how many objects are cached per bucket. Previously, every cache fill above the limit would go back to the central allocator, so the following scenario: 1. 1000 malloc(10) calls 2. 1000 free(ptr) calls (of the previously allocated memory) Woould acquire the lock 1000 - kMaxCountPerBucket times on the deallocation path. By batching deallocations, the lock is only acquired (1000 - kMaxCountPerBucket) / (kMaxCountPerBucket / 2) = 2000 / kMaxCountPerBucket - 2 times. It may also reduce cache footprint for these scenarios, since the bucket is rarely full. Note that the allocation patth is not affected, batching on this side may be investigated as well, but not without data showing that empty buckets are frequent. Bug: 998048 Change-Id: I626205e28d7a082a12303a493ca504e9581fc43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546599 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#829208}
-
Denis Kuznetsov authored
Bug: None Change-Id: Ie4329a1a00ad35316f22340a2ce42832427243c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549962 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ieda249b47c753697db3de49d482af1f8ec1d1591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549145Reviewed-by:
-
Maksim Sisov authored
In the first take, I thought buffer formats could be determined from the browser process side as early as possible, but several problems were identified in the end - 1) glx's bindings' initialization is required. And it's done on the gpu process side 2) gl implementation can be determined after gl is set (it's temporarily required before angle + gmb support is added, though). I also thought to make fetching gmb formats asynchronous, but it would require rewriting some important clients, which is non-trivial, unfortunately. Thus, that approach didn't work well and I had to reuse the existing approach to pass support buffer formats for gmb via gpu extra info. Now, OzonePlatform has fetch_buffer_formats_for_gmb_on_gpu variable that clients can use to determine the way that they are able to fetch supported buffer formats. All the previous logic that non-Ozone/X11 had stayed the same except that it's also used by OzonePlatform that has fetch_buffer_formats_for_gmb_on_gpu set to true. In this case, CollectGpuExtraInfo collects supported buffer formats. Bug: 1099183 Change-Id: I56c1323af54ae5bec4a5f9152aca47a21035d6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540286Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#829205}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d40c6d7f3bef..745ab6e3c09a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mkwst@google.com Change-Id: If781c93efa24c71f3be9c1d61845e74e46dc80e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549162Reviewed-by:
-
Viktor Semeniuk authored
Bug: 1096986 Change-Id: Ic3f4b69c0762afd09386d42a3639a207da24aa9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546007Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#829203}
-
