- 23 Jul, 2018 40 commits
-
-
Manu Cornet authored
Bug: 805612 Change-Id: I1ec642dd31a69a00b3c3bc56a5a43ea5f85e2985 Reviewed-on: https://chromium-review.googlesource.com/1144646 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#577176}
-
Nicolas Ouellet-payeur authored
The test was missing EXPECT_*() statements on other platforms than Mac/Windows. Bug: 816389 Change-Id: Ib50b315445e810025f403faaad7bd1f288369b7f Reviewed-on: https://chromium-review.googlesource.com/1145623Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#577175}
-
Danyao Wang authored
The SlimNav experiment is hitting the CHECK(_webUsageEnabled) in -ensureWebViewCreatedWithConfiguration when loading placeholder URL while web usage is disabled. One cause for this situation is when clearing website data while an interstitial is presented over a native view. WebInterstitialImpl::DontProceed() is called after web usage is disabled and it triggers the reload of the native view, which in turn triggers the placeholder load. Deferring the load fixes the problem, because the web view is recreated immediately after. Other causes for placeholder load when web usage is disabled exist, but the causes are not fully understood. This CL fixes the crashes in these cases as well. This should uncover behavior changes, that hopefully give us more details to fix the root cause later. A downstream egtest for the interstitial case is added in http://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/654301 Bug: 865985 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I03d928ce82d128c2f67f36e204731576e479d497 Reviewed-on: https://chromium-review.googlesource.com/1145725Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577174}
-
Charlie Andrews authored
A recent bisect in the linked bug shows that it's passing again. NOTRY=true TBR=nednguyen@chromium.org Bug: 803461 Change-Id: If9e240bbb03a7941ae3fe4ea48149bfe606d9ec4 Reviewed-on: https://chromium-review.googlesource.com/1146772Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#577173}
-
Jennifer Apacible authored
This change adds in KeyEvent handling to support keyboard usage with the controls buttons. They should be activated when the 'enter' or 'space' keys are used. The previous implementation of OnKeyEvent used an OverlayWindowViews tracking of which control is being focused, which is now obsolete. Bug: 866291 Change-Id: I8a59337aa7aef5c95da081a9b5f33762462eeaef Reviewed-on: https://chromium-review.googlesource.com/1146283Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#577172}
-
sebsg authored
Change-Id: Ie5ed5f28bfdc5a7914dac544db17deac45e1f3b0 Reviewed-on: https://chromium-review.googlesource.com/1129044Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#577171}
-
Charlie Andrews authored
A recent bisect in the linked bug suggests that they aren't flaky anymore. NOTRY=true TBR=nednguyen@chromium.org Bug: 842163 Change-Id: I79442bf895ff3596f1b1c8ae3db8ccb596041e78 Reviewed-on: https://chromium-review.googlesource.com/1146765Reviewed-by:
-
Ryan Harrison authored
Change-Id: If254e5468f7adbf42d08ce292b0d63a7ebc152c4 Reviewed-on: https://chromium-review.googlesource.com/1145128Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#577169}
-
Chris Mumford authored
This change introduces the ExtensionURLLoaderThrottle which exists in the renderer and replaces ExtensionRequestLimitingThrottle when the network service is both enabled and disabled. Also re-enabled two extension throttle tests to speculatively fix issue 836188. Hopefully now that the throttling is done in the renderer they will no longer be flaky. Bug: 784576,836188 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo Change-Id: Ib0c18f7b3fb17f4fbe47d79bf2f5bd7f1ebd6e06 Reviewed-on: https://chromium-review.googlesource.com/914589Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#577168}
-
stkhapugin@chromium.org authored
Adds a histogram action recording on location bar share button tap. It is the same histogram as for the share button in the toolbar. Bug: 866449 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I89cef712fe6488619c88a35b5528924961d4835a Reviewed-on: https://chromium-review.googlesource.com/1146727 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#577167}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kSeparatorWidth in: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc This commit solves the issue by renaming the constants to something more file specific. It also renames other variables in the same namespace, so the naming is locally consistent. Change-Id: I2ae24ce5b67372286a5aa4e48a0bc125606ff778 Reviewed-on: https://chromium-review.googlesource.com/1146641 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577166}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: If70c9ef565f4526366e5fc2235534adff2d0ed8a Reviewed-on: https://chromium-review.googlesource.com/1146497 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577165}
-
Jonathan Ross authored
The test WebContentsImplBrowserTest NotifyFullscreenAcquired_Navigate Flakes has been flaking on Android for some time. The owner of the test is currently OOO. So I'm disabling it on Android. TBR=boliu@chromium.org TEST=WebContentsImplBrowserTest NotifyFullscreenAcquired_Navigate Bug: 855018 Change-Id: I1e3f71e696e6186663ee162a81a1f3bed5ad80c5 Reviewed-on: https://chromium-review.googlesource.com/1146261 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#577164}
-
Greg Thompson authored
The test was timing out as a result of the first-run dialog appearing. Now, this dialog is suppressed by setting the MetricsReportingEnabled policy to false. BUG=856995 R=pastarmovj@chromium.org Change-Id: Id5ccd5fbda849c586607b3b81d8fc8bef1cadb09 Reviewed-on: https://chromium-review.googlesource.com/1146731Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#577163}
-
Noel Gordon authored
Rename the FileManager part of the test fixture to FilesApp since it's all FilesApp these days, and it simplifies --gtest-filter. Bug: 836254 Change-Id: Ibfd29300ced82fec3029864230c4db8f1e3accee Reviewed-on: https://chromium-review.googlesource.com/1146416Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577162}
-
stkhapugin@chromium.org authored
Monitor omnibox focus notification to update the clear button visibility on focus. Bug: 866446, 865019, 865013, 864511 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iecf54d4550e4c6fe3f3988a54602c4d32d417f89 Reviewed-on: https://chromium-review.googlesource.com/1143860 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577161}
-
Farah Charab authored
Refactor code to support using resource fetch priorities (https://chromium-review.googlesource.com/c/chromium/src/+/1127364) in blink scheduler. Change-Id: I0b6eef1ae1d4b3d5f480437a1eac190c17b2fa7c Reviewed-on: https://chromium-review.googlesource.com/1138079 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577160}
-
Alexander Timin authored
This is a reland of 775612b8 Original change's description: > [scheduler] Add task type and queue type to tracing. > > R=skyostil@chromium.org > > Change-Id: Id0aea377558e876c8178e82eb3a170f678c415cc > Reviewed-on: https://chromium-review.googlesource.com/1140717 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576201} Change-Id: I8289cc417637e7e605dbb5f9df8cc6ea68fa457f Reviewed-on: https://chromium-review.googlesource.com/1143224Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577159}
-
Jérôme Lebel authored
+ Earlgrey cannot scroll down a scroll view that doesn't bounce. To work around the issue, the unified consent is now always bouncing, even when the content is smaller than the screen. + Whlie selecting an identity to sign-in, EarlGrey finds the right label to find with the right email address, but it also finds the button in the view behind the modal dialog box, with the right email address. To fix that, the matcher is now on the cell using the accessibility identifier. https://screenshot.googleplex.com/bd7p1JtcE0n Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I03d77e0e53bf29dec19d13a535cd08ebe46857c5 Reviewed-on: https://chromium-review.googlesource.com/1145279Reviewed-by:
-
Colin Blundell authored
While preparing a refactoring of AccountTracker, I noticed that this unittest is not doing what its name says it's doing; rather, it's just a copy of the unittest above it. This CL changes the test to match the name (as best as I could infer the intent of the test from the name). Change-Id: I46d809c1fa9d786688ddca82641f3df4d96c5821 Reviewed-on: https://chromium-review.googlesource.com/1142776 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#577157}
-
Mark Cogan authored
A small tweak to the spring damping ratio for the new tab animation, which ensures that the spring effect doesn't show a black hairline on an iPhone X. Bug: 851872 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1b6769f9d4b124e332efddf2f9602b4665d7aca8 Reviewed-on: https://chromium-review.googlesource.com/1146640Reviewed-by:
-
Alexander Timin authored
Replace an error with a prompt warning to gracefully handle false positives when the patch touches existing code. R=haraken@chromium.org CC=hajimehoshi@chromium.org,farahcharab@chromium.org Change-Id: I979f1b72dd515b30df5aac97e47e6cad8b3400f6 Reviewed-on: https://chromium-review.googlesource.com/1146720Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577155}
-
Tiger Oakes authored
The overall goal is to prevent storing the result of calls to context#getApplicationContext. We previously removed them all, but more have snuck in since. Bug: 846456 Change-Id: I6ff008b75a3980cc2db770ea42a18b9ee3669cae Reviewed-on: https://chromium-review.googlesource.com/1082666Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577154}
-
Timothy Loh authored
This reverts commit 574add02. Reason for revert: network_service_browser_tests / DevToolsFrontendInWebRequestApiTest.HiddenRequests times out most of the time https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_browser_tests&tests=DevToolsFrontendInWebRequestApiTest.HiddenRequests Original change's description: > Reset URLLoaderFactory bindings for web request proxy > > Previously, if a request was made before any web request listeners or > rules were added, the URLLoaderFactory would not be proxied through the > browser process to run the WebRequest code. Now, if it is detected that > WebRequest listeners/rules are added, we reset the bindings so they will > be recreated and proxied through the browser process. > > Observers were added for a few classes so WebRequestAPI can listen to > rule changes. > > Changes in URLLoaderFactoryGetter were needed due to crbug.com/613371. > > Bug: 857577 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I7805be86512545b496e30b9693374981fdc2633e > Reviewed-on: https://chromium-review.googlesource.com/1139048 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577036} TBR=kinuko@chromium.org,rockot@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 857577 Change-Id: I1c70daaa63107ac1527755b3d94e0fe61cb49ae8 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1146541Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#577153}
-
Yi Gu authored
Change-Id: Ide25550f5db4b0d64edd767059cfd89fb2833d85 Reviewed-on: https://chromium-review.googlesource.com/1145233Reviewed-by:
-
Hiroki Nakagawa authored
Thanks to recent works that make network APIs (fetch, importScripts, WebSocket, etc) off-the-main-thread, the shadow page is now used only for fetching the top-level classic script. Therefore the shadow page no longer needs CSP and referrer policy for subresource fetch. This change is useful for deprecating the shadow page. Bug: 538751 Change-Id: Id192a17068de0e3a20f08cbe9ba2463bc56ffb1f Reviewed-on: https://chromium-review.googlesource.com/1098427 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577151}
-
Mythri Alle authored
Add an api for clearing the GeneratedCodeCache. Bug: chromium:812168 Change-Id: Iba8fb3c81e8bed04573ed0cd4dabf4af31ea0c21 Reviewed-on: https://chromium-review.googlesource.com/1114974 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#577150}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0c3ad73948e4..94ef424b3160 git log 0c3ad73948e4..94ef424b3160 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 mbonadei@webrtc.org Enable clang::find_bad_constructs for examples/androidnativeapi. Created with: gclient setdep -r src/third_party/webrtc@94ef424b3160 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I813a82c05560d3fcc05bf9d0b5c989573f3faf84 Reviewed-on: https://chromium-review.googlesource.com/1146600Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577149}
-
Mugdha Lakhani authored
Background Fetch introduced a new way to select icons (Bug: 813564) However, now that we have udpated our spec and code to use ImageResource instead of IconDefinition to represent icons, we should reuse the Web Manifest's icon selection code here. This is the second step towards that. Bug: 860507 Change-Id: I1e8795f8768610e22002a9a87b0c7bf8c33f9d0b Reviewed-on: https://chromium-review.googlesource.com/1128086 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577148}
-
Alexander Timin authored
This change was dropped from https://chromium-review.googlesource.com/c/chromium/src/+/1102505 due to a bad merge. Add it back. R=eseckler@chromium.org BUG=806271 Change-Id: I6dc5f83cfe61ccbad3069e7d194c1dc494909ff9 Reviewed-on: https://chromium-review.googlesource.com/1145437Reviewed-by:
-
Hiroki Nakagawa authored
WebSockets on workers now run off the main thread. This CL removes unused on-the-main-thread code for cleanup. Bug: 825740 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5cf5b846e6099067d2da9b8b90de157e09020d7c Reviewed-on: https://chromium-review.googlesource.com/1146134Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#577146}
-
jdoerrie authored
This change cleans up the password list sorting logic by removing the PasswordEntryType enum. This two state enum added no value, as the same information was already stored on the PasswordForm itself in the form of `blacklisted_by_user`. This change cleans up the interface of CreateSortKey() and SortEntriesAndHideDuplicates(). Bug: 778146 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I883a5945168b569cdf1d6312f5e5d2eab4fb2ba5 Reviewed-on: https://chromium-review.googlesource.com/1143384Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#577145}
-
Thomas Tangl authored
When sync is paused, i.e. the user is in an auth error, the syncSetup page now has a button to sign in again to resolve the error. Mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr664Bt8FBOxWEyjSSOyFCbW0 Bug: 856210 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iab413fb69fcabff076f3c48d3b828dea05df6229 Reviewed-on: https://chromium-review.googlesource.com/1138619 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577144}
-
Mihai Sardarescu authored
This CL does not solve the bug, but it adds instrumentation that could help us understand if Chromium sends the Desktop Identity Consistency headers for requests that are sent to Gaia. Bug: 865941 Change-Id: I868394f7b23390b87494b26c49e2f8ac13a21795 Reviewed-on: https://chromium-review.googlesource.com/1145263 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577143}
-
Marc Treib authored
CLEAR_DATA is what's typically used in practice, and KEEP_DATA is a weird concept anyway. Bug: 860482 Change-Id: Ia3d15463a03f947db19d08ebfd035299ee566eaf Reviewed-on: https://chromium-review.googlesource.com/1146572Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#577142}
-
Mihai Sardarescu authored
This CL turns off Safe Browsing Extended Reporting when the user clears the primary account. Bug: 865526 Change-Id: I92f42f1ae1e24e0948db00848e17cd6b61c2c4e3 Reviewed-on: https://chromium-review.googlesource.com/1146573Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#577141}
-
Tanja Gornak authored
Bug: 812553 NOPRESUBMIT=true Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8522ebbc147afd0d39b85cda1545ef526d037e44 Reviewed-on: https://chromium-review.googlesource.com/1128890 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577140}
-
Justin Cohen authored
Bug: 865408 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I43ace7047750f8754cf6882d35fd598c3fffda3a Reviewed-on: https://chromium-review.googlesource.com/1146209Reviewed-by:
-
Laís Minchillo authored
Originally the webview content was always set to clickable but after http://crrev.com/551479 it wasn't. This CL restores original behaviour. Also adds a test to ensure this remains true in the future. Bug: 857427 Change-Id: If7a765f146290b933f57e514f26ad8a672f7695e Reviewed-on: https://chromium-review.googlesource.com/1127951Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#577138}
-
Marek Haranczyk authored
Random failures encountered so far can be reproduced by compiling third_party/blink/renderer/bindings/core/v8:testing target on clean repo. Change-Id: If92737cdfdc6f12533776b6ded935ac1a2689137 Reviewed-on: https://chromium-review.googlesource.com/1127040 Commit-Queue: Marek Haranczyk <mharanczyk@opera.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
