- 24 Sep, 2018 40 commits
-
-
Yi Su authored
Flag for the new feature that allows user to add custom search engines in settings. Bug: 433824 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If3b91e276b752b546013644119a5560f0a486314 Reviewed-on: https://chromium-review.googlesource.com/1236314 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#593591}
-
Sammie Quon authored
The minimized windows are now stacked underneath non-minimized windows. Minimized windows now animate back when uncessfully swipe to close. Test: manual Bug: 886392, 886390 Change-Id: I520a9cfc642e5f417af6755b783b831098430ce8 Reviewed-on: https://chromium-review.googlesource.com/1238782 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#593590}
-
Parastoo Geranmayeh authored
There are some cases that though the validity map on the server side has not changed, we need to update the validity states of the profiles. This is when the profiles are updated. Thus, we need to turn on the flag for profile_validities_need_update in case they have changed. Change-Id: I87f7d6f6df914b98ffb9ef744ff055c0b4c92f3c Reviewed-on: https://chromium-review.googlesource.com/1239436Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593589}
-
Xiaohan Wang authored
Currently this is only allowed for renderer and gpu process. This CL also allows it for utility process. Also pass logging switches to the UtilityProcessHost. These switches are already passed in ServiceUtilityProcessHost. Both are using kUtilityProcess process type. Bug: 888088 Change-Id: Ic26b9c9e6ce0c9024fb3ca4c8d352c5a283bef81 Reviewed-on: https://chromium-review.googlesource.com/1239172Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#593588}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a9adb6f03525..4fb073ac7328 git log a9adb6f03525..4fb073ac7328 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 mtklein@google.com use __builtin_debugtrap() in sk_abort_no_print() where possible 2018-09-24 mtklein@google.com make only valid SkRRects in FuzzPath 2018-09-24 kjlubick@google.com Remove coverage bots 2018-09-24 mtklein@google.com Reland "focus exported color apis" Created with: gclient setdep -r src/third_party/skia@4fb073ac7328 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:888381 TBR=bsalomon@chromium.org Change-Id: I9f3de224dfaf69b7693e936acd43d9f192a44ff3 Reviewed-on: https://chromium-review.googlesource.com/1240476Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593587}
-
Robert Sesek authored
Bug: 832676 Change-Id: I25fa2e314592f392a716bcb3b5dd3836bfb878cc Reviewed-on: https://chromium-review.googlesource.com/1239636 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593586}
-
Thomas Tangl authored
When the user disables the unified consent toggle in settings, a metric is recorded. This metric is added to UnifiedConsent.RevokeReason. Bug: 868892 Change-Id: Iff196b3428b130ea4b3d71a50c2b861f5da48966 Reviewed-on: https://chromium-review.googlesource.com/1240278Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#593585}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2c8e12da..d786acd3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If21a1481d1c94548968e357b1c8294f5acc96212 Reviewed-on: https://chromium-review.googlesource.com/1240493Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593584}
-
Pete Williamson authored
Change-Id: I69b90b0ff716c3b506f699fcec6fed9ab32f351c Reviewed-on: https://chromium-review.googlesource.com/1239994Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#593583}
-
Wei Li authored
These two tests were disabled due to assertion failures on Cocoa call stack. By porting fullscreen code to Views, we no longer call into such functions. With some minor improvement -- adding initial preference setup, the tests should pass. BUG=823490 Change-Id: I9b3c7838d1502c52a2da8cbc4a954ae9f8e71da7 Reviewed-on: https://chromium-review.googlesource.com/1239356Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#593582}
-
Dominic Battre authored
This CL changes the default parameters for password generation so that we don't need a configuration on the server unless anything changes. It also removes the PasswordGenerationRequirements feature which was only implemented as an early kill switch in case of crashes and is not necessary anymore. PasswordGenerationRequirementsDomainOverrides remains as a feature that is enabled by default in case some distribution wants to disable this feature that talks to Google. Bug: 846694 Change-Id: I32bd06ef908f16c189cd0fa2a376d490c6fe20d0 Reviewed-on: https://chromium-review.googlesource.com/1233740Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#593581}
-
Xianda Sun authored
Before launching V2 viz hit testing, we need to verify the correctness. This patch forces V2 to do slow path async hit testing and compare the results. If there is no reported mismatched results, it will be safe to launch V2 viz hit testing. Bug: 823888 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I060b9626e6e59cc12ae2b476425cef715475e40d Reviewed-on: https://chromium-review.googlesource.com/1157227 Commit-Queue: Xianda Sun <sunxd@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#593580}
-
Luigi Semenzato authored
Implementation CL: https://chromium-review.googlesource.com/c/aosp/platform/system/connectivity/shill/+/1220430 BUG=chromium:729335 TEST=none Change-Id: I00fe89328d9ec0f910b354733fb1914838c5d75c Reviewed-on: https://chromium-review.googlesource.com/1234696 Commit-Queue: Luigi Semenzato <semenzato@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Henrique Grandinetti authored
Bug: 881445 Change-Id: I745c35e6f3ba0dba1804ee5787a6dc811fb123db Reviewed-on: https://chromium-review.googlesource.com/1238794 Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#593578}
-
Stephen McGruer authored
Bug: 884711 Change-Id: Ice9b8c2d260a98f5612884a19abca85d200e5ee4 Reviewed-on: https://chromium-review.googlesource.com/1240354Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#593577}
-
Paul Meyer authored
Spec: https://w3c.github.io/reporting/#generate-test-report-command Change-Id: Ia6932007db49eb11c005752b8eace6d7f1267e4f Reviewed-on: https://chromium-review.googlesource.com/1221694Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#593576}
-
erikchen authored
The hooks are currently required by the jank calculator. They will eventually be the mechanism that the browser task scheduler hooks into native events. Bug: 859155 Change-Id: I4b633c7b350c673c7b59cdcfe3a115ae74e5bacb Reviewed-on: https://chromium-review.googlesource.com/1238777Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593575}
-
Dominic Mazzoni authored
This reverts commit 33d3164a. Reason for revert: Breaks NVDA / JAWS Original change's description: > Ensure Windows accessibility is enabled properly. > > http://crrev.com/c/1192062 made it so that we don't enable accessibility > as often. The idea was to only enable accessibility if we get a call to > IAccessible2, or to both get_accName and a response to our alert message > on a honeypot window. > > However, this only worked if we constructed at least one > BrowserAccessibilityManager. In cases where the external client > never explored and discovered a BrowserAccessibilityManager, the > IAccessible2UsageObserver wasn't registered yet. > > As a fix, move the IAccessible2UsageObserver code to part of > BrowserAccessibilityStateImpl. > > Bug: 878072 > Change-Id: Iadcbd032fa1d6f635bbb99c1e130d384efe0d9b1 > Reviewed-on: https://chromium-review.googlesource.com/1234267 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593233} TBR=dmazzoni@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 878072 Change-Id: I482cb7e3fa19f5f6357c4bc28f44cb20272142cd Reviewed-on: https://chromium-review.googlesource.com/1240473Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#593574}
-
Aga Wronska authored
Automatically continue from welcome to network screen when hands-off enrollment is in progress. This fixes the regression introduced by split of welcome screen into welcome and network screen: https://chromium-review.googlesource.com/c/chromium/src/+/1139586 Bug: 886919 Test: HandsOffEnrollmentTest + manually Change-Id: I9f5fe438c5dd7284973e76728c4204b4cad2ea52 Reviewed-on: https://chromium-review.googlesource.com/1236662Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The previous code in VisualOffsetFromPaintOffsetRoot() converting the result into scrolling contents space used ScrolledContentOffset which mismatched the new ScrollTranslation which also includes scroll origin. Now use ScrollTranslation instead. Also removed the wrong remedy about scroll origin in one of the callers. Bug: 887423 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9a72ed6ddc066c5b4c9970037ed4c4287c5a2f0f Reviewed-on: https://chromium-review.googlesource.com/1239170 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593572}
-
Dan Harrington authored
Change-Id: I586fbd98fbf5529d7144513f75fa470d1accd0e8 Reviewed-on: https://chromium-review.googlesource.com/1236462Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#593571}
-
Charlie Harrison authored
This is set for ~3% of PageVisits. Bug: 638198 Change-Id: Ib6c3d10565f2776aadbabea1a2d4d1363f2a6f9d Reviewed-on: https://chromium-review.googlesource.com/1240166Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#593570}
-
Tien Mai authored
Adds the new two line suggestion display experiment argument for credit card and profile autofill drop downs. This new experiment argument will allow autofill drop downs to show two lines worth of information for autofill suggestions as well as a leading icon for the given suggestion (if any). Bug: 870342 Change-Id: Iaa303bafea5fe09f81538d452e2f6871c0d4282a Screenshots (Googlers-only): https://drive.google.com/drive/folders/1XDzDE9GiOt4bAG_kDXZDaiJbbBvuTwPX?usp=sharing Change-Id: Iaa303bafea5fe09f81538d452e2f6871c0d4282a Reviewed-on: https://chromium-review.googlesource.com/1234968 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#593569}
-
Moe Ahmadi authored
Bug: 867106 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I931d15446e55a2f68b673d71525a805914bad422 Reviewed-on: https://chromium-review.googlesource.com/1239369 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593568}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ibc83b79270a95040405b7ff1a5bd0628fe287068 Reviewed-on: https://chromium-review.googlesource.com/1240170Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#593567}
-
Tarun Bansal authored
Use Network Quality Tracker (NQT) in network metrics provider instead of the network quality estimator (NQE). NQT works when network servicification is enabled or disabled. NQE works only when network servicification is disabled. Note that NQT is to be used on UI thread, while NQE was on IO thread, which makes the code a bit simpler. Change-Id: If95a8882d578ef6d00ea1a51e4bc5a861b3a47a2 Bug: 882482 Reviewed-on: https://chromium-review.googlesource.com/1215371Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593566}
-
Sam Maier authored
TBR=smaier@chromium.org (mechanical refactor) Bug: 825947 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng;master.tryserver.chromium.android:android_cronet_tester Change-Id: I378c64c40f3c7ce9522f3d8f534eaee88225880b Reviewed-on: https://chromium-review.googlesource.com/1231989 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#593565}
-
Nico Weber authored
Bug: 832676 Change-Id: I844589ee9726882c5a19b4d7e0ffd2543118d6a4 Reviewed-on: https://chromium-review.googlesource.com/1240167Reviewed-by:
-
Nico Weber authored
Bug: 832676 Change-Id: If8b70eefc57a17b734c33a953b3c06a1a0dc2bd2 Reviewed-on: https://chromium-review.googlesource.com/1240165 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593563}
-
Aaron Leventhal authored
NOTRY:true Bug: 887512 Change-Id: Ie4aab44d8eb186b9aff35036aa5317c6f79fc643 Reviewed-on: https://chromium-review.googlesource.com/1236714 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/de54d7c5e325..a9adb6f03525 git log de54d7c5e325..a9adb6f03525 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 halcanary@google.com SkPDF: cleanup GraphicStackState Created with: gclient setdep -r src/third_party/skia@a9adb6f03525 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I17c88ede0c0c6d0b36c62759fa5b826231b41725 Reviewed-on: https://chromium-review.googlesource.com/1239116Reviewed-by:
-
Jinho Bang authored
The hasError() method is already calling IsNull() internally. Also, the error field in mojom has a default value as empty string. Bug: none Change-Id: I98edd7c11a32379cc477b3f0520b3293b83a9009 Reviewed-on: https://chromium-review.googlesource.com/1239294Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#593560}
-
David Trainor authored
The CircularProgressView button was built using View#setForeground(), which is unavailable on early versions of Android. This patch addresses that by adding a helper class that can give a View setForeground-like support. This patch also adds an AutoAminatorDrawable, which will start and stop Drawable animations when the Drawable is visible or not. BUG=868554 Change-Id: I4a11921962aeac9dcee701f7e3584ba70ac96def Reviewed-on: https://chromium-review.googlesource.com/1231295Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#593559}
-
Andrew Grieve authored
Bug: 880671 Change-Id: I5ed6803daf97609fe2814618f51d8199f8c44390 Reviewed-on: https://chromium-review.googlesource.com/1240185 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#593558}
-
Kevin McNee authored
We update/remove comments that claim that double-tap to zoom is specific to Android. We also enable double-tap to zoom on Mac via WebPreferences rather than hardcoding it as always enabled. Bug: 802369 Change-Id: Ib78a0a85f295166bff3363ed65dceca9e5e3468e Reviewed-on: https://chromium-review.googlesource.com/1235129Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#593557}
-
Bo Liu authored
Setting opacity on a layer with children that draws leads to using a render pass, which is super expensive. Use the usual trick of setting opacity on the leaf layers directly instead. Change-Id: If394f0bba0953b9c6b951d2f320b358fe16c8acb Reviewed-on: https://chromium-review.googlesource.com/1238566Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593556}
-
Xi Cheng authored
Bug: 886957 Change-Id: I36adf26e497b0dee187ed151a09f16b966e277a8 Reviewed-on: https://chromium-review.googlesource.com/1240175Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#593555}
-
Sergei Istomin authored
This CL adds test cases to "cast_audio_backend_unittests" for checking external audio pipeline library. Tests check "StreamMixer" interaction with the library when library returns IsSupported() true. "Cast_audio_backend_unittests" unittest now is built with "fake_external_audio_pipeline" that has library implementation. For test reason the library supports additional functions (returns interface) that are used only from unittests. Additional functions are defined in "fake_external_audio_pipeline_support.h" "testing" namespace. There are the following test cases: - "SetMediaVolume"/"SetMediaMuted" for testing media volume/mute notification when the volume/mute is changed. - "SetVolumeChangeRequest"/"SetMuteChangeRequest" for testing a change request for volume/mute from the library. - "ExternalAudioPipelineLoopbackData" for testing loopback data. Bug: internal b/113337099 Depends-On: I755aaa94470dc8ba33a458d6139ef9254655d3e4 Change-Id: Ie8ebaf878e0d1c0d1f8485e645a2e05142745928 Reviewed-on: https://chromium-review.googlesource.com/1218045 Commit-Queue: Sergei Istomin <sistomin@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#593554}
-
Arthur Sonzogni authored
history.back() called twice causes the browser to navigate back twice. This is wrong. It should navigate back only once. This CL adds regression tests. The specification says the following: --- If there is an ongoing attempt to navigate specified browsing context that has not yet matured (i.e. it has not passed the point of making its Document the active document), then cancel that attempt to navigate the browsing context. --- Specification: https://html.spec.whatwg.org/multipage/history.html#traverse-the-history-by-a-delta Bug: 869710 Change-Id: I1534c7a04dbd220920970576baad02cedfaf6a12 Reviewed-on: https://chromium-review.googlesource.com/1215803 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593553}
-
Javier Fernandez authored
Since we integrated the baseline alignment logic in the grid tracks sizing algorithm, its impact on performance has grown considerably. The analysis of the new logic added and its overhead, due to different operations, shows that evaluating the item's participation in the baseline alignment context is the most expensive one. It's specially demanding the evaluation of the grid item's alignment properties. Considering that currently we are doing this for every grid item, this CL propose to reuse the loop we already have to clear the grid item's override size to cache the items with a baseline value in their alignment CSS properties. Thanks to this cache we can determine the item's participation in a baseline alignment context in the different phases of the track sizing algorithm, with almost no cost (compared to the current logic). It may be possible to share the cache with the algorithm run for computing the grid's intrinsic size; however, if the intrinsic size logic is run before the grid's layout, we'll end up duplicating the cache. Additionally, this cache is also used in the alignment phase of the grid layout logic; this change helps to avoid the various issues we have been suffering related to the different evaluations of the item's participation in baseline during the different phases of the grid layout algorithm. BUG = 873452 Change-Id: Ida27be11ae0f5c455e6077367a277981ab35cec1 Reviewed-on: https://chromium-review.googlesource.com/1179897 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#593552}
-
