- 12 Jan, 2021 40 commits
-
-
Josh Nohle authored
1. Only emit the receive-message metrics and logs if the callback has not already been invoked. 2. Record a fast-path-ready notification as a receive-message success. 3. Clarify receive-message histogram summaries to indicate that the metric records the result of opening the receive stream, i.e., starting to receive messages, not a result for every message receipt. 4. Add metrics and logs to track send- and receive-message OAuth token fetches. Manually verified logs and histograms. Fixed: 1164009 Change-Id: I2a064cae444ec890971db40b15c93c713e32565c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619628 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#842617}
-
Nicolas Ouellet-Payeur authored
ScopedProfileKeepAlive is not meant for use with OTR profiles, so this caused a failed DCHECK() when a downloading a file in Incognito (with DestroyProfileOnBrowserClose=true). Bug: 88586 Change-Id: I1aff2cadf62ab1bd56a0b44e9154d6843f92cc89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622873Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#842616}
-
Charlie Reis authored
The NEW_PAGE, EXISTING_PAGE, and SAME_PAGE names are confusing because they refer to NavigationEntries rather than pages. For example, NEW_PAGE is used for same-document main frame navigations, which create a new entry but not a new page. This CL mechanically renames them to NEW_ENTRY, EXISTING_ENTRY, and SAME_ENTRY. Bug: 1164466 Change-Id: Idb0bfa4de08a69f55088b248a9b05619dd17cca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618392Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#842615}
-
Gavin Williams authored
When the first option in the select is hidden, even though the option won't be shown in the dropdown list, its text still appears as the selected option in the dropdown. Moving the |noScannersText| option to after the list of scanners allows the first scanner to replace |noScannersText| as the selected value when loaded. Bug: 1059779 Change-Id: Ic06363e55d082fe758a6ae04ddbe4e7206841f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622894 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#842614}
-
Yuheng Huang authored
Add tab_search:measure_memory:before and tab_search:measure_memory:after to measure memory before/after open tab search. Add tab_search:clean_slate to benchmark tab search without any traffic. Bug: 1099917 Change-Id: I748609a91af8866c9814ff0cf2a17e92dd197d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622951Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842613}
-
Jordan Demeulenaere authored
This CL merges multiple details into a single block, with the details separated by a line. See b/174652960#comment16 for screenshots. Bug: b/174652960 Change-Id: Ia562ec600b513a120b503c8f7ffa676124089749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611096 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#842612}
-
Yulun Wu authored
Bug: 1139478 Change-Id: I9fd0a87bcc2086e27a5c4b3b6c025c2ff4065dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623672 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842611}
-
Anastasia Helfinstein authored
Per the bug filed by our UX designer, update the preview focus ring to have a solid inner ring, and a dashed outer ring with 4dip dashes and 2dip gaps. Since Switch Access is the only application of the DASHED focus ring style currently, I modified that style directly, rather than creating another new style. Bug: 1152610 Change-Id: If61810ed594e7f388a8cbf71aaa41a44c2ed3cb6 AX-Relnotes: Dashed focus ring in Switch Access now has a different style. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622757Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#842610}
-
Owen Min authored
Bump the expire date to 2022-02-01 Bug: 1165249 Change-Id: Ifb567252ac93f21073d16019adbed1b3c9622bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622993Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842609}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/81d005b6696c..767ed2f6b642 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: zmin@google.com Change-Id: I0a20a271d883525e958b9ad30faa6f555a566609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624854Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842608}
-
Łukasz Anforowicz authored
This reverts commit f0314d14. Reason for revert: Enforcement is not yet ready for M89 (see https://crbug.com/1151438) - need to temporarily disable before the branch point. Original change's description: > Reland "Enable |request_initiator_site_lock| enforcement on Android." > > This reverts commit 207fb0e1. > > Reason for revert: Trying again on M89 (with new crash keys from https://crrev.com/c/2575368) > > TBR=yhirano@chromium.org,lukasza@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 920634 > Bug: 1151008 > Bug: 1151438 > Change-Id: Iff849597312d7843b1fff809a00743d0785680e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578100 > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834521} TBR=yhirano@chromium.org,lukasza@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 920634 Bug: 1151438 Change-Id: Ibd1aea1a23c2cc04256724de5b8a8685f866de9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623468Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#842607}
-
Evan Stade authored
Migrating GetWebPageMetadata to the component will necessitate a browser/renderer split directory structure. Bug: 1164069 Change-Id: I789a7991d2d98247415b2c6d35108fdf258d1113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621987 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842606}
-
Erik Chen authored
From the perspective of extensions, Lacros should be functionally equivalent to ChromeOS rather than Linux. Bug: 1164523 Change-Id: I020997a4185afb54018f19653f00f7b9d00f4f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623121Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#842605}
-
Jordan Oroshiba authored
This fixes bug where if looking at site settings in PageInfo or through SingleWebsiteSettings and view Notification preference on Android O+, the notification icon will be duplicated upon returning to setting pages. Bug: 1163799 Change-Id: I7705b8c4d3bf55cb09ab171ee40e1b9f6c29ef22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617463 Commit-Queue: Jordan Oroshiba <oroshiba@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#842604}
-
Sammie Quon authored
Addressing missed feedback from crrev.com/c/2581027, use right click instead of adding new API. Bug: none Test: compiles Change-Id: I988c92c87e9339702a5554bd7e5375d467616412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623424Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#842603}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 57 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-04-12. TBR=chromium-metrics-reviews@google.com Change-Id: I8174bb5839ae52353832435a8b44ba7ee5646254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622341Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#842602}
-
Swapnil authored
We assign the priority as FOREGROUND if there is any pending force installed extension. Then for the enabled/disabled extensions, we set the priority as FOREGROUND in this case. This causes a high rate of "ondemand" updates for certain extensions. This CL fixes this by assigning FOREGROUND priority only in case of first installs. Bug: 1133407 Change-Id: I7b6e84e22c240ead798eb6f625ef3c26142c786f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621893Reviewed-by:
-
Ana Salazar authored
Bug: 1156270 Change-Id: I895cac0847e226374efc27d5a9cfdc6f29b09130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622664Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842600}
-
Solomon Kinard authored
Bug: 1133624 Change-Id: I71e50481f0d7942f6ce428e890742828bfe0699e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500422 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842599}
-
Marc Treib authored
This config is supposed to enable the account indication footers for *Save Card* bubbles, not for *Password* bubbles. Bug: 1121258 Change-Id: I09a4cbc636582c3298d837d356f1274c0d5c36c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624787Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#842598}
-
Mike West authored
This CL adds a new WebFeature metric for pages that are embedded via <frame> or <iframe> by default, without explicitly setting an X-Frame-Options header or frame-ancestors CSP directive. https://github.com/mikewest/embedding-requires-opt-in Bug: 1153274 Change-Id: I5bb45df3eb2aec0010f2ddd2dfe457551de9d40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623010 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842597}
-
Owen Min authored
Disable org.chromium.chrome.browser.omnibox.voice .AssistantVoiceSearchServiceRenderTest#testAssistantColorfulMic on Android due to flaky. Bug: 1165682 Tbr: fgorski@chromium.org Change-Id: I036cde50ce6b9c4664eb242e6a2f6b02b3979d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622338Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842596}
-
Darren Shen authored
This is a reland of 29ff7965 Reordered initialization to fix ASAN/MSAN bug. Original change's description: > ime: Handle InsertTextCursorBehavior in InputMethodChromeOS. > > TextInputClients now support moving the cursor after committing some > text. This patch adds support for input engines to call the new API. > > There is a slight complication with multiple CommitText calls during > key event handling. Previously, when handling a key event, any calls > to CommitText will be coalesced together and executed once the key > event is handled. However, this coalescing logic doesn't handle > cursor movement. > > Add logic to handle cursor movement when coalescing commits by observing that > any sequence of CommitTexts with cursor movement can be implemented with two > separate CommitTexts. Note that this is a no-op change if the IME never uses > the new cursor movement parameter. > > Bug: 1155331 > Change-Id: I6c89ec1cde5624eca7bf0d5c803085f7d7803c71 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576067 > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840082} Bug: 1155331 Change-Id: I373a8195946ec4fb966f932eaf084b2b74f06b6c Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_msan_rel_ng,linux_chromium_chromeos_asan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612604Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#842595}
-
Owen Min authored
The test is also flaky on Chromium trybot, disable it. Bug: 1165749 Change-Id: I992be191e2ab52106239dd13572dc058fde4b448 Tbr: dtseng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624829Reviewed-by:
-
Sahir Vellani authored
This is a reland of 07b882d4 The original CL was reverted due to a few layout tests failing in ASAN. The cause of these failures was that vertical_autoscroll_layout_box_ and horizontal_autoscroll_layout_box were not being cleared in StopMiddleClickAutocroll. This resulted in heap-use-after-free errors. In order to fix this issue, the two pointers are cleared in StopMiddleClickAutoscroll. They are also cleared if necessary in StopAutoscrollIfNeeded. In the latter, middle click autoscroll would be stopped if both layout boxes are to be cleared. Original change's description: > Change autoscroll latching to top-most delta-consumable scroller > > Users will now be able to use middle click autoscroll to scroll a > parent div if the inner-most scroller is unable to scroll in that > direction. > > If there is no delta-consumable scroller, the top-most autoscrollable > scroller will be latched. > > Bug: 1107648 > Change-Id: Iccd4efec3b1ce5d09c701d3d46052176275dbc32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488042 > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Rahul Arakeri <arakeri@microsoft.com> > Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#835318} Bug: 1107648 Change-Id: Idf3c2253a25d2cfbe12a8ffe30bbf697c636d222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582733Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842593}
-
Ali Juma authored
This adds an OWNERS file to ios/chrome/test/wpt, with the initial author of this code as an owner. Change-Id: I0d2f22b4ec3c53ae7a3fad9e06c2d64db7695371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624587Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#842592}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610441943-347418dd52d747baeeb402622c1d23998512f08e.profdata to chrome-win32-master-1610452567-971e6bfbeacac133e734933b87972f0e8c85e431.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I70ae8f6df2a4604c8cff4ea67d200fd9496eb539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624258Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842591}
-
Yu Han authored
This is a reland of 909901eb The revert was due to greater pixels error difference between Mac 10.12 & 10.15 and the baseline. After checking the error rate on failed Mac bots, the fix is to increase the error_pixels_percentage_limit from 9f to 10.2f in form_controls_browsertest::FuzzyPixelComparator. Original change's description: > [Controls Refresh Android] Fixes input missing border > > Prior to this CL, controls-refresh text input is missing its border. > > The fix is to make sure property text_field.has_border is passed to > native theme. This property is only used by form controls-refresh > so it has no impact on existing text input. > > Bug: 1155397 > Change-Id: I3cacd4d9550e10388b15122d7ff94a32ffa5e39d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612495 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841106} Bug: 1155397, 1164011 Change-Id: I6f06173f677b45664ff4cb6dedfb9197b8ece95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618675Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842590}
-
Caroline Rising authored
Add user action metrics for: - Clicking to open the reading list - Adding to the reading list from the Bookmark icon entry point - Adding to the reading list from the tab context menu Bug: 1163938 Change-Id: I95d655ce60f5b76c80f4d3b6a8490310befa8fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622315 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#842589}
-
Renato Silva authored
Canada requires a legal footer to be shown on the marketing opt-in screen. Add the footer and tests for it. Fixed: 1124956 Change-Id: If9f1dd34dfb9ea9209498521eeee107f8aa132f9 Bug: 1124956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577364 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#842588}
-
Sophie Chang authored
Bug: 1154790 Change-Id: I2cdc9451fedddcea9e1515b59c2dc787c2b8beef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618290Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Josh Simmons <jds@google.com> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842587}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bd6bd346f677..e3e59aac750e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2a9e927c414af1d0b99974f76a14845fc5c20557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623430Reviewed-by:
-
bttk authored
getOffsetOfFirstVisibleFocusedView is moved as well Change-Id: I96bc2a476fab2cd16372915ee0141a28236eeff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622842Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
chinsenj authored
Currently the WmGestureHandler handles events for the wm and also the window cycle list. There is also the WindowCycleEventFilter which handles some events for the window cycle list. This was implemented like this to share logic for scrolling, but after further investigation the common logic has been determined to not warrant having the handling for the window cycle list to live in two separate event handlers. This CL refactors the WmGestureHandler, moving all window cycle list logic to the WindowCycleEventFilter. A followup CL will refactor the WindowCycleEventFilter to reorder fcns according to order in its header file. Test: manual + existing tests. Bug: 1136554 Change-Id: I055d0533169992ad1022bdd14da9ce89d91f7e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606494Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#842584}
-
Sophie Chang authored
Bug: 1154790 Change-Id: If4d9a70b41151d3f465976637a54aa826821bbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623717 Auto-Submit: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
-
Roman Arora authored
This reverts commit 339975cc. Reason for revert: Search filter in Tab Search dialog not working as expected with this change. Original change's description: > Tab Search: Infinite list - Efficient list DOM item updates > > Leverage the ListPropertyUpdateBehavior logic that uses Polymer's > splices and calculateSplices functions to efficiently modify a single > list item on tab updates, and avoid unnecessary scroll height > calculations. > > Additionally, tab updates for not yet rendered items do not result in > DOM updates. > > Proposal doc & benchmarks: https://docs.google.com/document/d/1FcuhM98moL-BYB1DJGXrpwf-JqMz1aI-RQV08giArBY/edit#heading=h.xzptrog8pyxf > > Most relevant pinpoint benchmarks: > https://pinpoint-dot-chromeperf.appspot.com/job/15db6158d20000 > https://pinpoint-dot-chromeperf.appspot.com/job/107ab7f4d20000 > https://pinpoint-dot-chromeperf.appspot.com/job/16ccacccd20000 > > Bug: 1149400 > Change-Id: I07fae967033b13830708da3035db3e8b2f0ff9d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578119 > Commit-Queue: Roman Arora <romanarora@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842182} TBR=dpapad@chromium.org,aee@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,tluk@chromium.org,romanarora@chromium.org Change-Id: Ic4e8289e6ade648a8a006dad3b5310443e4c8c4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1149400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622721Reviewed-by:
Roman Arora <romanarora@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#842582}
-
Ulan Degenbaev authored
Bug: 1085129 Change-Id: I14e36d7e7901ec308ca469d32bf9a7eabc949637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617789Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842581}
-
Dave Tapuska authored
Page should be non-null, but check that it is. BUG=1160652 Change-Id: I1b126af29cc1f0dbebdd475fe205c77aa31e90f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622283Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#842580}
-
Sonny Sasaka authored
Battery reporting via HID is now consolidated into BlueZ (CL:2593287), so there is no need to listen to powerd directly. This only affects Bluetooth HID devies and does not affect non-Bluetooth HID battery notification. Bug: b:166543531, b:172361193 Change-Id: I222677b96463120acdd2f7665d9a3c87df32346e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594158 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#842579}
-
Eric Orth authored
Similar logic is currently duplicated between DnsConfigServiceWin and DnsConfigServicePosix, and there would be even more duplication if DCSPosix is further split by platforms (as I intend to do in a subsequent CL). Some logic for handling the detected-change notifications also moved from the (now-shared) Watcher to DnsConfigService, as the logic wasn't really part of "watching" but more handling. Bug: 1157492 Change-Id: Ie813e5d9085cb4a109f7cad9b28d351562352b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616421Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#842578}
-
