- 23 Mar, 2020 40 commits
-
-
Gauthier Ambard authored
https://chromium-review.googlesource.com/c/chromium/src/+/2024895 https://chromium-review.googlesource.com/c/chromium/src/+/2027787 Bug: none Change-Id: I4f8ae1753f557f5dd5d9216619a94d7dc9d40d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111094Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#752393}
-
Rune Lillesveen authored
The print preview UI used HasCustomPageSizeStyle() to decide if the CSS dictates the given page size, or if a UI to change the page size should be available when printing to PDF. We returned true when the size descriptor only contained an orientation, which does not give the user an opportunity to select if "size:landscape" should print to Letter or A4. Instead, replace HasCustomPageSizeStyle() with a GetPageSizeType() to pass the page size type out of Blink instead of a boolean to make it possible for the printing UI to disable the UI for selecting page size and orientation separately. The testRunner API for hasCustomPageSizeStyle() is removed since it was only used for a single test which we now have coverage for in unit tests. This CL should not have any behavioral changes. Bug: 1016235 Change-Id: Id12c4310f87fc99b17660c355913150f12ff3e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107598Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#752392}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6a431038c911..13c0df80dca5 git log 6a431038c911..13c0df80dca5 --date=short --first-parent --format='%ad %ae %s' 2020-03-22 ramakrishnan.nikhil@gmail.com [docs] Fix building docs if `srcdir' != `builddir'. 2020-03-21 ramakrishnan.nikhil@gmail.com [docwriter] Drop support for Python < 3.5. Created with: gclient setdep -r src/third_party/freetype/src@13c0df80dca5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I43a54d99663fc8cca2acd0896e90ce56a518bb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113204Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#752391}
-
Anatoliy Potapchuk authored
Currently, AccessibilityControllerImpl is mid-way of the refactoring for feature controls. This CL makes other features be controlled by their own Feature or FeatureWithDialog instance. We will remove/rename redundant methods in the following CL. Bug: 1051892 Change-Id: I840a2d64ff20e51e67656c55a4572ae2aff479bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108020Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#752390}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57af8b538c0c..be8affce16ac Created with: gclient setdep -r src-internal@be8affce16ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4b481f1b3e80a1d1f7fb431f786bfd0d691ef594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114837Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752389}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I6041045479150048ab5c5da3ad7a72d53d51c45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114971Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752388}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c23bd5e4e38d..f04f21a5c913 git log c23bd5e4e38d..f04f21a5c913 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1c9f24263e6c..22d73d15e778 (1 commits) Created with: gclient setdep -r src/third_party/skia@f04f21a5c913 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Id8c326e3d860450a45ac4043168827b614bd855a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114839Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4481dd59..d67bef80 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8ece03547dcb8f80770c52aa9921be17061bfd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114930Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752386}
-
Krishna Govind authored
This reverts commit a33032ad. Reason for revert: Breaks canary, crbug 1063647 Original change's description: > [WebLayer] Delete browserservices.Origin > > This is the last CL to move browserservices.Origin to > //components/embedder_support so it can be used by WebLayer. This was > split into multiple CLs to avoid breaking Clank. > > Bug: 1058597 > Change-Id: I1964b9fc54c378528ba4935e2385da99fc663e70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106889 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752248} TBR=boliu@chromium.org,yusufo@chromium.org,rmcelrath@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=rmcelrath@chromium.org Bug: 1058597 Change-Id: I02ed8bfea70aa7e4913d8e27bc058f05185509f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114970 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#752385}
-
Noel Gordon authored
When keyboard is being used to interact with FilesApp, the html element gains a .focus-outline-visible class. That class is removed if the user clicks anywhere in Filesapp [1]. Add a test for this behavior. [1] See cr/ui/focus_outline_manager.js, which is available in FilesApp, and initializes html.focus-outline-visible on creation. CSS like: html.focus-outline-visible some-element:focus { outline: 1px auto -webkit-focus-ring-color; } can be used to show focus rings only for keyboard interaction. Test: browser_test --gtest_filter="*keyboardFocusOutlineVisible" Bug: 1062902 Change-Id: Ieec9d66c328b4f9b64ded0d34c060493454892c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114772Reviewed-by:Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#752384}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I355345e48d1c491cf02efff6a2a240e1669aacb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114597 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#752383}
-
Alan Cutter authored
This CL updates the Extensions API chrome.management.generateAppForLink() to function with the new web apps backend by translating the installed web app's properties into an equivalent ExtensionInfo return value. Bug: 945205 Change-Id: I250659fb6e6c210ca467558e95c00a779104f763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094852 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752382}
-
Luciano Pacheco authored
In Files app we added a title inside the list, when clicking in the title it throws an exception in the assertInstanceof() in getListItemAncestor(). This CL fixes getListItemAncestor() to not raise in this condition, instead it returns null as the description says. It also fixes event handlers that calls this function to check if it has returned null. Test: browser_tests --gtest_filter="WebUIResourceBrowserTest.ListTest" Bug: 1063184 Change-Id: Icf92cc30bb0a346c7e19660f847a994286abfea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111252 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#752381}
-
Manuel Rego Casasnovas authored
In ShapeResult::OffsetToFit() when the size to fit matches result.origin_x we were returning the left_character_index only if Direction() was RTL. However if line_direction is RTL we also want that index. With this change css/css-ui/text-overflow-028.html starts to pass on Linus and Windows, we add new tests here too (the RTL ones were failing before this patch). BUG=1063319 TEST=css/css-overflow/text-overflow-ellipsis-001.html TEST=css/css-overflow/text-overflow-ellipsis-rtl-001.html TEST=css/css-overflow/text-overflow-ellipsis-vertical-001.html TEST=css/css-overflow/text-overflow-ellipsis-vertical-ltr-001.html Change-Id: Idbaed07a63d4ec6335e722b7fb7b4e91f4076564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111152Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#752380}
-
tby authored
We've got some very spammy vlogging to debug an issue we've fixed, let's remove it. Bug: 959679 Change-Id: Iff5bbbe4f3745b3d44059e591c137276b141c8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114773Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#752379}
-
Yuki Shiino authored
No prod change. This patch makes changes only on the new bindings generator, which is not yet shipped. Bug: 839389 Change-Id: Ic36d910d20c5d497639979fa106cb315db3519c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114590Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#752378}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/538e358b0d82..c23bd5e4e38d git log 538e358b0d82..c23bd5e4e38d --date=short --first-parent --format='%ad %ae %s' 2020-03-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src e0f773c5..be0a271f (446 commits) Created with: gclient setdep -r src/third_party/skia@c23bd5e4e38d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I98d51af09d120a36aa63d21032a0a146fddacc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114835Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/94f264655d7b..a80b423b2136 git log 94f264655d7b..a80b423b2136 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@a80b423b2136 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I58ba5d9d657976448fcc34e94fc22728f4eb28e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114836Reviewed-by:
-
Joel Hockey authored
Bug: 1057591 Change-Id: Ibae5f698d1c9b27ea72e006ff7b274ace7524578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114476 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#752375}
-
Gyuyoung Kim authored
Remove tests marked as flaky on Mac. Because they don't make flakiness now. Bug: 1060175 Change-Id: I6a4c192421f6f9688375246e91fff1015bcb2ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102990Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#752374}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/221bbbc58554..57af8b538c0c Created with: gclient setdep -r src-internal@57af8b538c0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6047d4a4704ffc6df7e39087fa77c0accac6420c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114832Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic2785caff657e97de8f0fd553f6a3e71d6b7373f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114834Reviewed-by:
-
tby authored
The first step to supporting 'projects' (several events tied together with one key) is to add a section to the structured.xml file for projects, and then link that information together with events. This CL: - Updates the XML model to add a <projects></projects> section. - Updates the codegen for event builder classes to include a kKeyNameHash member. This will be used to do key lookups instead of the event name hash. - Creates a 'namespace' for event names and project names, so that there's no way eventual key lookups will get confused between a project and an event with the same name. - Updates the unit tests to use the correct hashes with these new namespaced event names. - Adds compile-time validation to ensure that any projects referenced by an event actually exist. Specifying a project for an event is optional, if not provided the event receives a key based on its name-hash as-is. If a project is provided for an event, we check that it exists in the <projects> section and otherwise fail to compile. Follow-up CLs will: - Change the key generation logic to use kKeyNameHash instead of kEventNameHash as the identifier for a key. - Add more presubmit validation to double-check all project references are correct, and that the projects section of the XML file doesn't have any problems. - Add new tests to check the kKeyNameHash is set correctly. Bug: 1034842 Change-Id: Id1d2303ee5c7a25df1fac565f6df123bf078c7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112370Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#752371}
-
Robert Ma authored
Bug: 1048470 Change-Id: I3f524b1aa4c129c9ff1abfbe8b2d99903f9005e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113443 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4e36ac84996b..94f264655d7b git log 4e36ac84996b..94f264655d7b --date=short --first-parent --format='%ad %ae %s' 2020-03-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@94f264655d7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3078567e3b587065ba6c1cd7fa90d1af2792702c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114833Reviewed-by:
-
calamity authored
Bug: 1063736 TBR=mcrouse@chromium.org Change-Id: I85974b2938ad575100039fd943c38ebbf55f717a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114632Reviewed-by:
-
Jinsuk Kim authored
mEphemeralTabCoordinatorSupplier.get() (not the supplier itself) can be null, so it should have been guarded with a null check to prevent the reported NPE. This CL fixes it. This reverts commit edafb249. Bug: 1063264 Change-Id: I6aa5dfee9bf822055fc1fd3ee04062de4a459c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113590Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#752367}
-
Simon Que authored
This is the os value used by other iOS Goma RBE builders. R=tikuta@chromium.org, ukai@chromium.org, yekuang@google.com, yyanagisawa@chromium.org Bug: 1063727 Change-Id: I1df2def9f0e3d1d5dc79d711188494550ffc4d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114312Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#752366}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b49ee2484237..221bbbc58554 Created with: gclient setdep -r src-internal@221bbbc58554 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I82e4a423d72f16a78d130abefbeb04a432896574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114543Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Iab1e2ff40570bc2e370fcc6b1939d3e4b3e5e0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113686Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752364}
-
Noel Gordon authored
Add a test that the html element gains a pointer-active class when the pointer device (the mouse in our tests) is active. Test: browser_test --gtest_filter="*keyboardFocusOutlineVisibleMouse*" Bug: 1062142 Change-Id: Ibd7c3939b4880e5b7cb2364a8b04e4d92d5d3725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114012Reviewed-by:
-
Kenichi Ishibashi authored
This CL moves header checks from CreateHttpResponseInfoAndCheckHeaders() into a separate function. This is a preparation to remove HttpResponseInfo dependencies from ServiceWorkerNewScriptLoader and ServiceWorkerSingleScriptUpdateChecker. These classes will stop converting URLResponseHead but still need to check headers. Bug: 1060076 Change-Id: I1484e2523f42e8e7779b06f0be6cb0119de6101f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107032 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#752362}
-
Noel Gordon authored
Test helper fakeEvent does not convert mouse events to pointer events, so add them to the pointer-active handler list for testing purposes. Bug: 1062902 Change-Id: I1feef4dde4f8814fb64fd6e3a246947b3d277dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114513Reviewed-by:
-
Luciano Pacheco authored
Nits only affecting the testing code. Bug: 1062148 Change-Id: I7ca6defb71405eaa6702572fab8640a935deba93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114594 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
BSTR roles are no longer used by screen readers -- they were an old hack used in the days before IA2 roles and xml-roles were provided. MSAA's get_accRole will now wexpose ROLE_SYSTEM_GROUPING or ROLE_SYSTEM_GRAPHIC are now used for anything that had a BSTR role. Discussion where ROLE_SYSTEM_GROUPING was determined to be the best role we can find for the fallback: https://github.com/w3c/core-aam/issues/55#issue-494946973 This change is being coordinated with JAWS, NVDA and Mozilla. Bug: None Change-Id: I72166f17786c8f1ed8874b9fe20453a445ed5c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107765 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#752359}
-
wutao authored
We do not want to keep the Assistant UI in the overview mode. This patch closes Assistant UI before entering overview mode. This cl will also fix a crash of entering overview mode when Assistant UI is visible. The root cause is analyzed in bug 1061856 and will be fixed later. Bug: 1061856 b/139939378 Test: new unit test Change-Id: Id59cacddecca316ab1413665db6a5c427995a155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112896 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#752358}
-
calamity authored
This reverts commit 3014d931. Reason for revert: Failing on Linux Chromium OS Asan https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37195 Original change's description: > Inject NetworkMetadataStore in wifi sync classes which depend on it. > > The instance of NetworkMetadataStore for a user profile is created > after the sync service is already initialized. This change does > the necessary plumbing to get the metadata store instance to > the wifi sync classes. > > Bug: 966270 > Change-Id: Icd235cd780df97a367f09f281f3e957893baa93b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110079 > Commit-Queue: Jon Mann <jonmann@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752273} TBR=stevenjb@chromium.org,treib@chromium.org,jonmann@chromium.org,vecore@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 966270 Change-Id: If4cc3b26c510b86ed0abe2fc3a95b1a1358405a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113400Reviewed-by:
-
Shuhei Takahashi authored
The former code used to assume that argv and envp fit in a memory page, but it is not true (at least today), causing setproctitle to fail randomly and silently. This patch rewrites setproctitle to remove the memory page assumption entirely. Instead it now writes the process title up to the end of envp after saving envp storage. BUG=chromium:1044502 TEST=set_process_title_linux_unittests # on Linux 3.{0..19}, 4.{0..20}, 5.{0..5} TEST=Build and run Chrome OS Chrome and see ps output Change-Id: Ie2f060a38b3e5003155ef8e5788855761e229776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026772Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#752356}
-
Eric Willigers authored
web_app_file_handler_registration.h now uses a forward declaration for Profile instead of including a header. Change-Id: I7f0175ec47d16f015538ac2981c0e6e89242eeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114310 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#752355}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/39af23ead96c..bf306f5ba556 git log 39af23ead96c..bf306f5ba556 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 dberris@google.com Pinpoint: Limit all Swarming tasks to 45 minutes Created with: gclient setdep -r src/third_party/catapult@bf306f5ba556 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1023451 Tbr: crouleau@chromium.org Change-Id: I56204c3fd68e73879b83635002b768918f179c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114541Reviewed-by:
-
